https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac10.10/builds/35226 Flakiness dashboard: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=svg%2Fdynamic-updates%2FSVGFEDropShadowElement-dom-shadow-color-attr.html Regression range: https://chromium.googlesource.com/chromium/src/+log/7aa4e8bf36efda4db554567ffc5b13f14540601e%5E..0fbc79aab000df51cb43513c03d9c34700edffc8?pretty=fuller
These two CLs from the regression range seem like possible causes: https://chromium.googlesource.com/chromium/src/+/4455a5185e98db25d73eacaceb9f8713730197ec https://chromium.googlesource.com/chromium/src/+/638b500582b0ffb30843452c6895f775be3b31dd
10:57:56.508 8884 [55918/59098] svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-color-attr.html failed unexpectedly (image diff) 10:57:56.507 8925 worker/4 svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-color-attr.html failed: 10:57:56.507 8925 worker/4 image diff
I'm not really sure who the right owner is for this. Florin, I'm sending this your way. Hopefully, that's close :) Do we need to rebaseline these tests?
Looks like it just needs rebaselining. I'll take it.
likely caused by crbug.com/737620 ...
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ee4d4d912c63490b2fd87eded9f10006a46e49e2 commit ee4d4d912c63490b2fd87eded9f10006a46e49e2 Author: Mike Reed <reed@google.com> Date: Thu Jun 29 22:25:34 2017 need to rebaseline after colorfilter change NOTRY=true Bug: 738149 Change-Id: I63548e249bd1d35df92e26ec43423a39bcb411fe Reviewed-on: https://chromium-review.googlesource.com/556699 Reviewed-by: Florin Malita <fmalita@chromium.org> Reviewed-by: Nick Maniscalco <maniscalco@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#483517} [modify] https://crrev.com/ee4d4d912c63490b2fd87eded9f10006a46e49e2/third_party/WebKit/LayoutTests/TestExpectations
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8df40f03b4cbd912d4075944222c6314019daffd commit 8df40f03b4cbd912d4075944222c6314019daffd Author: Florin Malita <fmalita@chromium.org> Date: Fri Jun 30 15:35:08 2017 More rebaselines after SK_SUPPORT_LEGACY_COLORFILTER_FILTERSPAN change BUG= 738149 Change-Id: Id6c6122e2fb718f9312a2016940e1e0651a30e22 Reviewed-on: https://chromium-review.googlesource.com/556941 Commit-Queue: Florin Malita <fmalita@chromium.org> Reviewed-by: Mike Reed <reed@chromium.org> Cr-Commit-Position: refs/heads/master@{#483711} [modify] https://crrev.com/8df40f03b4cbd912d4075944222c6314019daffd/third_party/WebKit/LayoutTests/TestExpectations [add] https://crrev.com/8df40f03b4cbd912d4075944222c6314019daffd/third_party/WebKit/LayoutTests/platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-color-attr-expected.png [add] https://crrev.com/8df40f03b4cbd912d4075944222c6314019daffd/third_party/WebKit/LayoutTests/platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-opacity-attr-expected.png [add] https://crrev.com/8df40f03b4cbd912d4075944222c6314019daffd/third_party/WebKit/LayoutTests/platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-color-prop-expected.png [add] https://crrev.com/8df40f03b4cbd912d4075944222c6314019daffd/third_party/WebKit/LayoutTests/platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-opacity-prop-expected.png [modify] https://crrev.com/8df40f03b4cbd912d4075944222c6314019daffd/third_party/WebKit/LayoutTests/platform/mac/svg/filters/feBlend-all-modes-expected.png [modify] https://crrev.com/8df40f03b4cbd912d4075944222c6314019daffd/third_party/WebKit/LayoutTests/platform/mac/svg/filters/feDropShadow-expected.png
Comment 1 by manisca...@chromium.org
, Jun 29 2017