New issue
Advanced search Search tips

Issue 738148 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug
Proj-XR



Sign in to add a comment

"org.chromium.chrome.browser.vr_shell.WebVrTabTest#testPoseDataUnfocusedTab" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Jun 29 2017

Issue description

"org.chromium.chrome.browser.vr_shell.WebVrTabTest#testPoseDataUnfocusedTab" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyVQsSBUZsYWtlIkpvcmcuY2hyb21pdW0uY2hyb21lLmJyb3dzZXIudnJfc2hlbGwuV2ViVnJUYWJUZXN0I3Rlc3RQb3NlRGF0YVVuZm9jdXNlZFRhYgw.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs

This flaky test/step was previously tracked in  issue 734291 .
 
Cc: bsheedy@chromium.org
Components: Blink>WebVR
Labels: Proj-VR OS-Android
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/08df4b02246c6f05978059918ba6adc37322fe2a

commit 08df4b02246c6f05978059918ba6adc37322fe2a
Author: maniscalco <maniscalco@chromium.org>
Date: Fri Jun 30 03:06:44 2017

Disable test WebVrTabTest#testPoseDataUnfocusedTab as it is flaky

TBR=bshe@chromium.org

BUG= 738148 

Review-Url: https://codereview.chromium.org/2967533002
Cr-Commit-Position: refs/heads/master@{#483609}

[modify] https://crrev.com/08df4b02246c6f05978059918ba6adc37322fe2a/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/WebVrTabTest.java

Comment 4 by timloh@chromium.org, Jun 30 2017

Cc: -bsheedy@chromium.org
Labels: -Sheriff-Chromium
Owner: bsheedy@chromium.org
Status: Assigned (was: Untriaged)
Removing from sheriff queue as the test has been disabled and assigning to bsheedy@ to look into, ptal when you get a chance.
Labels: M-61
I would guess this is either because of  issue 738443  or  issue 737259 
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/148ba381de06ad2c6e420b98e1a3d8992662b6d9

commit 148ba381de06ad2c6e420b98e1a3d8992662b6d9
Author: bsheedy <bsheedy@chromium.org>
Date: Wed Jul 05 18:55:58 2017

Re-enable flaky VR test

Re-enables WebVrTabTest#testPoseDataUnfocusedTab. It was suspected that
https://bugs.chromium.org/p/chromium/issues/detail?id=737259 may have
been the cause, and I was unable to reproduce the flakiness after the
fix for that bug went in. Will keep an eye on this for a few days
after submission to be sure.

Bug:  738148 
Change-Id: I8e98fc58ab3416fffe8c0294eac30c19396a9674
Reviewed-on: https://chromium-review.googlesource.com/559630
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484322}
[modify] https://crrev.com/148ba381de06ad2c6e420b98e1a3d8992662b6d9/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/WebVrTabTest.java

Labels: VR-Test
Status: Fixed (was: Assigned)
Appears to be fixed now.
Components: Blink>WebXR

Sign in to add a comment