Code cleaning and metric retirement for JumpList |
||
Issue descriptionThis bug is filed to track any changes that clean the code or retire the metrics for JumpList.
,
Jul 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f76319aac84ed31caf40bb206699caa487353c31 commit f76319aac84ed31caf40bb206699caa487353c31 Author: Xi Cheng <chengx@chromium.org> Date: Mon Jul 10 20:01:37 2017 Retire WinJumplist.DeleteDirectoryContentDuration UMA metric This metric is no longer needed. Bug: 738126 Change-Id: If8baa53178238335d75ccefd8d6ae9065b2d00ad Reviewed-on: https://chromium-review.googlesource.com/563757 Reviewed-by: Ilya Sherman <isherman@chromium.org> Reviewed-by: Patrick Monette <pmonette@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#485355} [modify] https://crrev.com/f76319aac84ed31caf40bb206699caa487353c31/chrome/browser/win/jumplist.cc [modify] https://crrev.com/f76319aac84ed31caf40bb206699caa487353c31/chrome/browser/win/jumplist_file_util.cc [modify] https://crrev.com/f76319aac84ed31caf40bb206699caa487353c31/chrome/browser/win/jumplist_file_util.h [modify] https://crrev.com/f76319aac84ed31caf40bb206699caa487353c31/tools/metrics/histograms/histograms.xml
,
Jul 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/51d8ed4661845ddd161953250d445ba777a37a8c commit 51d8ed4661845ddd161953250d445ba777a37a8c Author: Xi Cheng <chengx@chromium.org> Date: Tue Jul 11 17:35:13 2017 Remove metric WinJumplist.UpdateJumpListDuration This metric has been marked obsolete in histograms.xml. This CL deletes it in the code. Bug: 738126 Change-Id: I8d0f965fa35a6387a765851210e25f6c136572b0 Reviewed-on: https://chromium-review.googlesource.com/566118 Reviewed-by: Patrick Monette <pmonette@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#485669} [modify] https://crrev.com/51d8ed4661845ddd161953250d445ba777a37a8c/chrome/browser/win/jumplist.cc
,
Jul 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/30f7b97ee69160736dc3a1087bae880264dafd24 commit 30f7b97ee69160736dc3a1087bae880264dafd24 Author: Xi Cheng <chengx@chromium.org> Date: Tue Jul 11 18:57:42 2017 Update NotificationTimeInterval, retire AddTasksDuration for JumpList The metric WinJumplistUpdater.AddTasksDuration is no longer needed. WinJumplist.NotificationTimeInterval is updated to track the percentage of the notifications that get coalesced. Bug: 733034 , 738126 Change-Id: I92669e5cd261a47df8a3a782ea64072c106a4195 Reviewed-on: https://chromium-review.googlesource.com/565580 Commit-Queue: Xi Cheng <chengx@chromium.org> Reviewed-by: Patrick Monette <pmonette@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#485687} [modify] https://crrev.com/30f7b97ee69160736dc3a1087bae880264dafd24/chrome/browser/win/jumplist.cc [modify] https://crrev.com/30f7b97ee69160736dc3a1087bae880264dafd24/chrome/browser/win/jumplist_updater.cc [modify] https://crrev.com/30f7b97ee69160736dc3a1087bae880264dafd24/tools/metrics/histograms/histograms.xml
,
Jul 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/585cbfe2936465d20143ac6da0b4b2a2a4c56f0b commit 585cbfe2936465d20143ac6da0b4b2a2a4c56f0b Author: Xi Cheng <chengx@chromium.org> Date: Thu Jul 13 02:14:11 2017 Remove unused timers for JumpList After landing crrev/2956553002 which removes the metrics, these two elapsed timers are no longer needed. Bug: 738126 Change-Id: I04b29e4728cedb9e7f1fc740036d1a6106cbf0a5 Reviewed-on: https://chromium-review.googlesource.com/566990 Reviewed-by: Patrick Monette <pmonette@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#486222} [modify] https://crrev.com/585cbfe2936465d20143ac6da0b4b2a2a4c56f0b/chrome/browser/win/jumplist.cc
,
Jul 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/54a292d8c1e6bdeef888bfe7ee8b029c4a82ebc0 commit 54a292d8c1e6bdeef888bfe7ee8b029c4a82ebc0 Author: Xi Cheng <chengx@chromium.org> Date: Mon Jul 24 17:26:52 2017 Retire metrics RatioAddCategoryTime and NotificationTimeInterval2 These two UMA metrics are retired as they are no longer needed. Bug: 738126 Cq-Include-Trybots: master.tryserver.chromium.win:win10_chromium_x64_rel_ng Change-Id: I77517a1bd3a9ad6681bce58cd9e06aaf57900327 Reviewed-on: https://chromium-review.googlesource.com/582369 Reviewed-by: Patrick Monette <pmonette@chromium.org> Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#489010} [modify] https://crrev.com/54a292d8c1e6bdeef888bfe7ee8b029c4a82ebc0/chrome/browser/win/jumplist.cc [modify] https://crrev.com/54a292d8c1e6bdeef888bfe7ee8b029c4a82ebc0/tools/metrics/histograms/histograms.xml
,
Jul 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e1af97ee3bc1d6f9b5a9f83d214f3604ca3d26a3 commit e1af97ee3bc1d6f9b5a9f83d214f3604ca3d26a3 Author: Xi Cheng <chengx@chromium.org> Date: Fri Jul 28 02:35:00 2017 Update the documentation of the JumpList class This CL documents the states that an update run can be in, the policy of handling the update notifications, the way an updated JumpList is assembled and written to the OS, the timeout strategy to help slow machines and so on. Bug: 738126 Cq-Include-Trybots: master.tryserver.chromium.win:win10_chromium_x64_rel_ng Change-Id: I5417905442f3b4997098b0967e7b1368bd281a5d Reviewed-on: https://chromium-review.googlesource.com/590387 Commit-Queue: Xi Cheng <chengx@chromium.org> Reviewed-by: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#490217} [modify] https://crrev.com/e1af97ee3bc1d6f9b5a9f83d214f3604ca3d26a3/chrome/browser/win/jumplist.h
,
Jul 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/028616d2593c59a14a87b218b4ef716ae77e1e69 commit 028616d2593c59a14a87b218b4ef716ae77e1e69 Author: Xi Cheng <chengx@chromium.org> Date: Fri Jul 28 20:47:03 2017 Retire OS notification related UMA metrics in JumpList These metrics are no longer needed as crbug/736530 is fixed. Bug: 738126 Change-Id: I497d9192063d16ba57e03924a10e27450ba7dc3a Reviewed-on: https://chromium-review.googlesource.com/586408 Reviewed-by: Patrick Monette <pmonette@chromium.org> Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#490504} [modify] https://crrev.com/028616d2593c59a14a87b218b4ef716ae77e1e69/chrome/browser/win/jumplist_updater.cc [modify] https://crrev.com/028616d2593c59a14a87b218b4ef716ae77e1e69/tools/metrics/histograms/histograms.xml
,
Jul 28 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Jun 30 2017