New issue
Advanced search Search tips

Issue 738120 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

handling of "lgtm" inconsistent in gerrit

Project Member Reported by jochen@chromium.org, Jun 29 2017

Issue description

when typing lgtm in the reply dialog, it'll automatically switch to CR+1, however, when typing e.g. chrome/ lgtm, this doesn't happen

would be nice if "lgtm" anywhere (except for when preceeded by not) would be detected
 

Comment 1 by aga...@chromium.org, Jun 29 2017

Status: WontFix (was: Untriaged)
This is by design. Rietveld's LGTM parsing was an absolute nightmare, and often resulted in people having to post a second message saying "not lgtm" (which then turns scary red) because they didn't realize they'd typed or pasted "lgtm" somewhere in the middle of their message.

We offer the nice shortcut that a message started with "lgtm" will also set CR+1, because that is a very clear indication of intent. Otherwise, please just use the CR+1 button like normal.

Sign in to add a comment