New issue
Advanced search Search tips

Issue 738109 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

run-time detect missing egl extensions and fallback to software

Project Member Reported by boliu@chromium.org, Jun 29 2017

Issue description

fallback to auxilliary bitmap path

This is the first step to removing (some of) hard coded disabling gpu on emulator: https://cs.chromium.org/chromium/src/android_webview/java/src/org/chromium/android_webview/AwContents.java?rcl=7c3996033bfbba55546e24e8845d8f76e271ff27&l=121
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9cad099c836bb41d1324460ba84eeb983655b90f

commit 9cad099c836bb41d1324460ba84eeb983655b90f
Author: Bo Liu <boliu@chromium.org>
Date: Thu Jul 06 14:45:27 2017

aw: Falback to software rendering if missing extensions

Android webview relies on EGLImage extensions to share textures across
context and threads. EGL fence is also required for synchornization:
EGL_KHR_image_base
EGL_KHR_gl_texture_2D_image
GL_OES_EGL_image
EGL_KHR_fence_sync

Detect if these extensions are missing at runtime, and fallback to
super slow software rendering.

Note the check in webview needs to be move to later in init so it
happens after collecting gpu info.

Bug:  738109 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I369d3432b8ee4e58489f1858244f2a315621f10d
Reviewed-on: https://chromium-review.googlesource.com/558654
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: Bo Liu <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484587}
[modify] https://crrev.com/9cad099c836bb41d1324460ba84eeb983655b90f/android_webview/browser/aw_contents.cc
[modify] https://crrev.com/9cad099c836bb41d1324460ba84eeb983655b90f/android_webview/browser/aw_contents.h
[modify] https://crrev.com/9cad099c836bb41d1324460ba84eeb983655b90f/android_webview/java/src/org/chromium/android_webview/AwContents.java
[modify] https://crrev.com/9cad099c836bb41d1324460ba84eeb983655b90f/gpu/config/gpu_info.cc
[modify] https://crrev.com/9cad099c836bb41d1324460ba84eeb983655b90f/gpu/config/gpu_info.h
[modify] https://crrev.com/9cad099c836bb41d1324460ba84eeb983655b90f/gpu/config/gpu_info_collector_android.cc
[modify] https://crrev.com/9cad099c836bb41d1324460ba84eeb983655b90f/gpu/ipc/common/gpu_info.mojom
[modify] https://crrev.com/9cad099c836bb41d1324460ba84eeb983655b90f/gpu/ipc/common/gpu_info_struct_traits.cc
[modify] https://crrev.com/9cad099c836bb41d1324460ba84eeb983655b90f/gpu/ipc/common/gpu_info_struct_traits.h

Project Member

Comment 2 by bugdroid1@chromium.org, Jul 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/428a5f8309bbb20f55f4734ba31680d55498a40f

commit 428a5f8309bbb20f55f4734ba31680d55498a40f
Author: Bo Liu <boliu@chromium.org>
Date: Wed Jul 12 00:11:18 2017

aw: Remove emulator gpu blacklist

Prefer to use dynamic look up required EGL extensions instead.
This is only temporary, to get an official build to allow for manual
testing. Will revert after.

Bug:  738109 
Change-Id: Iaea11e2b6118fa46d1d5ff2d205b1df65e482fd6
Reviewed-on: https://chromium-review.googlesource.com/567422
Reviewed-by: Selim Gurun <sgurun@chromium.org>
Commit-Queue: Bo Liu <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485737}
[modify] https://crrev.com/428a5f8309bbb20f55f4734ba31680d55498a40f/android_webview/java/src/org/chromium/android_webview/AwContents.java

Project Member

Comment 3 by bugdroid1@chromium.org, Jul 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/70bd26799e4304a84ed4b8f958e9b9dc71e46cfa

commit 70bd26799e4304a84ed4b8f958e9b9dc71e46cfa
Author: Bo Liu <boliu@chromium.org>
Date: Wed Jul 12 17:33:59 2017

Revert "aw: Remove emulator gpu blacklist"

This reverts commit 428a5f8309bbb20f55f4734ba31680d55498a40f.

Reason for revert:
Has build 61.0.3155.0 which contains this CL.

Original change's description:
> aw: Remove emulator gpu blacklist
> 
> Prefer to use dynamic look up required EGL extensions instead.
> This is only temporary, to get an official build to allow for manual
> testing. Will revert after.
> 
> Bug:  738109 
> Change-Id: Iaea11e2b6118fa46d1d5ff2d205b1df65e482fd6
> Reviewed-on: https://chromium-review.googlesource.com/567422
> Reviewed-by: Selim Gurun <sgurun@chromium.org>
> Commit-Queue: Bo Liu <boliu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#485737}

TBR=boliu@chromium.org,sgurun@chromium.org

Change-Id: I87fc12af9fc2fda4dcc917f4d56a93746ee4aa67
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  738109 
Reviewed-on: https://chromium-review.googlesource.com/568159
Reviewed-by: Bo Liu <boliu@chromium.org>
Reviewed-by: Selim Gurun <sgurun@chromium.org>
Commit-Queue: Bo Liu <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486009}
[modify] https://crrev.com/70bd26799e4304a84ed4b8f958e9b9dc71e46cfa/android_webview/java/src/org/chromium/android_webview/AwContents.java

Comment 4 by boliu@chromium.org, Jul 17 2017

Status: Fixed (was: Assigned)
technically fixed already. might get one more CL to enable gpu on emulators but we'll see

Sign in to add a comment