NotificationPresenter::RemovePotentialHotspotNotification() needs to be called before each host scan is called, and likely also when host scan results become stale.
Summary: "Available host(s)" notification issues (was: 'available host(s)' notification should be dismissed when a new scan begins)
Merged with another related bug.
Issues to resolve:
(1) The notification is shown when users are already connected to the Internet. It should only be shown if there is no current connection.
(2) The notification should be removed when a connection attempt is started.
(3) The notification should be removed if the HostScanCache becomes empty.
Note: I don't think we should dismiss the notification when a new scan begins, as this bug originally said. When a new scan finishes and successfully finds devices, we can just update the existing notification. When a new scan finishes and does not find any devices, the HostScanCache will become empty, and the notification should be removed (see point (3) above).
One more issue:
(5) The notification should be removed if the Tether TechnologyState becomes anything but ENABLED (e.g., if the user disabled tethering via the settings toggle).
Your change meets the bar and is auto-approved for M61. Please go ahead and merge the CL to branch 3163 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid @(ChromeOS), govind@(Desktop)
For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Comment 1 by khorimoto@chromium.org
, Jul 11 2017