New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 738106 link

Starred by 1 user
Status: Fixed
Owner:
█ jif@chromium.org
Last visit > 30 days ago
Closed: Jul 2017
Cc:
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Task

Blocked on:
issue 740611
Blocking:
issue 738030



Sign in to add a comment

Make the "NewKeyboardAccessoryView" be the default one.

Project Member Reported by jif@chromium.org, Jun 29 2017 
Should be done once M61 has branched.

This entails:
-removing IsKeyboardAccessoryViewWithCameraSearchEnabled
-removing keyboard_accessory_view.mm/keyboard_accessory_view.h
-removing KeyboardAccessoryViewMode
-removing the code that re-instanciate the KAV in web_toolbar_controller.mm's traitCollectionDidChange

Comment 1 by eugene...@chromium.org, Jul 6 2017

Components: UI>Browser>Core
Labels: -Type-Bug Type-Task
jif@, could you please update component when assigning the bug. Thanks!

Comment 2 by jif@chromium.org, Jul 11 2017

Status: Started (was: Assigned)

Comment 3 by jif@chromium.org, Jul 11 2017

Blocking: 738030

Comment 4 by jif@chromium.org, Jul 11 2017

Blockedon: 740611

Comment 5 by jif@chromium.org, Jul 11 2017 

Also required:
-remove obsolete assets
-rename new_kav.[h|mm] to toolbar_kav.[h|mm]
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7774ffbffc14fa93b82ef261a98d923b69db3209

commit 7774ffbffc14fa93b82ef261a98d923b69db3209
Author: Jean-François Geyelin <jif@chromium.org>
Date: Wed Jul 12 16:25:37 2017

[iOS] Prepare for the support of InputAssistantItems on iPad.

This CL cleans the Keyboard Accessory View (KAV) situation for the
web toolbar to support InputAssistantItems on iPad (1).
In particular, this CL:
- Removes keyboard_accessory_view.*.
  Now only new_keyboard_accessory_view.* is used.
- Removes HardwareKeyboardWatcher because it only works when there is
  a KAV (crbug.com/740898).
- Removes |-locationBarChanged| because it would only be used to
  record MobileFirstTextInOmnibox ( crbug.com/740611 ).
- Removes the |_keyboardAccessoryView| ivar. It was used when the KAV
  was not laid out with auto layout and had multiple modes.

(1) https://docs.google.com/document/d/1pWfwHEeCNeWgkDjawJiDoEf93gkDV9usINcYDyXvwcY/edit#heading=h.sku52p315l4d

Bug:  738106 ,  708341 ,  740611 
Change-Id: If6e509de3e6d57f0347b3e355b91af16bd055adb
Reviewed-on: https://chromium-review.googlesource.com/567087
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Jean-François Geyelin <jif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485989}
[modify] https://crrev.com/7774ffbffc14fa93b82ef261a98d923b69db3209/ios/chrome/browser/ui/keyboard/BUILD.gn
[delete] https://crrev.com/f6a6833d464b96fbc7cc27abe41e411487779ba2/ios/chrome/browser/ui/keyboard/hardware_keyboard_watcher.h
[delete] https://crrev.com/f6a6833d464b96fbc7cc27abe41e411487779ba2/ios/chrome/browser/ui/keyboard/hardware_keyboard_watcher.mm
[delete] https://crrev.com/f6a6833d464b96fbc7cc27abe41e411487779ba2/ios/chrome/browser/ui/keyboard/hardware_keyboard_watcher_unittest.mm
[modify] https://crrev.com/7774ffbffc14fa93b82ef261a98d923b69db3209/ios/chrome/browser/ui/omnibox/location_bar_controller_impl.mm
[modify] https://crrev.com/7774ffbffc14fa93b82ef261a98d923b69db3209/ios/chrome/browser/ui/toolbar/BUILD.gn
[delete] https://crrev.com/f6a6833d464b96fbc7cc27abe41e411487779ba2/ios/chrome/browser/ui/toolbar/keyboard_accessory_view.h
[delete] https://crrev.com/f6a6833d464b96fbc7cc27abe41e411487779ba2/ios/chrome/browser/ui/toolbar/keyboard_accessory_view.mm
[add] https://crrev.com/7774ffbffc14fa93b82ef261a98d923b69db3209/ios/chrome/browser/ui/toolbar/keyboard_accessory_view_delegate.h
[delete] https://crrev.com/f6a6833d464b96fbc7cc27abe41e411487779ba2/ios/chrome/browser/ui/toolbar/keyboard_accessory_view_protocol.h
[modify] https://crrev.com/7774ffbffc14fa93b82ef261a98d923b69db3209/ios/chrome/browser/ui/toolbar/new_keyboard_accessory_view.h
[modify] https://crrev.com/7774ffbffc14fa93b82ef261a98d923b69db3209/ios/chrome/browser/ui/toolbar/new_keyboard_accessory_view.mm
[modify] https://crrev.com/7774ffbffc14fa93b82ef261a98d923b69db3209/ios/chrome/browser/ui/toolbar/web_toolbar_controller.mm
[modify] https://crrev.com/7774ffbffc14fa93b82ef261a98d923b69db3209/ios/clean/chrome/browser/ui/omnibox/location_bar_mediator.mm
[modify] https://crrev.com/7774ffbffc14fa93b82ef261a98d923b69db3209/ios/shared/chrome/browser/ui/omnibox/location_bar_delegate.h
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 25 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bf4f873ce4549ea36f8cb0a2b8dcf3cda370a1d2

commit bf4f873ce4549ea36f8cb0a2b8dcf3cda370a1d2
Author: Jean-François Geyelin <jif@chromium.org>
Date: Tue Jul 25 16:36:17 2017

[iOS] Move keyboard accessory view code to separate target.

Bug:  738106 
Change-Id: Ieba5f06da18e55a675ccac0082e0c0bef676abc4
Reviewed-on: https://chromium-review.googlesource.com/580991
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Jean-François Geyelin <jif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489332}
[modify] https://crrev.com/bf4f873ce4549ea36f8cb0a2b8dcf3cda370a1d2/ios/chrome/browser/ui/toolbar/BUILD.gn
[add] https://crrev.com/bf4f873ce4549ea36f8cb0a2b8dcf3cda370a1d2/ios/chrome/browser/ui/toolbar/keyboard_assist/BUILD.gn
[add] https://crrev.com/bf4f873ce4549ea36f8cb0a2b8dcf3cda370a1d2/ios/chrome/browser/ui/toolbar/keyboard_assist/resources/BUILD.gn
[rename] https://crrev.com/bf4f873ce4549ea36f8cb0a2b8dcf3cda370a1d2/ios/chrome/browser/ui/toolbar/keyboard_assist/resources/keyboard_accessory_qr_scanner.imageset/Contents.json
[rename] https://crrev.com/bf4f873ce4549ea36f8cb0a2b8dcf3cda370a1d2/ios/chrome/browser/ui/toolbar/keyboard_assist/resources/keyboard_accessory_qr_scanner.imageset/keyboard_accessory_qr_scanner.png
[rename] https://crrev.com/bf4f873ce4549ea36f8cb0a2b8dcf3cda370a1d2/ios/chrome/browser/ui/toolbar/keyboard_assist/resources/keyboard_accessory_qr_scanner.imageset/keyboard_accessory_qr_scanner@2x.png
[rename] https://crrev.com/bf4f873ce4549ea36f8cb0a2b8dcf3cda370a1d2/ios/chrome/browser/ui/toolbar/keyboard_assist/resources/keyboard_accessory_qr_scanner.imageset/keyboard_accessory_qr_scanner@3x.png
[rename] https://crrev.com/bf4f873ce4549ea36f8cb0a2b8dcf3cda370a1d2/ios/chrome/browser/ui/toolbar/keyboard_assist/resources/keyboard_accessory_voice_search.imageset/Contents.json
[rename] https://crrev.com/bf4f873ce4549ea36f8cb0a2b8dcf3cda370a1d2/ios/chrome/browser/ui/toolbar/keyboard_assist/resources/keyboard_accessory_voice_search.imageset/keyboard_accessory_voice_search.png
[rename] https://crrev.com/bf4f873ce4549ea36f8cb0a2b8dcf3cda370a1d2/ios/chrome/browser/ui/toolbar/keyboard_assist/resources/keyboard_accessory_voice_search.imageset/keyboard_accessory_voice_search@2x.png
[rename] https://crrev.com/bf4f873ce4549ea36f8cb0a2b8dcf3cda370a1d2/ios/chrome/browser/ui/toolbar/keyboard_assist/resources/keyboard_accessory_voice_search.imageset/keyboard_accessory_voice_search@3x.png
[rename] https://crrev.com/bf4f873ce4549ea36f8cb0a2b8dcf3cda370a1d2/ios/chrome/browser/ui/toolbar/keyboard_assist/toolbar_assistive_keyboard_delegate.h
[modify] https://crrev.com/bf4f873ce4549ea36f8cb0a2b8dcf3cda370a1d2/ios/chrome/browser/ui/toolbar/keyboard_assist/toolbar_assistive_keyboard_views.h
[modify] https://crrev.com/bf4f873ce4549ea36f8cb0a2b8dcf3cda370a1d2/ios/chrome/browser/ui/toolbar/keyboard_assist/toolbar_assistive_keyboard_views.mm
[rename] https://crrev.com/bf4f873ce4549ea36f8cb0a2b8dcf3cda370a1d2/ios/chrome/browser/ui/toolbar/keyboard_assist/toolbar_keyboard_accessory_view.h
[rename] https://crrev.com/bf4f873ce4549ea36f8cb0a2b8dcf3cda370a1d2/ios/chrome/browser/ui/toolbar/keyboard_assist/toolbar_keyboard_accessory_view.mm
[modify] https://crrev.com/bf4f873ce4549ea36f8cb0a2b8dcf3cda370a1d2/ios/chrome/browser/ui/toolbar/resources/BUILD.gn
[modify] https://crrev.com/bf4f873ce4549ea36f8cb0a2b8dcf3cda370a1d2/ios/chrome/browser/ui/toolbar/web_toolbar_controller.mm

Comment 9 by jif@chromium.org, Jul 26 2017

Status: Fixed (was: Started)
Project Member

Comment 10 by bugdroid1@chromium.org, Jul 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/709777eba8e607ee24ed23f067aaebf39628b0b0

commit 709777eba8e607ee24ed23f067aaebf39628b0b0
Author: Jean-François Geyelin <jif@chromium.org>
Date: Thu Jul 27 09:10:46 2017

[iOS] Remove IDC_SHOW_QR_SCANNER

Bug:  738881 ,  738106 
Change-Id: I22773332fdc53a22754e79b6030bc285e599f9da
Reviewed-on: https://chromium-review.googlesource.com/586597
Commit-Queue: Jean-François Geyelin <jif@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489887}
[modify] https://crrev.com/709777eba8e607ee24ed23f067aaebf39628b0b0/ios/chrome/app/main_controller.mm
[modify] https://crrev.com/709777eba8e607ee24ed23f067aaebf39628b0b0/ios/chrome/browser/ui/browser_view_controller.h
[modify] https://crrev.com/709777eba8e607ee24ed23f067aaebf39628b0b0/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/709777eba8e607ee24ed23f067aaebf39628b0b0/ios/chrome/browser/ui/commands/browser_commands.h
[modify] https://crrev.com/709777eba8e607ee24ed23f067aaebf39628b0b0/ios/chrome/browser/ui/commands/ios_command_ids.h
[modify] https://crrev.com/709777eba8e607ee24ed23f067aaebf39628b0b0/ios/chrome/browser/ui/toolbar/keyboard_assist/toolbar_assistive_keyboard_delegate.h
[modify] https://crrev.com/709777eba8e607ee24ed23f067aaebf39628b0b0/ios/chrome/browser/ui/toolbar/keyboard_assist/toolbar_assistive_keyboard_views.mm
[modify] https://crrev.com/709777eba8e607ee24ed23f067aaebf39628b0b0/ios/chrome/browser/ui/toolbar/web_toolbar_controller.mm
►

Sign in to add a comment