New issue
Advanced search Search tips

Issue 738101 link

Starred by 1 user
Status: Fixed
Owner:
afakhry@chromium.org
Closed: Jun 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

[Night Light] UI Enhancements to Scheduler

Project Member Reported by ovanieva@chromium.org, Jun 29 2017 
suggestions from UI Review to be landed for M61:

- On scheduler the time overlap when dragged close-by. They should already be stacked at this point.

- The grabbed time indicator is too big - we should limit its scaling to 125% it's original size. The spec is updated.

- Padding between slider knob and time chip is too big right now. It should be 8dp. It should also be maintained when we show the scaled up version.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 30 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0f66f4a7c5941784cbfd8600cc36671218ef6c1d

commit 0f66f4a7c5941784cbfd8600cc36671218ef6c1d
Author: afakhry <afakhry@chromium.org>
Date: Fri Jun 30 18:38:01 2017

[Night Light] CL11: Enhancements

Implement requested enhancements by UI review:
- Make short animation duration = 1 second.
- Reduce expanded knob scale to 125%.
- Prevent label bubbles from touching.
- Reduce label bubble and knob distance.
- Add a cubic-bezier label-bubble overlap animation.
- Make knobs snap distance = 60 minutes.

Demo: https://bugs.chromium.org/p/chromium/issues/detail?id=705816#c28

BUG=705816, 738101 , 738102 , 736875 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2969473004
Cr-Commit-Position: refs/heads/master@{#483774}

[modify] https://crrev.com/0f66f4a7c5941784cbfd8600cc36671218ef6c1d/ash/system/night_light/night_light_controller.cc
[modify] https://crrev.com/0f66f4a7c5941784cbfd8600cc36671218ef6c1d/chrome/browser/resources/settings/device_page/night_light_slider.html
[modify] https://crrev.com/0f66f4a7c5941784cbfd8600cc36671218ef6c1d/chrome/browser/resources/settings/device_page/night_light_slider.js

Comment 2 by afakhry@chromium.org, Jun 30 2017

Status: Fixed (was: Untriaged)
►

Sign in to add a comment