Settings: Mobile data sub-page should be available even with no devices available |
||
Issue description0) Enable Instant Tethering. 1) Ensure no Tether hosts have been scanned. 2) Open settings. Expected: When the Mobile data section is clicked, it will bring users to a Mobile data sub-page, similar to the Wi-Fi section sub-page. Actual: Mobile data section doesn't do anything when clicked, despite the mouse cursor changing to a pointer when it is hovered. Clicking the section only works once a Tether host has already been scanned.
,
Jul 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/38f4b19162b7938b4993e9fa8a1d569373b45fbb commit 38f4b19162b7938b4993e9fa8a1d569373b45fbb Author: Kyle Horimoto <khorimoto@google.com> Date: Wed Jul 19 01:23:57 2017 [CrOS Tether] Enable the Mobile data settings subpage when no scanned Tether hosts are present. This fixes an issue in which clicking the Mobile data page did nothing when there were no scanned Tether hosts. This CL also shows a message to the user in this situation which alerts the user to turn on Instant Tethering. Note: This CL also fixes an issue in which the "no networks" message was not actually ever shown. Previously, we used the Polymer binding: hidden$="[[networkStateList_.length]]" However, this binding returned "0", which Polymer converted to a truthy string; as a result, this element was *always* hidden. Instead, I converted this to a function call. Bug: 672263, 738100 Change-Id: I6194a0b681606fffbab8b711a9ca4283343db9e0 Reviewed-on: https://chromium-review.googlesource.com/576663 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#487707} [modify] https://crrev.com/38f4b19162b7938b4993e9fa8a1d569373b45fbb/chrome/app/settings_strings.grdp [modify] https://crrev.com/38f4b19162b7938b4993e9fa8a1d569373b45fbb/chrome/browser/resources/settings/internet_page/internet_subpage.html [modify] https://crrev.com/38f4b19162b7938b4993e9fa8a1d569373b45fbb/chrome/browser/resources/settings/internet_page/internet_subpage.js [modify] https://crrev.com/38f4b19162b7938b4993e9fa8a1d569373b45fbb/chrome/browser/resources/settings/internet_page/network_summary_item.js [modify] https://crrev.com/38f4b19162b7938b4993e9fa8a1d569373b45fbb/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc [modify] https://crrev.com/38f4b19162b7938b4993e9fa8a1d569373b45fbb/chrome/common/url_constants.cc [modify] https://crrev.com/38f4b19162b7938b4993e9fa8a1d569373b45fbb/chrome/common/url_constants.h
,
Jul 19 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by khorimoto@chromium.org
, Jul 18 2017