New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 738092 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug



Sign in to add a comment

ios_web_view_inttests should be running on upstream bots

Project Member Reported by rohitrao@chromium.org, Jun 29 2017

Issue description

I believe that this is a public test suite, but for some reason it's only running on downstream bots.  We should add it to the CQ if possible, or to chromium.fyi if not.

(Alternatively, we could remove the tests from the downstream bots, if they're unimportant for some reason.)
 

Comment 1 Deleted

Let's move these tests to the downstream FYI waterfall please.  If it's not a priority to solve the infra issues that are keeping them from running upstream, then they shouldn't be important enough to block the autoroller or close the downstream tree.
Cc: sdefresne@chromium.org
Components: Test>iOS
I've tried to put on on bot, but if fails (I think because of dependency issues in GN):
https://codereview.chromium.org/2941443002/ (see purple bot). I asked Sylvain if he know how to fix the problem, but then forgot to follow up. Sylvain, do you know why ChromeWebView is not built with ios_web_view_inttests target?
I see, it looks like this is failing because the framework is not signed. I will look into singing the framework. (The cronet folks alluded to this the fact that the framework may require code signing and I was planning to look into this further soon anyway.

From the log of the purple ios-simulator run:
"required code signature missing for '...ios_web_view_inttests.app/Frameworks/ChromeWebView.framework/ChromeWebView'"
Maybe the problem is that only downstream bots can sign the binary?
We may have enabled simulator signing as part of  Issue 638141 .  It was enabled downstream, but not upstream.  We might have hit the same problem here as well.

I kicked off some new tryjobs on the original CL.  Let's see how they do.
The original CL needed a rebase so I uploaded a new one and am running it through the trybots.

CL is here: https://chromium-review.googlesource.com/556394

It does look like it passes the ios-simulator bot now, however half of the upload steps after the tests ran failed and I'm unsure why.

Please see "Upload to test-results [ios_web_view_inttests]" steps in results here: https://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/248973

Any ideas why this would fail and is it a problem?
Was it an intentional decision to use "/" as a delimiter in test names, rather than "." like gtest uses?  Is this something that can be changed?
Sorry, ignore the "/" question.  I was looking at unrelated test output.

I think the 400s are unrelated, because your CL couldn't have affected any egtests.  I'll kick off some more tryjobs to see.
Cc: sergeybe...@chromium.org
The first two attempts to upload test results fail every time, it seems always reproducible rather than some unrelated issue. I don't see the 400 errors on any other steps.

https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Ftryserver.chromium.mac%2Fios-simulator%2F249417%2F%2B%2Frecipes%2Fsteps%2FUpload_to_test-results__ios_web_view_inttests_%2F0%2Fstdout

+ sergeyberezin@ Sergey, do you have any idea what could be causing this consistent 400 failure the first 2 times when uploading test results? The second two times of each test run seem ok.

Project Member

Comment 12 by bugdroid1@chromium.org, Jul 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/562972160cd3ccbf31cebc2300d46fe4f69451a4

commit 562972160cd3ccbf31cebc2300d46fe4f69451a4
Author: Mike Dougherty <michaeldo@chromium.org>
Date: Wed Jul 05 17:42:07 2017

Add ios_web_view_inttests test suite to the bots.

This test suite has just a few quick tests and should not really have
any impact on bots capacity.

BUG= 738092 

Change-Id: I2b4d8b42c865a291bb8eb94c12ae0fe19a3d7a9b
Reviewed-on: https://chromium-review.googlesource.com/556394
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484302}
[modify] https://crrev.com/562972160cd3ccbf31cebc2300d46fe4f69451a4/ios/build/bots/tests/common_tests.json

Status: Assigned (was: Untriaged)
Status: Fixed (was: Assigned)
Project Member

Comment 15 by bugdroid1@chromium.org, Jul 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/699927d1ada48b55db3663529b23323ec205b7a8

commit 699927d1ada48b55db3663529b23323ec205b7a8
Author: Mike Dougherty <michaeldo@chromium.org>
Date: Wed Jul 05 19:43:24 2017

Revert "Add ios_web_view_inttests test suite to the bots."

This reverts commit 562972160cd3ccbf31cebc2300d46fe4f69451a4.

Reason for revert: Failing analyze step.  crbug.com/739469 

Original change's description:
> Add ios_web_view_inttests test suite to the bots.
> 
> This test suite has just a few quick tests and should not really have
> any impact on bots capacity.
> 
> BUG= 738092 
> 
> Change-Id: I2b4d8b42c865a291bb8eb94c12ae0fe19a3d7a9b
> Reviewed-on: https://chromium-review.googlesource.com/556394
> Reviewed-by: Eugene But <eugenebut@chromium.org>
> Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#484302}

TBR=eugenebut@chromium.org,michaeldo@chromium.org

Change-Id: Iac13343989cb576071863a4c290fc5ecb55598cc
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  738092 
Reviewed-on: https://chromium-review.googlesource.com/559918
Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484330}
[modify] https://crrev.com/699927d1ada48b55db3663529b23323ec205b7a8/ios/build/bots/tests/common_tests.json

Status: Started (was: Fixed)
Project Member

Comment 17 by bugdroid1@chromium.org, Jul 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/33e75bbcf30171f4bfa94525cb2955d7e24fe7f3

commit 33e75bbcf30171f4bfa94525cb2955d7e24fe7f3
Author: Mike Dougherty <michaeldo@chromium.org>
Date: Thu Jul 13 16:32:26 2017

Add ios_web_view_inttests test suite to the bots.

Reland of https://chromium-review.googlesource.com/c/556394 which was
reverted due to failure of the analyze step.

The analyze step failed locally with the input file as described in #c0
of  crbug.com/739469 . After modifications to manage.py and
gn_isolate_map.pyl, the analyze step passes successfully.

The configuration also moved to screen_size_dependent_tests.json.

Bug:  738092 
Change-Id: I29b96e57ab193c2dd7045f91199a5f87f2621e2f
Reviewed-on: https://chromium-review.googlesource.com/559945
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486409}
[modify] https://crrev.com/33e75bbcf30171f4bfa94525cb2955d7e24fe7f3/ios/build/bots/tests/screen_size_dependent_tests.json
[modify] https://crrev.com/33e75bbcf30171f4bfa94525cb2955d7e24fe7f3/testing/buildbot/gn_isolate_map.pyl
[modify] https://crrev.com/33e75bbcf30171f4bfa94525cb2955d7e24fe7f3/testing/buildbot/manage.py

Status: Fixed (was: Started)

Sign in to add a comment