Audio Parameters Incorrect For System Audio Capture When Microphone or Speaker Missing |
||||
Issue descriptionChrome Version: M61 System (loopback) audio capture relies on the existence of a speaker to work. But when query the preferred audio parameters, we check the existence of a microphone to decide whether using fallback parameters or not. See [1]. Ideally, we should check the existence of a speaker in the loopback case. [1] https://cs.chromium.org/chromium/src/media/audio/audio_system_impl.cc?type=cs&l=166
,
Jun 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/84323803d1079a3c3180196b7947fff6064550c5 commit 84323803d1079a3c3180196b7947fff6064550c5 Author: Qiang Chen <qiangchen@google.com> Date: Fri Jun 30 16:47:43 2017 Bug Fix: System audio capture abnormal when microphones missing When querying audio parameters for a given device id, we check the existence of microphones, which is correct if we want to capture microphone stream. But it is not a correct check, if we need to capture the system audio, we should instead guarantee the existence of a speaker device. Bug: 738053 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I2511da28c23cd44b1077efd52f1c80b1b5aed848 Reviewed-on: https://chromium-review.googlesource.com/550935 Reviewed-by: Yuri Wiitala <miu@chromium.org> Reviewed-by: Olga Sharonova <olka@chromium.org> Commit-Queue: Qiang Chen <qiangchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#483733} [modify] https://crrev.com/84323803d1079a3c3180196b7947fff6064550c5/media/audio/audio_device_description.cc [modify] https://crrev.com/84323803d1079a3c3180196b7947fff6064550c5/media/audio/audio_device_description.h [modify] https://crrev.com/84323803d1079a3c3180196b7947fff6064550c5/media/audio/audio_system_impl.cc
,
Jun 30 2017
,
Jul 3 2017
Should it be merged to M60 on top of the fix to Issue 733356 ?
,
Jul 5 2017
,
Jul 5 2017
The bug is marked as P3 or Feature. It should not be merged as M60 is in beta. Please contact the approriate milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 5 2017
Ah, merge request rejected. Anyway, non-optimal parameters may lead some extra resampling work on the code path, but no crash anymore. So this CL is not so urgent to be merged.
,
Dec 19 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by qiangchen@chromium.org
, Jun 29 2017