Use explicit TimeDelta values, rather than "frame_duration_" in FrameProcessorTests for readability |
|||
Issue description
,
Oct 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1648bb02f9707a8d4db1318942a4e27056c73060 commit 1648bb02f9707a8d4db1318942a4e27056c73060 Author: Matt Wolenetz <wolenetz@chromium.org> Date: Tue Oct 03 22:17:27 2017 MSE: Improve FrameProcessorTest readability The tests assumed the reader understood the current value of |frame_duration_|, and also overused |frame_duration_| in some cases (like seeking, expectation checking, etc.). This change inlines the actual time values in milliseconds in the tests to make them more readable. BUG= 738034 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Icafdf69e2be4bce8837ca755325d70d44e8e2f46 Reviewed-on: https://chromium-review.googlesource.com/692509 Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Reviewed-by: Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#506205} [modify] https://crrev.com/1648bb02f9707a8d4db1318942a4e27056c73060/media/filters/frame_processor_unittest.cc
,
Oct 3 2017
#2 fixes this issue.
,
Oct 3 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by wolenetz@chromium.org
, Sep 29 2017Status: Started (was: Assigned)