[MacViews] Traffic lights are mis-positioned |
|||
Issue descriptionIn Cocoa builds, the traffic lights are vertically centered inside the tab strip; in MacViews builds, they are at the default position, which is not centered relative to the tab strip. This probably means duplicating or factoring out the logic in FramedBrowserWindow; we need to pay special attention to: 1) The hit-testing logic in [FramedBrowserWindow accessibilityHitTest:], since this might be difficult to factor out 2) The [FramedBrowserWindow forbidAddingWindowButtonsTrackingArea] workaround
,
Feb 7 2018
,
Feb 10 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3401663175b3a9803095bd43434d6886b6c2b378 commit 3401663175b3a9803095bd43434d6886b6c2b378 Author: Sidney San Martín <sdy@chromium.org> Date: Sat Feb 10 03:50:18 2018 [MacViews] Add a browser window class with custom title bar height and button placement. - Like a Cocoa build, the work is done by a custom frame view class. - MacViews browser will target macOS 10.10+, so don't bother emulating NSFullSizeContentViewWindowMask or positioning the full screen button. (There's one @available guard because Chrome's deployment target is still 10.9). Bug: 737957 Change-Id: I6b9a848b750c3fda5a7b172da8f7b78d5e2b033d Reviewed-on: https://chromium-review.googlesource.com/912628 Commit-Queue: Sidney San Martín <sdy@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#535951} [modify] https://crrev.com/3401663175b3a9803095bd43434d6886b6c2b378/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/3401663175b3a9803095bd43434d6886b6c2b378/chrome/browser/ui/views/frame/browser_frame_mac.mm [add] https://crrev.com/3401663175b3a9803095bd43434d6886b6c2b378/chrome/browser/ui/views/frame/browser_native_widget_window_mac.h [add] https://crrev.com/3401663175b3a9803095bd43434d6886b6c2b378/chrome/browser/ui/views/frame/browser_native_widget_window_mac.mm
,
Mar 5 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by ellyjo...@chromium.org
, Jan 11 2018Owner: sdy@chromium.org
Status: Assigned (was: Available)