New issue
Advanced search Search tips

Issue 737947 link

Starred by 2 users
Status: WontFix
Owner:
eroman@chromium.org
Closed: Jun 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

[Missing tests]:net::URLRequestContext/Builder and net::ProxyService should use SequencedTaskRunner

Project Member Reported by ranjitkan@chromium.org, Jun 29 2017 
Automated tests for the below commit have been missing.Would it be possible to add test coverage to avoid regressions in future?

CL: https://chromium.googlesource.com/chromium/src/+/98e76eb9375e2db29291163aeec9f0bdf9ff85cb

Ref Bug: 
https://bugs.chromium.org/p/chromium/issues/detail?id=735368&desc=2

Thank you!

Comment 1 by mmenke@chromium.org, Jun 29 2017 

Is this really something worth having tests for?  What would a test do, exactly?  Implement its own SequencedTaskRunner subclass that deliberately executes tasks on different threads and makes sure nothing breaks?  Should that be done for every single class that takes a SequencedTaskRunner?  If not, why single out this case?

Comment 2 by eroman@chromium.org, Jun 29 2017

Status: WontFix (was: Assigned)
Closing as WontFix as I am not sure what test coverage you would like to see.

Code is exercising the use of the SequencedTaskRunner in question.

Short of changing the IOThread to be a non-SingleThreadedTaskRunner and seeing if tests continue to pass (or fail due to some thread affinity), I don't think there is much more to do.

That latter configuration wouldn't make sense IMO, but if that seems important it would be an argument to revert my change and keep passing IO Thread as a SingleThreadedTaskRunner.
►

Sign in to add a comment