New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 737942 link

Starred by 1 user
Status: Started
Owner:
█ djkurtz@chromium.org
Last visit > 30 days ago
Cc:
benchan@chromium.org
drinkcat@chromium.org
derat@chromium.org
mnissler@chromium.org
vapier@chromium.org
█ ejcaruso@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 649672



Sign in to add a comment

Fix chromeos-base/libchrome for OpenSSL 1.1

Project Member Reported by djkurtz@chromium.org, Jun 29 2017 
Chrome OS currently uses chromeos-base/libchrome-395517-r10, which points to:
commit 7b88bc885b9d8dc551beab840b853a79fa06494d
Add build options to skip some libraries

In the repository aosp/external/libchrome, with one extra patch applied on top.

This actual builds fine with dev-libs/openssl-1.1.0f - however, it installs a header file "crypto/scoped_openssl_types.h" which is not compatible with OpenSSL 1.1 due to the line:

using ScopedEVP_MD_CTX = ScopedOpenSSL<EVP_MD_CTX, EVP_MD_CTX_destroy>;

because EVP_MD_CTX_destroy has been replaced by EVP_MD_CTX_free in OpenSSL 1.1.

Comment 1 by djkurtz@chromium.org, Jun 29 2017 

One complication with fixing this, is "crypto/scoped_openssl_types.h" itself has been removed from upstream Chromium, in favor of the equivalent BoringSSL scopers.

See: https://chromium.googlesource.com/chromium/src/+/f165962d15779b07d42d5ecefd304c494a459f1c

So, for now we can fix this with a local non-upstream patch to aosp/external/libchrome.
►

Sign in to add a comment