New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 737933 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jul 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

CHECK failure: false in DOMPluginArray.cpp

Project Member Reported by ClusterFuzz, Jun 29 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5993441652899840

Fuzzer: inferno_twister
Job Type: mac_asan_content_shell
Platform Id: mac

Crash Type: CHECK failure
Crash Address: 
Crash State:
  false in DOMPluginArray.cpp
  blink::DOMPluginArray::item
  blink::V8PluginArray::indexedPropertyGetterCallback
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=mac_asan_content_shell&range=481648:481685

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5993441652899840


Issue filed automatically.

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 
Project Member

Comment 1 by ClusterFuzz, Jun 29 2017

Labels: OS-Linux
Cc: msrchandra@chromium.org
Labels: M-61 Test-Predator-Wrong
Owner: lfg@chromium.org
Status: Assigned (was: Untriaged)
Predator and CL did not provide any possible suspects.
Using Code Search for the file, "DOMPluginArray.cpp" assigning to the concern owner.
Suspecting Commit#
https://chromium.googlesource.com/chromium/src/+/309a5318b1dac39692ffd771f249b0f7e02e1fe5

@lfg -- Could you please look into the issue, kindly re-assign if this is not related to your changes.
Thank You.

Comment 3 by lfg@chromium.org, Jun 30 2017

Labels: -Pri-1 Pri-2
I can reproduce, this is issue is test-only, a problem in the layout test runner.
Project Member

Comment 4 by ClusterFuzz, Jul 2 2017

Labels: OS-Windows
Project Member

Comment 5 by ClusterFuzz, Jul 6 2017

ClusterFuzz has detected this issue as fixed in range 484025:484263.

Detailed report: https://clusterfuzz.com/testcase?key=5993441652899840

Fuzzer: inferno_twister
Job Type: mac_asan_content_shell
Platform Id: mac

Crash Type: CHECK failure
Crash Address: 
Crash State:
  false in DOMPluginArray.cpp
  blink::DOMPluginArray::item
  blink::V8PluginArray::indexedPropertyGetterCallback
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=mac_asan_content_shell&range=481648:481685
Fixed: https://clusterfuzz.com/revisions?job=mac_asan_content_shell&range=484025:484263

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5993441652899840


See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 6 by ClusterFuzz, Jul 6 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 5993441652899840 is verified as fixed, so closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/18bb1984886aa473f24fefa9b91e4f524a086e45

commit 18bb1984886aa473f24fefa9b91e4f524a086e45
Author: Lucas Furukawa Gadani <lfg@chromium.org>
Date: Thu Jul 06 13:23:24 2017

Fix crash in TestRunner.

When disallowing plugins, TestRunner needs to notify blink so that
existing instances of DOMPluginArrays can be invalidated.

Bug:  737933 
Change-Id: I42257f458a509159fb196e63cb545aae4dd8ef86
Reviewed-on: https://chromium-review.googlesource.com/558544
Commit-Queue: Lucas Gadani <lfg@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Lukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484566}
[modify] https://crrev.com/18bb1984886aa473f24fefa9b91e4f524a086e45/chrome/renderer/content_settings_observer.cc
[modify] https://crrev.com/18bb1984886aa473f24fefa9b91e4f524a086e45/chrome/renderer/content_settings_observer.h
[modify] https://crrev.com/18bb1984886aa473f24fefa9b91e4f524a086e45/content/shell/test_runner/mock_content_settings_client.cc
[modify] https://crrev.com/18bb1984886aa473f24fefa9b91e4f524a086e45/content/shell/test_runner/mock_content_settings_client.h
[modify] https://crrev.com/18bb1984886aa473f24fefa9b91e4f524a086e45/content/shell/test_runner/test_runner.cc
[modify] https://crrev.com/18bb1984886aa473f24fefa9b91e4f524a086e45/third_party/WebKit/Source/core/frame/ContentSettingsClient.cpp
[modify] https://crrev.com/18bb1984886aa473f24fefa9b91e4f524a086e45/third_party/WebKit/Source/core/frame/ContentSettingsClient.h
[modify] https://crrev.com/18bb1984886aa473f24fefa9b91e4f524a086e45/third_party/WebKit/Source/core/loader/FrameLoader.cpp
[modify] https://crrev.com/18bb1984886aa473f24fefa9b91e4f524a086e45/third_party/WebKit/public/platform/WebContentSettingsClient.h

Sign in to add a comment