Data saver promo in incognito tab |
|||
Issue descriptionI just got a data saver promo while I was on an incognito tab. Data saver is disabled in incognito, so I think it would be better if the promo isn't shown while in incognito? The steps I did were: On a relatively fresh install of chrome canary, open incognito tab, change display size in android settings, go back to chrome, see "save data and browse faster" while on incognito tab. Maybe something in these steps triggered the promo? Version: Chrome Canary 61.0.3143.0
,
Jul 6 2017
,
Jul 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7e469cba37139f2f438acbeef855923d21c731c8 commit 7e469cba37139f2f438acbeef855923d21c731c8 Author: megjablon <megjablon@chromium.org> Date: Tue Jul 11 00:13:37 2017 Don't show the Data Saver promo in incognito mode BUG= 737926 Review-Url: https://codereview.chromium.org/2969843004 Cr-Commit-Position: refs/heads/master@{#485456} [modify] https://crrev.com/7e469cba37139f2f438acbeef855923d21c731c8/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java [modify] https://crrev.com/7e469cba37139f2f438acbeef855923d21c731c8/chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionPromoScreen.java
,
Jul 11 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by bengr@chromium.org
, Jun 30 2017Owner: megjab...@chromium.org
Status: Assigned (was: Untriaged)