New issue
Advanced search Search tips

Issue 737920 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Make pytest documents better

Project Member Reported by hungte@chromium.org, Jun 29 2017

Issue description

The docstring provides a way to describe test details and we are publishing factor pytest docs in https://storage.googleapis.com/chromeos-factory-docs/sdk/pytests/index.html .

Currently most tests do not have "good" docs. I think we want to create a template so that each test has following information that when a partner or non-factory engineer asks "what does this test do?", we can have a good page of description:

SUMMARY (One line as summary of this test)

DESCRIPTION

 Short description for what this test is and the scope of test.

TEST PROCEDURE

 Mostly for interactive tests - what OP should do.

DEPENDENCY

 List what python modules or userland tools are needed

EXAMPLE
 
 Example of how to use this test (in test list).

NOTES
 
 Additional notes (if any)
 

Comment 1 by hungte@chromium.org, Jun 29 2017

Cc: youcheng@chromium.org phoenixshen@chromium.org
Anyone is available in helping this?

You can define the template of test description - the items I've listed are just for reference.

Comment 2 by hungte@chromium.org, Jun 30 2017

Let's do this by assigning everyone to solve few tests.

Comment 3 by hungte@chromium.org, Jun 30 2017

Status: Started (was: Untriaged)
I think the template would be:

Description
-----------

Test Procedure
--------------

Dependency
----------

Examples
--------
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/b9862c4377c46ff892748c550c3cc12d893380cc

commit b9862c4377c46ff892748c550c3cc12d893380cc
Author: Hung-Te Lin <hungte@chromium.org>
Date: Fri Jun 30 11:53:41 2017

pytests: Make better docs for stressapptest and stylus.

Document stressapptest (non-interactive) and style (interactive) in the
new template.

BUG= chromium:737920 
TEST=make doc

Change-Id: I6abdb2e66c4892501b61697725ce945b95caf77d
Reviewed-on: https://chromium-review.googlesource.com/555690
Commit-Ready: Hung-Te Lin <hungte@chromium.org>
Tested-by: Hung-Te Lin <hungte@chromium.org>
Reviewed-by: Youcheng Syu <youcheng@chromium.org>

[modify] https://crrev.com/b9862c4377c46ff892748c550c3cc12d893380cc/py/test/pytests/stressapptest.py
[modify] https://crrev.com/b9862c4377c46ff892748c550c3cc12d893380cc/py/test/pytests/stylus.py
[modify] https://crrev.com/b9862c4377c46ff892748c550c3cc12d893380cc/doc/pytests/index.rst
[modify] https://crrev.com/b9862c4377c46ff892748c550c3cc12d893380cc/Makefile

Project Member

Comment 5 by bugdroid1@chromium.org, Jul 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/8e2a9b6e3acffe55a2207fc58618f711f14fb5d5

commit 8e2a9b6e3acffe55a2207fc58618f711f14fb5d5
Author: Peter Shih <pihsun@chromium.org>
Date: Tue Jul 04 13:51:01 2017

pytests: Make better docs for nop.

Document nop pytest.

BUG= chromium:737920 
TEST=make doc

Change-Id: Ib4a6210b7c1096e17a55966939c70f571fcdbc1a
Reviewed-on: https://chromium-review.googlesource.com/559025
Commit-Ready: Pi-Hsun Shih <pihsun@chromium.org>
Tested-by: Pi-Hsun Shih <pihsun@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>

[modify] https://crrev.com/8e2a9b6e3acffe55a2207fc58618f711f14fb5d5/py/test/pytests/nop.py

Another example in b/63270390#comment2

Developers may ask "StressGroup_fail: What does this test do? Is it running reboot stress test?"
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/b1ce9feba72f1f658745be05ce9e939d69b88c8f

commit b1ce9feba72f1f658745be05ce9e939d69b88c8f
Author: Ting Shen <phoenixshen@google.com>
Date: Wed Jul 05 21:24:48 2017

execpython: add document string

BUG= chromium:737920 
TEST=make doc

Change-Id: I992fc9127e2f37f892e0d948278296532d23810c
Reviewed-on: https://chromium-review.googlesource.com/559035
Commit-Ready: Ting Shen <phoenixshen@chromium.org>
Tested-by: Ting Shen <phoenixshen@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>

[modify] https://crrev.com/b1ce9feba72f1f658745be05ce9e939d69b88c8f/py/test/pytests/execpython.py

Project Member

Comment 8 by bugdroid1@chromium.org, Jul 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/5ec3d70126422cb4a28d25d9176268e06d3acefe

commit 5ec3d70126422cb4a28d25d9176268e06d3acefe
Author: You-Cheng Syu <youcheng@chromium.org>
Date: Thu Jul 06 10:26:31 2017

pytests: Make better docs for touchpad, touchpad_hover, and touchscreen.

Document touchpad, touchpad_hover, and touchscreen pytests.

BUG= chromium:737920 
TEST=none

Change-Id: I71335ad7f277175e2c5d1fdaef1dddc3a9944935
Reviewed-on: https://chromium-review.googlesource.com/559369
Commit-Ready: Youcheng Syu <youcheng@chromium.org>
Tested-by: Youcheng Syu <youcheng@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>

[modify] https://crrev.com/5ec3d70126422cb4a28d25d9176268e06d3acefe/py/test/pytests/touchpad.py
[modify] https://crrev.com/5ec3d70126422cb4a28d25d9176268e06d3acefe/py/test/pytests/touchscreen.py
[modify] https://crrev.com/5ec3d70126422cb4a28d25d9176268e06d3acefe/py/test/pytests/touchpad_hover.py

Project Member

Comment 9 by bugdroid1@chromium.org, Jul 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/89cdac072c63a99dded4a9c125dfdbb1e0c53790

commit 89cdac072c63a99dded4a9c125dfdbb1e0c53790
Author: Hung-Te Lin <hungte@chromium.org>
Date: Fri Jul 07 16:26:21 2017

pytests: Fix and improve update_device_data to take values from JSON config.

To share test lists, we want to provision device data from an external
source instead of hard-coded values in test list. The new config_name
argument allows loading device data from a JSON config (using
config_utils).

Since JSON config may come in flattened or layered, we do want to
flatten before using it, so the FlattenData is moved from
shopfloor_service to device_data module.

Also few bug fixes:

- Entry.key was not properly set.
- When value is specified as non-zero from fields or JSON config, we
  should use it with higher priority than existing values in DUT device data.
- Fevised test doc for how to use the test for RMA and pre-defined (from
  test list or board config) values.

BUG= chromium:737920 
TEST=none

Change-Id: I288f2403c52e84d089cc8c8f8b70d488ea65e85b
Reviewed-on: https://chromium-review.googlesource.com/562851
Commit-Ready: Hung-Te Lin <hungte@chromium.org>
Tested-by: Hung-Te Lin <hungte@chromium.org>
Reviewed-by: Wei-Han Chen <stimim@chromium.org>

[modify] https://crrev.com/89cdac072c63a99dded4a9c125dfdbb1e0c53790/py/test/pytests/update_device_data.py
[modify] https://crrev.com/89cdac072c63a99dded4a9c125dfdbb1e0c53790/py/test/device_data.py
[add] https://crrev.com/89cdac072c63a99dded4a9c125dfdbb1e0c53790/py/test/device_data.schema.json
[modify] https://crrev.com/89cdac072c63a99dded4a9c125dfdbb1e0c53790/py/test/pytests/shopfloor_service.py

Project Member

Comment 10 by bugdroid1@chromium.org, Jul 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/a63a83732918a5bbe0ecad21eb259e9e5b78dd3f

commit a63a83732918a5bbe0ecad21eb259e9e5b78dd3f
Author: Chih-Yu Huang <akahuang@google.com>
Date: Wed Jul 12 16:31:57 2017

pytest: Make better docs for rf_graphyte.

BUG= chromium:737920 
TEST=make doc

Change-Id: Ic44baf6b8ae5b43649bd71b7fd05a2418e6f9809
Reviewed-on: https://chromium-review.googlesource.com/558534
Commit-Ready: Hung-Te Lin <hungte@chromium.org>
Tested-by: Chih-Yu Huang <akahuang@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>
Reviewed-by: Shen-En Shih <petershih@chromium.org>

[modify] https://crrev.com/a63a83732918a5bbe0ecad21eb259e9e5b78dd3f/py/test/pytests/rf_graphyte/rf_graphyte.py

Cc: -youcheng@chromium.org -petershih@chromium.org -yhong@chromium.org -phoenixshen@chromium.org -yllin@chromium.org chromeos-factory-eng@google.com
Project Member

Comment 12 by bugdroid1@chromium.org, Jul 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/01c71926815039f9a6ab959acd5cd6d47d14f415

commit 01c71926815039f9a6ab959acd5cd6d47d14f415
Author: Ting Shen <phoenixshen@google.com>
Date: Fri Jul 14 12:51:51 2017

ext_display: add document

BUG= chromium:737920 
TEST=make doc

Change-Id: I1e95a1cf326dd096a616fc06f61719fb24685f9a
Reviewed-on: https://chromium-review.googlesource.com/569901
Commit-Ready: Ting Shen <phoenixshen@chromium.org>
Tested-by: Ting Shen <phoenixshen@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>

[modify] https://crrev.com/01c71926815039f9a6ab959acd5cd6d47d14f415/py/test/pytests/ext_display/ext_display.py

Project Member

Comment 13 by bugdroid1@chromium.org, Jul 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/67b7cfa58ae09a50ecd15081aabe3c05f12c1c26

commit 67b7cfa58ae09a50ecd15081aabe3c05f12c1c26
Author: You-Cheng Syu <youcheng@chromium.org>
Date: Tue Jul 25 14:00:25 2017

pytest: Make better docs for sync_time and update_cr50_firmware.

BUG= chromium:737920 
TEST=make doc

Change-Id: I1e6eb176a4ad7fe4c4eef4769cbcf3e24a2af547
Reviewed-on: https://chromium-review.googlesource.com/583753
Commit-Ready: Youcheng Syu <youcheng@chromium.org>
Tested-by: Youcheng Syu <youcheng@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>

[modify] https://crrev.com/67b7cfa58ae09a50ecd15081aabe3c05f12c1c26/py/test/pytests/sync_time.py
[modify] https://crrev.com/67b7cfa58ae09a50ecd15081aabe3c05f12c1c26/py/test/pytests/update_cr50_firmware.py

Project Member

Comment 14 by bugdroid1@chromium.org, Jul 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/0e23539e368861a499c777c6a6ca17a4106ea1ab

commit 0e23539e368861a499c777c6a6ca17a4106ea1ab
Author: Peter Shih <pihsun@chromium.org>
Date: Tue Jul 25 14:00:22 2017

Rename ec_temp_sensors to thermal_sensors.

Rename ec_temp_sensors to thermal_sensors, to match what the test is
trying to do.

Also, since JSON test list won't support tuple type, all arguments that
originally accept tuple only should also accept list.

Also improve the documents for the test.

BUG= chromium:737920 ,b:64014659
TEST=make test

Change-Id: Iecff41fa0208c57d73ac06c5e830782c760a25a9
Reviewed-on: https://chromium-review.googlesource.com/584687
Commit-Ready: Pi-Hsun Shih <pihsun@chromium.org>
Tested-by: Pi-Hsun Shih <pihsun@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>

[modify] https://crrev.com/0e23539e368861a499c777c6a6ca17a4106ea1ab/po/zh-CN.po
[rename] https://crrev.com/0e23539e368861a499c777c6a6ca17a4106ea1ab/py/test/pytests/thermal_sensors.py

Project Member

Comment 15 by bugdroid1@chromium.org, Jul 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/c718d61a31530959b53639aab75fff0ed036d621

commit c718d61a31530959b53639aab75fff0ed036d621
Author: Hung-Te Lin <hungte@chromium.org>
Date: Tue Jul 25 18:35:58 2017

pytests: Add how to write new pytest in README.md and add presubmit checks.

Check if the doc for pytest is written properly in presubmit check, with
more information explained in pytests/README.md.

BUG= chromium:737920 
TEST=make test

Change-Id: Ie35e30f65989844cf11819aa730c09cf72ab0068
Reviewed-on: https://chromium-review.googlesource.com/584153
Commit-Ready: Hung-Te Lin <hungte@chromium.org>
Tested-by: Hung-Te Lin <hungte@chromium.org>
Reviewed-by: Pi-Hsun Shih <pihsun@chromium.org>
Reviewed-by: Youcheng Syu <youcheng@chromium.org>

[modify] https://crrev.com/c718d61a31530959b53639aab75fff0ed036d621/py/test/pytests/README.md
[modify] https://crrev.com/c718d61a31530959b53639aab75fff0ed036d621/devtools/mk/presubmit-test.py

Project Member

Comment 16 by bugdroid1@chromium.org, Jul 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/8cb9f77cfdab567e4e02fd820d8793cec90af41b

commit 8cb9f77cfdab567e4e02fd820d8793cec90af41b
Author: Peter Shih <pihsun@chromium.org>
Date: Wed Jul 26 09:07:35 2017

pytests: Rename ec_battery to battery.

Rename ec_battery to battery, to match what the test is trying to do.

Also, since JSON test list won't support tuple type, all arguments that
originally accept tuple only should also accept list.

Also improve the documents for the test.

BUG= chromium:737920 ,b:64014659
TEST=make test

Change-Id: If25112e29e419cf5656a655fac84a873254ef4f1
Reviewed-on: https://chromium-review.googlesource.com/584247
Commit-Ready: Pi-Hsun Shih <pihsun@chromium.org>
Tested-by: Pi-Hsun Shih <pihsun@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>

[modify] https://crrev.com/8cb9f77cfdab567e4e02fd820d8793cec90af41b/po/zh-CN.po
[delete] https://crrev.com/acade5be2f1e56f2d06c1de27778cdd487610c72/py/test/pytests/ec_battery.py
[add] https://crrev.com/8cb9f77cfdab567e4e02fd820d8793cec90af41b/py/test/pytests/battery.py

Project Member

Comment 17 by bugdroid1@chromium.org, Jul 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/acade5be2f1e56f2d06c1de27778cdd487610c72

commit acade5be2f1e56f2d06c1de27778cdd487610c72
Author: Peter Shih <pihsun@chromium.org>
Date: Wed Jul 26 09:07:34 2017

ext_display: Change tuple arguments to (list, tuple).

Since JSON test list won't support tuple type, all arguments that
originally accept tuple only should also accept list.

BUG= chromium:737920 
TEST=make test

Change-Id: I847a27c130c1f85b4c7d81ac3961f5b4228c1ca2
Reviewed-on: https://chromium-review.googlesource.com/584556
Commit-Ready: Pi-Hsun Shih <pihsun@chromium.org>
Tested-by: Pi-Hsun Shih <pihsun@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>

[modify] https://crrev.com/acade5be2f1e56f2d06c1de27778cdd487610c72/py/test/pytests/ext_display/ext_display.py

Project Member

Comment 18 by bugdroid1@chromium.org, Jul 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/9904d2679ce9af56e127aaeeb14495a2935ae72b

commit 9904d2679ce9af56e127aaeeb14495a2935ae72b
Author: Peter Shih <pihsun@chromium.org>
Date: Thu Jul 27 05:41:55 2017

battery_current: Change tuple arguments to (list, tuple).

Since JSON test list won't support tuple type, all arguments that
originally accept tuple only should also accept list.

Also improve the documents for the test.

BUG= chromium:737920 ,b:64014659
TEST=make test

Change-Id: Ib3ba5f8a2865040d38af46836f23ea6e2d65c383
Reviewed-on: https://chromium-review.googlesource.com/583755
Commit-Ready: Pi-Hsun Shih <pihsun@chromium.org>
Tested-by: Pi-Hsun Shih <pihsun@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>
Reviewed-by: Ting Shen <phoenixshen@chromium.org>

[modify] https://crrev.com/9904d2679ce9af56e127aaeeb14495a2935ae72b/py/test/pytests/battery_current.py

Project Member

Comment 19 by bugdroid1@chromium.org, Jul 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/c0112195e4bd3df82d58a7cb7841e441779b2b81

commit c0112195e4bd3df82d58a7cb7841e441779b2b81
Author: Peter Shih <pihsun@chromium.org>
Date: Thu Jul 27 05:41:54 2017

verify_value: Change tuple arguments to (list, tuple).

Since JSON test list won't support tuple type, all arguments that
originally accept tuple only should also accept list.

Also improve the documents for the test.

BUG= chromium:737920 ,b:64014659
TEST=make test

Change-Id: I34dc40a48f2dbf903b370ac4711c767bbec518a8
Reviewed-on: https://chromium-review.googlesource.com/584214
Commit-Ready: Pi-Hsun Shih <pihsun@chromium.org>
Tested-by: Pi-Hsun Shih <pihsun@chromium.org>
Reviewed-by: Chih-Yu Huang <akahuang@chromium.org>

[modify] https://crrev.com/c0112195e4bd3df82d58a7cb7841e441779b2b81/py/test/pytests/verify_value.py

Project Member

Comment 20 by bugdroid1@chromium.org, Jul 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/19a7b7b22a50c43b5afadafe9618926de7bab681

commit 19a7b7b22a50c43b5afadafe9618926de7bab681
Author: You-Cheng Syu <youcheng@chromium.org>
Date: Thu Jul 27 05:41:54 2017

pytests: Fix typo in sync_time.

Fix a typo.

BUG= chromium:737920 
TEST=none

Change-Id: I436f68af03a1aaaf5fc19577d7da143f2c04d0e9
Reviewed-on: https://chromium-review.googlesource.com/584565
Commit-Ready: Youcheng Syu <youcheng@chromium.org>
Tested-by: Youcheng Syu <youcheng@chromium.org>
Reviewed-by: Pi-Hsun Shih <pihsun@chromium.org>

[modify] https://crrev.com/19a7b7b22a50c43b5afadafe9618926de7bab681/py/test/pytests/sync_time.py

Project Member

Comment 21 by bugdroid1@chromium.org, Jul 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/04d774eaf5ca557ec65c26ee4720281eb6c49033

commit 04d774eaf5ca557ec65c26ee4720281eb6c49033
Author: Shen-En Shih <petershih@chromium.org>
Date: Thu Jul 27 05:41:51 2017

update_device_data: fix typo

BUG= chromium:737920 
TEST=none

Change-Id: Iacf66c729b58ff6afccbf1eff2d821295d5b4212
Reviewed-on: https://chromium-review.googlesource.com/585987
Commit-Ready: Shen-En Shih <petershih@chromium.org>
Tested-by: Shen-En Shih <petershih@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>

[modify] https://crrev.com/04d774eaf5ca557ec65c26ee4720281eb6c49033/py/test/pytests/update_device_data.py

Project Member

Comment 22 by bugdroid1@chromium.org, Jul 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/5d70e093f2119afdb4ddf60feaf11890919162ed

commit 5d70e093f2119afdb4ddf60feaf11890919162ed
Author: Shen-En Shih <petershih@chromium.org>
Date: Thu Jul 27 05:41:51 2017

retrieve_config: add pytest document

Add a more detailed document on 'retrieve_config'.

BUG= chromium:737920 
TEST=make test

Change-Id: Ifa2adfd313ba8f7651c3168622e5bbd557f450b9
Reviewed-on: https://chromium-review.googlesource.com/585988
Commit-Ready: Shen-En Shih <petershih@chromium.org>
Tested-by: Shen-En Shih <petershih@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>

[modify] https://crrev.com/5d70e093f2119afdb4ddf60feaf11890919162ed/py/test/pytests/retrieve_config.py

Project Member

Comment 23 by bugdroid1@chromium.org, Jul 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/5306803c953f5a1233ec22078740f3a3e778ae45

commit 5306803c953f5a1233ec22078740f3a3e778ae45
Author: Shen-En Shih <petershih@chromium.org>
Date: Thu Jul 27 05:41:51 2017

pytests: Refine docs for recovery_button and removable_storage

Refine the document of two pytests:
* recovery_button
* removable_storage

BUG= chromium:737920 
TEST=make test

Change-Id: I5ce6e60d36499a550d09f47dd2cb9ed3bc9577bd
Reviewed-on: https://chromium-review.googlesource.com/585989
Commit-Ready: Shen-En Shih <petershih@chromium.org>
Tested-by: Shen-En Shih <petershih@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>

[modify] https://crrev.com/5306803c953f5a1233ec22078740f3a3e778ae45/py/test/pytests/removable_storage/removable_storage.py
[modify] https://crrev.com/5306803c953f5a1233ec22078740f3a3e778ae45/py/test/pytests/recovery_button.py

Project Member

Comment 24 by bugdroid1@chromium.org, Jul 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/010fa1d1e54c0c98de778a3f93b57186800efc62

commit 010fa1d1e54c0c98de778a3f93b57186800efc62
Author: Shen-En Shih <petershih@chromium.org>
Date: Thu Jul 27 11:22:41 2017

simple_storage_stress_test: refine document

Refine the document for the 'simple_storage_stress_test' pytest.

BUG= chromium:737920 
TEST=make test

Change-Id: I0f2b6926609baa69f3495be02a05ae74d2ac24ea
Reviewed-on: https://chromium-review.googlesource.com/588528
Commit-Ready: Shen-En Shih <petershih@chromium.org>
Tested-by: Shen-En Shih <petershih@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>

[modify] https://crrev.com/010fa1d1e54c0c98de778a3f93b57186800efc62/py/test/pytests/simple_storage_stress_test.py

Project Member

Comment 25 by bugdroid1@chromium.org, Jul 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/393ef238c25347b4fc057dc5dd3cf59b9b5d99ab

commit 393ef238c25347b4fc057dc5dd3cf59b9b5d99ab
Author: Wei-Han Chen <stimim@google.com>
Date: Thu Jul 27 15:06:33 2017

finalize: better documentation

Also removed {min,max}_charge_pct, which is not supported not.

BUG= chromium:737920 
TEST=make test

Change-Id: Ic1b79201a77374d1d79896fc6caa4043b869f8fd
Reviewed-on: https://chromium-review.googlesource.com/587696
Commit-Ready: Wei-Han Chen <stimim@chromium.org>
Tested-by: Wei-Han Chen <stimim@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>

[modify] https://crrev.com/393ef238c25347b4fc057dc5dd3cf59b9b5d99ab/py/test/pytests/finalize/finalize.py
[modify] https://crrev.com/393ef238c25347b4fc057dc5dd3cf59b9b5d99ab/py/test/test_lists/generic.py
[modify] https://crrev.com/393ef238c25347b4fc057dc5dd3cf59b9b5d99ab/py/test/test_lists/generic_grt.py

Project Member

Comment 26 by bugdroid1@chromium.org, Jul 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/b7cfaa9f451ebd06c8ef9984a0998baf5bf8f5e6

commit b7cfaa9f451ebd06c8ef9984a0998baf5bf8f5e6
Author: Shen-En Shih <petershih@chromium.org>
Date: Thu Jul 27 15:06:33 2017

station_entry: Refine document

Refine document on pytest 'station_entry'

BUG= chromium:737920 
TEST=make test

Change-Id: I1e8c7e272bab9bcf254a84dd86ff536179f5fba0
Reviewed-on: https://chromium-review.googlesource.com/588870
Commit-Ready: Shen-En Shih <petershih@chromium.org>
Tested-by: Shen-En Shih <petershih@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>

[modify] https://crrev.com/b7cfaa9f451ebd06c8ef9984a0998baf5bf8f5e6/py/test/pytests/station_entry.py

Project Member

Comment 27 by bugdroid1@chromium.org, Jul 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/e0467abb37357021d0c057cd51bc58766355a4cf

commit e0467abb37357021d0c057cd51bc58766355a4cf
Author: Hung-Te Lin <hungte@chromium.org>
Date: Thu Jul 27 22:43:57 2017

pytests: Make better docs for countdown.

BUG= chromium:737920 
TEST=make doc

Change-Id: Ib0452f58403d7b14d2301947c3f25680f7cdf961
Reviewed-on: https://chromium-review.googlesource.com/586089
Commit-Ready: Hung-Te Lin <hungte@chromium.org>
Tested-by: Hung-Te Lin <hungte@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>

[modify] https://crrev.com/e0467abb37357021d0c057cd51bc58766355a4cf/py/test/pytests/countdown.py

Project Member

Comment 28 by bugdroid1@chromium.org, Jul 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/fec31c24122b80d418cde822867a205042b5de69

commit fec31c24122b80d418cde822867a205042b5de69
Author: Wei-Han Chen <stimim@google.com>
Date: Fri Jul 28 12:45:00 2017

light_sensor: i18n support for subtest instructions

1. i18n support fo subtest instructions
2. add pytest document

BUG= chromium:737920 
TEST=manual

Change-Id: I49bddac69d078a6c74583e6fb5ed6ee08db913b3
Reviewed-on: https://chromium-review.googlesource.com/586090
Commit-Ready: Wei-Han Chen <stimim@chromium.org>
Tested-by: Wei-Han Chen <stimim@chromium.org>
Reviewed-by: Ting Shen <phoenixshen@chromium.org>

[modify] https://crrev.com/fec31c24122b80d418cde822867a205042b5de69/po/zh-CN.po
[modify] https://crrev.com/fec31c24122b80d418cde822867a205042b5de69/py/test/pytests/light_sensor.py

Project Member

Comment 29 by bugdroid1@chromium.org, Aug 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/fd1aee2d888e51118af74a10cd7f0849cce3a7e2

commit fd1aee2d888e51118af74a10cd7f0849cce3a7e2
Author: Shen-En Shih <petershih@chromium.org>
Date: Wed Aug 02 11:32:23 2017

pytests: Add document on 'robot_movement' pytest

Refine the document on the 'robot_movement' pytest.

BUG= chromium:737920 
TEST=make test

Change-Id: Icbb89e854939ea6655baadf9d72e593bd577524d
Reviewed-on: https://chromium-review.googlesource.com/594808
Commit-Ready: Shen-En Shih <petershih@chromium.org>
Tested-by: Shen-En Shih <petershih@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>
Reviewed-by: Shun-Hsing Ou <shunhsingou@chromium.org>

[modify] https://crrev.com/fd1aee2d888e51118af74a10cd7f0849cce3a7e2/py/test/pytests/robot_movement.py

Project Member

Comment 30 by bugdroid1@chromium.org, Aug 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/ca47a7a1625e850593decc1c0bae677694b43b58

commit ca47a7a1625e850593decc1c0bae677694b43b58
Author: Shen-En Shih <petershih@chromium.org>
Date: Wed Aug 02 19:47:44 2017

pytests: Add document for sample_customized_test.

Add a more detail document for sample_customized_test.

BUG= chromium:737920 
TEST=make test

Change-Id: I8e94926313d3d530e36ec4af88830a306d71d126
Reviewed-on: https://chromium-review.googlesource.com/597476
Commit-Ready: Shen-En Shih <petershih@chromium.org>
Tested-by: Shen-En Shih <petershih@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>

[modify] https://crrev.com/ca47a7a1625e850593decc1c0bae677694b43b58/py/test/pytests/sample_customized_test.py

Project Member

Comment 31 by bugdroid1@chromium.org, Aug 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/0ea4ff19ba57d242ab1dd6596919df8ced490875

commit 0ea4ff19ba57d242ab1dd6596919df8ced490875
Author: Shen-En Shih <petershih@chromium.org>
Date: Wed Aug 02 19:47:44 2017

scan: Refine document for scan test.

Refine the document for the scan pytest.

BUG= chromium:737920 
TEST=make test

Change-Id: Ia5805e38b8da0e36772a4cfce14f54e4ad0c9ec0
Reviewed-on: https://chromium-review.googlesource.com/597477
Commit-Ready: Shen-En Shih <petershih@chromium.org>
Tested-by: Shen-En Shih <petershih@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>

[modify] https://crrev.com/0ea4ff19ba57d242ab1dd6596919df8ced490875/py/test/pytests/scan/scan.py

Project Member

Comment 32 by bugdroid1@chromium.org, Aug 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/0579f6e9a2204ec1d775a83b83f0f5af070d8c5b

commit 0579f6e9a2204ec1d775a83b83f0f5af070d8c5b
Author: Peter Shih <pihsun@chromium.org>
Date: Fri Aug 04 04:51:36 2017

blocking_charge: Add options to get target from cutoff / goofy.

Since the min_charge_pct is not in test list options anymore, we can't
pass it in from test list as before. Add special values to the
pytest to indicate that the target level should be either read from
config of cutoff (cutoff.json), or be read from config of Goofy plugin
charge_manager, so we don't need to write the level twice.

Also improve the document.

BUG= chromium:737920 
TEST=make test
TEST=manually on DUT.

Change-Id: Ie7c9ef57187a0421b0ca50ea1d94777d9fe310c6
Reviewed-on: https://chromium-review.googlesource.com/597562
Commit-Ready: Pi-Hsun Shih <pihsun@chromium.org>
Tested-by: Pi-Hsun Shih <pihsun@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>

[modify] https://crrev.com/0579f6e9a2204ec1d775a83b83f0f5af070d8c5b/py/tools/deps.conf
[modify] https://crrev.com/0579f6e9a2204ec1d775a83b83f0f5af070d8c5b/py/test/pytests/blocking_charge.py
[add] https://crrev.com/0579f6e9a2204ec1d775a83b83f0f5af070d8c5b/py/test/utils/goofy_plugin_utils.py

Project Member

Comment 33 by bugdroid1@chromium.org, Aug 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/60c56863820e504a3f386406b3c2d08b1a99807e

commit 60c56863820e504a3f386406b3c2d08b1a99807e
Author: Peter Shih <pihsun@chromium.org>
Date: Mon Aug 07 07:19:23 2017

audio: Change tuple arguments to (list, tuple).

Since JSON test list won't support tuple type, all arguments that
originally accept tuple only should also accept list.

Also improve the documents for the test.

BUG= chromium:737920 ,b:64014659
TEST=make test

Change-Id: I33726ffafd386a87cc7dd8957abfeade26ff883c
Reviewed-on: https://chromium-review.googlesource.com/584629
Commit-Ready: Pi-Hsun Shih <pihsun@chromium.org>
Tested-by: Pi-Hsun Shih <pihsun@chromium.org>
Reviewed-by: Youcheng Syu <youcheng@chromium.org>

[modify] https://crrev.com/60c56863820e504a3f386406b3c2d08b1a99807e/py/test/pytests/audio.py

Project Member

Comment 34 by bugdroid1@chromium.org, Aug 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/66fd7f7d571c101ebac0e6fa805b86f491f6da96

commit 66fd7f7d571c101ebac0e6fa805b86f491f6da96
Author: Hung-Te Lin <hungte@chromium.org>
Date: Mon Aug 07 10:01:01 2017

pytests: Make better docs for test 'button'.

Revise button test doc in new template.

BUG= chromium:737920 
TEST=make test; make doc

Change-Id: Ic029e9a71634ad893c5d06dc77db8f5d34e21dbb
Reviewed-on: https://chromium-review.googlesource.com/601732
Commit-Ready: Hung-Te Lin <hungte@chromium.org>
Tested-by: Hung-Te Lin <hungte@chromium.org>
Reviewed-by: Pi-Hsun Shih <pihsun@chromium.org>

[modify] https://crrev.com/66fd7f7d571c101ebac0e6fa805b86f491f6da96/py/test/pytests/button.py

Project Member

Comment 35 by bugdroid1@chromium.org, Aug 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/1f138f6e443eab200ad25259fc11a84efbd9b9db

commit 1f138f6e443eab200ad25259fc11a84efbd9b9db
Author: Shen-En Shih <petershih@chromium.org>
Date: Mon Aug 07 12:51:16 2017

pytests: Refine documenet for select_for_sampling.

Refine the document for the pytest 'select_for_sampling'

BUG= chromium:737920 
TEST=make test

Change-Id: I7685cf5e592258d26343270efc2fa7d80d1c4e60
Reviewed-on: https://chromium-review.googlesource.com/601612
Commit-Ready: Shen-En Shih <petershih@chromium.org>
Tested-by: Shen-En Shih <petershih@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>

[modify] https://crrev.com/1f138f6e443eab200ad25259fc11a84efbd9b9db/py/test/pytests/select_for_sampling.py

Project Member

Comment 36 by bugdroid1@chromium.org, Aug 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/60cfe6b748e840347bd18d04631fc705683eca80

commit 60cfe6b748e840347bd18d04631fc705683eca80
Author: Shen-En Shih <petershih@chromium.org>
Date: Mon Aug 07 18:45:03 2017

pytests: Refine documenet for 'sysfs_battery'

Refine the document of pytest 'sysfs_battery'.

BUG= chromium:737920 
TEST=make test

Change-Id: I95f46d1af8ae6948d5c3aa170392d4c32e140705
Reviewed-on: https://chromium-review.googlesource.com/602105
Commit-Ready: Shen-En Shih <petershih@chromium.org>
Tested-by: Shen-En Shih <petershih@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>

[modify] https://crrev.com/60cfe6b748e840347bd18d04631fc705683eca80/py/test/pytests/sysfs_battery.py

Project Member

Comment 37 by bugdroid1@chromium.org, Aug 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/0c993e41facade20cd99fa7d0d9834d82313ec35

commit 0c993e41facade20cd99fa7d0d9834d82313ec35
Author: Peter Shih <pihsun@chromium.org>
Date: Tue Aug 08 08:11:39 2017

pytests: Make better docs for message.

Document message pytest.

BUG= chromium:737920 
TEST=make doc

Change-Id: I5ef3c44f3f23a589c69336cacc9ef2bc4b3b5fbe
Reviewed-on: https://chromium-review.googlesource.com/603196
Commit-Ready: Pi-Hsun Shih <pihsun@chromium.org>
Tested-by: Pi-Hsun Shih <pihsun@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>

[modify] https://crrev.com/0c993e41facade20cd99fa7d0d9834d82313ec35/py/test/pytests/message/message.py

Project Member

Comment 38 by bugdroid1@chromium.org, Aug 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/df4ac89649409a170e2cb0084a501c5b8e0dc6c6

commit df4ac89649409a170e2cb0084a501c5b8e0dc6c6
Author: Yilun Lin <yllin@google.com>
Date: Wed Aug 09 06:29:02 2017

pytest: Make better docs for plankton_cc_flip_check.

BUG= chromium:737920 
TEST=make doc

Change-Id: Ib5869969c58e27050453bb1593814958fde4bfab
Reviewed-on: https://chromium-review.googlesource.com/604631
Commit-Ready: Yilun Lin <yllin@chromium.org>
Tested-by: Yilun Lin <yllin@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>

[modify] https://crrev.com/df4ac89649409a170e2cb0084a501c5b8e0dc6c6/py/test/pytests/plankton_cc_flip_check.py

Project Member

Comment 39 by bugdroid1@chromium.org, Aug 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/f7779c1bb762af362a603c69ab58cc93e4bafa9a

commit f7779c1bb762af362a603c69ab58cc93e4bafa9a
Author: Yilun Lin <yllin@google.com>
Date: Wed Aug 09 06:29:01 2017

pytest: Make better docs for plankton_charge.

BUG= chromium:737920 
TEST=make doc

Change-Id: Ib0c20dcb89874c658ac9089eaa8f8ef70abb226b
Reviewed-on: https://chromium-review.googlesource.com/605030
Commit-Ready: Yilun Lin <yllin@chromium.org>
Tested-by: Yilun Lin <yllin@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>

[modify] https://crrev.com/f7779c1bb762af362a603c69ab58cc93e4bafa9a/py/test/pytests/plankton_charge.py

Project Member

Comment 40 by bugdroid1@chromium.org, Aug 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/90ac3b2f06a4b2b8c676b3bcb3e9b4ef5376c45c

commit 90ac3b2f06a4b2b8c676b3bcb3e9b4ef5376c45c
Author: Shen-En Shih <petershih@chromium.org>
Date: Wed Aug 09 09:23:17 2017

pytests: Refine document on 'simple_battery'

Refine the document on the pytest 'simple_battery'.

BUG= chromium:737920 
TEST=make test

Change-Id: I86b4be2aa70dfd8e0876b9650c63906be264272d
Reviewed-on: https://chromium-review.googlesource.com/603035
Commit-Ready: Shen-En Shih <petershih@chromium.org>
Tested-by: Shen-En Shih <petershih@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>

[modify] https://crrev.com/90ac3b2f06a4b2b8c676b3bcb3e9b4ef5376c45c/py/test/pytests/simple_battery.py

Project Member

Comment 41 by bugdroid1@chromium.org, Aug 18 2017

Labels: merge-merged-factory-gru-9017.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/96799d499a5617f07409a7fe48b90f53cf290904

commit 96799d499a5617f07409a7fe48b90f53cf290904
Author: You-Cheng Syu <youcheng@chromium.org>
Date: Fri Aug 18 02:19:33 2017

pytest: Make better docs for sync_time and update_cr50_firmware.

BUG= chromium:737920 
TEST=make doc

Original-Change-Id: I1e6eb176a4ad7fe4c4eef4769cbcf3e24a2af547
Original-Reviewed-on: https://chromium-review.googlesource.com/583753
Commit-Ready: Youcheng Syu <youcheng@chromium.org>
Tested-by: Youcheng Syu <youcheng@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>

Change-Id: I9249943dd542654187db4b0b98297650065beb31
Reviewed-on: https://chromium-review.googlesource.com/616522
Reviewed-by: Youcheng Syu <youcheng@chromium.org>
Commit-Queue: Marco Chen <marcochen@chromium.org>
Tested-by: Marco Chen <marcochen@chromium.org>

[modify] https://crrev.com/96799d499a5617f07409a7fe48b90f53cf290904/py/test/pytests/sync_time.py
[modify] https://crrev.com/96799d499a5617f07409a7fe48b90f53cf290904/py/test/pytests/update_cr50_firmware.py

Project Member

Comment 42 by bugdroid1@chromium.org, Aug 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/c38353ffbb60c367c9ef7b23798b0f1c41bd4307

commit c38353ffbb60c367c9ef7b23798b0f1c41bd4307
Author: Hung-Te Lin <hungte@chromium.org>
Date: Fri Aug 25 08:19:12 2017

pytests: Make better docs for wait_external_test.

Revise the document for wait_external_test so it's easier for partners
to know how to make integration.

BUG= chromium:737920 
TEST=make doc

Change-Id: Ia3cd76ce124a5312c9462a9f15862681c9e14c51
Reviewed-on: https://chromium-review.googlesource.com/631761
Commit-Ready: Hung-Te Lin <hungte@chromium.org>
Tested-by: Hung-Te Lin <hungte@chromium.org>
Reviewed-by: Wei-Han Chen <stimim@chromium.org>

[modify] https://crrev.com/c38353ffbb60c367c9ef7b23798b0f1c41bd4307/py/test/pytests/wait_external_test.py
[add] https://crrev.com/c38353ffbb60c367c9ef7b23798b0f1c41bd4307/bin/factory_external_result
[add] https://crrev.com/c38353ffbb60c367c9ef7b23798b0f1c41bd4307/sh/factory_external_result.sh

Project Member

Comment 43 by bugdroid1@chromium.org, Aug 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/10bc7af39348c32ff749f640bb0181db5fa48e27

commit 10bc7af39348c32ff749f640bb0181db5fa48e27
Author: Peter Shih <pihsun@chromium.org>
Date: Mon Aug 28 11:27:10 2017

pytests: Make better docs for mrc_cache.

BUG= chromium:737920 
TEST=make doc
TEST=make test

Change-Id: Id82aaa90865ddba1c6a7501ff5383fd527231376
Reviewed-on: https://chromium-review.googlesource.com/612964
Commit-Ready: Hung-Te Lin <hungte@chromium.org>
Tested-by: Pi-Hsun Shih <pihsun@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>

[modify] https://crrev.com/10bc7af39348c32ff749f640bb0181db5fa48e27/py/test/pytests/mrc_cache.py

Project Member

Comment 44 by bugdroid1@chromium.org, Sep 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/1365acee7c3120bbe272ce2061381f4591cfde96

commit 1365acee7c3120bbe272ce2061381f4591cfde96
Author: Shen-En Shih <petershih@chromium.org>
Date: Thu Sep 14 18:36:39 2017

pytest: Refine document for 'start' pytest

Refine document for 'start' pytest.

BUG= chromium:737920 
TEST=make test

Change-Id: Ie80f5bca42f12d5c9388b2abebfd3b960355bcc9
Reviewed-on: https://chromium-review.googlesource.com/662964
Commit-Ready: Shen-En Shih <petershih@chromium.org>
Tested-by: Shen-En Shih <petershih@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>

[modify] https://crrev.com/1365acee7c3120bbe272ce2061381f4591cfde96/py/test/pytests/start/start.py

Project Member

Comment 45 by bugdroid1@chromium.org, Sep 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/26dbbf35272a3839b7254b80f1d5a01488fe9992

commit 26dbbf35272a3839b7254b80f1d5a01488fe9992
Author: Peter Shih <pihsun@chromium.org>
Date: Sat Sep 16 11:19:07 2017

pytest: Add e2e mode for camera.py.

Add an end-to-end mode for camera pytest, similar to e2e mode in
touchpad. The test would use the ImageCapture API for Chrome to do image
capturing from camera, instead of using camera device API.

BUG=b:65388920,b:65654317, chromium:737920 
TEST=make test
TEST=manually on DUT, test camera pytest with e2e mode on, and try that
     both QR and face mode can be passed.

Change-Id: I784362b94b4cc220f21b52a245e3a6ef416769ee
Reviewed-on: https://chromium-review.googlesource.com/668347
Commit-Ready: Pi-Hsun Shih <pihsun@chromium.org>
Tested-by: Pi-Hsun Shih <pihsun@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>

[modify] https://crrev.com/26dbbf35272a3839b7254b80f1d5a01488fe9992/po/zh-CN.po
[add] https://crrev.com/26dbbf35272a3839b7254b80f1d5a01488fe9992/py/test/pytests/camera_static/camera.css
[add] https://crrev.com/26dbbf35272a3839b7254b80f1d5a01488fe9992/py/test/pytests/camera_static/camera.js
[modify] https://crrev.com/26dbbf35272a3839b7254b80f1d5a01488fe9992/py/test/pytests/camera.py

Project Member

Comment 46 by bugdroid1@chromium.org, Sep 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/42ff379618df572ae304a2efc65fc2c6ea0019d2

commit 42ff379618df572ae304a2efc65fc2c6ea0019d2
Author: chuntsen <chuntsen@google.com>
Date: Mon Sep 18 14:43:57 2017

pytests: Make better docs for bluetooth.

Document bluetooth in the new template.
Also fix scan doc typo.

BUG= chromium:737920 
TEST=make doc

Change-Id: Ic6359dd12d6f2d24ed47c4fbaaffbf98b55a4ce7
Reviewed-on: https://chromium-review.googlesource.com/649589
Commit-Ready: Chun-Tsen Kuo <chuntsen@chromium.org>
Tested-by: Chun-Tsen Kuo <chuntsen@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>

[modify] https://crrev.com/42ff379618df572ae304a2efc65fc2c6ea0019d2/py/test/pytests/scan/scan.py
[modify] https://crrev.com/42ff379618df572ae304a2efc65fc2c6ea0019d2/py/test/pytests/bluetooth.py

Project Member

Comment 47 by bugdroid1@chromium.org, Sep 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/410981c4ae057bcfb6d9c98c17758a083c0d62e5

commit 410981c4ae057bcfb6d9c98c17758a083c0d62e5
Author: Shen-En Shih <petershih@chromium.org>
Date: Fri Sep 22 11:04:14 2017

shutdown: Refine document

Add a more detailed documenet for shutdown test.

BUG= chromium:737920 
TEST=make test

Change-Id: I86b405950ca1a745e5c7a77b8c7024d91c86e92e
Reviewed-on: https://chromium-review.googlesource.com/674889
Commit-Ready: Shen-En Shih <petershih@chromium.org>
Tested-by: Shen-En Shih <petershih@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>

[modify] https://crrev.com/410981c4ae057bcfb6d9c98c17758a083c0d62e5/py/test/pytests/shutdown/shutdown.py

Project Member

Comment 48 by bugdroid1@chromium.org, Sep 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/93ac97cbd25a7a98b7174398283af4b7f4e41234

commit 93ac97cbd25a7a98b7174398283af4b7f4e41234
Author: Peter Shih <pihsun@chromium.org>
Date: Tue Sep 26 06:25:26 2017

pytests: Make better doc for network_setup.

BUG= chromium:737920 
TEST=make doc
TEST=make test

Change-Id: I94b4d21e5f2717a691c8f4238e69425bfb9d85f3
Reviewed-on: https://chromium-review.googlesource.com/662080
Commit-Ready: Pi-Hsun Shih <pihsun@chromium.org>
Tested-by: Pi-Hsun Shih <pihsun@chromium.org>
Reviewed-by: Wei-Han Chen <stimim@chromium.org>

[modify] https://crrev.com/93ac97cbd25a7a98b7174398283af4b7f4e41234/py/test/pytests/network_setup/network_setup.py

Status: Fixed (was: Started)
Close the issue while we may still use t his for pytest doc changes.
Project Member

Comment 50 by bugdroid1@chromium.org, Sep 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/6b9b2b2a762e4447e8af62eaf3cd304222a5eb13

commit 6b9b2b2a762e4447e8af62eaf3cd304222a5eb13
Author: Peter Shih <pihsun@chromium.org>
Date: Thu Sep 28 09:04:06 2017

pytests: Make better doc for ping_test.

BUG= chromium:737920 
TEST=make doc
TEST=make test

Change-Id: Icaaedb05d60384fca5b15000651a9e329b0a3fc9
Reviewed-on: https://chromium-review.googlesource.com/686435
Commit-Ready: Pi-Hsun Shih <pihsun@chromium.org>
Tested-by: Pi-Hsun Shih <pihsun@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>

[modify] https://crrev.com/6b9b2b2a762e4447e8af62eaf3cd304222a5eb13/py/test/pytests/ping_test.py

Project Member

Comment 51 by bugdroid1@chromium.org, Sep 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/73c763699da8aca1fab39cf02adcb34705a7976d

commit 73c763699da8aca1fab39cf02adcb34705a7976d
Author: Peter Shih <pihsun@chromium.org>
Date: Thu Sep 28 13:27:25 2017

pytests: Move example to JSON test list format.

Move all examples to use JSON test list format, instead of the old
Python based test list format.

BUG= chromium:758115 , chromium:737920 
TEST=make test
TEST=make doc

Change-Id: I76cb3b6ed293c398cc59da550a5f065f5f1724f3
Reviewed-on: https://chromium-review.googlesource.com/686218
Commit-Ready: Pi-Hsun Shih <pihsun@chromium.org>
Tested-by: Pi-Hsun Shih <pihsun@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>

[modify] https://crrev.com/73c763699da8aca1fab39cf02adcb34705a7976d/py/test/pytests/thermal_sensors.py
[modify] https://crrev.com/73c763699da8aca1fab39cf02adcb34705a7976d/py/test/pytests/audio.py
[modify] https://crrev.com/73c763699da8aca1fab39cf02adcb34705a7976d/py/test/pytests/countdown.py
[modify] https://crrev.com/73c763699da8aca1fab39cf02adcb34705a7976d/py/test/pytests/sample_customized_test.py
[modify] https://crrev.com/73c763699da8aca1fab39cf02adcb34705a7976d/py/test/pytests/plankton_charge.py
[modify] https://crrev.com/73c763699da8aca1fab39cf02adcb34705a7976d/py/test/pytests/memory_size.py
[modify] https://crrev.com/73c763699da8aca1fab39cf02adcb34705a7976d/py/test/pytests/exec_python.py
[modify] https://crrev.com/73c763699da8aca1fab39cf02adcb34705a7976d/py/test/pytests/wait_external_test.py
[modify] https://crrev.com/73c763699da8aca1fab39cf02adcb34705a7976d/py/test/pytests/bluetooth.py
[modify] https://crrev.com/73c763699da8aca1fab39cf02adcb34705a7976d/py/test/pytests/storage_simple_stress.py
[modify] https://crrev.com/73c763699da8aca1fab39cf02adcb34705a7976d/py/test/pytests/recovery_button.py
[modify] https://crrev.com/73c763699da8aca1fab39cf02adcb34705a7976d/py/test/pytests/select_for_sampling.py
[modify] https://crrev.com/73c763699da8aca1fab39cf02adcb34705a7976d/py/test/pytests/ping_test.py
[modify] https://crrev.com/73c763699da8aca1fab39cf02adcb34705a7976d/py/test/pytests/sync_factory_server.py
[modify] https://crrev.com/73c763699da8aca1fab39cf02adcb34705a7976d/py/test/pytests/sync_time.py
[modify] https://crrev.com/73c763699da8aca1fab39cf02adcb34705a7976d/py/test/pytests/battery_sysfs.py
[modify] https://crrev.com/73c763699da8aca1fab39cf02adcb34705a7976d/py/test/pytests/plankton_cc_flip_check.py
[modify] https://crrev.com/73c763699da8aca1fab39cf02adcb34705a7976d/py/test/pytests/shopfloor_service.py
[modify] https://crrev.com/73c763699da8aca1fab39cf02adcb34705a7976d/py/test/pytests/summary/summary.py
[modify] https://crrev.com/73c763699da8aca1fab39cf02adcb34705a7976d/py/test/pytests/flash_netboot.py
[modify] https://crrev.com/73c763699da8aca1fab39cf02adcb34705a7976d/py/test/pytests/external_display.py
[modify] https://crrev.com/73c763699da8aca1fab39cf02adcb34705a7976d/py/test/pytests/exec_shell.py
[modify] https://crrev.com/73c763699da8aca1fab39cf02adcb34705a7976d/py/test/pytests/battery_current.py
[modify] https://crrev.com/73c763699da8aca1fab39cf02adcb34705a7976d/py/test/pytests/touchpad_hover.py
[modify] https://crrev.com/73c763699da8aca1fab39cf02adcb34705a7976d/py/test/pytests/robot_movement.py
[modify] https://crrev.com/73c763699da8aca1fab39cf02adcb34705a7976d/py/test/pytests/rf_graphyte/rf_graphyte.py
[modify] https://crrev.com/73c763699da8aca1fab39cf02adcb34705a7976d/py/test/pytests/button.py
[modify] https://crrev.com/73c763699da8aca1fab39cf02adcb34705a7976d/py/test/pytests/nop.py
[modify] https://crrev.com/73c763699da8aca1fab39cf02adcb34705a7976d/py/test/pytests/network_setup/network_setup.py
[modify] https://crrev.com/73c763699da8aca1fab39cf02adcb34705a7976d/py/test/pytests/stressapptest.py
[modify] https://crrev.com/73c763699da8aca1fab39cf02adcb34705a7976d/py/test/pytests/touchscreen.py
[modify] https://crrev.com/73c763699da8aca1fab39cf02adcb34705a7976d/py/test/pytests/update_device_data.py
[modify] https://crrev.com/73c763699da8aca1fab39cf02adcb34705a7976d/py/test/pytests/scan/scan.py
[modify] https://crrev.com/73c763699da8aca1fab39cf02adcb34705a7976d/py/test/pytests/finalize/finalize.py
[modify] https://crrev.com/73c763699da8aca1fab39cf02adcb34705a7976d/py/test/pytests/update_cr50_firmware.py
[modify] https://crrev.com/73c763699da8aca1fab39cf02adcb34705a7976d/py/test/pytests/touchpad.py
[modify] https://crrev.com/73c763699da8aca1fab39cf02adcb34705a7976d/py/test/pytests/read_device_data_from_vpd.py
[modify] https://crrev.com/73c763699da8aca1fab39cf02adcb34705a7976d/py/test/pytests/battery.py
[modify] https://crrev.com/73c763699da8aca1fab39cf02adcb34705a7976d/py/test/pytests/camera.py
[modify] https://crrev.com/73c763699da8aca1fab39cf02adcb34705a7976d/py/test/pytests/urandom.py
[modify] https://crrev.com/73c763699da8aca1fab39cf02adcb34705a7976d/py/test/pytests/light_sensor.py
[modify] https://crrev.com/73c763699da8aca1fab39cf02adcb34705a7976d/py/test/pytests/message/message.py
[modify] https://crrev.com/73c763699da8aca1fab39cf02adcb34705a7976d/py/test/pytests/shutdown/shutdown.py
[modify] https://crrev.com/73c763699da8aca1fab39cf02adcb34705a7976d/py/test/pytests/station_setup.py
[modify] https://crrev.com/73c763699da8aca1fab39cf02adcb34705a7976d/py/test/pytests/retrieve_config.py
[modify] https://crrev.com/73c763699da8aca1fab39cf02adcb34705a7976d/py/test/pytests/battery_basic.py
[modify] https://crrev.com/73c763699da8aca1fab39cf02adcb34705a7976d/py/test/pytests/line_check_item.py
[modify] https://crrev.com/73c763699da8aca1fab39cf02adcb34705a7976d/py/test/pytests/verify_value.py
[modify] https://crrev.com/73c763699da8aca1fab39cf02adcb34705a7976d/py/test/pytests/station_entry.py
[modify] https://crrev.com/73c763699da8aca1fab39cf02adcb34705a7976d/py/test/pytests/start/start.py
[modify] https://crrev.com/73c763699da8aca1fab39cf02adcb34705a7976d/py/test/pytests/stylus.py
[modify] https://crrev.com/73c763699da8aca1fab39cf02adcb34705a7976d/py/test/pytests/write_device_data_to_vpd.py
[modify] https://crrev.com/73c763699da8aca1fab39cf02adcb34705a7976d/py/test/pytests/removable_storage/removable_storage.py
[modify] https://crrev.com/73c763699da8aca1fab39cf02adcb34705a7976d/py/test/pytests/mrc_cache.py
[modify] https://crrev.com/73c763699da8aca1fab39cf02adcb34705a7976d/py/test/pytests/check_image_version.py
[modify] https://crrev.com/73c763699da8aca1fab39cf02adcb34705a7976d/py/test/pytests/factory_state.py
[modify] https://crrev.com/73c763699da8aca1fab39cf02adcb34705a7976d/py/test/pytests/model_sku.py
[modify] https://crrev.com/73c763699da8aca1fab39cf02adcb34705a7976d/py/test/pytests/blocking_charge.py

Project Member

Comment 52 by bugdroid1@chromium.org, Sep 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/2bdd1aaf604d796f7772d83897952dd9d9c298d4

commit 2bdd1aaf604d796f7772d83897952dd9d9c298d4
Author: Peter Shih <pihsun@chromium.org>
Date: Fri Sep 29 13:29:12 2017

pytest: Make better document for tablet_rotation.

Make better document for tablet_rotation.

Also change the custom StartDaemonThread call to RunInBackground, and
fix some issue about accelerometer API change.

BUG= chromium:737920 , chromium:756182 
TEST=make test
TEST=manually on DUT.

Change-Id: Ie113e99e7c3d7a51fbee0b9d98c42ba07a51b398
Reviewed-on: https://chromium-review.googlesource.com/691500
Commit-Ready: Pi-Hsun Shih <pihsun@chromium.org>
Tested-by: Pi-Hsun Shih <pihsun@chromium.org>
Reviewed-by: Ting Shen <phoenixshen@chromium.org>

[modify] https://crrev.com/2bdd1aaf604d796f7772d83897952dd9d9c298d4/py/test/pytests/tablet_rotation.py

Project Member

Comment 53 by bugdroid1@chromium.org, Oct 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/07fc230210723f69494f41db513d3c29f9b5e656

commit 07fc230210723f69494f41db513d3c29f9b5e656
Author: Yong Hong <yhong@chromium.org>
Date: Mon Oct 02 12:30:58 2017

pytests: Make better docs for probe.

Also cleans up useless README for probe pytest and merges
`probe_sampe.json` into the document in `probe.py`.

BUG= chromium:737920 
TEST=make doc

Change-Id: If0239b681bf48f3f6a3a794228a793ed701541ac
Reviewed-on: https://chromium-review.googlesource.com/689415
Commit-Ready: Yong Hong <yhong@google.com>
Tested-by: Yong Hong <yhong@google.com>
Reviewed-by: Yong Hong <yhong@google.com>

[delete] https://crrev.com/65a1d782bd4343bda6b24949d6d93ca1b0ae40a6/py/test/pytests/probe/README.md
[delete] https://crrev.com/65a1d782bd4343bda6b24949d6d93ca1b0ae40a6/py/test/pytests/probe/probe_sample.json
[modify] https://crrev.com/07fc230210723f69494f41db513d3c29f9b5e656/py/test/pytests/probe/probe.py

Project Member

Comment 54 by bugdroid1@chromium.org, Oct 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/671a50e3f3b8ecf1dc18d2592f282d0a372e771b

commit 671a50e3f3b8ecf1dc18d2592f282d0a372e771b
Author: chuntsen <chuntsen@google.com>
Date: Mon Oct 23 11:28:26 2017

pytests: Make better docs for accelerometers_calibration

Document accelerometers_calibration in the new template.

BUG= chromium:737920 
TEST=make doc

Change-Id: Ifee8ee4962bf480762dfd03461fd3c8d89a2bc57
Reviewed-on: https://chromium-review.googlesource.com/670524
Commit-Ready: Chun-Tsen Kuo <chuntsen@chromium.org>
Tested-by: Chun-Tsen Kuo <chuntsen@chromium.org>
Reviewed-by: Ting Shen <phoenixshen@chromium.org>

[modify] https://crrev.com/671a50e3f3b8ecf1dc18d2592f282d0a372e771b/py/test/pytests/accelerometers_calibration.py

Project Member

Comment 55 by bugdroid1@chromium.org, Nov 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/d8ed35321dd80ddb8acb01a985af90d659fa2bdd

commit d8ed35321dd80ddb8acb01a985af90d659fa2bdd
Author: Peter Shih <pihsun@chromium.org>
Date: Thu Nov 30 15:09:33 2017

pytests: Make better docs for keyboard.

BUG= chromium:737920 
TEST=make doc

Change-Id: Ia88e4618a1662eb101b6d9b39870b0fefaffda30
Reviewed-on: https://chromium-review.googlesource.com/773905
Commit-Ready: Pi-Hsun Shih <pihsun@chromium.org>
Tested-by: Pi-Hsun Shih <pihsun@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>

[modify] https://crrev.com/d8ed35321dd80ddb8acb01a985af90d659fa2bdd/py/test/pytests/keyboard/keyboard.py

Project Member

Comment 56 by bugdroid1@chromium.org, Dec 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/787abb6a3d2f7180e3a856b9ef4afee912668809

commit 787abb6a3d2f7180e3a856b9ef4afee912668809
Author: Peter Shih <pihsun@chromium.org>
Date: Tue Dec 05 14:25:00 2017

pytests: Make better docs for display.

BUG= chromium:737920 
TEST=make doc

Change-Id: Iac0612a6eec9b9797d1077e1807e063bd453f06a
Reviewed-on: https://chromium-review.googlesource.com/799015
Commit-Ready: Pi-Hsun Shih <pihsun@chromium.org>
Tested-by: Pi-Hsun Shih <pihsun@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>

[modify] https://crrev.com/787abb6a3d2f7180e3a856b9ef4afee912668809/py/test/pytests/display.py

Project Member

Comment 57 by bugdroid1@chromium.org, Dec 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/2d73fb0090d51fcf26483e347ff8439d3a5d420b

commit 2d73fb0090d51fcf26483e347ff8439d3a5d420b
Author: Peter Shih <pihsun@chromium.org>
Date: Thu Dec 07 13:09:14 2017

pytests: Refactor audio_basic to use TestCaseWithUI.

Also make better docs for audio_basic.

BUG=b:68681772, chromium:737920 
TEST=make test

Change-Id: I18d6ab6c16308e0d254d5bce569c92d3ade625ce
Reviewed-on: https://chromium-review.googlesource.com/807841
Commit-Ready: Pi-Hsun Shih <pihsun@chromium.org>
Tested-by: Pi-Hsun Shih <pihsun@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>

[modify] https://crrev.com/2d73fb0090d51fcf26483e347ff8439d3a5d420b/po/zh-CN.po
[modify] https://crrev.com/2d73fb0090d51fcf26483e347ff8439d3a5d420b/py/test/pytests/audio_basic.py

Project Member

Comment 58 by bugdroid1@chromium.org, Dec 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/7c93dea40bd28bb1b20d33a45677c1828daa5f97

commit 7c93dea40bd28bb1b20d33a45677c1828daa5f97
Author: Peter Shih <pihsun@chromium.org>
Date: Thu Dec 07 16:04:51 2017

pytests: Make better docs for backlight.

BUG= chromium:737920 
TEST=make doc

Change-Id: I70069c659bd7a5b5cf3a4d8a785297c11401f2bd
Reviewed-on: https://chromium-review.googlesource.com/810287
Commit-Ready: Pi-Hsun Shih <pihsun@chromium.org>
Tested-by: Pi-Hsun Shih <pihsun@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>

[modify] https://crrev.com/7c93dea40bd28bb1b20d33a45677c1828daa5f97/py/test/pytests/backlight.py

Comment 59 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 60 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)
Project Member

Comment 61 by bugdroid1@chromium.org, Mar 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/8267613594f39ff8640a7d0842136adef44dabe7

commit 8267613594f39ff8640a7d0842136adef44dabe7
Author: Hung-Te Lin <hungte@chromium.org>
Date: Tue Mar 27 18:59:37 2018

pytests: Make better docs for suspend_resume and update_kernel.

Revise the document for suspend_resume and update_kernel so it's easier
for partners to know how to make integration.

BUG= chromium:737920 
TEST=make doc

Change-Id: Ifde4c1e606a59a8ecec83681cbd284cb57918dbc
Reviewed-on: https://chromium-review.googlesource.com/981833
Commit-Ready: Hung-Te Lin <hungte@chromium.org>
Tested-by: Hung-Te Lin <hungte@chromium.org>
Reviewed-by: Wei-Han Chen <stimim@chromium.org>

[modify] https://crrev.com/8267613594f39ff8640a7d0842136adef44dabe7/py/test/pytests/update_kernel.py
[modify] https://crrev.com/8267613594f39ff8640a7d0842136adef44dabe7/py/test/pytests/suspend_resume.py

Sign in to add a comment