New issue
Advanced search Search tips

Issue 737895 link

Starred by 1 user
Status: Untriaged
Owner: ----
Cc:
ukai@chromium.org
tikuta@chromium.org
yyanagisawa@chromium.org
shinyak@chromium.org
sque@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Introduce compile_confirm_no-op for goma canary builder

Project Member Reported by shinyak@chromium.org, Jun 29 2017 
Derived from  Issue 737863 

We should have detected cache contamination when we have compile_confirm_no-op step.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 30 2017 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/goma/client/+/51f2af255eccc557e117137b19809224529810a6

commit 51f2af255eccc557e117137b19809224529810a6
Author: Takuto Ikuta <tikuta@google.com>
Date: Fri Jun 30 06:13:04 2017
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/dc52549684aa316062981e1f400e725fe1d91b76

commit dc52549684aa316062981e1f400e725fe1d91b76
Author: Takuto Ikuta <tikuta@google.com>
Date: Mon Jul 03 02:41:04 2017

Enable ninja confirm no-op step in goma canary and staging bots

Bug:737895
Change-Id: I96ba376f46104fd7169a7b50939d60ed9cbc1ed9
Reviewed-on: https://chromium-review.googlesource.com/555071
Reviewed-by: Shinya Kawanaka <shinyak@chromium.org>
Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@google.com>

[modify] https://crrev.com/dc52549684aa316062981e1f400e725fe1d91b76/scripts/slave/recipe_modules/chromium/tests/compile.expected/goma_canary.json
[modify] https://crrev.com/dc52549684aa316062981e1f400e725fe1d91b76/scripts/slave/recipe_modules/chromium/config.py
►

Sign in to add a comment