New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 737882 link

Starred by 2 users
Status: Verified
Owner:
█ ingem...@opera.com
Resigned
Closed: Jul 2017
Cc:
agrieve@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Generated Android Lint suppression regexp incompatible with inner classes

Reported by ingem...@opera.com, Jun 29 2017 
build/android/lint/suppress.py generates a lint config to build/android/lint/suppressions.xml, where all lint errors in the input lint report are suppressed. While doing this the path component of the lint error is interpreted as regexp. Java class names may contain '$' which is a EOL matcher in Java regex Patterns, causing generated regexps for lint errors occurring in inner classes to not match.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 5 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ae15d6be803a668bf58e215d29ac5fb8d854a98c

commit ae15d6be803a668bf58e215d29ac5fb8d854a98c
Author: Ingemar Ådahl <ingemara@opera.com>
Date: Wed Jul 05 09:38:33 2017

Escape '$' when generating lint suppression regexp

Java class names (for inner classes) may contain '$', which is a EOL
pattern marker in Java regexps. To ensure proper regexps are generated,
escape the marker to allow the regexp to match the entire path.

Bug:  737882 
Change-Id: I935d06c197453b674bb0e493d0887e271fdd9610
Reviewed-on: https://chromium-review.googlesource.com/554750
Commit-Queue: Ingemar Ådahl <ingemara@opera.com>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484228}
[modify] https://crrev.com/ae15d6be803a668bf58e215d29ac5fb8d854a98c/build/android/lint/suppress.py

Comment 2 by ingem...@opera.com, Jul 5 2017

Status: Verified (was: Started)
►

Sign in to add a comment