Web Share Web Platform Tests need to be explicitly skipped in TestExpectations |
||
Issue descriptionthird_party/WebKit/LayoutTests/TestExpectations currently explicitly skips all of the web-share manual tests (external/wpt/web-share/*-manual.html). These tests are never going to run automatically as part of layout tests. Ideally we wouldn't have to explicitly list them all here and they would automatically be skipped. I'm a bit confused why this isn't the case, given that external/wpt/geolocation-API/*-manual.html are *not* listed in TestExpectations, yet also aren't run when I run webkit tests.
,
Jun 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/33a59e704de04c5798408e528be2ec81c2d01856 commit 33a59e704de04c5798408e528be2ec81c2d01856 Author: Matt Giuca <mgiuca@chromium.org> Date: Fri Jun 30 02:28:57 2017 Layout test expectations: Moved web-share manual tests to NeverFixTests. Manual tests should never be run automatically, so are listed in this file, rather than in the generic "failing tests" soup that is TestExpectations. Bug: 737871 Change-Id: Ifb91e5759a6f79802b96fa8ed27c2ab4c7d0046f Reviewed-on: https://chromium-review.googlesource.com/554651 Commit-Queue: Matt Giuca <mgiuca@chromium.org> Reviewed-by: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#483596} [modify] https://crrev.com/33a59e704de04c5798408e528be2ec81c2d01856/third_party/WebKit/LayoutTests/NeverFixTests [modify] https://crrev.com/33a59e704de04c5798408e528be2ec81c2d01856/third_party/WebKit/LayoutTests/TestExpectations
,
Jun 30 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by mgiuca@chromium.org
, Jun 29 2017