pretty_print.py should sort <suffix> elements as well as <affected-histogram> elements |
|||
Issue description1. In histograms.xml (from commit cbc07924907af3ac0157f3208c1ce1463e8bf888), under ServiceWorker.StartSituation, move <affected-histogram name="EmbeddedWorkerInstance.Start.StartMessageLatency"/> to the end, with the other affected-histograms. 2. Run pretty_print.py. 3. pretty_print.py tries to put the affected-histogram back to the front.
,
Jul 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/472a9d0d9e143632f9d096c589ae15caf820eb06 commit 472a9d0d9e143632f9d096c589ae15caf820eb06 Author: isherman <isherman@chromium.org> Date: Mon Jul 03 22:03:09 2017 [Cleanup] Pretty-print histograms.xml BUG= 737822 TEST=none R=asvitkine@chromium.org Review-Url: https://codereview.chromium.org/2970573002 Cr-Commit-Position: refs/heads/master@{#484031} [modify] https://crrev.com/472a9d0d9e143632f9d096c589ae15caf820eb06/tools/metrics/histograms/enums.xml [modify] https://crrev.com/472a9d0d9e143632f9d096c589ae15caf820eb06/tools/metrics/histograms/histograms.xml
,
Jul 4
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 4
I believe this is fixed now. |
|||
►
Sign in to add a comment |
|||
Comment 1 by isherman@chromium.org
, Jun 30 2017Status: Available (was: Untriaged)
Summary: pretty_print.py should sort <suffix> elements as well as <affected-histogram> elements (was: pretty_print.py puts <affected-histogram> in a strange order)