New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 737822 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Jul 4
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

pretty_print.py should sort <suffix> elements as well as <affected-histogram> elements

Project Member Reported by falken@chromium.org, Jun 29 2017

Issue description

1. In histograms.xml (from commit cbc07924907af3ac0157f3208c1ce1463e8bf888), under  ServiceWorker.StartSituation, move <affected-histogram name="EmbeddedWorkerInstance.Start.StartMessageLatency"/> to the end, with the other affected-histograms.

2. Run pretty_print.py.

3. pretty_print.py tries to put the affected-histogram back to the front.

 
Owner: ----
Status: Available (was: Untriaged)
Summary: pretty_print.py should sort <suffix> elements as well as <affected-histogram> elements (was: pretty_print.py puts <affected-histogram> in a strange order)
Okay, I investigated this a bit, and here's what I think is happening: pretty_print.py attempts to alphabetize just the affected-histogram elements, and tries to ignore the suffixes.  The way it does this is to keep the <suffix> elements in the same order relative to the <affected-histogram> element that follows them.  If <affected-histogram name="EmbeddedWorkerInstance.Start.StartMessageLatency"/> is inserted at the beginning of the <affected-histogram>s list, then everything works fine.  If it's inserted anywhere else, it ends up being sorted above the <suffix> elements.

This would be nice to fix -- by sorting all of the suffixes too -- but is a bit inconvenient given the current structure of the code.  Going to leave as available in case anyone wants to take a stab at it.
Project Member

Comment 3 by sheriffbot@chromium.org, Jul 4

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Fixed (was: Untriaged)
I believe this is fixed now.

Sign in to add a comment