We want to track the smoothness of foreground tabs during session restore, which can be estimated by ExpectedTaskQueueingDuration of the tabs.
We want to track the smoothness of foreground tabs during session restore, which can be estimated by their ExpectedTaskQueueingDuration.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/88324da79c7f4301661eb06ae73f4282403034a6 commit 88324da79c7f4301661eb06ae73f4282403034a6 Author: Duc Bui <ducbui@google.com> Date: Thu Jul 13 17:30:42 2017 [GRC] Add Visible property to Coordination Unit. This patch adds visible property, and uses it in WebContentsCoordinationUnit. This property is useful for metrics which need to determine whether the corresponding tab is foreground or not. Change-Id: I99520710a8887ea3f5aa3d3c9a56b2d6f446ac53 BUG= 737817 Change-Id: I99520710a8887ea3f5aa3d3c9a56b2d6f446ac53 Reviewed-on: https://chromium-review.googlesource.com/568365 Commit-Queue: Duc Bui <ducbui@google.com> Reviewed-by: Zhen Wang <zhenw@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#486430} [modify] https://crrev.com/88324da79c7f4301661eb06ae73f4282403034a6/chrome/browser/resource_coordinator/resource_coordinator_web_contents_observer.cc [modify] https://crrev.com/88324da79c7f4301661eb06ae73f4282403034a6/services/resource_coordinator/public/cpp/resource_coordinator_interface.cc [modify] https://crrev.com/88324da79c7f4301661eb06ae73f4282403034a6/services/resource_coordinator/public/cpp/resource_coordinator_interface.h [modify] https://crrev.com/88324da79c7f4301661eb06ae73f4282403034a6/services/resource_coordinator/public/interfaces/coordination_unit.mojom
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/525244b2766b65ccb317bdf9f387eb3fb7053faf commit 525244b2766b65ccb317bdf9f387eb3fb7053faf Author: Duc Bui <ducbui@google.com> Date: Thu Aug 10 19:38:35 2017 [GRC] Track Expected Task Queueing Duration of tabs in GRC. We want to track the smoothness of foreground tabs during session restore, which can be estimated by their ExpectedTaskQueueingDuration. This patch sends ExpectedTaskQueueingDuration metric measured in Blink RendererScheduler to GRC. BUG= 737817 Change-Id: I54be5ef1171fb885598e259ffe0580631b8e6f9c Reviewed-on: https://chromium-review.googlesource.com/567539 Reviewed-by: Nasko Oskov <nasko@chromium.org> Reviewed-by: Nate Chapin <japhet@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Ken Rockot <rockot@chromium.org> Reviewed-by: Zhen Wang <zhenw@chromium.org> Commit-Queue: Duc Bui <ducbui@google.com> Cr-Commit-Position: refs/heads/master@{#493501} [modify] https://crrev.com/525244b2766b65ccb317bdf9f387eb3fb7053faf/content/child/blink_platform_impl.cc [modify] https://crrev.com/525244b2766b65ccb317bdf9f387eb3fb7053faf/content/child/blink_platform_impl.h [modify] https://crrev.com/525244b2766b65ccb317bdf9f387eb3fb7053faf/content/public/test/render_view_test.cc [modify] https://crrev.com/525244b2766b65ccb317bdf9f387eb3fb7053faf/content/public/test/render_view_test.h [modify] https://crrev.com/525244b2766b65ccb317bdf9f387eb3fb7053faf/services/resource_coordinator/public/interfaces/signals.mojom [modify] https://crrev.com/525244b2766b65ccb317bdf9f387eb3fb7053faf/third_party/WebKit/Source/core/frame/LocalFrame.cpp [modify] https://crrev.com/525244b2766b65ccb317bdf9f387eb3fb7053faf/third_party/WebKit/Source/core/frame/LocalFrame.h [modify] https://crrev.com/525244b2766b65ccb317bdf9f387eb3fb7053faf/third_party/WebKit/Source/platform/BUILD.gn [modify] https://crrev.com/525244b2766b65ccb317bdf9f387eb3fb7053faf/third_party/WebKit/Source/platform/exported/Platform.cpp [add] https://crrev.com/525244b2766b65ccb317bdf9f387eb3fb7053faf/third_party/WebKit/Source/platform/instrumentation/resource_coordinator/BlinkResourceCoordinatorBase.cpp [add] https://crrev.com/525244b2766b65ccb317bdf9f387eb3fb7053faf/third_party/WebKit/Source/platform/instrumentation/resource_coordinator/BlinkResourceCoordinatorBase.h [modify] https://crrev.com/525244b2766b65ccb317bdf9f387eb3fb7053faf/third_party/WebKit/Source/platform/instrumentation/resource_coordinator/FrameResourceCoordinator.cpp [modify] https://crrev.com/525244b2766b65ccb317bdf9f387eb3fb7053faf/third_party/WebKit/Source/platform/instrumentation/resource_coordinator/FrameResourceCoordinator.h [add] https://crrev.com/525244b2766b65ccb317bdf9f387eb3fb7053faf/third_party/WebKit/Source/platform/instrumentation/resource_coordinator/RendererResourceCoordinator.cpp [add] https://crrev.com/525244b2766b65ccb317bdf9f387eb3fb7053faf/third_party/WebKit/Source/platform/instrumentation/resource_coordinator/RendererResourceCoordinator.h [modify] https://crrev.com/525244b2766b65ccb317bdf9f387eb3fb7053faf/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc [modify] https://crrev.com/525244b2766b65ccb317bdf9f387eb3fb7053faf/third_party/WebKit/Source/platform/testing/TestingPlatformSupport.cpp [modify] https://crrev.com/525244b2766b65ccb317bdf9f387eb3fb7053faf/third_party/WebKit/Source/platform/testing/TestingPlatformSupport.h [modify] https://crrev.com/525244b2766b65ccb317bdf9f387eb3fb7053faf/third_party/WebKit/public/platform/Platform.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/962d584403f921069f45f52f6c3fe05504110e0c commit 962d584403f921069f45f52f6c3fe05504110e0c Author: Duc Bui <ducbui@google.com> Date: Thu Aug 10 21:43:21 2017 Revert "[GRC] Track Expected Task Queueing Duration of tabs in GRC." This reverts commit 525244b2766b65ccb317bdf9f387eb3fb7053faf. Reason for revert: Compilation failure on Linux64/Win64/Mac64 trunk official. https://bugs.chromium.org/p/chromium/issues/detail?id=754400 Original change's description: > [GRC] Track Expected Task Queueing Duration of tabs in GRC. > > We want to track the smoothness of foreground tabs during session restore, > which can be estimated by their ExpectedTaskQueueingDuration. > > This patch sends ExpectedTaskQueueingDuration metric measured in Blink > RendererScheduler to GRC. > > BUG= 737817 > > Change-Id: I54be5ef1171fb885598e259ffe0580631b8e6f9c > Reviewed-on: https://chromium-review.googlesource.com/567539 > Reviewed-by: Nasko Oskov <nasko@chromium.org> > Reviewed-by: Nate Chapin <japhet@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Ken Rockot <rockot@chromium.org> > Reviewed-by: Zhen Wang <zhenw@chromium.org> > Commit-Queue: Duc Bui <ducbui@google.com> > Cr-Commit-Position: refs/heads/master@{#493501} TBR=dcheng@chromium.org,nasko@chromium.org,rockot@chromium.org,zhenw@chromium.org,fmeawad@chromium.org,haraken@chromium.org,japhet@chromium.org,oysteine@chromium.org,lpy@chromium.org,ducbui@google.com Change-Id: Idd2ae215bf2aad017021df73f722a1e2b6e03a47 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 737817 Reviewed-on: https://chromium-review.googlesource.com/610451 Reviewed-by: Fadi Meawad <fmeawad@chromium.org> Commit-Queue: Fadi Meawad <fmeawad@chromium.org> Cr-Commit-Position: refs/heads/master@{#493555} [modify] https://crrev.com/962d584403f921069f45f52f6c3fe05504110e0c/content/child/blink_platform_impl.cc [modify] https://crrev.com/962d584403f921069f45f52f6c3fe05504110e0c/content/child/blink_platform_impl.h [modify] https://crrev.com/962d584403f921069f45f52f6c3fe05504110e0c/content/public/test/render_view_test.cc [modify] https://crrev.com/962d584403f921069f45f52f6c3fe05504110e0c/content/public/test/render_view_test.h [modify] https://crrev.com/962d584403f921069f45f52f6c3fe05504110e0c/services/resource_coordinator/public/interfaces/signals.mojom [modify] https://crrev.com/962d584403f921069f45f52f6c3fe05504110e0c/third_party/WebKit/Source/core/frame/LocalFrame.cpp [modify] https://crrev.com/962d584403f921069f45f52f6c3fe05504110e0c/third_party/WebKit/Source/core/frame/LocalFrame.h [modify] https://crrev.com/962d584403f921069f45f52f6c3fe05504110e0c/third_party/WebKit/Source/platform/BUILD.gn [modify] https://crrev.com/962d584403f921069f45f52f6c3fe05504110e0c/third_party/WebKit/Source/platform/exported/Platform.cpp [delete] https://crrev.com/5ae4efa170db895c068bc08da205e60ff9886c5b/third_party/WebKit/Source/platform/instrumentation/resource_coordinator/BlinkResourceCoordinatorBase.cpp [delete] https://crrev.com/5ae4efa170db895c068bc08da205e60ff9886c5b/third_party/WebKit/Source/platform/instrumentation/resource_coordinator/BlinkResourceCoordinatorBase.h [modify] https://crrev.com/962d584403f921069f45f52f6c3fe05504110e0c/third_party/WebKit/Source/platform/instrumentation/resource_coordinator/FrameResourceCoordinator.cpp [modify] https://crrev.com/962d584403f921069f45f52f6c3fe05504110e0c/third_party/WebKit/Source/platform/instrumentation/resource_coordinator/FrameResourceCoordinator.h [delete] https://crrev.com/5ae4efa170db895c068bc08da205e60ff9886c5b/third_party/WebKit/Source/platform/instrumentation/resource_coordinator/RendererResourceCoordinator.cpp [delete] https://crrev.com/5ae4efa170db895c068bc08da205e60ff9886c5b/third_party/WebKit/Source/platform/instrumentation/resource_coordinator/RendererResourceCoordinator.h [modify] https://crrev.com/962d584403f921069f45f52f6c3fe05504110e0c/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc [modify] https://crrev.com/962d584403f921069f45f52f6c3fe05504110e0c/third_party/WebKit/Source/platform/testing/TestingPlatformSupport.cpp [modify] https://crrev.com/962d584403f921069f45f52f6c3fe05504110e0c/third_party/WebKit/Source/platform/testing/TestingPlatformSupport.h [modify] https://crrev.com/962d584403f921069f45f52f6c3fe05504110e0c/third_party/WebKit/public/platform/Platform.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/49124acbdd202db7fbf4db80b9f86eacfd0e48ab commit 49124acbdd202db7fbf4db80b9f86eacfd0e48ab Author: Duc Bui <ducbui@google.com> Date: Wed Aug 16 02:03:52 2017 Reland "[GRC] Track Expected Task Queueing Duration of tabs in GRC." This CL fixes the compilation failure for the previously reverted CL (https://chromium-review.googlesource.com/c/610451). The compilation failure is due to the missing dependency from Blink platform/scheduler to generated coordination_unit.mojom-blink.h. This CL separates platform/instrumentation into an independent module and makes scheduler/ depend on it. The only differences with the original CL are BUILD.gn files in Blink platform/, platform/scheduler/ and platform/instrumentation/. This is a reland of 525244b2766b65ccb317bdf9f387eb3fb7053faf Original change's description: > [GRC] Track Expected Task Queueing Duration of tabs in GRC. > > We want to track the smoothness of foreground tabs during session restore, > which can be estimated by their ExpectedTaskQueueingDuration. > > This patch sends ExpectedTaskQueueingDuration metric measured in Blink > RendererScheduler to GRC. > > BUG= 737817 > > Change-Id: I54be5ef1171fb885598e259ffe0580631b8e6f9c > Reviewed-on: https://chromium-review.googlesource.com/567539 > Reviewed-by: Nasko Oskov <nasko@chromium.org> > Reviewed-by: Nate Chapin <japhet@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Ken Rockot <rockot@chromium.org> > Reviewed-by: Zhen Wang <zhenw@chromium.org> > Commit-Queue: Duc Bui <ducbui@google.com> > Cr-Commit-Position: refs/heads/master@{#493501} TBR=nasko@chromium.org Bug: 737817 Change-Id: I353b9e98468e5dfbcf1bfe2e66deb75322aa3be2 Reviewed-on: https://chromium-review.googlesource.com/613820 Commit-Queue: Duc Bui <ducbui@google.com> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Ken Rockot <rockot@chromium.org> Reviewed-by: Nate Chapin <japhet@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: lpy <lpy@chromium.org> Cr-Commit-Position: refs/heads/master@{#494666} [modify] https://crrev.com/49124acbdd202db7fbf4db80b9f86eacfd0e48ab/content/child/blink_platform_impl.cc [modify] https://crrev.com/49124acbdd202db7fbf4db80b9f86eacfd0e48ab/content/child/blink_platform_impl.h [modify] https://crrev.com/49124acbdd202db7fbf4db80b9f86eacfd0e48ab/content/public/test/render_view_test.cc [modify] https://crrev.com/49124acbdd202db7fbf4db80b9f86eacfd0e48ab/content/public/test/render_view_test.h [modify] https://crrev.com/49124acbdd202db7fbf4db80b9f86eacfd0e48ab/services/resource_coordinator/public/interfaces/signals.mojom [modify] https://crrev.com/49124acbdd202db7fbf4db80b9f86eacfd0e48ab/third_party/WebKit/Source/core/frame/LocalFrame.cpp [modify] https://crrev.com/49124acbdd202db7fbf4db80b9f86eacfd0e48ab/third_party/WebKit/Source/core/frame/LocalFrame.h [modify] https://crrev.com/49124acbdd202db7fbf4db80b9f86eacfd0e48ab/third_party/WebKit/Source/platform/BUILD.gn [modify] https://crrev.com/49124acbdd202db7fbf4db80b9f86eacfd0e48ab/third_party/WebKit/Source/platform/exported/Platform.cpp [add] https://crrev.com/49124acbdd202db7fbf4db80b9f86eacfd0e48ab/third_party/WebKit/Source/platform/instrumentation/BUILD.gn [add] https://crrev.com/49124acbdd202db7fbf4db80b9f86eacfd0e48ab/third_party/WebKit/Source/platform/instrumentation/resource_coordinator/BlinkResourceCoordinatorBase.cpp [add] https://crrev.com/49124acbdd202db7fbf4db80b9f86eacfd0e48ab/third_party/WebKit/Source/platform/instrumentation/resource_coordinator/BlinkResourceCoordinatorBase.h [modify] https://crrev.com/49124acbdd202db7fbf4db80b9f86eacfd0e48ab/third_party/WebKit/Source/platform/instrumentation/resource_coordinator/FrameResourceCoordinator.cpp [modify] https://crrev.com/49124acbdd202db7fbf4db80b9f86eacfd0e48ab/third_party/WebKit/Source/platform/instrumentation/resource_coordinator/FrameResourceCoordinator.h [add] https://crrev.com/49124acbdd202db7fbf4db80b9f86eacfd0e48ab/third_party/WebKit/Source/platform/instrumentation/resource_coordinator/RendererResourceCoordinator.cpp [add] https://crrev.com/49124acbdd202db7fbf4db80b9f86eacfd0e48ab/third_party/WebKit/Source/platform/instrumentation/resource_coordinator/RendererResourceCoordinator.h [modify] https://crrev.com/49124acbdd202db7fbf4db80b9f86eacfd0e48ab/third_party/WebKit/Source/platform/scheduler/BUILD.gn [modify] https://crrev.com/49124acbdd202db7fbf4db80b9f86eacfd0e48ab/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc [modify] https://crrev.com/49124acbdd202db7fbf4db80b9f86eacfd0e48ab/third_party/WebKit/Source/platform/testing/TestingPlatformSupport.cpp [modify] https://crrev.com/49124acbdd202db7fbf4db80b9f86eacfd0e48ab/third_party/WebKit/Source/platform/testing/TestingPlatformSupport.h [modify] https://crrev.com/49124acbdd202db7fbf4db80b9f86eacfd0e48ab/third_party/WebKit/public/platform/Platform.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b2a524683799e8f092f97b2bc71379f718702f3b commit b2a524683799e8f092f97b2bc71379f718702f3b Author: Max Morin <maxmorin@chromium.org> Date: Wed Aug 16 07:37:23 2017 Revert "Reland "[GRC] Track Expected Task Queueing Duration of tabs in GRC."" This reverts commit 49124acbdd202db7fbf4db80b9f86eacfd0e48ab. Reason for revert: Speculative revert for resource coordinator asan failures, see https://build.chromium.org/p/chromium.memory/builders/Linux%20ChromiumOS%20MSan%20Tests/builds/2355 and subsequent builds Original change's description: > Reland "[GRC] Track Expected Task Queueing Duration of tabs in GRC." > > This CL fixes the compilation failure for the previously reverted CL > (https://chromium-review.googlesource.com/c/610451). The compilation > failure is due to the missing dependency from Blink platform/scheduler > to generated coordination_unit.mojom-blink.h. This CL separates > platform/instrumentation into an independent module and makes > scheduler/ depend on it. > > The only differences with the original CL are BUILD.gn files in > Blink platform/, platform/scheduler/ and platform/instrumentation/. > > This is a reland of 525244b2766b65ccb317bdf9f387eb3fb7053faf > Original change's description: > > [GRC] Track Expected Task Queueing Duration of tabs in GRC. > > > > We want to track the smoothness of foreground tabs during session restore, > > which can be estimated by their ExpectedTaskQueueingDuration. > > > > This patch sends ExpectedTaskQueueingDuration metric measured in Blink > > RendererScheduler to GRC. > > > > BUG= 737817 > > > > Change-Id: I54be5ef1171fb885598e259ffe0580631b8e6f9c > > Reviewed-on: https://chromium-review.googlesource.com/567539 > > Reviewed-by: Nasko Oskov <nasko@chromium.org> > > Reviewed-by: Nate Chapin <japhet@chromium.org> > > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > > Reviewed-by: Kentaro Hara <haraken@chromium.org> > > Reviewed-by: Ken Rockot <rockot@chromium.org> > > Reviewed-by: Zhen Wang <zhenw@chromium.org> > > Commit-Queue: Duc Bui <ducbui@google.com> > > Cr-Commit-Position: refs/heads/master@{#493501} > > TBR=nasko@chromium.org > > Bug: 737817 > Change-Id: I353b9e98468e5dfbcf1bfe2e66deb75322aa3be2 > Reviewed-on: https://chromium-review.googlesource.com/613820 > Commit-Queue: Duc Bui <ducbui@google.com> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Ken Rockot <rockot@chromium.org> > Reviewed-by: Nate Chapin <japhet@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: lpy <lpy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#494666} TBR=dcheng@chromium.org,nasko@chromium.org,rockot@chromium.org,zhenw@chromium.org,fmeawad@chromium.org,haraken@chromium.org,japhet@chromium.org,oysteine@chromium.org,lpy@chromium.org,ducbui@google.com Change-Id: I9a329458b1690d0c69ae2e9b4c53f6d161a9b700 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 737817 Reviewed-on: https://chromium-review.googlesource.com/616143 Reviewed-by: Max Morin <maxmorin@chromium.org> Commit-Queue: Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#494717} [modify] https://crrev.com/b2a524683799e8f092f97b2bc71379f718702f3b/content/child/blink_platform_impl.cc [modify] https://crrev.com/b2a524683799e8f092f97b2bc71379f718702f3b/content/child/blink_platform_impl.h [modify] https://crrev.com/b2a524683799e8f092f97b2bc71379f718702f3b/content/public/test/render_view_test.cc [modify] https://crrev.com/b2a524683799e8f092f97b2bc71379f718702f3b/content/public/test/render_view_test.h [modify] https://crrev.com/b2a524683799e8f092f97b2bc71379f718702f3b/services/resource_coordinator/public/interfaces/signals.mojom [modify] https://crrev.com/b2a524683799e8f092f97b2bc71379f718702f3b/third_party/WebKit/Source/core/frame/LocalFrame.cpp [modify] https://crrev.com/b2a524683799e8f092f97b2bc71379f718702f3b/third_party/WebKit/Source/core/frame/LocalFrame.h [modify] https://crrev.com/b2a524683799e8f092f97b2bc71379f718702f3b/third_party/WebKit/Source/platform/BUILD.gn [modify] https://crrev.com/b2a524683799e8f092f97b2bc71379f718702f3b/third_party/WebKit/Source/platform/exported/Platform.cpp [delete] https://crrev.com/f0790b38fa924ada8d4b228bc293247ace1455ec/third_party/WebKit/Source/platform/instrumentation/BUILD.gn [delete] https://crrev.com/f0790b38fa924ada8d4b228bc293247ace1455ec/third_party/WebKit/Source/platform/instrumentation/resource_coordinator/BlinkResourceCoordinatorBase.cpp [delete] https://crrev.com/f0790b38fa924ada8d4b228bc293247ace1455ec/third_party/WebKit/Source/platform/instrumentation/resource_coordinator/BlinkResourceCoordinatorBase.h [modify] https://crrev.com/b2a524683799e8f092f97b2bc71379f718702f3b/third_party/WebKit/Source/platform/instrumentation/resource_coordinator/FrameResourceCoordinator.cpp [modify] https://crrev.com/b2a524683799e8f092f97b2bc71379f718702f3b/third_party/WebKit/Source/platform/instrumentation/resource_coordinator/FrameResourceCoordinator.h [delete] https://crrev.com/f0790b38fa924ada8d4b228bc293247ace1455ec/third_party/WebKit/Source/platform/instrumentation/resource_coordinator/RendererResourceCoordinator.cpp [delete] https://crrev.com/f0790b38fa924ada8d4b228bc293247ace1455ec/third_party/WebKit/Source/platform/instrumentation/resource_coordinator/RendererResourceCoordinator.h [modify] https://crrev.com/b2a524683799e8f092f97b2bc71379f718702f3b/third_party/WebKit/Source/platform/scheduler/BUILD.gn [modify] https://crrev.com/b2a524683799e8f092f97b2bc71379f718702f3b/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc [modify] https://crrev.com/b2a524683799e8f092f97b2bc71379f718702f3b/third_party/WebKit/Source/platform/testing/TestingPlatformSupport.cpp [modify] https://crrev.com/b2a524683799e8f092f97b2bc71379f718702f3b/third_party/WebKit/Source/platform/testing/TestingPlatformSupport.h [modify] https://crrev.com/b2a524683799e8f092f97b2bc71379f718702f3b/third_party/WebKit/public/platform/Platform.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7be7aceb006f81a3638bba4249c4367ddf659351 commit 7be7aceb006f81a3638bba4249c4367ddf659351 Author: Duc Bui <ducbui@google.com> Date: Thu Aug 17 03:03:05 2017 Reland "Reland "[GRC] Track Expected Task Queueing Duration of tabs in GRC."" This CL fixes error "MemorySanitizer: use-of-uninitialized-value" on ChromeOS. The cause is that CoordinationUnitImpl::CreateCoordinationUnit() returns a value after it was uninitialized by std::move(). https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.memory%2FLinux_ChromiumOS_MSan_Tests%2F2355%2F%2B%2Frecipes%2Fsteps%2Fbrowser_tests%2F0%2Flogs%2FExtensionURLRewriteBrowserTest.BookmarksURL%2F0 This is a reland of 49124acbdd202db7fbf4db80b9f86eacfd0e48ab Original change's description: > Reland "[GRC] Track Expected Task Queueing Duration of tabs in GRC." > > This CL fixes the compilation failure for the previously reverted CL > (https://chromium-review.googlesource.com/c/610451). The compilation > failure is due to the missing dependency from Blink platform/scheduler > to generated coordination_unit.mojom-blink.h. This CL separates > platform/instrumentation into an independent module and makes > scheduler/ depend on it. > > The only differences with the original CL are BUILD.gn files in > Blink platform/, platform/scheduler/ and platform/instrumentation/. > > This is a reland of 525244b2766b65ccb317bdf9f387eb3fb7053faf > Original change's description: > > [GRC] Track Expected Task Queueing Duration of tabs in GRC. > > > > We want to track the smoothness of foreground tabs during session restore, > > which can be estimated by their ExpectedTaskQueueingDuration. > > > > This patch sends ExpectedTaskQueueingDuration metric measured in Blink > > RendererScheduler to GRC. > > > > BUG= 737817 > > > > Change-Id: I54be5ef1171fb885598e259ffe0580631b8e6f9c > > Reviewed-on: https://chromium-review.googlesource.com/567539 > > Reviewed-by: Nasko Oskov <nasko@chromium.org> > > Reviewed-by: Nate Chapin <japhet@chromium.org> > > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > > Reviewed-by: Kentaro Hara <haraken@chromium.org> > > Reviewed-by: Ken Rockot <rockot@chromium.org> > > Reviewed-by: Zhen Wang <zhenw@chromium.org> > > Commit-Queue: Duc Bui <ducbui@google.com> > > Cr-Commit-Position: refs/heads/master@{#493501} > > TBR=nasko@chromium.org > > Bug: 737817 > Change-Id: I353b9e98468e5dfbcf1bfe2e66deb75322aa3be2 > Reviewed-on: https://chromium-review.googlesource.com/613820 > Commit-Queue: Duc Bui <ducbui@google.com> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Ken Rockot <rockot@chromium.org> > Reviewed-by: Nate Chapin <japhet@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: lpy <lpy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#494666} Bug: 737817 Change-Id: Ifefe45613b09b8062261aa08f3921c6fe3368a5f TBR=nasko@chromium.org Change-Id: Ifefe45613b09b8062261aa08f3921c6fe3368a5f Reviewed-on: https://chromium-review.googlesource.com/617982 Commit-Queue: Duc Bui <ducbui@google.com> Reviewed-by: lpy <lpy@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#495062} [modify] https://crrev.com/7be7aceb006f81a3638bba4249c4367ddf659351/content/child/blink_platform_impl.cc [modify] https://crrev.com/7be7aceb006f81a3638bba4249c4367ddf659351/content/child/blink_platform_impl.h [modify] https://crrev.com/7be7aceb006f81a3638bba4249c4367ddf659351/content/public/test/render_view_test.cc [modify] https://crrev.com/7be7aceb006f81a3638bba4249c4367ddf659351/content/public/test/render_view_test.h [modify] https://crrev.com/7be7aceb006f81a3638bba4249c4367ddf659351/services/resource_coordinator/coordination_unit/coordination_unit_impl.cc [modify] https://crrev.com/7be7aceb006f81a3638bba4249c4367ddf659351/services/resource_coordinator/public/interfaces/signals.mojom [modify] https://crrev.com/7be7aceb006f81a3638bba4249c4367ddf659351/third_party/WebKit/Source/core/frame/LocalFrame.cpp [modify] https://crrev.com/7be7aceb006f81a3638bba4249c4367ddf659351/third_party/WebKit/Source/core/frame/LocalFrame.h [modify] https://crrev.com/7be7aceb006f81a3638bba4249c4367ddf659351/third_party/WebKit/Source/platform/BUILD.gn [modify] https://crrev.com/7be7aceb006f81a3638bba4249c4367ddf659351/third_party/WebKit/Source/platform/exported/Platform.cpp [add] https://crrev.com/7be7aceb006f81a3638bba4249c4367ddf659351/third_party/WebKit/Source/platform/instrumentation/BUILD.gn [add] https://crrev.com/7be7aceb006f81a3638bba4249c4367ddf659351/third_party/WebKit/Source/platform/instrumentation/resource_coordinator/BlinkResourceCoordinatorBase.cpp [add] https://crrev.com/7be7aceb006f81a3638bba4249c4367ddf659351/third_party/WebKit/Source/platform/instrumentation/resource_coordinator/BlinkResourceCoordinatorBase.h [modify] https://crrev.com/7be7aceb006f81a3638bba4249c4367ddf659351/third_party/WebKit/Source/platform/instrumentation/resource_coordinator/FrameResourceCoordinator.cpp [modify] https://crrev.com/7be7aceb006f81a3638bba4249c4367ddf659351/third_party/WebKit/Source/platform/instrumentation/resource_coordinator/FrameResourceCoordinator.h [add] https://crrev.com/7be7aceb006f81a3638bba4249c4367ddf659351/third_party/WebKit/Source/platform/instrumentation/resource_coordinator/RendererResourceCoordinator.cpp [add] https://crrev.com/7be7aceb006f81a3638bba4249c4367ddf659351/third_party/WebKit/Source/platform/instrumentation/resource_coordinator/RendererResourceCoordinator.h [modify] https://crrev.com/7be7aceb006f81a3638bba4249c4367ddf659351/third_party/WebKit/Source/platform/scheduler/BUILD.gn [modify] https://crrev.com/7be7aceb006f81a3638bba4249c4367ddf659351/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc [modify] https://crrev.com/7be7aceb006f81a3638bba4249c4367ddf659351/third_party/WebKit/Source/platform/testing/TestingPlatformSupport.cpp [modify] https://crrev.com/7be7aceb006f81a3638bba4249c4367ddf659351/third_party/WebKit/Source/platform/testing/TestingPlatformSupport.h [modify] https://crrev.com/7be7aceb006f81a3638bba4249c4367ddf659351/third_party/WebKit/public/platform/Platform.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1ec35bf958b198b7948785c14d013d4a6ffd71a3 commit 1ec35bf958b198b7948785c14d013d4a6ffd71a3 Author: Duc Bui <ducbui@google.com> Date: Fri Aug 18 02:32:24 2017 [GRC] Send Expected Task Queueing Duration to TabManagerStatsCollector. We want to track the smoothness of foreground tabs during session restore, which can be estimated by their ExpectedTaskQueueingDuration. This patch sends ExpectedTaskQueueingDuration metric values from GRC to TabManagerStatsCollector. Bug: 737817 Change-Id: I07ff8aa9735c73fa3180564101cf2692c776b469 Reviewed-on: https://chromium-review.googlesource.com/585906 Commit-Queue: Duc Bui <ducbui@google.com> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: lpy <lpy@chromium.org> Reviewed-by: Zhen Wang <zhenw@chromium.org> Cr-Commit-Position: refs/heads/master@{#495431} [modify] https://crrev.com/1ec35bf958b198b7948785c14d013d4a6ffd71a3/chrome/browser/resource_coordinator/tab_manager_grc_tab_signal_observer.cc [modify] https://crrev.com/1ec35bf958b198b7948785c14d013d4a6ffd71a3/chrome/browser/resource_coordinator/tab_manager_grc_tab_signal_observer.h [modify] https://crrev.com/1ec35bf958b198b7948785c14d013d4a6ffd71a3/chrome/browser/resource_coordinator/tab_manager_stats_collector.cc [modify] https://crrev.com/1ec35bf958b198b7948785c14d013d4a6ffd71a3/chrome/browser/resource_coordinator/tab_manager_stats_collector.h [modify] https://crrev.com/1ec35bf958b198b7948785c14d013d4a6ffd71a3/services/resource_coordinator/BUILD.gn [modify] https://crrev.com/1ec35bf958b198b7948785c14d013d4a6ffd71a3/services/resource_coordinator/coordination_unit/coordination_unit_impl.cc [modify] https://crrev.com/1ec35bf958b198b7948785c14d013d4a6ffd71a3/services/resource_coordinator/coordination_unit/coordination_unit_impl.h [modify] https://crrev.com/1ec35bf958b198b7948785c14d013d4a6ffd71a3/services/resource_coordinator/coordination_unit/frame_coordination_unit_impl.cc [modify] https://crrev.com/1ec35bf958b198b7948785c14d013d4a6ffd71a3/services/resource_coordinator/coordination_unit/frame_coordination_unit_impl.h [modify] https://crrev.com/1ec35bf958b198b7948785c14d013d4a6ffd71a3/services/resource_coordinator/coordination_unit/process_coordination_unit_impl.cc [modify] https://crrev.com/1ec35bf958b198b7948785c14d013d4a6ffd71a3/services/resource_coordinator/coordination_unit/tab_signal_generator_impl.cc [modify] https://crrev.com/1ec35bf958b198b7948785c14d013d4a6ffd71a3/services/resource_coordinator/coordination_unit/tab_signal_generator_impl.h [add] https://crrev.com/1ec35bf958b198b7948785c14d013d4a6ffd71a3/services/resource_coordinator/coordination_unit/tab_signal_generator_impl_unittest.cc [modify] https://crrev.com/1ec35bf958b198b7948785c14d013d4a6ffd71a3/services/resource_coordinator/coordination_unit/web_contents_coordination_unit_impl.cc [modify] https://crrev.com/1ec35bf958b198b7948785c14d013d4a6ffd71a3/services/resource_coordinator/coordination_unit/web_contents_coordination_unit_impl.h [modify] https://crrev.com/1ec35bf958b198b7948785c14d013d4a6ffd71a3/services/resource_coordinator/coordination_unit/web_contents_coordination_unit_impl_unittest.cc [modify] https://crrev.com/1ec35bf958b198b7948785c14d013d4a6ffd71a3/services/resource_coordinator/public/interfaces/tab_signal.mojom
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b53744615a689fc82e76e1847011d1f34aaa83f6 commit b53744615a689fc82e76e1847011d1f34aaa83f6 Author: Duc Bui <ducbui@google.com> Date: Fri Aug 18 04:17:05 2017 [TabManager] Record EQT metrics This CL records Task Expected Queueing Time UMA in TabManagerStatsCollector. Bug: 737817 Change-Id: I16b1a46b02a419ed5c9f2241d84a44c6a73fff20 Reviewed-on: https://chromium-review.googlesource.com/609682 Commit-Queue: Duc Bui <ducbui@google.com> Reviewed-by: Mark Pearson <mpearson@chromium.org> Reviewed-by: Zhen Wang <zhenw@chromium.org> Reviewed-by: lpy <lpy@chromium.org> Cr-Commit-Position: refs/heads/master@{#495458} [modify] https://crrev.com/b53744615a689fc82e76e1847011d1f34aaa83f6/chrome/browser/resource_coordinator/tab_manager.h [modify] https://crrev.com/b53744615a689fc82e76e1847011d1f34aaa83f6/chrome/browser/resource_coordinator/tab_manager_stats_collector.cc [modify] https://crrev.com/b53744615a689fc82e76e1847011d1f34aaa83f6/chrome/browser/resource_coordinator/tab_manager_stats_collector.h [modify] https://crrev.com/b53744615a689fc82e76e1847011d1f34aaa83f6/chrome/browser/resource_coordinator/tab_manager_stats_collector_unittest.cc [modify] https://crrev.com/b53744615a689fc82e76e1847011d1f34aaa83f6/tools/metrics/histograms/histograms.xml
Comment 1 by ducbui@google.com
, Jul 4 2017