Issue metadata
Sign in to add a comment
|
Improving symbolize_trace end-to-end tests. |
||||||||||||||||||||||
Issue descriptionRight now, the tests run through all steps: dl symbols, expand, symbolize, update, compress. Then it compares the result against an opaque binary [e.g. a symbolized trace that was verified to be correct]. This has 2 issues: 1) In many respects, this is a change detector. Every time we make a minor change, we'll need to replace the full end-result-binary. This is *not great*. 2) This binary includes dictionaries. Serialization of dictionaries is not well-defined. This means that pypy and python result in different serializations. I think we want to move towards a world where: (1) We iterate through all steps including serialization/compression. (2) We then take our trace-reader, read from the symbolized trace, and confirm that those elements have appropriate properties. etienneb and dskiba - you both have scripts that do some amount of trace-reading/processing. wdyt?
,
Jul 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ae939669dffe7e34b5ed8f8397b0d40c1b842d46 commit ae939669dffe7e34b5ed8f8397b0d40c1b842d46 Author: catapult-deps-roller@chromium.org <catapult-deps-roller@chromium.org> Date: Mon Jul 10 20:55:13 2017 Roll src/third_party/catapult/ 30c9d9b85..f8681638b (1 commit) https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/30c9d9b85571..f8681638b945 $ git log 30c9d9b85..f8681638b --date=short --no-merges --format='%ad %ae %s' 2017-07-10 etienneb Add end-to-end test for symbolisation on windows. Created with: roll-dep src/third_party/catapult BUG=737803 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I32594a32994908eb505671932c297b4944b0938f Reviewed-on: https://chromium-review.googlesource.com/565744 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#485376} [modify] https://crrev.com/ae939669dffe7e34b5ed8f8397b0d40c1b842d46/DEPS |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by erikc...@chromium.org
, Jun 29 2017