Port src/media to fuchsia |
|||||||||
Issue descriptionCurrently media_unittests fails to compile for fuchsia. Make it compile and then pass
,
Jun 29 2017
,
Jun 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/923a488989d0e46fca1c6697af5b29eb95843a32 commit 923a488989d0e46fca1c6697af5b29eb95843a32 Author: Sergey Ulanov <sergeyu@google.com> Date: Thu Jun 29 02:18:05 2017 Fix device/gamepad/BUILD.gn for fuchsia Currently gn fails to process the file, because the file assumes that either is_android, is_linux, is_mac or is_win is set. Bug: 737802 Change-Id: I7d4d44a79467f984c990b3726639fab718dfe706 Reviewed-on: https://chromium-review.googlesource.com/553998 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#483263} [modify] https://crrev.com/923a488989d0e46fca1c6697af5b29eb95843a32/device/gamepad/BUILD.gn
,
Jun 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5d06b091553f11b8490197120700adc26dbf76c1 commit 5d06b091553f11b8490197120700adc26dbf76c1 Author: Sergey Ulanov <sergeyu@google.com> Date: Thu Jun 29 21:23:26 2017 Fixes in GN files for Fuchsia A few simple fixes for is_fuchsia=true: 1. Disabled NaCl. 2. Disabled components/crash dependency in content_shell. 3. Disabled ALSA. 4. Updated gpu/config/BUILD.gn to pass correct os_filter to process_json.py With these changes GN doesn't fail when enabling media_unittest. Bug: 737802 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ifac6527db04b5a64281b5fb2479556238f1dbdce Reviewed-on: https://chromium-review.googlesource.com/556319 Reviewed-by: Brett Wilson <brettw@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#483489} [modify] https://crrev.com/5d06b091553f11b8490197120700adc26dbf76c1/build/config/features.gni [modify] https://crrev.com/5d06b091553f11b8490197120700adc26dbf76c1/content/shell/BUILD.gn [modify] https://crrev.com/5d06b091553f11b8490197120700adc26dbf76c1/gpu/config/BUILD.gn [modify] https://crrev.com/5d06b091553f11b8490197120700adc26dbf76c1/media/media_options.gni
,
Jul 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/147af9e4a6f1b9ffc46eaff28010093b7dbe11fe commit 147af9e4a6f1b9ffc46eaff28010093b7dbe11fe Author: Sergey Ulanov <sergeyu@google.com> Date: Fri Jul 07 21:44:18 2017 Fixes to compile //gpu:gpu on Fuchsia Several simple fixes to make //gpu compile on Fuchsia: 1. Updated surface_handle.h to declare SurfaceHandle. 2. gpu/ipc/common/memory_stats.h updated to convert int32_t between ProcessId. 3. Updated eglplatform.h in third_party/khronos to define types for Fuchsia 4. Enabled use_egl in ui/gl Bug: 737802 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Iad46d340ebdd3916ac43a3528cdaa37c9641d2be Reviewed-on: https://chromium-review.googlesource.com/563764 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Antoine Labour <piman@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#485058} [modify] https://crrev.com/147af9e4a6f1b9ffc46eaff28010093b7dbe11fe/gpu/ipc/common/memory_stats_struct_traits.h [modify] https://crrev.com/147af9e4a6f1b9ffc46eaff28010093b7dbe11fe/gpu/ipc/common/surface_handle.h [modify] https://crrev.com/147af9e4a6f1b9ffc46eaff28010093b7dbe11fe/third_party/khronos/EGL/eglplatform.h [modify] https://crrev.com/147af9e4a6f1b9ffc46eaff28010093b7dbe11fe/third_party/khronos/README.chromium [modify] https://crrev.com/147af9e4a6f1b9ffc46eaff28010093b7dbe11fe/ui/gl/BUILD.gn
,
Jul 10 2017
,
Jul 11 2017
,
Jul 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/third_party/ffmpeg/+/b47a5831d87bf790cdade0072b19aa010d13536c commit b47a5831d87bf790cdade0072b19aa010d13536c Author: Sergey Ulanov <sergeyu@google.com> Date: Tue Jul 11 17:13:42 2017 Add Fuchia support in third_party/ffmpeg Now it's possible to build ffmpeg on fuchsia. Linux configs are used on Fuchsia instead of adding another ffmpeg configurarations. They were mostly compatible with Fuchsia exception that HAVE_SYSCTL was set, while sysctl is not supported. This CL updates build_ffmpeg.py to set HAVE_SYSCTL to 0. Also updated generate_gn.py to generate gn files that reuse linux configuration on Fuchsia. Bug: 737802 Change-Id: I93e803f60c3fa685485072bab6c979c64d1c4a80 Reviewed-on: https://chromium-review.googlesource.com/565363 Reviewed-by: Dale Curtis <dalecurtis@chromium.org> [modify] https://crrev.com/b47a5831d87bf790cdade0072b19aa010d13536c/chromium/scripts/generate_gn.py [modify] https://crrev.com/b47a5831d87bf790cdade0072b19aa010d13536c/chromium/config/Chrome/linux/arm64/config.h [modify] https://crrev.com/b47a5831d87bf790cdade0072b19aa010d13536c/chromium/scripts/generate_gn_unittest.py [modify] https://crrev.com/b47a5831d87bf790cdade0072b19aa010d13536c/chromium/config/ChromeOS/linux/x64/config.h [modify] https://crrev.com/b47a5831d87bf790cdade0072b19aa010d13536c/ffmpeg_options.gni [modify] https://crrev.com/b47a5831d87bf790cdade0072b19aa010d13536c/ffmpeg_generated.gni [modify] https://crrev.com/b47a5831d87bf790cdade0072b19aa010d13536c/chromium/config/Chromium/linux/arm64/config.h [modify] https://crrev.com/b47a5831d87bf790cdade0072b19aa010d13536c/chromium/config/Chromium/linux/x64/config.h [modify] https://crrev.com/b47a5831d87bf790cdade0072b19aa010d13536c/BUILD.gn [modify] https://crrev.com/b47a5831d87bf790cdade0072b19aa010d13536c/chromium/config/Chrome/linux/x64/config.h [modify] https://crrev.com/b47a5831d87bf790cdade0072b19aa010d13536c/chromium/scripts/build_ffmpeg.py [modify] https://crrev.com/b47a5831d87bf790cdade0072b19aa010d13536c/chromium/config/ChromeOS/linux/arm64/config.h
,
Jul 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/third_party/ffmpeg/+/f82eb1989c0cdd5ed179ee4979ffb18a8030c78a commit f82eb1989c0cdd5ed179ee4979ffb18a8030c78a Author: Sergey Ulanov <sergeyu@google.com> Date: Wed Jul 12 01:02:16 2017 revert incorrect changes in ffmpeg_generated.gn Previous change (https://chromium-review.googlesource.com/c/565363/) added libavformat/gsmdec.c to the build by mistake. Because of that ffmpeg_generated.gn was referencing libavcodec/autorename_libavcodec_gsmdec.c instead of libavcodec/gsmdec.c, but that file doesn't exist anymore, so build was failing when trying to roll that change. This change removes libavformat/gsmdec.cc . Bug: 737802 Change-Id: I1d8f985fbcc6398418019bdbb828121a2cd65049 Reviewed-on: https://chromium-review.googlesource.com/567607 Reviewed-by: Dale Curtis <dalecurtis@chromium.org> [modify] https://crrev.com/f82eb1989c0cdd5ed179ee4979ffb18a8030c78a/ffmpeg_generated.gni
,
Jul 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5ffe4dd335accb5a9172c39a8a2f91284e5bf96d commit 5ffe4dd335accb5a9172c39a8a2f91284e5bf96d Author: Sergey Ulanov <sergeyu@google.com> Date: Wed Jul 12 01:26:25 2017 Enable base::SyncSocket on Fuchsia Latest SDK supports socketpair(), so SyncSocket builds now and passes tests. Bug: 737802 Change-Id: Ifa34ae6d0098c3ee6d71be8c174226f0a2b09ddd Reviewed-on: https://chromium-review.googlesource.com/565582 Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#485766} [modify] https://crrev.com/5ffe4dd335accb5a9172c39a8a2f91284e5bf96d/base/BUILD.gn
,
Jul 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/392d1944ac11cf5900c99677c9b1d8074e6b7fec commit 392d1944ac11cf5900c99677c9b1d8074e6b7fec Author: Sergey Ulanov <sergeyu@google.com> Date: Wed Jul 12 01:30:10 2017 Add stubs for GL initialization functions on Fuchsia. Bug: 737802 Change-Id: Ia39269fef6a67e109b731f0036ec650c0d92f522 Reviewed-on: https://chromium-review.googlesource.com/566158 Reviewed-by: Antoine Labour <piman@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#485772} [modify] https://crrev.com/392d1944ac11cf5900c99677c9b1d8074e6b7fec/ui/gl/init/BUILD.gn [add] https://crrev.com/392d1944ac11cf5900c99677c9b1d8074e6b7fec/ui/gl/init/gl_factory_fuchsia.cc [add] https://crrev.com/392d1944ac11cf5900c99677c9b1d8074e6b7fec/ui/gl/init/gl_initializer_fuchsia.cc
,
Jul 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/108fc33c12e6ba7001b0f530e5d1bf660079da6a commit 108fc33c12e6ba7001b0f530e5d1bf660079da6a Author: Sergey Ulanov <sergeyu@google.com> Date: Wed Jul 12 07:13:05 2017 Roll ffmpeg f82eb19 Updated version now builds on Fuchsia. There are no other changes. Bug: 737802 Change-Id: I134248a719aaea783349ec3f6a663bde1a82ec30 Reviewed-on: https://chromium-review.googlesource.com/567024 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#485886} [modify] https://crrev.com/108fc33c12e6ba7001b0f530e5d1bf660079da6a/DEPS
,
Jul 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dd606ed5fa66f9f979ae3e1b36b203c9914deee7 commit dd606ed5fa66f9f979ae3e1b36b203c9914deee7 Author: Sergey Ulanov <sergeyu@google.com> Date: Thu Jul 13 00:44:24 2017 Compile skia_unittests on Fuchsia 1. Added a dummy FontMgr for Fuchsia 2. Fixed libjpeg_turbo linking issues (ELF wasn't defined) Bug: 737802 Change-Id: I3a48e448fd03a350130680ced5fafc309fc00ae9 Reviewed-on: https://chromium-review.googlesource.com/567032 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#486189} [modify] https://crrev.com/dd606ed5fa66f9f979ae3e1b36b203c9914deee7/BUILD.gn [modify] https://crrev.com/dd606ed5fa66f9f979ae3e1b36b203c9914deee7/build/secondary/third_party/libjpeg_turbo/BUILD.gn [modify] https://crrev.com/dd606ed5fa66f9f979ae3e1b36b203c9914deee7/skia/BUILD.gn [add] https://crrev.com/dd606ed5fa66f9f979ae3e1b36b203c9914deee7/skia/ext/fontmgr_default_fuchsia.cc [add] https://crrev.com/dd606ed5fa66f9f979ae3e1b36b203c9914deee7/skia/ext/fontmgr_default_fuchsia.h [modify] https://crrev.com/dd606ed5fa66f9f979ae3e1b36b203c9914deee7/testing/buildbot/chromium.fyi.json
,
Jul 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0e129f6d15325add03dba433bae7828dd3220395 commit 0e129f6d15325add03dba433bae7828dd3220395 Author: Sergey Ulanov <sergeyu@google.com> Date: Fri Jul 14 01:02:49 2017 Add dummy AudioManager for Fuchsia. AudioManagerFuchsia is a dummy implementation of AudioManager that will need to be extended to integrate with the OS. Bug: 737802 Change-Id: I1d2d9d8dcba00085fd0531207dbf5b3d8164a9d6 Reviewed-on: https://chromium-review.googlesource.com/569039 Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#486570} [modify] https://crrev.com/0e129f6d15325add03dba433bae7828dd3220395/media/audio/BUILD.gn [add] https://crrev.com/0e129f6d15325add03dba433bae7828dd3220395/media/audio/fuchsia/audio_manager_fuchsia.cc [add] https://crrev.com/0e129f6d15325add03dba433bae7828dd3220395/media/audio/fuchsia/audio_manager_fuchsia.h
,
Jul 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/64d556c90effa613f81855d74218d8173ca12de9 commit 64d556c90effa613f81855d74218d8173ca12de9 Author: Sergey Ulanov <sergeyu@google.com> Date: Fri Jul 14 01:33:14 2017 Add Fuchisa to the list of platforms in //services Bug: 737802 Change-Id: I95d347a34665f8ec1273fa0b3bd7d9eecc25cfad Reviewed-on: https://chromium-review.googlesource.com/568566 Reviewed-by: Yuzhu Shen <yzshen@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#486606} [modify] https://crrev.com/64d556c90effa613f81855d74218d8173ca12de9/services/catalog/public/cpp/manifest_parsing_util.cc [modify] https://crrev.com/64d556c90effa613f81855d74218d8173ca12de9/services/catalog/store.cc [modify] https://crrev.com/64d556c90effa613f81855d74218d8173ca12de9/services/catalog/store.h
,
Jul 15 2017
,
Jul 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/89ddf7b921d7a48664789e791ad2fc132a798831 commit 89ddf7b921d7a48664789e791ad2fc132a798831 Author: Sergey Ulanov <sergeyu@google.com> Date: Tue Jul 18 02:15:24 2017 Disable OS file locking on Fuchsia Fuchsia doesn't support file locking, i.e. there is no base::File::Lock(), so components/filesystem was failing to compile. Added ifdefs so File::Lock() is not used on Fuchsia. Bug: 737802 , 744893 Change-Id: I825fba49b9c6247d1b4c75ca23fce4c150344db1 Reviewed-on: https://chromium-review.googlesource.com/575288 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by: Kevin Marshall <kmarshall@chromium.org> Reviewed-by: Elliot Glaysher <erg@chromium.org> Cr-Commit-Position: refs/heads/master@{#487347} [modify] https://crrev.com/89ddf7b921d7a48664789e791ad2fc132a798831/components/filesystem/file_impl.cc [modify] https://crrev.com/89ddf7b921d7a48664789e791ad2fc132a798831/components/filesystem/file_impl.h [modify] https://crrev.com/89ddf7b921d7a48664789e791ad2fc132a798831/components/filesystem/lock_table.cc
,
Jul 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/135ba0849bc569fe9844490d6b66b468eb7f1505 commit 135ba0849bc569fe9844490d6b66b468eb7f1505 Author: Sergey Ulanov <sergeyu@google.com> Date: Tue Jul 18 19:39:22 2017 Enable media_unittest compilation on fuchsia Bug: 737802 Change-Id: I5b1d11793f4edd19e9cb8b0d3435689b3b77f827 Reviewed-on: https://chromium-review.googlesource.com/574891 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#487560} [modify] https://crrev.com/135ba0849bc569fe9844490d6b66b468eb7f1505/BUILD.gn [modify] https://crrev.com/135ba0849bc569fe9844490d6b66b468eb7f1505/testing/buildbot/chromium.fyi.json
,
Aug 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fdc62f8eb593ff1da731dc28e197fe32ddb14779 commit fdc62f8eb593ff1da731dc28e197fe32ddb14779 Author: Sergey Ulanov <sergeyu@google.com> Date: Tue Aug 01 19:51:00 2017 Fix Fuchsia implementation of base::RandBytes() to allow empty buffer. base::RandBytes() may be called with output_length=0 and all implementations supported this case, except Fuchsia. On Fuchsia the function was crashing due to a failed CHECK(). This was breaking MemoryDataSourceTest.EmptySource test. Bug: 737802 Change-Id: Ib9ec20a82dd6966a146f0c66936e232c061466a5 Reviewed-on: https://chromium-review.googlesource.com/595012 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Reviewed-by: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#491086} [modify] https://crrev.com/fdc62f8eb593ff1da731dc28e197fe32ddb14779/base/rand_util_fuchsia.cc [modify] https://crrev.com/fdc62f8eb593ff1da731dc28e197fe32ddb14779/base/rand_util_unittest.cc
,
Aug 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7f29ca0cf604f56fc8ae5fcae650872de26f9f0e commit 7f29ca0cf604f56fc8ae5fcae650872de26f9f0e Author: Sergey Ulanov <sergeyu@google.com> Date: Tue Aug 08 17:42:06 2017 Enable media_unittests on Fuchsia bots Enable media_unittests with a filter. Also fixed a preprocessor conditional to fix a test. NOTRY=true Bug: 737802 Change-Id: I5f70f96a08daaf67b67c42649ea635afb576647f Reviewed-on: https://chromium-review.googlesource.com/602391 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Reviewed-by: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#492690} [modify] https://crrev.com/7f29ca0cf604f56fc8ae5fcae650872de26f9f0e/media/base/audio_latency.cc [modify] https://crrev.com/7f29ca0cf604f56fc8ae5fcae650872de26f9f0e/testing/buildbot/chromium.fyi.json [add] https://crrev.com/7f29ca0cf604f56fc8ae5fcae650872de26f9f0e/testing/buildbot/filters/fuchsia.media_unittests.filter
,
Aug 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b88b21525491cdf05652bed18f0f6c7c9d33d138 commit b88b21525491cdf05652bed18f0f6c7c9d33d138 Author: Sergey Ulanov <sergeyu@google.com> Date: Tue Aug 08 19:13:54 2017 Add MediaRemotingIntegrationTest to media_unittests filter MediaRemotingIntegrationTests are expensive, so they may be flaky under qemu. NOTRY=true Bug: 737802 , 745094 Change-Id: I1fb321ae4d0d3f418fc891c89942c77f5d22d761 Reviewed-on: https://chromium-review.googlesource.com/606548 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#492722} [modify] https://crrev.com/b88b21525491cdf05652bed18f0f6c7c9d33d138/testing/buildbot/filters/fuchsia.media_unittests.filter
,
Aug 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/58d191dea8670d38e6bfa2d9aa5b6d97db785ea3 commit 58d191dea8670d38e6bfa2d9aa5b6d97db785ea3 Author: Sergey Ulanov <sergeyu@google.com> Date: Wed Aug 09 00:55:22 2017 Fix AudioOutputControllerTest to pass on slow machines. AudioOutputControllerTest were setting expectations for a function that may be called more than once when running on a slow machine. This caused these tests to be flaky on Fuchsia bots where they are executed under qemu. Added .Times(AtLeast(1)) when setting expectation, so these tests can cope with this case properly. Bug: 737802 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Id21be52d9ed4b30173faf68790877eab747aad70 Reviewed-on: https://chromium-review.googlesource.com/607267 Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#492793} [modify] https://crrev.com/58d191dea8670d38e6bfa2d9aa5b6d97db785ea3/media/audio/audio_output_controller_unittest.cc
,
Aug 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6c5186257e56f5e73686145a1f66ba3fd03c2b62 commit 6c5186257e56f5e73686145a1f66ba3fd03c2b62 Author: Sergey Ulanov <sergeyu@chromium.org> Date: Sat Aug 12 19:06:27 2017 Filter failing tests in net_unittests and media_unittests on Fuchsia TBR=scottmg@chromium.org Bug: 737802 , 731302 Change-Id: I166c0b168a216f8f9453cf7d2e3fb719ecf81f9f Reviewed-on: https://chromium-review.googlesource.com/612748 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#493982} [modify] https://crrev.com/6c5186257e56f5e73686145a1f66ba3fd03c2b62/testing/buildbot/filters/fuchsia.media_unittests.filter [modify] https://crrev.com/6c5186257e56f5e73686145a1f66ba3fd03c2b62/testing/buildbot/filters/fuchsia.net_unittests.filter
,
Aug 15 2017
,
Aug 17 2017
,
Sep 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c41c1d17393f4fce7be7705b8bc3bcbb1cdf80fe commit c41c1d17393f4fce7be7705b8bc3bcbb1cdf80fe Author: Sergey Ulanov <sergeyu@chromium.org> Date: Fri Sep 15 18:59:11 2017 Stop quitting MessageLoop in media pipeline tests Previously PipelineIntegrationTestBase was posting a task for base::MessageLoop::QuitWhenIdleClosure to quit run loop. This may make some tests flaky, as there is no guarantee that the right run loop quits. This CL updates PipelineIntegrationTestBase to avoid accessing MessageLoop directly. Insted it's using RunLoop::Quit(), which guarantees that only the right RunLoop quits. Bug: 737802 Change-Id: I501bb9b613004a613c4892bf91e3f4a1b177433d Reviewed-on: https://chromium-review.googlesource.com/667749 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#502323} [modify] https://crrev.com/c41c1d17393f4fce7be7705b8bc3bcbb1cdf80fe/media/test/pipeline_integration_test_base.cc [modify] https://crrev.com/c41c1d17393f4fce7be7705b8bc3bcbb1cdf80fe/media/test/pipeline_integration_test_base.h
,
Sep 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1bdd029f12b5905717535db5247ac7dde4689068 commit 1bdd029f12b5905717535db5247ac7dde4689068 Author: Sergey Ulanov <sergeyu@chromium.org> Date: Fri Sep 15 22:02:45 2017 Remove media_unittests filter on Fuchsia All tests in media_unittests shold pass now, so we no longer need the filter. Bug: 737802 Change-Id: Iebe0e1cb4f6c148aac4abc11f729b211d23b1d39 Reviewed-on: https://chromium-review.googlesource.com/667782 Reviewed-by: Wez <wez@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#502396} [modify] https://crrev.com/1bdd029f12b5905717535db5247ac7dde4689068/testing/buildbot/chromium.fyi.json [modify] https://crrev.com/1bdd029f12b5905717535db5247ac7dde4689068/testing/buildbot/filters/BUILD.gn [delete] https://crrev.com/25f2c01656c9c3edbea69428b08e0b03432f7c63/testing/buildbot/filters/fuchsia.media_unittests.filter
,
Sep 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9e4a3e9fc974b2c0267aba091ef3effe8ebcd3ca commit 9e4a3e9fc974b2c0267aba091ef3effe8ebcd3ca Author: Sergey Ulanov <sergeyu@chromium.org> Date: Tue Sep 26 16:55:27 2017 Roll Fuchsia SDK to 36d9ffb6bda53112e826941757efe04654050d46 This version: - Fixes getaddrinfo(). - Adds media_client library. TBR=yzshen@chromium.org NOTRY=true Bug: 707030, 737802 , 731302 Change-Id: I271d9681194d81d2979635784b3f0ca2c0a946d0 Reviewed-on: https://chromium-review.googlesource.com/683311 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#504401} [modify] https://crrev.com/9e4a3e9fc974b2c0267aba091ef3effe8ebcd3ca/DEPS [modify] https://crrev.com/9e4a3e9fc974b2c0267aba091ef3effe8ebcd3ca/mojo/edk/embedder/platform_handle.h
,
Oct 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cae560d544c1d5f82d0f40e664d2e40b33d145e7 commit cae560d544c1d5f82d0f40e664d2e40b33d145e7 Author: Sergey Ulanov <sergeyu@chromium.org> Date: Wed Oct 04 20:20:48 2017 Implement AudioOutputStream for Fuchsia Added AudioOutputStreamFuchsia which implemented audio output using Fuchsia's media_client library. Also updated AudioManagerFuchsia to enumerate output devices and create AudioOutputStream. Bug: 737802 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I344ed5ad885d602574dd03ad31e85d7b76e0c2b8 Reviewed-on: https://chromium-review.googlesource.com/690622 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#506500} [modify] https://crrev.com/cae560d544c1d5f82d0f40e664d2e40b33d145e7/media/audio/BUILD.gn [modify] https://crrev.com/cae560d544c1d5f82d0f40e664d2e40b33d145e7/media/audio/fuchsia/audio_manager_fuchsia.cc [modify] https://crrev.com/cae560d544c1d5f82d0f40e664d2e40b33d145e7/media/audio/fuchsia/audio_manager_fuchsia.h [add] https://crrev.com/cae560d544c1d5f82d0f40e664d2e40b33d145e7/media/audio/fuchsia/audio_output_stream_fuchsia.cc [add] https://crrev.com/cae560d544c1d5f82d0f40e664d2e40b33d145e7/media/audio/fuchsia/audio_output_stream_fuchsia.h
,
Oct 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bb856afd88cddc0d5c41dd04e628c10458f7b107 commit bb856afd88cddc0d5c41dd04e628c10458f7b107 Author: Sergey Ulanov <sergeyu@chromium.org> Date: Fri Oct 06 01:55:26 2017 Add OWNERS file in media/audio/fuchsia Bug: 737802 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I19a1edacd4cda27c06f4df631bea9a0b2f9e6a2c Reviewed-on: https://chromium-review.googlesource.com/690626 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#506948} [add] https://crrev.com/bb856afd88cddc0d5c41dd04e628c10458f7b107/media/audio/fuchsia/OWNERS
,
Oct 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a9afc724710eeca3c28e48cbed41e09430efc4fd commit a9afc724710eeca3c28e48cbed41e09430efc4fd Author: Sergey Ulanov <sergeyu@chromium.org> Date: Wed Oct 11 00:21:38 2017 Fix a simple bug in AudioOutputStreamFuchsia AudioOutputStreamFuchsia::UpdatePresentatioDelay() was returning false on success and true on failure. Bug: 737802 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ic02497cebe279fc7846a944bdcd1265a8106c261 Reviewed-on: https://chromium-review.googlesource.com/709742 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#507835} [modify] https://crrev.com/a9afc724710eeca3c28e48cbed41e09430efc4fd/media/audio/fuchsia/audio_output_stream_fuchsia.cc
,
Oct 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4434fb5d04066a9fb4e993dbc6332f767ae198dd commit 4434fb5d04066a9fb4e993dbc6332f767ae198dd Author: Sergey Ulanov <sergeyu@chromium.org> Date: Thu Oct 12 21:53:17 2017 Fix AudioOutputStreamFuchsia to initialize stream position properly. Previously AudioOutputStreamFuchsia was leaving stream_position_samples_ set to 0 after the stream starts. As result when PumpSamples() is called again GetCurrentStreamTime() was returnin a value in the past and so the stream was restarted. Fixed it by moving the line that advances stream_postion_sample_ to the end of PumpSamples(). Bug: 737802 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Icac393cf1a108e37825063092e185cdb4fc6aa30 Reviewed-on: https://chromium-review.googlesource.com/716798 Reviewed-by: James Robinson <jamesr@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#508488} [modify] https://crrev.com/4434fb5d04066a9fb4e993dbc6332f767ae198dd/media/audio/fuchsia/audio_output_stream_fuchsia.cc
,
Oct 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eec981f16b43c158dc5a660714a60b3251ec13a9 commit eec981f16b43c158dc5a660714a60b3251ec13a9 Author: Sergey Ulanov <sergeyu@chromium.org> Date: Tue Oct 17 20:53:48 2017 Add unittests for AudioOutputStream. Previosly there were no cross-platforms tests for AudioOutputStream. This CL adds new tests that will run on all platforms. The tests are based on Windows-specific tests in media/audio/win. Bug: 737802 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I2accac0d7dc5e5d5ac813923ec6b83c0af6c9da6 Reviewed-on: https://chromium-review.googlesource.com/702688 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by: Olga Sharonova <olka@chromium.org> Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#509522} [modify] https://crrev.com/eec981f16b43c158dc5a660714a60b3251ec13a9/media/audio/BUILD.gn [add] https://crrev.com/eec981f16b43c158dc5a660714a60b3251ec13a9/media/audio/audio_output_unittest.cc [modify] https://crrev.com/eec981f16b43c158dc5a660714a60b3251ec13a9/media/audio/mac/audio_auhal_mac.cc
,
Oct 18 2017
Tests added in latest change seem to crash here: https://build.chromium.org/p/chromium.gpu.fyi/builders/Win10%20Release%20%28Intel%20HD%20630%29/builds/832 also https://build.chromium.org/p/chromium.gpu.fyi/builders/Win10%20Release%20%28NVIDIA%29/builds/3589/steps/audio_unittests%20on%20NVIDIA%20GPU%20on%20Windows%20on%20Windows-10 https://build.chromium.org/p/chromium.gpu.fyi/builders/Win7%20Debug%20%28AMD%29/builds/3259/steps/audio_unittests%20on%20ATI%20GPU%20on%20Windows%20on%20Windows-2008ServerR2-SP1
,
Oct 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fbb109a31d2a474b7b34a61d1a4801840290fcc3 commit fbb109a31d2a474b7b34a61d1a4801840290fcc3 Author: Jamie Madill <jmadill@chromium.org> Date: Wed Oct 18 17:44:37 2017 Revert "Add unittests for AudioOutputStream." This reverts commit eec981f16b43c158dc5a660714a60b3251ec13a9. Reason for revert: This seems to be causing a flaky test failures on the GPU.FYI bots and the ANGLE try servers/CQ. See first failing on these configs: https://build.chromium.org/p/chromium.gpu.fyi/builders/Win7%20Release%20%28AMD%29/builds/5105 https://build.chromium.org/p/chromium.gpu.fyi/builders/Win7%20x64%20Release%20%28NVIDIA%29/builds/12627 Bug: 737802 Original change's description: > Add unittests for AudioOutputStream. > > Previosly there were no cross-platforms tests for AudioOutputStream. > This CL adds new tests that will run on all platforms. The tests > are based on Windows-specific tests in media/audio/win. > > Bug: 737802 > Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > Change-Id: I2accac0d7dc5e5d5ac813923ec6b83c0af6c9da6 > Reviewed-on: https://chromium-review.googlesource.com/702688 > Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> > Reviewed-by: Olga Sharonova <olka@chromium.org> > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#509522} TBR=dalecurtis@chromium.org,sergeyu@chromium.org,olka@chromium.org Change-Id: I9ec3daf0e9c519be6b4a23f5a357048264d401fb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 737802 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/726339 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#509805} [modify] https://crrev.com/fbb109a31d2a474b7b34a61d1a4801840290fcc3/media/audio/BUILD.gn [delete] https://crrev.com/636a40f79ddd1cda1fc6d92f4a8829f71cd3e514/media/audio/audio_output_unittest.cc [modify] https://crrev.com/fbb109a31d2a474b7b34a61d1a4801840290fcc3/media/audio/mac/audio_auhal_mac.cc
,
Oct 18 2017
Filed https://bugs.chromium.org/p/chromium/issues/detail?id=776020 for the GPU FYI failures. Attempting to disable on those bots.
,
Nov 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f966ce658c85b635347b89f3812ddcab500d3180 commit f966ce658c85b635347b89f3812ddcab500d3180 Author: Sergey Ulanov <sergeyu@chromium.org> Date: Mon Nov 20 22:23:25 2017 Reland "Add unittests for AudioOutputStream." This is a reland of eec981f16b43c158dc5a660714a60b3251ec13a9 Original change's description: > Add unittests for AudioOutputStream. > > Previosly there were no cross-platforms tests for AudioOutputStream. > This CL adds new tests that will run on all platforms. The tests > are based on Windows-specific tests in media/audio/win. > > Bug: 737802 > Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > Change-Id: I2accac0d7dc5e5d5ac813923ec6b83c0af6c9da6 > Reviewed-on: https://chromium-review.googlesource.com/702688 > Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> > Reviewed-by: Olga Sharonova <olka@chromium.org> > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#509522} Bug: 737802 Change-Id: I6c637e731810574fabe0f6cd8d4dcc7d40380288 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/728400 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Reviewed-by: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#517952} [modify] https://crrev.com/f966ce658c85b635347b89f3812ddcab500d3180/media/audio/BUILD.gn [add] https://crrev.com/f966ce658c85b635347b89f3812ddcab500d3180/media/audio/audio_output_unittest.cc [modify] https://crrev.com/f966ce658c85b635347b89f3812ddcab500d3180/media/audio/mac/audio_auhal_mac.cc
,
Nov 21 2017
fails here: https://build.chromium.org/p/chromium.gpu.fyi/builders/Win10%20Release%20%28Intel%20HD%20630%29/builds/1074 [ RUN ] AudioOutputTest.Play200HzTone [20016:20020:1120/183541.477:11416078:WARNING:audio_low_latency_output_win.cc(196)] Using WASAPI output with a non-optimal buffer size, glitches from back to back shared memory reads and partial fills of WASAPI output buffers may occur. Buffer size of 4800 is not an even divisor of 480 ../../media/audio/audio_output_unittest.cc(100): error: Expected: (source.callbacks()) >= (1), actual: 0 vs 1 [ FAILED ] AudioOutputTest.Play200HzTone (452 ms) [256/256] AudioOutputTest.Play200HzTone (452 ms) Retrying 1 test (retry #2) [ RUN ] AudioOutputTest.Play200HzTone [20188:20108:1120/183541.949:11416546:WARNING:audio_low_latency_output_win.cc(196)] Using WASAPI output with a non-optimal buffer size, glitches from back to back shared memory reads and partial fills of WASAPI output buffers may occur. Buffer size of 4800 is not an even divisor of 480 ../../media/audio/audio_output_unittest.cc(100): error: Expected: (source.callbacks()) >= (1), actual: 0 vs 1 [ FAILED ] AudioOutputTest.Play200HzTone (441 ms) [257/257] AudioOutputTest.Play200HzTone (441 ms) Retrying 1 test (retry #3) [ RUN ] AudioOutputTest.Play200HzTone [21208:21280:1120/183542.417:11417015:WARNING:audio_low_latency_output_win.cc(196)] Using WASAPI output with a non-optimal buffer size, glitches from back to back shared memory reads and partial fills of WASAPI output buffers may occur. Buffer size of 4800 is not an even divisor of 480 ../../media/audio/audio_output_unittest.cc(100): error: Expected: (source.callbacks()) >= (1), actual: 0 vs 1 [ FAILED ] AudioOutputTest.Play200HzTone (466 ms) [258/258] AudioOutputTest.Play200HzTone (466 ms) 1 test failed: AudioOutputTest.Play200HzTone (../../media/audio/audio_output_unittest.cc:80)
,
Nov 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/133582909af148b44fc286c887b0133161e97dea commit 133582909af148b44fc286c887b0133161e97dea Author: Jamie Madill <jmadill@chromium.org> Date: Tue Nov 21 15:33:41 2017 Revert "Reland "Add unittests for AudioOutputStream."" This reverts commit f966ce658c85b635347b89f3812ddcab500d3180. Reason for revert: Failing tests on multiple bots: https://build.chromium.org/p/chromium.gpu.fyi/builders/Win10%20Release%20%28Intel%20HD%20630%29/builds/1074 https://build.chromium.org/p/chromium.gpu.fyi/builders/Win10%20Release%20%28NVIDIA%29/builds/3982 https://build.chromium.org/p/chromium.gpu.fyi/builders/Win7%20Debug%20%28AMD%29/builds/3565 https://build.chromium.org/p/chromium.gpu.fyi/builders/Win7%20x64%20Release%20%28NVIDIA%29/builds/13153 Failing test: AudioOutputTest.Play200HzTone [ RUN ] AudioOutputTest.Play200HzTone [4244:4412:1121/055656.174:27876973:WARNING:audio_low_latency_output_win.cc(196)] Using WASAPI output with a non-optimal buffer size, glitches from back to back shared memory reads and partial fills of WASAPI output buffers may occur. Buffer size of 4410 is not an even divisor of 441 ../../media/audio/audio_output_unittest.cc(100): error: Expected: (source.callbacks()) >= (1), actual: 0 vs 1 [ FAILED ] AudioOutputTest.Play200HzTone (315 ms) Original change's description: > Reland "Add unittests for AudioOutputStream." > > This is a reland of eec981f16b43c158dc5a660714a60b3251ec13a9 > Original change's description: > > Add unittests for AudioOutputStream. > > > > Previosly there were no cross-platforms tests for AudioOutputStream. > > This CL adds new tests that will run on all platforms. The tests > > are based on Windows-specific tests in media/audio/win. > > > > Bug: 737802 > > Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > > Change-Id: I2accac0d7dc5e5d5ac813923ec6b83c0af6c9da6 > > Reviewed-on: https://chromium-review.googlesource.com/702688 > > Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> > > Reviewed-by: Olga Sharonova <olka@chromium.org> > > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#509522} > > Bug: 737802 > Change-Id: I6c637e731810574fabe0f6cd8d4dcc7d40380288 > Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > Reviewed-on: https://chromium-review.googlesource.com/728400 > Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Reviewed-by: Olga Sharonova <olka@chromium.org> > Cr-Commit-Position: refs/heads/master@{#517952} TBR=dalecurtis@chromium.org,sergeyu@chromium.org,olka@chromium.org Change-Id: I216c41d3f23de8b406435a1e1700a8c4a72eca98 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 737802 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/782019 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#518262} [modify] https://crrev.com/133582909af148b44fc286c887b0133161e97dea/media/audio/BUILD.gn [delete] https://crrev.com/9a3ee08dab4bac17fe3b74141ab20a8e94bff7c9/media/audio/audio_output_unittest.cc [modify] https://crrev.com/133582909af148b44fc286c887b0133161e97dea/media/audio/mac/audio_auhal_mac.cc
,
Nov 21 2017
,
Dec 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c8467809ff51db3a033b54bd6274e41dfa6ba965 commit c8467809ff51db3a033b54bd6274e41dfa6ba965 Author: Sergey Ulanov <sergeyu@chromium.org> Date: Fri Dec 01 00:13:04 2017 [fuchsia] Use FUCHSIA_AUDIO_NO_TIMESTAMP in AudioOutputStreamFuchsia Previously AudioOutputStreamFuchsia was setting PTS (presentation timestamp) to 0 to indicate that PTS is not set. The media_client API expects FUCHSIA_AUDIO_NO_TIMESTAMP (!= 0) in that case. Bug: 737802 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I858d72044f283f5bce1d457f7358644d6b258aa3 Reviewed-on: https://chromium-review.googlesource.com/801481 Reviewed-by: James Robinson <jamesr@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#520764} [modify] https://crrev.com/c8467809ff51db3a033b54bd6274e41dfa6ba965/media/audio/fuchsia/audio_output_stream_fuchsia.cc
,
Dec 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2b290d978563789ecb9a5fd1aa742595be534f74 commit 2b290d978563789ecb9a5fd1aa742595be534f74 Author: Sergey Ulanov <sergeyu@chromium.org> Date: Wed Dec 06 23:21:06 2017 Reland "Add unittests for AudioOutputStream." This is a reland of eec981f16b43c158dc5a660714a60b3251ec13a9 Original change's description: > Add unittests for AudioOutputStream. > > Previosly there were no cross-platforms tests for AudioOutputStream. > This CL adds new tests that will run on all platforms. The tests > are based on Windows-specific tests in media/audio/win. > > Bug: 737802 > Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > Change-Id: I2accac0d7dc5e5d5ac813923ec6b83c0af6c9da6 > Reviewed-on: https://chromium-review.googlesource.com/702688 > Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> > Reviewed-by: Olga Sharonova <olka@chromium.org> > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#509522} Bug: 737802 Change-Id: Ia3b7953437b484f37a339a90e3db9af1f315bdd9 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/809540 Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#522245} [modify] https://crrev.com/2b290d978563789ecb9a5fd1aa742595be534f74/media/audio/BUILD.gn [add] https://crrev.com/2b290d978563789ecb9a5fd1aa742595be534f74/media/audio/audio_output_unittest.cc [modify] https://crrev.com/2b290d978563789ecb9a5fd1aa742595be534f74/media/audio/mac/audio_auhal_mac.cc
,
Dec 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/23266554aedc85b44b1312aee8c8f5612d308a4d commit 23266554aedc85b44b1312aee8c8f5612d308a4d Author: Sergey Ulanov <sergeyu@chromium.org> Date: Fri Dec 08 00:54:52 2017 Remove DCHECK from AudioOutputStreamFuchsia::Stop AudioOutputStream::Stop() may be called more than once, but Fuchsia's implementation allowed it to be called only once. Removed DCHECK to avoid this restriction. Bug: 737802 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I6cbee991f7d6361f4041c21f2340f2560dfb4483 Reviewed-on: https://chromium-review.googlesource.com/815669 Reviewed-by: Wez <wez@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#522657} [modify] https://crrev.com/23266554aedc85b44b1312aee8c8f5612d308a4d/media/audio/fuchsia/audio_output_stream_fuchsia.cc
,
Dec 9 2017
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by sergeyu@chromium.org
, Jun 29 2017