New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 737793 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 737674
Owner: ----
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

pre-cq-launcher should recompute the target pre-cq set on every attempt

Project Member Reported by pprabhu@chromium.org, Jun 28 2017

Issue description

Recently, there have been multiple instances where we turned down builders. As part of this we either (a) removed the *-pre-cq, or (b) *-pre-cq just broke due to bitrot.

In either case, a bunch of CLs that contained that -pre-cq config in its target set got stuck until user action or verification timeout (weeks, iirc).


Instead, we should:
- Recompute target set each time we're about to launch pre-cq jobs / validate a CL
- Find what needs to be done (we don't need to reset the passed set)
- Launch / validate against the remaining.


pre-cq is a class-A cros-infra service, and this bug is causing a non-trivial number of CLs to get stuck until developer action ( I've heard of people complaining about rebasing not fixing this problem, but I don't believe them ;) )
Also, I'd expect this problem to only grow as our board churn isn't going to reduce any time soon.

So, Pri-1.

 
Cc: nxia@chromium.org dgarr...@chromium.org
Mergedinto: 737674
Status: Duplicate (was: Untriaged)

Sign in to add a comment