New issue
Advanced search Search tips

Issue 737787 link

Starred by 0 users

Issue metadata

Status: Duplicate
Merged: issue 681041
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

PDF placeholder doesn't allow user to open PDF

Project Member Reported by amberwon@google.com, Jun 28 2017

Issue description

When a user has plugins disabled, iframe, object, embed tags within a page are replaced with a placeholder. The placeholder does not allow the user to download or open the PDF. This affects users that have the "Open PDF files in the default PDF viewer application" setting enabled and  users on mobile devices.

A new placeholder should allow the user to open the PDF.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3da52ff61da23b01c1a87fb8d253cd1dd585e9ac

commit 3da52ff61da23b01c1a87fb8d253cd1dd585e9ac
Author: amberwon <amberwon@google.com>
Date: Thu Jun 29 17:13:04 2017

Add Click to Open PDF Placeholder feature

Create this feature and have it disabled while it's under development.

BUG= 737787 

Review-Url: https://codereview.chromium.org/2956373003
Cr-Commit-Position: refs/heads/master@{#483403}

[modify] https://crrev.com/3da52ff61da23b01c1a87fb8d253cd1dd585e9ac/chrome/common/chrome_features.cc
[modify] https://crrev.com/3da52ff61da23b01c1a87fb8d253cd1dd585e9ac/chrome/common/chrome_features.h

Project Member

Comment 2 by bugdroid1@chromium.org, Jul 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/daee0ce8d5a883fd879a1d6988333f5efb21dc3a

commit daee0ce8d5a883fd879a1d6988333f5efb21dc3a
Author: amberwon <amberwon@google.com>
Date: Sat Jul 01 02:19:40 2017

Show a new placeholder for PDF's when plugins are disabled.

Created PDFPluginPlaceholder class that is used to create the
placeholder in ChromeContentRendererClient, when plugins are
disabled and a PDF is supposed to be displayed. The current placeholder
says "This plugin is not supported," but does not allow the user to
open the PDF. The new placeholder is blank, for now, but will later
allow users to open PDF's by clicking a button.

BUG= 737787 

Review-Url: https://codereview.chromium.org/2961383002
Cr-Commit-Position: refs/heads/master@{#483895}

[modify] https://crrev.com/daee0ce8d5a883fd879a1d6988333f5efb21dc3a/chrome/renderer/BUILD.gn
[modify] https://crrev.com/daee0ce8d5a883fd879a1d6988333f5efb21dc3a/chrome/renderer/chrome_content_renderer_client.cc
[add] https://crrev.com/daee0ce8d5a883fd879a1d6988333f5efb21dc3a/chrome/renderer/plugins/pdf_plugin_placeholder.cc
[add] https://crrev.com/daee0ce8d5a883fd879a1d6988333f5efb21dc3a/chrome/renderer/plugins/pdf_plugin_placeholder.h
[add] https://crrev.com/daee0ce8d5a883fd879a1d6988333f5efb21dc3a/chrome/renderer/resources/plugins/pdf_plugin.html
[modify] https://crrev.com/daee0ce8d5a883fd879a1d6988333f5efb21dc3a/chrome/renderer/resources/renderer_resources.grd

Project Member

Comment 3 by bugdroid1@chromium.org, Jul 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bff2c9eb427afcdc4f2162ec8b64e95c4aa3f079

commit bff2c9eb427afcdc4f2162ec8b64e95c4aa3f079
Author: amberwon <amberwon@google.com>
Date: Wed Jul 05 23:35:06 2017

Add DownloadPDF Callback function.

Added stub for callback function. Will be called in pdf_plugin.html to
start downloading the PDF. Was tested manually by adding a link that
calls the function.

BUG= 737787 

Review-Url: https://codereview.chromium.org/2971753003
Cr-Commit-Position: refs/heads/master@{#484369}

[modify] https://crrev.com/bff2c9eb427afcdc4f2162ec8b64e95c4aa3f079/chrome/renderer/plugins/pdf_plugin_placeholder.cc
[modify] https://crrev.com/bff2c9eb427afcdc4f2162ec8b64e95c4aa3f079/chrome/renderer/plugins/pdf_plugin_placeholder.h

Project Member

Comment 4 by sheriffbot@chromium.org, Jul 11 2017

Labels: Hotlist-Google
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/254fa14030667b2a7b707e975a23437d9faca45d

commit 254fa14030667b2a7b707e975a23437d9faca45d
Author: amberwon <amberwon@google.com>
Date: Mon Jul 17 20:48:11 2017

Click to Open PDF: Open PDF once View PDF is clicked.

pdf_plugin.html shows the file name and a View PDF link. When View PDF is
clicked, the callback function sends a message. When this message is
handled in PluginObserver, the URL for the PDF file is opened in a new
tab. However, in guest view, when the message is handled, nothing is
done.

BUG= 737787 

Review-Url: https://codereview.chromium.org/2972123002
Cr-Commit-Position: refs/heads/master@{#487235}

[modify] https://crrev.com/254fa14030667b2a7b707e975a23437d9faca45d/chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.cc
[modify] https://crrev.com/254fa14030667b2a7b707e975a23437d9faca45d/chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.h
[modify] https://crrev.com/254fa14030667b2a7b707e975a23437d9faca45d/chrome/browser/plugins/plugin_observer.cc
[modify] https://crrev.com/254fa14030667b2a7b707e975a23437d9faca45d/chrome/browser/plugins/plugin_observer.h
[modify] https://crrev.com/254fa14030667b2a7b707e975a23437d9faca45d/chrome/common/render_messages.h
[modify] https://crrev.com/254fa14030667b2a7b707e975a23437d9faca45d/chrome/renderer/plugins/pdf_plugin_placeholder.cc
[modify] https://crrev.com/254fa14030667b2a7b707e975a23437d9faca45d/chrome/renderer/plugins/pdf_plugin_placeholder.h
[modify] https://crrev.com/254fa14030667b2a7b707e975a23437d9faca45d/chrome/renderer/resources/plugins/pdf_plugin.html

Project Member

Comment 6 by bugdroid1@chromium.org, Jul 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/11a205da815b94a7cc345b427bedec7dcd08e593

commit 11a205da815b94a7cc345b427bedec7dcd08e593
Author: Amber Won <amberwon@google.com>
Date: Tue Jul 18 19:42:24 2017

Click to Open PDF: Create PDF placeholder on mobile.

Create PDF placeholder in ChromeContentRendererClient when the
enable_plugins build flag is off. Tested manually on mobile.

Bug:  737787 
Change-Id: Iddb276b8ce71c92ee7fb626115269f2730b8b943
Reviewed-on: https://chromium-review.googlesource.com/575190
Commit-Queue: Amber Won <amberwon@google.com>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487561}
[modify] https://crrev.com/11a205da815b94a7cc345b427bedec7dcd08e593/chrome/renderer/BUILD.gn
[modify] https://crrev.com/11a205da815b94a7cc345b427bedec7dcd08e593/chrome/renderer/chrome_content_renderer_client.cc

Project Member

Comment 7 by bugdroid1@chromium.org, Jul 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bc812389439e9df45ede9e87635a90cd2477c1f5

commit bc812389439e9df45ede9e87635a90cd2477c1f5
Author: Amber Won <amberwon@google.com>
Date: Thu Jul 20 18:56:33 2017

Click to Open PDF: Update PDF placeholder UI.

On the placeholder page, add a PDF icon in the center and a bar on the
bottom of the page, which includes the file name and a link to the
view the PDF.

Bug:  737787 

Change-Id: Ia3612ee812118514666bafa195720b2191d31f6b
Reviewed-on: https://chromium-review.googlesource.com/578309
Commit-Queue: Amber Won <amberwon@google.com>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488333}
[modify] https://crrev.com/bc812389439e9df45ede9e87635a90cd2477c1f5/chrome/renderer/resources/plugins/pdf_plugin.html

Project Member

Comment 9 by bugdroid1@chromium.org, Aug 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6b5edc7529c6e7974ec0d18420cb1e72ceda898a

commit 6b5edc7529c6e7974ec0d18420cb1e72ceda898a
Author: Amber Won <amberwon@google.com>
Date: Thu Aug 17 19:23:54 2017

Click to Open PDF: Intercept navigations to PDF files in iframes.

Currently, when there are no PDF viewers available, iframes for PDF's
show up blank and immediately download the PDF. In this case, intercept
navigations to PDF files and instead open a data URL, which creates an
object element with the file. The object element shows a placeholder
with a button to view the PDF.

Bug:  737787 
Change-Id: Id37e0e76c88e0046dac64baf034bbfd1d70c353d
Reviewed-on: https://chromium-review.googlesource.com/594943
Commit-Queue: Amber Won <amberwon@google.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Nick Carter <nick@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495274}
[modify] https://crrev.com/6b5edc7529c6e7974ec0d18420cb1e72ceda898a/chrome/browser/BUILD.gn
[modify] https://crrev.com/6b5edc7529c6e7974ec0d18420cb1e72ceda898a/chrome/browser/chrome_content_browser_client.cc
[add] https://crrev.com/6b5edc7529c6e7974ec0d18420cb1e72ceda898a/chrome/browser/plugins/pdf_iframe_navigation_throttle.cc
[add] https://crrev.com/6b5edc7529c6e7974ec0d18420cb1e72ceda898a/chrome/browser/plugins/pdf_iframe_navigation_throttle.h
[add] https://crrev.com/6b5edc7529c6e7974ec0d18420cb1e72ceda898a/chrome/browser/plugins/pdf_iframe_navigation_throttle_unittest.cc
[modify] https://crrev.com/6b5edc7529c6e7974ec0d18420cb1e72ceda898a/chrome/browser/plugins/plugin_prefs.h
[modify] https://crrev.com/6b5edc7529c6e7974ec0d18420cb1e72ceda898a/chrome/test/BUILD.gn

Project Member

Comment 10 by bugdroid1@chromium.org, Aug 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/478561da83201902bc79a9d56723769808c46307

commit 478561da83201902bc79a9d56723769808c46307
Author: Amber Won <amberwon@google.com>
Date: Sat Aug 19 01:02:59 2017

Add click to open PDF feature to about flags.

Add flag to allow testing on Android.

Bug:  737787 
Change-Id: I594add760ac45be7788990bc5fff0fdef36572b0
Reviewed-on: https://chromium-review.googlesource.com/621288
Commit-Queue: Amber Won <amberwon@google.com>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495774}
[modify] https://crrev.com/478561da83201902bc79a9d56723769808c46307/chrome/browser/about_flags.cc
[modify] https://crrev.com/478561da83201902bc79a9d56723769808c46307/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/478561da83201902bc79a9d56723769808c46307/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/478561da83201902bc79a9d56723769808c46307/tools/metrics/histograms/enums.xml

Project Member

Comment 11 by bugdroid1@chromium.org, Aug 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/94afd81172083b40e080525914b014226d34069b

commit 94afd81172083b40e080525914b014226d34069b
Author: Amber Won <amberwon@google.com>
Date: Wed Aug 23 17:30:11 2017

Click to Open PDF: Intercept IFrame PDF navigations on Android.

Update the navigation throttle and unittest to work for Android by
not running the code involving plugins on Android.

Bug:  737787 
Change-Id: I8b0c23ea41c696d3b8aa75986b9abacd434c6903
Reviewed-on: https://chromium-review.googlesource.com/621951
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Amber Won <amberwon@google.com>
Cr-Commit-Position: refs/heads/master@{#496721}
[modify] https://crrev.com/94afd81172083b40e080525914b014226d34069b/chrome/browser/BUILD.gn
[modify] https://crrev.com/94afd81172083b40e080525914b014226d34069b/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/94afd81172083b40e080525914b014226d34069b/chrome/browser/plugins/pdf_iframe_navigation_throttle.cc
[modify] https://crrev.com/94afd81172083b40e080525914b014226d34069b/chrome/browser/plugins/pdf_iframe_navigation_throttle_unittest.cc
[modify] https://crrev.com/94afd81172083b40e080525914b014226d34069b/chrome/test/BUILD.gn

Project Member

Comment 12 by bugdroid1@chromium.org, Aug 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a19b1504d1a1f40e6c5358ec9880eb06b506b007

commit a19b1504d1a1f40e6c5358ec9880eb06b506b007
Author: Amber Won <amberwon@google.com>
Date: Sat Aug 26 00:16:05 2017

Click to Open PDF: Open PDF automatically after download.

To open the download on desktop, download the URL and set the download
to open when completed. On mobile, open the URL with has_user_gesture
set to true.

Bug:  737787 
Change-Id: I1d68c98ee1359983f475ace269c4604546708b93
Reviewed-on: https://chromium-review.googlesource.com/630505
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Amber Won <amberwon@google.com>
Cr-Commit-Position: refs/heads/master@{#497604}
[modify] https://crrev.com/a19b1504d1a1f40e6c5358ec9880eb06b506b007/chrome/browser/plugins/pdf_plugin_placeholder_observer.cc

Project Member

Comment 13 by bugdroid1@chromium.org, Sep 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3a0a714cd3abf61ccb1434dad1f5fac88b122b6d

commit 3a0a714cd3abf61ccb1434dad1f5fac88b122b6d
Author: Amber Won <amberwon@google.com>
Date: Fri Sep 08 01:23:35 2017

Click to Open PDF: Change background color and PDF logo size.

Change background color to google-grey-100. Increase the size of the
PDF logo.

Bug:  737787 
Change-Id: I401ea05efba9a6c438ce3471fc60ca78d19d527c
Reviewed-on: https://chromium-review.googlesource.com/656311
Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Amber Won <amberwon@google.com>
Cr-Commit-Position: refs/heads/master@{#500471}
[modify] https://crrev.com/3a0a714cd3abf61ccb1434dad1f5fac88b122b6d/chrome/renderer/resources/plugins/pdf_plugin.html

Owner: tommycli@chromium.org
Project Member

Comment 15 by bugdroid1@chromium.org, Jan 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c5b48e217408a16843dc1c2fe6bbe10b6771ad04

commit c5b48e217408a16843dc1c2fe6bbe10b6771ad04
Author: Chris Harrelson <chrishtr@chromium.org>
Date: Sat Jan 27 03:48:06 2018

Change WebWidget::Paint*() semantics to not force a lifecycle update.

This prevents animations from updating twice as fast for webview
plugins because plugins have their lifecycle run as part of the
containing plage, then have Paint() called on them.

Bug:  737787 
Change-Id: I7596d2d0dd74f5733a8d32e8d381662a88708eba
Reviewed-on: https://chromium-review.googlesource.com/888170
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532149}
[modify] https://crrev.com/c5b48e217408a16843dc1c2fe6bbe10b6771ad04/content/renderer/render_view_impl.cc
[modify] https://crrev.com/c5b48e217408a16843dc1c2fe6bbe10b6771ad04/third_party/WebKit/Source/core/page/PageWidgetDelegate.cpp
[modify] https://crrev.com/c5b48e217408a16843dc1c2fe6bbe10b6771ad04/third_party/WebKit/public/web/WebWidget.h

Project Member

Comment 16 by bugdroid1@chromium.org, Feb 5 2018

Mergedinto: 681041
Status: Duplicate (was: Started)
Project Member

Comment 18 by bugdroid1@chromium.org, Feb 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d3dd6bf630d4d67b1b0532a474e6c284a93c68fd

commit d3dd6bf630d4d67b1b0532a474e6c284a93c68fd
Author: Tommy C. Li <tommycli@chromium.org>
Date: Fri Feb 16 02:51:37 2018

Click to Open PDF: Allow Enter or Space keyboard to open PDFs

Adds a affordance for keyboard users to open PDFs for accessibility.

Bug:  737787 , 800399
Change-Id: Ifc234ab950357a512818ae0875fa6c156bc2ba1e
Reviewed-on: https://chromium-review.googlesource.com/922681
Reviewed-by: Anthony LaForge <laforge@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537145}
[modify] https://crrev.com/d3dd6bf630d4d67b1b0532a474e6c284a93c68fd/chrome/renderer/resources/plugins/pdf_plugin.html

Project Member

Comment 19 by bugdroid1@chromium.org, Feb 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fbf014ecba73781ead83cfea2195e291fb16883e

commit fbf014ecba73781ead83cfea2195e291fb16883e
Author: Tommy C. Li <tommycli@chromium.org>
Date: Wed Feb 28 20:09:00 2018

Click to Open PDF: Fix button misalignment for long PDF filenames

Bug:  737787 ,  817390 
Change-Id: I789a31b49ff5c648520b84e08d63838e0324d58c
Reviewed-on: https://chromium-review.googlesource.com/941404
Commit-Queue: Anthony LaForge <laforge@chromium.org>
Reviewed-by: Anthony LaForge <laforge@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539938}
[modify] https://crrev.com/fbf014ecba73781ead83cfea2195e291fb16883e/chrome/renderer/resources/plugins/pdf_plugin.html

Project Member

Comment 20 by bugdroid1@chromium.org, Feb 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/12f54fe316c43d843e95949b2f8ac45f35cbd467

commit 12f54fe316c43d843e95949b2f8ac45f35cbd467
Author: Tommy C. Li <tommycli@chromium.org>
Date: Wed Feb 28 21:45:06 2018

Click to Open PDF: Add to fieldtrial_testing_config.json

Bug:  737787 
Change-Id: Ib967821fd071f718d72e9a300809d33070e9729c
Reviewed-on: https://chromium-review.googlesource.com/938957
Reviewed-by: Anthony LaForge <laforge@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539947}
[modify] https://crrev.com/12f54fe316c43d843e95949b2f8ac45f35cbd467/testing/variations/fieldtrial_testing_config.json

Project Member

Comment 21 by bugdroid1@chromium.org, May 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8d12beda86860199eaa98dd63f10b4dbd451bfde

commit 8d12beda86860199eaa98dd63f10b4dbd451bfde
Author: Tommy C. Li <tommycli@chromium.org>
Date: Mon May 14 20:21:13 2018

Click to Open PDF: Enable on trunk

Enabling on trunk in preparation for the 100% Stable rollout. 1% Stable
experiment has concluded with positive metrics consistent with the Beta
experiment.

Bug: 799085,  737787 
Change-Id: I656f55dd100ca97973e417c11bbb494f4e3c4fa9
Reviewed-on: https://chromium-review.googlesource.com/1055929
Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558438}
[modify] https://crrev.com/8d12beda86860199eaa98dd63f10b4dbd451bfde/chrome/common/chrome_features.cc

Sign in to add a comment