New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 737781 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

luci-config caching of projects.cfg is broken

Project Member Reported by vadimsh@chromium.org, Jun 28 2017

Issue description

Expectation: adding a new project to projects.cfg (like this https://chrome-internal.googlesource.com/infradata/config/+/f094a5a170383ed6986ab75f33b18fd9bfdf88fd) leads to the project appearing in get_projects(...) API output (and all other relevant places).

Reality: adding a new project to projects.cfg has no effect. luci-config ingests new projects.cfg revision, but continues to use stale cached copy internally.

Workaround for now is to flush memcache after modifying projects.cfg :-/
 

Comment 1 by estaab@chromium.org, Jun 29 2017

Status: Available (was: Untriaged)

Comment 2 by no...@chromium.org, Jul 10 2017

for how long luci-config returned a stale copy?
Indefinitely (at least 1h) until we reset memcache manually.

Comment 4 by no...@chromium.org, Jul 10 2017

Owner: no...@chromium.org
Status: Started (was: Available)
https://codereview.chromium.org/2979593002/
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/external/github.com/luci/luci-py.git/+/131a21b1c390df4dd2139b4ded1bdfce9c605648

commit 131a21b1c390df4dd2139b4ded1bdfce9c605648
Author: nodir <nodir@chromium.org>
Date: Mon Jul 10 22:00:10 2017

config_service: set memcache timeout

storage.get_self_config_async memcaches results indefintely, thus app may not
see changes.

Set an expiration of 1min

R=vadimsh@chromium.org
BUG= 737781 

Review-Url: https://codereview.chromium.org/2979593002

[modify] https://crrev.com/131a21b1c390df4dd2139b4ded1bdfce9c605648/appengine/config_service/storage.py

Comment 6 by no...@chromium.org, Jul 10 2017

Status: Fixed (was: Started)

Sign in to add a comment