New issue
Advanced search Search tips

Issue 737779 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: ----


Previous locations:
gerrit:6604


Sign in to add a comment

mastermanager should pass --send-mail when uploading changes

Project Member Reported by martiniss@chromium.org, Jun 28 2017

Issue description

Affected Version:

What steps will reproduce the problem?
1. Upload CL https://chrome-internal-review.googlesource.com/c/403568/ with CR+1 and CQ +2
 
What is the expected output?
The CL lands successfully

What do you see instead?
It fails to CQ, because it's "still in review"


Please provide any additional information below.
I used a command line tool to create and upload the CL, so it's possibly a error in the script.
 

Comment 1 by aga...@chromium.org, Jun 28 2017

Project: chromium
Moved issue gerrit:6604 to now be  issue chromium:737779 .

Comment 2 by aga...@chromium.org, Jun 28 2017

Cc: aga...@chromium.org
Components: Infra>Client>Infra
Owner: martiniss@chromium.org
Status: Assigned (was: New)
Summary: mastermanager should pass --send-mail when uploading changes (was: TBR-ed CL failed to be submitted, because still WIP)
Thanks for finding this!
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/8363af8683bdf7d86b5f362d4f4ee8ed53109f45

commit 8363af8683bdf7d86b5f362d4f4ee8ed53109f45
Author: Stephen Martinis <martiniss@google.com>
Date: Fri Jun 30 00:04:58 2017

Add -s to deal with gerrit WIP

Bug:  737779 
Change-Id: I35b70bf1d42ea86a21b43073e6b983ec5c4af3b8
Reviewed-on: https://chromium-review.googlesource.com/553583
Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>

[modify] https://crrev.com/8363af8683bdf7d86b5f362d4f4ee8ed53109f45/infra/tools/restart/restart.py

Status: Fixed (was: Assigned)

Sign in to add a comment