Enable use-zoom-for-dsf on Android |
||||||||||||||||||||||||||||||||||||||||||
Issue descriptionThis bug is to track switching to use-zoom-for-dsf on Android. Master bug (tracking Aura originally) at http://crbug.com/485650 . Android has always used physical coordinates on the browser process, but it used DIP pixels in the renderer process. This flag moves the DIP pixel conversion boundary deeper into Blink such that web-platform (Javascript, etc) still works in DIP, but Blink layout is in physical pixels, fixing many small correctness/snapping issues with layout. Subtasks include: 1. Page zoom has never been used on Android before, so we need to get page zoom to run on Android properly without breaking layout, in particular resolving any interactions with the viewport meta tag. Fixing http://crbug.com/645717 might be a good first step to try it out. 2. Checking for weird behavior and possibly fixing each Android or touch-specific feature that uses viewport coordinates: - Touch and mouse input events - Form autofill dropdown popups - Spelling dropdown popups - Selection handles - Cut/copy/paste floating action popups - Overscroll glow and pull-to-refresh - Disambiguation popup (if not yet deleted as considered in http://crbug.com/704323) - Autoscroll-into-view when tapping on form field covered by soft keyboard - Fullscreen video - Double-tap zoom onto paragraph - Touch adjustment onto closest node for touches that don't hit any target. - Devtools inspector screen projection onto your desktop - SolidColorScrollbar size and positioning - Space taken up dynamically by URL-bar as it shows and hides - IME CursorAnchorInfo API (should return same values as before) - All Android WebView API coordinate getters, including View base class getters (should return same values as before) - Probably a few more I forgot...
Showing comments 36 - 135
of 135
Older ›
,
Oct 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/df27929c78fea325006be2cca89a50e1471179a9 commit df27929c78fea325006be2cca89a50e1471179a9 Author: Jaebaek Seo <jaebaek@chromium.org> Date: Wed Oct 11 01:05:03 2017 Update BrowserControls's height using DSF of ScreenInfo crrev.com/c/664322 scales the height of BrowserControls by the device scale (DSF). However, the DSF is obtained from the primary display in the CL and it can cause incorrect behaviors when there are multiple displays. When I wrote the code, I thought getting DSF from screen info causes uninitialized memory report by MSAN, but it is not the reason. This CL gets DSF from screen info rather than primary display. Bug: 737777 Change-Id: I232d47b02728c0296dbead919a92b76c1b93b742 Reviewed-on: https://chromium-review.googlesource.com/691696 Reviewed-by: Alexandre Elias <aelias@chromium.org> Commit-Queue: Jaebaek Seo <jaebaek@chromium.org> Cr-Commit-Position: refs/heads/master@{#507845} [modify] https://crrev.com/df27929c78fea325006be2cca89a50e1471179a9/content/browser/renderer_host/render_widget_host_impl.cc [modify] https://crrev.com/df27929c78fea325006be2cca89a50e1471179a9/content/browser/renderer_host/render_widget_host_unittest.cc
,
Oct 11 2017
Opening a new tab and visiting site A and visiting site B render elements of site B smaller than correctly rendered elements when --use-zoom-for-dsf is enabled in Android. See the following attachments. "visit_after_opening_tab.png" is the correctly rendered page and "visit_after_visiting_google.png" is the wrongly rendered page. Visiting an web page right after opening a new tab is fine, but visiting two web pages that have different domains causes the problem (when visiting the second web page, it shows the smaller page). It is not problem of user agent. This is because the device scale factor (DSF) is not updated when the root local frame is swapped in. crrev.com/c/690415 is the CL for this problem. It is WIP now.
,
Oct 11 2017
,
Oct 12 2017
A default video player has the longer play time bar when --use-zoom-for-dsf is enabled. Try https://www.w3schools.com/html/html5_video.asp Attachments shows the difference. Even though the length of bar is different, touch works fine.
,
Oct 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/02dffc89d823832ac8fbdefa53f3290e724078e7 commit 02dffc89d823832ac8fbdefa53f3290e724078e7 Author: Jaebaek Seo <jaebaek@chromium.org> Date: Fri Oct 13 08:24:53 2017 Update DSF after swap in root local frame Opening a new tab and visiting site A and visiting site B render elements of site B smaller than correctly rendered elements when --use-zoom-for-dsf is enabled in Android. This is because the device scale factor (DSF) is not updated when the root local frame is swapped in. Let's assume that the frame of site A is hosted by process A. When visiting site B, process B is created and it hosts the frame of site B. At this moment, the frame node tree of process B has a LocalFrame that is the frame of site B and the one of process A has a RemoteFrame that points B's LocalFrame. If there is no more message to site B from site A, process A swaps in the frame of site B as its root LocalFrame and process B swaps out it. However, the zoom level is scaled by DSF only once (i.e., when the RemoteFrame of process A is created) and it is actually not scaled because the frame is not LocalFrame. This CL updates the zoom level by DSF, after swapping in the frame of site B as LocalFrame of process A. Bug: 737777 Change-Id: I21754ee9f62e99c40c3f9ebdb3d4cc4b2fcf03bb Reviewed-on: https://chromium-review.googlesource.com/690415 Reviewed-by: Alexandre Elias <aelias@chromium.org> Reviewed-by: David Bokan <bokan@chromium.org> Commit-Queue: Jaebaek Seo <jaebaek@chromium.org> Cr-Commit-Position: refs/heads/master@{#508643} [modify] https://crrev.com/02dffc89d823832ac8fbdefa53f3290e724078e7/content/renderer/render_frame_impl.cc [modify] https://crrev.com/02dffc89d823832ac8fbdefa53f3290e724078e7/content/renderer/render_view_browsertest.cc [modify] https://crrev.com/02dffc89d823832ac8fbdefa53f3290e724078e7/content/renderer/render_view_impl.h [modify] https://crrev.com/02dffc89d823832ac8fbdefa53f3290e724078e7/third_party/WebKit/Source/core/exported/WebViewImpl.h [modify] https://crrev.com/02dffc89d823832ac8fbdefa53f3290e724078e7/third_party/WebKit/public/web/WebView.h
,
Oct 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f94dce65d4aaf92e063f92d3e58e901ef455ccc3 commit f94dce65d4aaf92e063f92d3e58e901ef455ccc3 Author: Jaebaek Seo <jaebaek@chromium.org> Date: Tue Oct 17 09:02:07 2017 Adjust page zoom and top control of remote devtools as DIP scale When enabling --use-zoom-for-dsf, inspecting Android chrome using devtool has three problems: 1. screencast is zoomed in, 2. the size of selected DOM element to inspect it is bigger than correct one, 3. a mouse click points weird position. See crbug.com/737777#c35 . The root cause of those problem is that --use-zoom-for-dsf multiplies the page zoom by the device scale factor (DSF), so scaling some lengths by the page zoom factor makes them DSF scale. To solve it, this CL scales down the page zoom factor and the top control height by DSF. Bug: 737777 Change-Id: I367b7e5cf4c485263f905857ed947977dd44a4ee Reviewed-on: https://chromium-review.googlesource.com/715080 Commit-Queue: Jaebaek Seo <jaebaek@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Reviewed-by: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#509330} [modify] https://crrev.com/f94dce65d4aaf92e063f92d3e58e901ef455ccc3/content/browser/devtools/protocol/page_handler.cc
,
Oct 23 2017
--use-zoom-for-dsf enabled WebView has larger height than the disabled one when the height is set as WRAP_CONTENT. (I installed SystemWebView.apk and tested a hello world WebView app)
,
Oct 26 2017
The location of DropdownPopup is wrong. See attachments, which are screenshots of http://jsbin.com/wunifor captured in Nexus 9 (tablet). DropdownPopup denotes option tags in a selection tag.
,
Nov 1 2017
The page rendered in iframe has a difference contents size. This looks similar with crbug.com/737777#c38 .
,
Nov 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c0b798d9f69d0fcddda0f60f26ab14a99eaf249c commit c0b798d9f69d0fcddda0f60f26ab14a99eaf249c Author: Jaebaek Seo <jaebaek@chromium.org> Date: Thu Nov 02 14:49:54 2017 Adjust size of AwContents as CSS scale for --use-zoom-for-dsf As shown in crbug.com/737777#c43 , enabling --use-zoom-for-dsf lets the height of webview contents longer. It is because the width and the height given to onWebLayoutContentsSizeChanged() method of AwContents.java are not CSS scale when --use-zoom-for-dsf is enabled. This CL scales down the contents size by the device scale factor (DSF) if --use-zoom-for-dsf is enabled (i.e., convert to CSS scale). Bug: 737777 Change-Id: I206359058f1098bdcd7ae25f175c29e770e77cfd Reviewed-on: https://chromium-review.googlesource.com/737614 Commit-Queue: Jaebaek Seo <jaebaek@chromium.org> Reviewed-by: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#513488} [modify] https://crrev.com/c0b798d9f69d0fcddda0f60f26ab14a99eaf249c/android_webview/java/DEPS [modify] https://crrev.com/c0b798d9f69d0fcddda0f60f26ab14a99eaf249c/android_webview/java/src/org/chromium/android_webview/AwLayoutSizer.java [modify] https://crrev.com/c0b798d9f69d0fcddda0f60f26ab14a99eaf249c/content/public/android/java/src/org/chromium/content/common/ContentSwitches.java
,
Nov 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/40117b7f1d1019e3909ae5807a58ccd80e23d021 commit 40117b7f1d1019e3909ae5807a58ccd80e23d021 Author: Jaebaek Seo <jaebaek@chromium.org> Date: Fri Nov 03 05:37:48 2017 Adjust AnchorRect of DropdownPopup for --use-zoom-for-dsf As shown in crbug.com/737777#c44 , the position of DropdownPopup for select and option html tags are weird. It is because ViewAndroid::SetAnchorRect() scales the AnchorRect by the devices scale factor (DSF). Since lenghts in this function was scaled by DSF already, the scale in this function results in the double scale. This CL makes the AnchorRect not scaled if --use-zoom-for-dsf is enabled. Bug: 737777 Change-Id: I339f8381ccb1a410ff08e57e4717129df42e3022 Reviewed-on: https://chromium-review.googlesource.com/737772 Reviewed-by: Ted Choc <tedchoc@chromium.org> Reviewed-by: Bo <boliu@chromium.org> Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org> Commit-Queue: Jaebaek Seo <jaebaek@chromium.org> Cr-Commit-Position: refs/heads/master@{#513700} [modify] https://crrev.com/40117b7f1d1019e3909ae5807a58ccd80e23d021/android_webview/java/src/org/chromium/android_webview/AwViewAndroidDelegate.java [modify] https://crrev.com/40117b7f1d1019e3909ae5807a58ccd80e23d021/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsAnchorViewTest.java [modify] https://crrev.com/40117b7f1d1019e3909ae5807a58ccd80e23d021/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelContent.java [modify] https://crrev.com/40117b7f1d1019e3909ae5807a58ccd80e23d021/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillTest.java [modify] https://crrev.com/40117b7f1d1019e3909ae5807a58ccd80e23d021/content/browser/browser_main_loop.cc [modify] https://crrev.com/40117b7f1d1019e3909ae5807a58ccd80e23d021/ui/android/java/src/org/chromium/ui/base/ViewAndroidDelegate.java [modify] https://crrev.com/40117b7f1d1019e3909ae5807a58ccd80e23d021/ui/android/view_android.cc [modify] https://crrev.com/40117b7f1d1019e3909ae5807a58ccd80e23d021/ui/android/view_android.h
,
Nov 6 2017
http://crbug.com/737777#c46 is not a problem of contents size nor navigation. It is a problem of text-autosizing. To be sure, I checked sizes of DOM elements after adding a picture. See attachments. "textautosize_dsf.png" is the --use-zoom-for-dsf enabled one and "textautosize.png" is the disabled one. Both in "textautosize_dsf.png" and "textautosize.png", the image size is the same, but the text size is different.
,
Nov 6 2017
Enabling --use-zoom-for-dsf locates Autofill popup in a wrong place. See the attachments. "autofill_dsf.png" is the enabled one and "autofill.png" is the disabled one.
,
Nov 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f8569b686affa06597c3823ff47552dbc125f56b commit f8569b686affa06597c3823ff47552dbc125f56b Author: Jaebaek Seo <jaebaek@chromium.org> Date: Wed Nov 08 00:39:35 2017 Adjust text size in text-autosize check for --use-zoom-for-dsf As shown in crbug.com/737777#c50 , enabling --use-zoom-for-dsf shows smaller text for some webpages. When TextAutosizer checks if a text must be autosized, it works incorrectly because the compared text length is in CSS (i.e., not device scale) while minimum_text_length_to_autosize (the compared one) is in the device scale. This CL sets the compared text length as the device scale. Bug: 737777 Change-Id: Ie9eb023f6b59aca9afda57e7b70afa1abed11677 Reviewed-on: https://chromium-review.googlesource.com/754351 Reviewed-by: Philip Rogers <pdr@chromium.org> Reviewed-by: Steve Kobes <skobes@chromium.org> Commit-Queue: Jaebaek Seo <jaebaek@chromium.org> Cr-Commit-Position: refs/heads/master@{#514674} [modify] https://crrev.com/f8569b686affa06597c3823ff47552dbc125f56b/third_party/WebKit/Source/core/layout/TextAutosizer.cpp [modify] https://crrev.com/f8569b686affa06597c3823ff47552dbc125f56b/third_party/WebKit/Source/core/layout/TextAutosizerTest.cpp
,
Nov 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1599c4d0e26027c601d6c7c4f7b415766e541c6d commit 1599c4d0e26027c601d6c7c4f7b415766e541c6d Author: Jaebaek Seo <jaebaek@chromium.org> Date: Thu Nov 16 08:24:03 2017 Adjust location of Autofill popup for --use-zoom-for-dsf As shown crbug.com/737777#c51 , enabling --use-zoom-for-dsf locates Autofill popup in a wrong place. It is because AutofillPopupViewAndroid::OnSuggestionsChanged() and AwAutofillClient::ShowAutofillPopupImpl() passes element_bounds in the CSS scale as an argument to ViewAndroid::SetAnchorRect() that must receive the device scaled bounds argument when --use-zoom-for-dsf is enabled. This CL lets ViewAndroid::SetAnchorRect() receive the CSS scaled bounds argument and scales down the bounds argument as the CSS scale that ContentViewCore::ShowSelectPopupMenu() gives to ViewAndroid::SetAnchorRect(). In addition, this CL sets ViewAndroid::content_offset() as the CSS scale, which must be in the CSS scale for ViewAndroid::SetAnchorRect(), RenderWidgetHostImpl::WindowSnapshotReachedScreen(), ContextMenuHelper::ShowContextMenu(), and TabAndroid::ShowMediaDownloadInProductHelp(). By refactoring RenderWidgetHostViewAndroid::OnFrameMetadataUpdated(), it also relocates the position of IME CursorAnchorInfo API to the correct position when --use-zoom-for-dsf is enabled. BUG= 737777 Change-Id: I8f2268562735b822478455dab7581b6418a397fd Reviewed-on: https://chromium-review.googlesource.com/771491 Commit-Queue: Jaebaek Seo <jaebaek@chromium.org> Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#517028} [modify] https://crrev.com/1599c4d0e26027c601d6c7c4f7b415766e541c6d/content/browser/android/content_view_core.cc [modify] https://crrev.com/1599c4d0e26027c601d6c7c4f7b415766e541c6d/content/browser/browser_main_loop.cc [modify] https://crrev.com/1599c4d0e26027c601d6c7c4f7b415766e541c6d/content/browser/renderer_host/render_widget_host_view_android.cc [modify] https://crrev.com/1599c4d0e26027c601d6c7c4f7b415766e541c6d/ui/android/view_android.cc [modify] https://crrev.com/1599c4d0e26027c601d6c7c4f7b415766e541c6d/ui/android/view_android.h
,
Nov 17 2017
,
Dec 11 2017
,
Dec 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/efa2fd9684708e32cb85de0f6b8477b1095dce8c commit efa2fd9684708e32cb85de0f6b8477b1095dce8c Author: Jaebaek Seo <jaebaek@chromium.org> Date: Fri Dec 15 02:36:29 2017 Adjust WebView contents size and scroll delta When enabling --use-zoom-for-dsf, 1. crrev.com/c/737614 is a CL to adjust WebView size, but its implementation has a problem (the flag is not added to switch of commandline). This CL moves the same logic to android_webview/browser/aw_contents.cc. 2. As shown in crbug.com/737777#c47 , scrolling WebView with autofill popup is weird. It is because WebView scroll is slower than Android scroll (i.e., autofill popup is an Android View element and scrolling WebView also scrolls it). This CL makes WebView's scroll faster. Bug: 737777 Change-Id: I57cfd184bc07df2120d0d8d7a7896a9f66891607 Reviewed-on: https://chromium-review.googlesource.com/773924 Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Reviewed-by: Bo <boliu@chromium.org> Commit-Queue: Jaebaek Seo <jaebaek@chromium.org> Cr-Commit-Position: refs/heads/master@{#524299} [modify] https://crrev.com/efa2fd9684708e32cb85de0f6b8477b1095dce8c/android_webview/browser/aw_contents.cc [modify] https://crrev.com/efa2fd9684708e32cb85de0f6b8477b1095dce8c/android_webview/browser/aw_contents.h [modify] https://crrev.com/efa2fd9684708e32cb85de0f6b8477b1095dce8c/android_webview/browser/browser_view_renderer.cc [modify] https://crrev.com/efa2fd9684708e32cb85de0f6b8477b1095dce8c/android_webview/browser/browser_view_renderer.h [modify] https://crrev.com/efa2fd9684708e32cb85de0f6b8477b1095dce8c/android_webview/java/DEPS [modify] https://crrev.com/efa2fd9684708e32cb85de0f6b8477b1095dce8c/android_webview/java/src/org/chromium/android_webview/AwContents.java [modify] https://crrev.com/efa2fd9684708e32cb85de0f6b8477b1095dce8c/android_webview/java/src/org/chromium/android_webview/AwLayoutSizer.java [modify] https://crrev.com/efa2fd9684708e32cb85de0f6b8477b1095dce8c/content/common/content_switches_internal.cc [modify] https://crrev.com/efa2fd9684708e32cb85de0f6b8477b1095dce8c/content/public/android/java/src/org/chromium/content/common/ContentSwitches.java [modify] https://crrev.com/efa2fd9684708e32cb85de0f6b8477b1095dce8c/content/public/common/BUILD.gn [add] https://crrev.com/efa2fd9684708e32cb85de0f6b8477b1095dce8c/content/public/common/use_zoom_for_dsf_policy.cc [add] https://crrev.com/efa2fd9684708e32cb85de0f6b8477b1095dce8c/content/public/common/use_zoom_for_dsf_policy.h
,
Dec 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/655110e8bf711800c3d2a39430e49adfb48bbc98 commit 655110e8bf711800c3d2a39430e49adfb48bbc98 Author: Jaebaek Seo <jaebaek@chromium.org> Date: Tue Dec 19 23:27:39 2017 Adjust unhandled tap UI position for --use-zoom-for-dsf When enabling --use-zoom-for-dsf, the contextual search is disabled and the selection of word is not shown. This is because x and y values given to RenderWidgetHostViewAndroid::OnShowUnhandledTapUIIfNeeded() and SelectionPopupController::OnShowUnhandledTapUIIfNeeded() are not in DIP scale when --use-zoom-for-dsf is enabled and accordingly scaling them by dip_scale in SelectionPopupController::OnShowUnhandledTapUIIfNeeded() causes bugs. This CL scales those x and y values in SelectionPopupController::OnShowUnhandledTapUIIfNeeded() by DSF only when --use-zoom-for-dsf is disabled. Bug: 737777 Change-Id: I4a9d11b4e1ef4f7b284b5e3a87a0adcf66ef8d2c Reviewed-on: https://chromium-review.googlesource.com/828244 Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Jaebaek Seo <jaebaek@chromium.org> Cr-Commit-Position: refs/heads/master@{#525180} [modify] https://crrev.com/655110e8bf711800c3d2a39430e49adfb48bbc98/content/browser/android/selection_popup_controller.cc [modify] https://crrev.com/655110e8bf711800c3d2a39430e49adfb48bbc98/content/browser/android/selection_popup_controller.h [modify] https://crrev.com/655110e8bf711800c3d2a39430e49adfb48bbc98/content/browser/renderer_host/render_widget_host_view_android.cc [modify] https://crrev.com/655110e8bf711800c3d2a39430e49adfb48bbc98/content/browser/renderer_host/render_widget_host_view_android.h [modify] https://crrev.com/655110e8bf711800c3d2a39430e49adfb48bbc98/content/renderer/render_widget.cc
,
Dec 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1a859d302e47f3b8c2376c0a7bcfbf9e9dda6287 commit 1a859d302e47f3b8c2376c0a7bcfbf9e9dda6287 Author: Jaebaek Seo <jaebaek@chromium.org> Date: Tue Dec 26 03:12:37 2017 Scale autosized font by DSF when --use-zoom-for-dsf is enabled crrev.com/c/666578 scales the autosized font by the device scale factor (DSF) when --use-zoom-for-dsf is enabled. In the CL, page_info_.device_scale_adjustment_ in TextAutosizer::UpdatePageInfo() is scaled to do so, but I just realized that page_info_.page_needs_autosizing_ must not be affected by DSF and the autosized font must be always scaled by DSF. This is because the font must always be zoomed by DSF when --use-zoom-for-dsf is enabled. This CL moves the same logic (i.e., scaling by DSF) to ComputedStyle::SetTextAutosizingMultiplier() to scale the applied multiplier by DSF. Bug: 737777 Change-Id: I6e8e5b383aa38776f51249c6deebe36c75e02dad Reviewed-on: https://chromium-review.googlesource.com/831814 Commit-Queue: Jaebaek Seo <jaebaek@chromium.org> Reviewed-by: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#526184} [modify] https://crrev.com/1a859d302e47f3b8c2376c0a7bcfbf9e9dda6287/third_party/WebKit/Source/core/layout/TextAutosizer.cpp [modify] https://crrev.com/1a859d302e47f3b8c2376c0a7bcfbf9e9dda6287/third_party/WebKit/Source/core/layout/TextAutosizerTest.cpp [modify] https://crrev.com/1a859d302e47f3b8c2376c0a7bcfbf9e9dda6287/third_party/WebKit/Source/core/style/ComputedStyle.cpp
,
Jan 3 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fed2c859128b1a97ded6b611fa5cd7c68bc30bcb commit fed2c859128b1a97ded6b611fa5cd7c68bc30bcb Author: Jaebaek Seo <jaebaek@chromium.org> Date: Wed Jan 03 05:23:51 2018 Round aw contents size when converting it to CSS pixels Enabling --use-zoom-for-dsf needs a conversions between integer values and float values for Android WebView contents size (See AwContents::OnWebLayoutContentsSizeChanged()). The previous code adopted ceiling for those conversions, which resulted in test failures of AndroidViewIntegrationTest. This CL adopts rounding for those conversions instead. Bug: 737777 Change-Id: I8b22981c0d94ff983e4d8d4254b0c4155892d5d8 Reviewed-on: https://chromium-review.googlesource.com/832326 Reviewed-by: Bo <boliu@chromium.org> Commit-Queue: Jaebaek Seo <jaebaek@chromium.org> Cr-Commit-Position: refs/heads/master@{#526625} [modify] https://crrev.com/fed2c859128b1a97ded6b611fa5cd7c68bc30bcb/android_webview/browser/aw_contents.cc
,
Jan 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0438fa7e555c996bb7c9b3eebe5f93379bc0f783 commit 0438fa7e555c996bb7c9b3eebe5f93379bc0f783 Author: Jaebaek Seo <jaebaek@chromium.org> Date: Fri Jan 19 06:56:52 2018 Adjust AndroidWebview smooth scroll and scrollto delta LocalDOMWindow::scrollX() must return a CSS pixel scaled value, but it returns a wrong value when enabling --use-zoom-for-dsf. Since LocalDOMWindow::scrollX() returns viewport_x / PageZoomFactor() and PageZoomFactor() is DSF when --use-zoom-for-dsf is enabled, viewport_x must be in physical pixel scale. root_offset given to SynchronousCompositor::DidChangeRootLayerScrollOffset() as an argument will be the value of viewport_x. It must be in physical pixel scale if --use-zoom-for-dsf is enabled (otherwise, it must be in DIP scale). This CL lets BrowserViewRenderer pass physical pixel scaled value to SynchronousCompositor::DidChangeRootLayerScrollOffset() when --use-zoom-for-dsf is enabled. Bug: 737777 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I36c3593633a90cb55c6e9eb7a48d4c406694c751 Reviewed-on: https://chromium-review.googlesource.com/844266 Commit-Queue: Jaebaek Seo <jaebaek@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: David Bokan <bokan@chromium.org> Reviewed-by: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#530444} [modify] https://crrev.com/0438fa7e555c996bb7c9b3eebe5f93379bc0f783/android_webview/browser/aw_contents.cc [modify] https://crrev.com/0438fa7e555c996bb7c9b3eebe5f93379bc0f783/android_webview/browser/browser_view_renderer.cc [modify] https://crrev.com/0438fa7e555c996bb7c9b3eebe5f93379bc0f783/android_webview/browser/browser_view_renderer.h [modify] https://crrev.com/0438fa7e555c996bb7c9b3eebe5f93379bc0f783/android_webview/javatests/src/org/chromium/android_webview/test/AndroidScrollIntegrationTest.java [modify] https://crrev.com/0438fa7e555c996bb7c9b3eebe5f93379bc0f783/content/common/BUILD.gn [add] https://crrev.com/0438fa7e555c996bb7c9b3eebe5f93379bc0f783/content/common/android/use_zoom_for_dsf_policy_android.cc [modify] https://crrev.com/0438fa7e555c996bb7c9b3eebe5f93379bc0f783/content/public/android/BUILD.gn [add] https://crrev.com/0438fa7e555c996bb7c9b3eebe5f93379bc0f783/content/public/android/java/src/org/chromium/content_public/common/UseZoomForDSFPolicy.java [modify] https://crrev.com/0438fa7e555c996bb7c9b3eebe5f93379bc0f783/content/public/browser/android/synchronous_compositor.h
,
Jan 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/16ca9fbd8073d565a99e09d3d63dab99988d53d1 commit 16ca9fbd8073d565a99e09d3d63dab99988d53d1 Author: Jaebaek Seo <jaebaek@chromium.org> Date: Tue Jan 23 01:08:54 2018 Adjust points in AccessibilityHitTestingBrowserTest When enabling --use-zoom-for-dsf, ui::AXActionData::target_point given to RenderFrameHostImpl::AccessibilityPerformAction() as an argument must be in physical pixel scale. In AccessibilityHitTestingBrowserTest, it does not use points in physical pixel scale. It results in test failures when DSF is not 1. Bug: 737777 Change-Id: Id2e903f3d1666e71bd11a7ce64f28e4697c9d325 Reviewed-on: https://chromium-review.googlesource.com/870013 Reviewed-by: Timothy Dresser <tdresser@chromium.org> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Jaebaek Seo <jaebaek@chromium.org> Cr-Commit-Position: refs/heads/master@{#531100} [modify] https://crrev.com/16ca9fbd8073d565a99e09d3d63dab99988d53d1/content/browser/accessibility/browser_accessibility_manager.cc [modify] https://crrev.com/16ca9fbd8073d565a99e09d3d63dab99988d53d1/content/browser/accessibility/browser_accessibility_manager_android.cc [modify] https://crrev.com/16ca9fbd8073d565a99e09d3d63dab99988d53d1/content/browser/accessibility/browser_accessibility_manager_android.h [modify] https://crrev.com/16ca9fbd8073d565a99e09d3d63dab99988d53d1/content/browser/accessibility/hit_testing_browsertest.cc [modify] https://crrev.com/16ca9fbd8073d565a99e09d3d63dab99988d53d1/content/browser/accessibility/web_contents_accessibility_android.cc [modify] https://crrev.com/16ca9fbd8073d565a99e09d3d63dab99988d53d1/ui/events/android/motion_event_android.cc [modify] https://crrev.com/16ca9fbd8073d565a99e09d3d63dab99988d53d1/ui/events/android/motion_event_android.h
,
Jan 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ba29acd9460d792f17a947bcadcec21ee531abf0 commit ba29acd9460d792f17a947bcadcec21ee531abf0 Author: Jaebaek Seo <jaebaek@chromium.org> Date: Tue Jan 23 15:28:26 2018 Scroll by navigation with URL anchor has precision issue Similar to crrev.com/c/844266, when enabling --use-zoom-for-dsf, NavigationControllerBrowserTest.ReloadWithUrlAnchor* tests fail because of precision issue. When the flag is enabled, Element::scrollTop() returns a float value (e.g., 99.8095 = 262 / device_scale_factor). box->ScrollTop() in Element::scrollTop() is an integer value (e.g., 262) and it will be divided by the device scale factor (DSF) because the default zoom factor is DSF when the flag is enabled. When the flag is disabled, the float value of scroll top in CSS pixel scale is truncated by ScrollableArea::ScrollOffsetChanged(). In Element::scrollTop(), the zoom factor is 1 as default and the return value is not divided by DSF. It returns an integer value as a result (e.g., 100). This CL solves the precision issue to enable --use-zoom-for-dsf. Bug: 737777 Change-Id: I6941576b5bbec34729596f14530e86097d807edc Reviewed-on: https://chromium-review.googlesource.com/878103 Reviewed-by: Bo <boliu@chromium.org> Reviewed-by: David Bokan <bokan@chromium.org> Commit-Queue: Jaebaek Seo <jaebaek@chromium.org> Cr-Commit-Position: refs/heads/master@{#531242} [modify] https://crrev.com/ba29acd9460d792f17a947bcadcec21ee531abf0/content/browser/frame_host/navigation_controller_impl_browsertest.cc
,
Jan 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/03742f3117149602b3ccbf5547eadf49eec75cd3 commit 03742f3117149602b3ccbf5547eadf49eec75cd3 Author: Jaebaek Seo <jaebaek@chromium.org> Date: Thu Jan 25 02:15:27 2018 Scale expected font size by DSF in accessibility snapshot test AccessibilitySnapshotTest.testRequestAccessibilitySnapshotFontSize fails when enabling --use-zoom-for-dsf. child.textSize is not 32.0, but it is 32.0 * device_scale_factor. It is because AXLayoutObject::FontSize() that is the source of child.textSize is in physical pixel scale when the flag is enabled. Since "the font size should take the scale into account", the expected font size in AccessibilitySnapshotTest.testRequestAccessibilitySnapshotFontSize must be also in physical pixel scale. Bug: 737777 Change-Id: I5b8ee73b8c829c87efad1fd56fee2c733087e7a9 Reviewed-on: https://chromium-review.googlesource.com/878107 Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by: Bo <boliu@chromium.org> Commit-Queue: Jaebaek Seo <jaebaek@chromium.org> Cr-Commit-Position: refs/heads/master@{#531790} [modify] https://crrev.com/03742f3117149602b3ccbf5547eadf49eec75cd3/content/public/android/javatests/src/org/chromium/content/browser/webcontents/AccessibilitySnapshotTest.java
,
Jan 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/53ab80a6625a378e7c1757f5fc07e1d2452c6a70 commit 53ab80a6625a378e7c1757f5fc07e1d2452c6a70 Author: Jaebaek Seo <jaebaek@chromium.org> Date: Mon Jan 29 04:50:46 2018 Refactoring --use-zoom-for-dsf check Previously, --use-zoom-for-dsf check (enabled/disabled) was done by IsUseZoomForDSFEnabled() in content/common/content_switches_internal.h, but it cannot be used for AndroidWebview. crrev.com/c/773924 added UseZoomForDSFEnabled() to content/public/common/use_zoom_for_dsf_policy.h in order to overcome this limitation. To get rid of the duplicated same function, this CL removes the one in content/common/content_switches_internal.h and changes the name of the one in content/public/common/use_zoom_for_dsf_policy.h as IsUseZoomForDSFEnabled(). Bug: 737777 Change-Id: I68640f3d506fa53c041d188796bdf8bc1223cdb4 Reviewed-on: https://chromium-review.googlesource.com/885162 Commit-Queue: Jaebaek Seo <jaebaek@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Reviewed-by: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#532323} [modify] https://crrev.com/53ab80a6625a378e7c1757f5fc07e1d2452c6a70/android_webview/browser/aw_contents.cc [modify] https://crrev.com/53ab80a6625a378e7c1757f5fc07e1d2452c6a70/android_webview/browser/browser_view_renderer.cc [modify] https://crrev.com/53ab80a6625a378e7c1757f5fc07e1d2452c6a70/content/browser/accessibility/browser_accessibility_manager.cc [modify] https://crrev.com/53ab80a6625a378e7c1757f5fc07e1d2452c6a70/content/browser/accessibility/browser_accessibility_manager_android.cc [modify] https://crrev.com/53ab80a6625a378e7c1757f5fc07e1d2452c6a70/content/browser/accessibility/hit_testing_browsertest.cc [modify] https://crrev.com/53ab80a6625a378e7c1757f5fc07e1d2452c6a70/content/browser/accessibility/web_contents_accessibility_android.cc [modify] https://crrev.com/53ab80a6625a378e7c1757f5fc07e1d2452c6a70/content/browser/android/content_view_core.cc [modify] https://crrev.com/53ab80a6625a378e7c1757f5fc07e1d2452c6a70/content/browser/android/overscroll_controller_android.cc [modify] https://crrev.com/53ab80a6625a378e7c1757f5fc07e1d2452c6a70/content/browser/android/text_suggestion_host_android.cc [modify] https://crrev.com/53ab80a6625a378e7c1757f5fc07e1d2452c6a70/content/browser/devtools/protocol/page_handler.cc [modify] https://crrev.com/53ab80a6625a378e7c1757f5fc07e1d2452c6a70/content/browser/frame_host/cross_process_frame_connector.cc [modify] https://crrev.com/53ab80a6625a378e7c1757f5fc07e1d2452c6a70/content/browser/frame_host/navigation_controller_impl_browsertest.cc [modify] https://crrev.com/53ab80a6625a378e7c1757f5fc07e1d2452c6a70/content/browser/frame_host/render_widget_host_view_guest.cc [modify] https://crrev.com/53ab80a6625a378e7c1757f5fc07e1d2452c6a70/content/browser/renderer_host/input/touch_selection_controller_client_child_frame.cc [modify] https://crrev.com/53ab80a6625a378e7c1757f5fc07e1d2452c6a70/content/browser/renderer_host/render_widget_host_impl.cc [modify] https://crrev.com/53ab80a6625a378e7c1757f5fc07e1d2452c6a70/content/browser/renderer_host/render_widget_host_view_android.cc [modify] https://crrev.com/53ab80a6625a378e7c1757f5fc07e1d2452c6a70/content/browser/renderer_host/render_widget_host_view_aura.cc [modify] https://crrev.com/53ab80a6625a378e7c1757f5fc07e1d2452c6a70/content/common/android/use_zoom_for_dsf_policy_android.cc [modify] https://crrev.com/53ab80a6625a378e7c1757f5fc07e1d2452c6a70/content/common/content_switches_internal.cc [modify] https://crrev.com/53ab80a6625a378e7c1757f5fc07e1d2452c6a70/content/common/content_switches_internal.h [modify] https://crrev.com/53ab80a6625a378e7c1757f5fc07e1d2452c6a70/content/public/common/use_zoom_for_dsf_policy.cc [modify] https://crrev.com/53ab80a6625a378e7c1757f5fc07e1d2452c6a70/content/public/common/use_zoom_for_dsf_policy.h [modify] https://crrev.com/53ab80a6625a378e7c1757f5fc07e1d2452c6a70/content/renderer/input/render_widget_input_handler.cc [modify] https://crrev.com/53ab80a6625a378e7c1757f5fc07e1d2452c6a70/content/renderer/render_view_browsertest.cc [modify] https://crrev.com/53ab80a6625a378e7c1757f5fc07e1d2452c6a70/content/renderer/render_view_impl.cc [modify] https://crrev.com/53ab80a6625a378e7c1757f5fc07e1d2452c6a70/content/renderer/render_widget.cc [modify] https://crrev.com/53ab80a6625a378e7c1757f5fc07e1d2452c6a70/content/shell/renderer/layout_test/blink_test_runner.cc
,
Jan 31 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d055eca7e24cb667ad4378c81204971c46256d85 commit d055eca7e24cb667ad4378c81204971c46256d85 Author: Jaebaek Seo <jaebaek@chromium.org> Date: Wed Jan 31 00:57:42 2018 Update Android overscroll unit tests for --use-zoom-for-dsf Enabling --use-zoom-for-dsf scales parameters given to OverscrollControllerAndroid::OnOverscrolled() by the device scale factor. Accordingly, crrev.com/c/638510 updated values given to glow_effect_->OnOverscrolled(), but related unit tests (i.e., OverscrollBehaviorContainPreventsNavigation and OverscrollBehaviorNonePreventsNavigationAndGlow of OverscrollControllerAndroidUnitTest) are not updated correctly. This CL changes those unit tests and solve those unit tests' failures that occur when --use-zoom-for-dsf is enabled. Bug: 737777 Change-Id: Ia52fa1bef039fb234bd731ca1919cb850602a70f Reviewed-on: https://chromium-review.googlesource.com/890141 Reviewed-by: Bo <boliu@chromium.org> Commit-Queue: Jaebaek Seo <jaebaek@chromium.org> Cr-Commit-Position: refs/heads/master@{#533125} [modify] https://crrev.com/d055eca7e24cb667ad4378c81204971c46256d85/content/browser/android/overscroll_controller_android_unittest.cc
,
Jan 31 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9526bf22952fc0e1540779d2969b885771a4eca8 commit 9526bf22952fc0e1540779d2969b885771a4eca8 Author: Jaebaek Seo <jaebaek@chromium.org> Date: Wed Jan 31 01:00:45 2018 aw scroll instrumentation test has precision issue AndroidScrollIntegrationTest.testUiScrollReflectedInJs has a precision issue when enabling --use-zoom-for-dsf. It is the same problem with the one described in crrev.com/c/844266. In crrev.com/c/844266, I did not apply the same thing to AndroidScrollIntegrationTest.testUiScrollReflectedInJs as a mistake. Bug: 737777 Change-Id: I9474e8cf424ed2bf6b10578ab3c7ff7fbf8b6c4b Reviewed-on: https://chromium-review.googlesource.com/892782 Reviewed-by: Bo <boliu@chromium.org> Commit-Queue: Jaebaek Seo <jaebaek@chromium.org> Cr-Commit-Position: refs/heads/master@{#533127} [modify] https://crrev.com/9526bf22952fc0e1540779d2969b885771a4eca8/android_webview/javatests/src/org/chromium/android_webview/test/AndroidScrollIntegrationTest.java
,
Jan 31 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c8b591b3256070801eb6d2f465db14047b59068f commit c8b591b3256070801eb6d2f465db14047b59068f Author: Jaebaek Seo <jaebaek@chromium.org> Date: Wed Jan 31 01:02:38 2018 Pass values in CSS pixel scale to ContentViewCore::UpdateFrameInfo ContentViewCore::UpdateFrameInfo() must receive positions and sizes in CSS pixel except top_shown_pix. When --use-zoom-for-dsf is enabled, those values given to ContentViewCore::UpdateFrameInfo() are in physical pixel. It results in test failures of ContentViewScrollingTest#testOverScroll and ContentViewScrollingTest#testScrollTo. This CL scales down those values given to ContentViewCore::UpdateFrameInfo() by the device scale factor. TEST=run_content_shell_test_apk -f ContentViewScrollingTest#testOverScroll (and ContentViewScrollingTest#testScrollTo) on NEXUS 5X Bug: 737777 Change-Id: I95be3ed63d569ec9d620fa431c0d6bfa932410ba Reviewed-on: https://chromium-review.googlesource.com/888183 Commit-Queue: Jaebaek Seo <jaebaek@chromium.org> Reviewed-by: Bo <boliu@chromium.org> Reviewed-by: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#533129} [modify] https://crrev.com/c8b591b3256070801eb6d2f465db14047b59068f/content/browser/renderer_host/render_widget_host_view_android.cc
,
Jan 31 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1dcf56572594400728dfd2fe787f32205e81b7c2 commit 1dcf56572594400728dfd2fe787f32205e81b7c2 Author: Jaebaek Seo <jaebaek@chromium.org> Date: Wed Jan 31 07:45:59 2018 Touch move has precision issue when enabling --use-zoom-for-dsf Enabling --use-zoom-for-dsf causes MainThreadEventQueueBrowserTest.TouchMove failure because of a precision issue. We expect that window.lastTouchMoveEvent.touches[0].pageX has 35, but it is 34.6666 when the device scale factor (DSF) is 2.625. It is because LocalFrameView::ConvertFromRootFrame() called by TouchEventManager::CreateDomTouch() (that sets pageX|Y) floors the pageX|Y (i.e., point_in_root_frame). This CL removes the flooring on pageX|Y by adding FloatPoint variants of all co-ordinate space conversion APIs and updating FloatPoint LocalFrameView::ConvertFromRootFrame(const FloatPoint&). TEST=content_browsertests MainThreadEventQueueBrowserTest.TouchMove on NEXUS 5X Bug: 737777 Change-Id: I6c8fb12e4f2fb4c38328ef9f18529e6559f91d43 Reviewed-on: https://chromium-review.googlesource.com/885321 Commit-Queue: Jaebaek Seo <jaebaek@chromium.org> Reviewed-by: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#533225} [modify] https://crrev.com/1dcf56572594400728dfd2fe787f32205e81b7c2/third_party/WebKit/Source/core/frame/LocalFrameView.cpp [modify] https://crrev.com/1dcf56572594400728dfd2fe787f32205e81b7c2/third_party/WebKit/Source/core/frame/LocalFrameView.h
,
Feb 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/15abc513f7f24b42d4238ff2ed1bed7562f1bc24 commit 15abc513f7f24b42d4238ff2ed1bed7562f1bc24 Author: Jaebaek Seo <jaebaek@chromium.org> Date: Thu Feb 01 03:12:18 2018 Adjust popup overlay position for ignoring MHTMLGenerationTest.RemovePopupOverlay fails when enabling --use-zoom-for-dsf. It is because |center_point| of MHTMLFrameSerializerDelegate::ShouldIgnorePopupOverlayElement() is in DIPs, while box->FrameRect() (which is compared to |center_point|) is in physical pixels. This CL scales |center_point| by the device scale factor to match those scales. TEST=content_browsertests MHTMLGenerationTest.RemovePopupOverlay on NEXUS 5X Bug: 737777 Change-Id: I8b4a97f546e73759af29e35b8d234ec2dbd937b3 Reviewed-on: https://chromium-review.googlesource.com/895103 Reviewed-by: Steve Kobes <skobes@chromium.org> Commit-Queue: Jaebaek Seo <jaebaek@chromium.org> Cr-Commit-Position: refs/heads/master@{#533539} [modify] https://crrev.com/15abc513f7f24b42d4238ff2ed1bed7562f1bc24/third_party/WebKit/Source/core/exported/WebFrameSerializer.cpp
,
Feb 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/be534f9ccd730b51e205b9e15d451ca112960dd9 commit be534f9ccd730b51e205b9e15d451ca112960dd9 Author: Jaebaek Seo <jaebaek@chromium.org> Date: Thu Feb 01 05:41:10 2018 Adjust touch position for aw hit test WebKitHitTestTest.testUnfocusedNodeAndTouchRace fails when enabling --use-zoom-for-dsf, because AwContents.AwViewMethodsImpl.onTouchEvent() passes the event position in DIPs to nativeRequestNewHitTestDataAt() method while values in physical pixels are expected. This CL lets AwContents.AwViewMethodsImpl.onTouchEvent() passes those values in physical pixels when --use-zoom-for-dsf is enabled. TEST=webview_instrumentation_test org.chromium.android_webview.test. WebKitHitTestTest#testUnfocusedNodeAndTouchRace on NEXUS 5X Bug: 737777 Change-Id: I6a51be615d646a9bc671cfad7374c1f73a69fbd3 Reviewed-on: https://chromium-review.googlesource.com/895102 Commit-Queue: Jaebaek Seo <jaebaek@chromium.org> Reviewed-by: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#533575} [modify] https://crrev.com/be534f9ccd730b51e205b9e15d451ca112960dd9/android_webview/java/src/org/chromium/android_webview/AwContents.java
,
Feb 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/511f364ba3ea82f8736ae70ca2dcc0b1075ecb9a commit 511f364ba3ea82f8736ae70ca2dcc0b1075ecb9a Author: Jaebaek Seo <jaebaek@chromium.org> Date: Thu Feb 01 23:54:09 2018 Type issue in WheelEventsBrowserTest AsyncWheelEventsBrowserTest.WheelEventTarget fails when enabling --use-zoom-for-dsf. It assumes that all values related to scroll delta (e.g., document.scrollingElement.scrollTop) are integer type values, but some of them are double values when --use-zoom-for-dsf is enabled (crrev.com/c/878103 has a similar issue). This CL lets the test get double values instead of integer values. TEST=content_browsertests AsyncWheelEventsBrowserTest.WheelEventTarget on NEXUS 5X Bug: 737777 Change-Id: If1fc0916d72a06db7999b4d41d9ecd6886412be0 Reviewed-on: https://chromium-review.googlesource.com/897282 Reviewed-by: Dave Tapuska <dtapuska@chromium.org> Reviewed-by: David Bokan <bokan@chromium.org> Commit-Queue: Jaebaek Seo <jaebaek@chromium.org> Cr-Commit-Position: refs/heads/master@{#533854} [modify] https://crrev.com/511f364ba3ea82f8736ae70ca2dcc0b1075ecb9a/content/browser/renderer_host/input/wheel_scroll_latching_browsertest.cc
,
Feb 2 2018
The location of Tap Disambiguator is not correct when --use-zoom-for-dsf is enabled. See the attachments. tapdisambiguator_enabled.png is the one when --use-zoom-for-dsf is enabled. tapdisambiguator_disabled.png is the one when --use-zoom-for-dsf is disabled.
,
Feb 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a5a8520ab829e83381ab7ad9d75a6901e75e9bad commit a5a8520ab829e83381ab7ad9d75a6901e75e9bad Author: Jaebaek Seo <jaebaek@chromium.org> Date: Thu Feb 08 00:47:21 2018 Precision problem in FrameConnectorDelegate When enabling --use-zoom-for-dsf on Android, SitePerProcessBrowserTest.PhysicalBackingSizeTest and SitePerProcessHitTestBrowserTest.AsynchronousHitTestChildTimeout fail because of a precision issue. It is caused by invalid conversions used in FrameConnectorDelegate. This CL changes those conversions. TEST=content_browsertests SitePerProcessBrowserTest.PhysicalBackingSizeTest and SitePerProcessHitTestBrowserTest.AsynchronousHitTestChildTimeout on NEXUS 5X Bug: 737777 Change-Id: Ib1cb8d0e094f97a42f267d3edfa891256f992068 Reviewed-on: https://chromium-review.googlesource.com/904224 Commit-Queue: Jaebaek Seo <jaebaek@chromium.org> Reviewed-by: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#535222} [modify] https://crrev.com/a5a8520ab829e83381ab7ad9d75a6901e75e9bad/content/browser/renderer_host/frame_connector_delegate.cc
,
Feb 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/14b6692736708509339cf60ea17a8113ce859312 commit 14b6692736708509339cf60ea17a8113ce859312 Author: Jaebaek Seo <jaebaek@chromium.org> Date: Wed Feb 14 01:21:44 2018 Let ShowWidgetMessageFilter::initial_rect_ be in DIPs When --use-zoom-for-dsf is enabled on Android, SitePerProcessHitTestBrowserTest.PopupMenuTest fails because ShowWidgetMessageFilter::initial_rect_ is in physical pixels while we expect that it is in DIPs. This CL gets the |initial_rect_| in DIPs to check its value. TEST=content_browsertests SitePerProcessHitTestBrowserTest.PopupMenuTest on NEXUS 5X Bug: 737777 Change-Id: I194625461b874fa09c75bf6138cc1b5461d11a0a Reviewed-on: https://chromium-review.googlesource.com/906269 Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Jaebaek Seo <jaebaek@chromium.org> Cr-Commit-Position: refs/heads/master@{#536587} [modify] https://crrev.com/14b6692736708509339cf60ea17a8113ce859312/content/browser/site_per_process_hit_test_browsertest.cc
,
Feb 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/92ac0ab4c6a0b335065fcf93153390ba9575574c commit 92ac0ab4c6a0b335065fcf93153390ba9575574c Author: Jaebaek Seo <jaebaek@chromium.org> Date: Wed Feb 14 01:25:41 2018 Set screen_space_rect as DIP When enabling --use-zoom-for-dsf on Android, SitePerProcessBrowserTest.ViewBoundsInNestedFrameTest fails because UpdateResizeParamsMessageFilter::last_rect_ is in physical pixels while the value compared to it is in DIPs. This CL set last_rect_ as DIPs. TEST=content_browsertests SitePerProcessBrowserTest.ViewBoundsInNestedFrameTest on NEXUS 5X Bug: 737777 Change-Id: Iddc1c655bd8c974e121048cafabd5a9a55fc5a8e Reviewed-on: https://chromium-review.googlesource.com/906268 Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Jaebaek Seo <jaebaek@chromium.org> Cr-Commit-Position: refs/heads/master@{#536588} [modify] https://crrev.com/92ac0ab4c6a0b335065fcf93153390ba9575574c/content/test/content_browser_test_utils_internal.cc [modify] https://crrev.com/92ac0ab4c6a0b335065fcf93153390ba9575574c/content/test/content_browser_test_utils_internal.h
,
Feb 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4c50e3e13d30c93d61b28119aac333f2aafc0d8b commit 4c50e3e13d30c93d61b28119aac333f2aafc0d8b Author: Jaebaek Seo <jaebaek@chromium.org> Date: Wed Feb 14 23:12:02 2018 Adjust location and size of TapDisambiguator As shown in crbug.com/737777#c72 , the location and size of Android tab disambiguator is not correct when --use-zoom-for-dsf is enabled. It is because RenderViewImpl::DidTapMultipleTargets() assumes |touch_rect| is in DIPs while it is in physical pixels when --use-zoom-for-dsf is enabled. This CL solves this problem. TEST=Android Chrome with production code on NEXUS 5X, content_browsertests RenderViewTapDisambiguationTest.CanvasSizeUseZoomForDSF on NEXUS 5X, NEXUS 4, NEXUS 9 (w/ and w/o this change). Bug: 737777 Change-Id: I64ca0b9b76fcfc3798036a80c9213973de8f3f77 Reviewed-on: https://chromium-review.googlesource.com/898824 Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Jaebaek Seo <jaebaek@chromium.org> Cr-Commit-Position: refs/heads/master@{#536868} [modify] https://crrev.com/4c50e3e13d30c93d61b28119aac333f2aafc0d8b/content/renderer/render_view_browsertest.cc [modify] https://crrev.com/4c50e3e13d30c93d61b28119aac333f2aafc0d8b/content/renderer/render_view_impl.cc [modify] https://crrev.com/4c50e3e13d30c93d61b28119aac333f2aafc0d8b/content/renderer/render_view_impl.h
,
Feb 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c61ef9142915213e7b8ee088f4c6b30eed745150 commit c61ef9142915213e7b8ee088f4c6b30eed745150 Author: Thomas Anderson <thomasanderson@chromium.org> Date: Wed Feb 14 23:54:18 2018 Revert "Adjust location and size of TapDisambiguator" This reverts commit 4c50e3e13d30c93d61b28119aac333f2aafc0d8b. Reason for revert: Build failure on Android builder: https://ci.chromium.org/buildbot/chromium/Android/81706 Original change's description: > Adjust location and size of TapDisambiguator > > As shown in crbug.com/737777#c72 , the location and size of Android tab > disambiguator is not correct when --use-zoom-for-dsf is enabled. It is because > RenderViewImpl::DidTapMultipleTargets() assumes |touch_rect| is in DIPs while it > is in physical pixels when --use-zoom-for-dsf is enabled. This CL solves this > problem. > > TEST=Android Chrome with production code on NEXUS 5X, > content_browsertests RenderViewTapDisambiguationTest.CanvasSizeUseZoomForDSF > on NEXUS 5X, NEXUS 4, NEXUS 9 (w/ and w/o this change). > > Bug: 737777 > Change-Id: I64ca0b9b76fcfc3798036a80c9213973de8f3f77 > Reviewed-on: https://chromium-review.googlesource.com/898824 > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Commit-Queue: Jaebaek Seo <jaebaek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#536868} TBR=dgozman@chromium.org,jaebaek@chromium.org Change-Id: I18a8a045b179eac287aad7b4fae8f71cadbff84d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 737777 Reviewed-on: https://chromium-review.googlesource.com/919045 Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#536895} [modify] https://crrev.com/c61ef9142915213e7b8ee088f4c6b30eed745150/content/renderer/render_view_browsertest.cc [modify] https://crrev.com/c61ef9142915213e7b8ee088f4c6b30eed745150/content/renderer/render_view_impl.cc [modify] https://crrev.com/c61ef9142915213e7b8ee088f4c6b30eed745150/content/renderer/render_view_impl.h
,
Feb 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6de124adeb753f1bb2ce05a8495f817986300fa3 commit 6de124adeb753f1bb2ce05a8495f817986300fa3 Author: Jaebaek Seo <jaebaek@chromium.org> Date: Thu Feb 15 03:34:03 2018 Reland "Adjust location and size of TapDisambiguator" This is a reland of 4c50e3e13d30c93d61b28119aac333f2aafc0d8b. It is reverted as shown in crrev.com/c/920222, because of a compile error. blink::WebInputEvent::kTimeStampForTesting is moved to blink::WebInputEvent::GetStaticTimeStampForTests(). This CL fixes the compile error. TEST=content_browsertests RenderViewTapDisambiguationTest.CanvasSizeUseZoomForDSF on NEXUS 5X. Original change's description: > Adjust location and size of TapDisambiguator > > As shown in crbug.com/737777#c72 , the location and size of Android tab > disambiguator is not correct when --use-zoom-for-dsf is enabled. It is because > RenderViewImpl::DidTapMultipleTargets() assumes |touch_rect| is in DIPs while it > is in physical pixels when --use-zoom-for-dsf is enabled. This CL solves this > problem. > > TEST=Android Chrome with production code on NEXUS 5X, > content_browsertests RenderViewTapDisambiguationTest.CanvasSizeUseZoomForDSF > on NEXUS 5X, NEXUS 4, NEXUS 9 (w/ and w/o this change). > > Bug: 737777 > Change-Id: I64ca0b9b76fcfc3798036a80c9213973de8f3f77 > Reviewed-on: https://chromium-review.googlesource.com/898824 > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Commit-Queue: Jaebaek Seo <jaebaek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#536868} Bug: 737777 Change-Id: Id21123049c71d49460f1f428f6baafb9807084a4 Reviewed-on: https://chromium-review.googlesource.com/920801 Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Jaebaek Seo <jaebaek@chromium.org> Cr-Commit-Position: refs/heads/master@{#536941} [modify] https://crrev.com/6de124adeb753f1bb2ce05a8495f817986300fa3/content/renderer/render_view_browsertest.cc [modify] https://crrev.com/6de124adeb753f1bb2ce05a8495f817986300fa3/content/renderer/render_view_impl.cc [modify] https://crrev.com/6de124adeb753f1bb2ce05a8495f817986300fa3/content/renderer/render_view_impl.h
,
Feb 21 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2c98648a24e726feb8e4c6e714ec730dbd125286 commit 2c98648a24e726feb8e4c6e714ec730dbd125286 Author: Jaebaek Seo <jaebaek@chromium.org> Date: Wed Feb 21 15:29:45 2018 Change type to get scrollTop When enabling --use-zoom-for-dsf, TouchActionBrowserTest.DefaultAuto fails because document.scrollingElement.scrollTop has double type (not integer). This CL replaces ExecuteScriptAndExtractInt with ExecuteScriptAndExtractDouble when getting the scrollTop. TEST=content_browsertests TouchActionBrowserTest.DefaultAuto on NEXUS 5X Bug: 737777 Change-Id: I57a0b0e6a1a7bd78d923b47cd4640e46d8a5e4a8 Reviewed-on: https://chromium-review.googlesource.com/927881 Reviewed-by: Bo <boliu@chromium.org> Commit-Queue: Jaebaek Seo <jaebaek@chromium.org> Cr-Commit-Position: refs/heads/master@{#538114} [modify] https://crrev.com/2c98648a24e726feb8e4c6e714ec730dbd125286/content/browser/renderer_host/input/touch_action_browsertest.cc
,
Feb 21 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ffef2eddf0568e5bb29eb7594510d59ddb8167ee commit ffef2eddf0568e5bb29eb7594510d59ddb8167ee Author: Jaebaek Seo <jaebaek@chromium.org> Date: Wed Feb 21 21:54:02 2018 Disable --use-zoom-for-dsf for DomDistillerJsTest DomDistillerJsTest.RunJsTests has precision issues when enabling --use-zoom-for-dsf. As discussed in crrev.com/c/916021, we concluded that just disabling --use-zoom-for-dsf is better solution than allowing small error. TEST=components_browsertests DomDistillerJsTest.RunJsTests on NEXUS 5X Bug: 737777 Change-Id: I0b53c09b7936545f4f0ed54d55471730571b5555 Reviewed-on: https://chromium-review.googlesource.com/927614 Reviewed-by: Matthew Jones <mdjones@chromium.org> Commit-Queue: Jaebaek Seo <jaebaek@chromium.org> Cr-Commit-Position: refs/heads/master@{#538222} [modify] https://crrev.com/ffef2eddf0568e5bb29eb7594510d59ddb8167ee/components/dom_distiller/content/browser/test/dom_distiller_js_browsertest.cc
,
Feb 22 2018
A gray block is shown when scrolling down the screen after the virtual keyboard is popped up. You can reproduce this bug: 1. visit https://www.kijiji.ca/b-cars-trucks/canada/c174l0 2. click "Filter Results" (green button) 3. scroll down and find input box (e.g., Kilometers) 4. popup the virtual keyboard by touch the input box 5. scroll up See the attachment.
,
Feb 27 2018
,
Mar 2 2018
I did not know that. Thanks for reporting it!
,
Mar 2 2018
,
Mar 2 2018
,
Apr 5 2018
,
May 18 2018
Another issue: page isn't zoomed when navigate to a new site.
,
May 18 2018
,
May 18 2018
,
May 31 2018
,
Jun 8 2018
,
Jul 6
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0e87e235062e6f11c95741c612cb7642323b1f6e commit 0e87e235062e6f11c95741c612cb7642323b1f6e Author: Ella Ge <eirage@chromium.org> Date: Fri Jul 06 18:58:14 2018 content_offset should be in css pixel(dip) ContentViewCore::UpdateFrameInfo() must receive positions and sizes in CSS pixel except top_shown_pix. When --use-zoom-for-dsf is enabled, value given to ContentViewCore::UpdateFrameInfo() should be in dip. TEST= pixel_integration_test with use-zoom-for-dsf enabled. Bug: 737777 Change-Id: Ib19f76331bc46e94c99549213e7955ff263f92f6 Reviewed-on: https://chromium-review.googlesource.com/1115472 Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by: Bo <boliu@chromium.org> Reviewed-by: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#573028} [modify] https://crrev.com/0e87e235062e6f11c95741c612cb7642323b1f6e/content/browser/renderer_host/render_widget_host_view_android.cc [modify] https://crrev.com/0e87e235062e6f11c95741c612cb7642323b1f6e/ui/android/view_android.h
,
Jul 7
Not sure if this has been pointed out yet but enabling zoom for dsf seems to turn off text scaling (Settings > Accessibility). I'm using the latest Canary
,
Jul 9
I didn't notice any behavior change on text scaling by enabling zoom for dsf (and it shouldn't be). Could you please provide any example or test page?
,
Jul 31
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d0b8bbd2dbf9c06dcbbd01a4b1285cf7a1bc2ba0 commit d0b8bbd2dbf9c06dcbbd01a4b1285cf7a1bc2ba0 Author: Ella Ge <eirage@chromium.org> Date: Tue Jul 31 20:06:02 2018 Enable use-zoom-for-dsf on Android on M70 This CL makes use-zoom-for-dsf enabled by default on Android This marks Test NoResizeAfterIframeLoad disabled on Android because it's failing on Android. This also rebaseline 22 gpu_tests: they are failing on Android after enabling the flag because the new result are one pixel off the original reference image. Will test expectations in a followup CL. Bug: 737777 , 485650 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: If06cf325a831e229fd6bb1889fe1e40ed4bbe764 Reviewed-on: https://chromium-review.googlesource.com/1055812 Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: David Bokan <bokan@chromium.org> Reviewed-by: Ken Buchanan <kenrb@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#579542} [modify] https://crrev.com/d0b8bbd2dbf9c06dcbbd01a4b1285cf7a1bc2ba0/content/browser/site_per_process_browsertest.cc [modify] https://crrev.com/d0b8bbd2dbf9c06dcbbd01a4b1285cf7a1bc2ba0/content/public/common/use_zoom_for_dsf_policy.cc [modify] https://crrev.com/d0b8bbd2dbf9c06dcbbd01a4b1285cf7a1bc2ba0/content/test/gpu/gpu_tests/pixel_expectations.py [modify] https://crrev.com/d0b8bbd2dbf9c06dcbbd01a4b1285cf7a1bc2ba0/content/test/gpu/gpu_tests/pixel_test_pages.py
,
Jul 31
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2e73888372b983f4b276e95c66ff96e3d3584a72 commit 2e73888372b983f4b276e95c66ff96e3d3584a72 Author: Ella Ge <eirage@chromium.org> Date: Tue Jul 31 23:56:30 2018 FollowUp: Remove failing expectations after rebaseline This cl recovers pixel_expectations.py so that the tests are not expected to fail after rebaseline. Bug: 737777 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I3a26737dc7bb545a3009da19de3c528ea6e00b72 Reviewed-on: https://chromium-review.googlesource.com/1131634 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#579626} [modify] https://crrev.com/2e73888372b983f4b276e95c66ff96e3d3584a72/content/test/gpu/gpu_tests/pixel_expectations.py
,
Aug 1
,
Aug 5
comment 95, it just happens sometimes, and then randomly goes back to normal. It's strange and I guess it's possible it's not about zoom for DSF. There is another issue though that I think might be related to zoom for DSF, I filed it here https://bugs.chromium.org/p/chromium/issues/detail?id=871054 apologies if it turns out it's not related to zoom for dsf
,
Aug 6
,
Aug 7
,
Aug 7
,
Aug 7
,
Aug 7
,
Aug 7
,
Aug 7
,
Aug 7
,
Aug 7
,
Aug 7
,
Aug 7
,
Aug 7
,
Aug 9
,
Aug 11
Just to follow up, I have text scaling at 110% and zoom for DSF disabled and I still see the issue of some sites not having the upscaled text (for example, one Instagram post has the 110% scaled text and another post does not, for some reason) , so this isn't a zoom for dsf problem :)
,
Aug 20
,
Aug 20
,
Aug 21
,
Aug 24
,
Aug 28
,
Aug 28
,
Aug 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/14d5c4330c08ac9bcdcda7960561e3e92c135da6 commit 14d5c4330c08ac9bcdcda7960561e3e92c135da6 Author: Ella Ge <eirage@chromium.org> Date: Thu Aug 30 01:32:23 2018 turn off use-zoom-for-dsf on Android Turn off the flag on Android due to perf regression crbug/873147 and crbug/871347 TBR=avi@chromium.org (content/public) Bug: 737777 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Iac09c7c0c73c2cb42e62367c4cedeb1cead7f27c Reviewed-on: https://chromium-review.googlesource.com/1194600 Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by: David Bokan <bokan@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#587380} [modify] https://crrev.com/14d5c4330c08ac9bcdcda7960561e3e92c135da6/content/public/common/use_zoom_for_dsf_policy.cc [modify] https://crrev.com/14d5c4330c08ac9bcdcda7960561e3e92c135da6/content/test/gpu/gpu_tests/pixel_expectations.py [modify] https://crrev.com/14d5c4330c08ac9bcdcda7960561e3e92c135da6/content/test/gpu/gpu_tests/pixel_test_pages.py
,
Aug 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c7324e59c1cb003bf974011ff10a9462bb82515e commit c7324e59c1cb003bf974011ff10a9462bb82515e Author: Ella Ge <eirage@chromium.org> Date: Thu Aug 30 04:23:23 2018 Rebaseline pixel tests Bug: 737777 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ia63a2a249c99c7c82e33f18720d7ae31fcd26536 Reviewed-on: https://chromium-review.googlesource.com/1195888 Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#587440} [modify] https://crrev.com/c7324e59c1cb003bf974011ff10a9462bb82515e/content/test/gpu/gpu_tests/pixel_expectations.py
,
Aug 30
,
Sep 17
,
Sep 21
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/de46e4da83ac65a2f1979935460ed05ef8a1a04d commit de46e4da83ac65a2f1979935460ed05ef8a1a04d Author: Ella Ge <eirage@chromium.org> Date: Fri Sep 21 23:14:25 2018 re-enable use-zoom-for-dsf This CL turns on zoom-for-dsf on M71 And also fix a webview unittest that doesn't count dsf. And rebaseline pixel tests.(difference see: http://chromium-browser-gpu-tests.commondatastorage.googleapis.com/view_test_results.html?2082aa2352cae2409ea1f102c52d7daa53daa13a_android_marshmallow_arm64_rel_telemetry) Bug: 737777 TBR: avi@chromium.org (feature flag) Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I4f3c56101333a0bfdbcb353fe1841fa01a8e082a Reviewed-on: https://chromium-review.googlesource.com/1234014 Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by: Bo <boliu@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#593366} [modify] https://crrev.com/de46e4da83ac65a2f1979935460ed05ef8a1a04d/android_webview/browser/browser_view_renderer_unittest.cc [modify] https://crrev.com/de46e4da83ac65a2f1979935460ed05ef8a1a04d/content/public/common/use_zoom_for_dsf_policy.cc [modify] https://crrev.com/de46e4da83ac65a2f1979935460ed05ef8a1a04d/content/test/gpu/gpu_tests/pixel_expectations.py [modify] https://crrev.com/de46e4da83ac65a2f1979935460ed05ef8a1a04d/content/test/gpu/gpu_tests/pixel_test_pages.py
,
Sep 22
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d98e9a9b828bf78f1ad91de959f888a5425973df commit d98e9a9b828bf78f1ad91de959f888a5425973df Author: Ella Ge <eirage@chromium.org> Date: Sat Sep 22 06:01:11 2018 rebaseline pixel tests for enable zoom-for-dsf remove expectations for rebaseline Bug: 737777 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: If1ba264a039086ca91a4872519e5f34e1fae9591 Reviewed-on: https://chromium-review.googlesource.com/1234996 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#593431} [modify] https://crrev.com/d98e9a9b828bf78f1ad91de959f888a5425973df/content/test/gpu/gpu_tests/pixel_expectations.py
,
Oct 3
,
Oct 3
,
Oct 4
,
Oct 10
,
Oct 12
,
Nov 1
This is fully shipping in M-71, right? Should we mark this bug fixed to make that clear?
,
Nov 1
,
Nov 2
#131: It's in for -71, but there are still a couple blocking issues. I think we should mark this fixed after resolving those two.
,
Nov 12
marking this as Fixed as there wasn't new bug after beta for 3 weeks.
,
Nov 20
Showing comments 36 - 135
of 135
Older ›
|
||||||||||||||||||||||||||||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||||||||||||||||||||||||||||
