[Findit] Before sending notification, check if the build is still red |
||
Issue descriptionBefore sending notification to code review, check: 1. if the build is still red 2. if the failure is a new failure(within 1 day)
,
Jul 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/5e68af28770a156a8e764f197acc22391b49fce8 commit 5e68af28770a156a8e764f197acc22391b49fce8 Author: Chan <chanli@chromium.org> Date: Fri Jul 21 20:34:12 2017 [Findit] Before sending notification, check if the build is still red. I have moved the check to an early stage so that if the build has become green, we will not revert or send any notifications(not even confirmation) to code review. Bug: 737772 Change-Id: I2490af68242fa23d9fefd3b0cc5970076715be9f Reviewed-on: https://chromium-review.googlesource.com/580534 Reviewed-by: Jeffrey Li <lijeffrey@chromium.org> Commit-Queue: Chan Li <chanli@chromium.org> [modify] https://crrev.com/5e68af28770a156a8e764f197acc22391b49fce8/appengine/findit/waterfall/create_revert_cl_pipeline.py [modify] https://crrev.com/5e68af28770a156a8e764f197acc22391b49fce8/appengine/findit/waterfall/revert_and_notify_culprit_pipeline.py [modify] https://crrev.com/5e68af28770a156a8e764f197acc22391b49fce8/appengine/findit/waterfall/test/revert_and_notify_culprit_pipeline_test.py [modify] https://crrev.com/5e68af28770a156a8e764f197acc22391b49fce8/appengine/findit/waterfall/test/create_revert_cl_pipeline_test.py
,
Aug 31 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by chanli@chromium.org
, Jun 28 2017