New issue
Advanced search Search tips

Issue 737768 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Reclassify MediaLog DEBUG to be either INFO or WARNING, and document what they mean

Project Member Reported by wolenetz@chromium.org, Jun 28 2017

Issue description

Semantically and practically, there's not much difference between "DEBUG" and "INFO" MEDIA_LOG levels currently. However, having a distinct "WARNING" level can help short-cut root-causing ERRORs (such as deprecation or detected-known-issue logs).

This bug tracks:
1) Changing most of the existing DEBUG to INFO, leaving only warnings and change DEBUG to be WARNING.
2) Document each of ERROR, WARNING, and INFO MediaLog levels in the code.

(At minimum, note that ERROR log entries' content can be exposed to the web app via MediaError.message, so must not expose pointer addresses, for example.)
 
Folks on CC: WDYT?

Thanks in advance!

Comment 2 by xhw...@chromium.org, Jun 28 2017

SGTM! The new categories are also consistent with Chromium LOG levels which would simplify some code if we want to report MediaLog and DLOG together.
See https://chromium-review.googlesource.com/c/chromium/src/+/1063009.
IIUC, after that CL, what remains is splitting out existing DEBUG into either INFO or WARNING, then removing DEBUG.

Sign in to add a comment