New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 737765 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Limit number of concurrent PreCQ builds.

Project Member Reported by dgarr...@chromium.org, Jun 28 2017

Issue description

The PreCQ launcher should have a limit for how many active PreCQ builder there should be. When it reaches the limit, simply stop scheduling additional builds.

 
Cc: nxia@chromium.org
Such a limit will prevent scheduling more builds than we have builders, and so prevent what I believe to be the main cause of PRECQ_LAUNCH_TIMEOUT errors.
This would replace the current concept of MAX_LAUNCHES_PER_CYCLE_DERIVATIVE, which limits how many jobs we launch in a single PreCQ launcher iteration.

Comment 4 by nxia@chromium.org, Jun 29 2017

Another option is to only timeout the builds not in 'scheduled' status in buildbucket.

A build will be marked as 'scheduled' in buildbucket once it's scheduled by pre-cq-launcher. when a buildslave picks up the build, it will mark it as 'started', and the build will be marked as 'failure' or 'success' after completion. we can only timeout the builds which are not in 'scheduled' status which mean they have already been picked up by buildslaves. so we don't need to add more logic to setup the cycle or get current running/ideal buildslaves.
SGTM.
Labels: Hotlist-Fixit
Status: Available (was: Untriaged)
PS: We are just starting to get accurate usage metrics, and we did briefly max out our PreCQ builders during the last 12 hours.

So... solving this will probably affect users.

A secondary nice-to-have feature. When there is a backlog, don't try to schedule 'speculative' PreCQ runs.
Cc: bmgordon@chromium.org
bmgordon has been thinking about this
Components: Infra>Client>ChromeOS>CI
Components: -Infra>Client>ChromeOS

Comment 11 by nxia@chromium.org, Jun 8 2018

Cc: -nxia@chromium.org

Sign in to add a comment