New issue
Advanced search Search tips

Issue 737763 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 8
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 737090



Sign in to add a comment

Make a Previously Patched CoCreateInstance DCHECK

Project Member Reported by robliao@chromium.org, Jun 28 2017

Issue description

As a workaround for  http://crbug.com/737090 , this was made into a warning. Once 737090 is fixed, this should DCHECK.
 
Status: Fixed (was: Assigned)
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d0c60c75f187c789f4908371391acb67db86b0ec

commit d0c60c75f187c789f4908371391acb67db86b0ec
Author: Robert Liao <robliao@chromium.org>
Date: Thu Nov 30 18:45:20 2017

Make Externally Patched COM Calls Fail the ComInitCheckHook

Now that WebRTC has disabled these hooks we can fail builds that
previously patched COM. This ensures that the hook is running where
we expect it to run instead of failing silently.

BUG=  737090  

Change-Id: I28b6f8203ecff3c3f54396848a70c78a17c9055e
Reviewed-on: https://chromium-review.googlesource.com/801250
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520618}
[modify] https://crrev.com/d0c60c75f187c789f4908371391acb67db86b0ec/base/win/com_init_check_hook.cc
[modify] https://crrev.com/d0c60c75f187c789f4908371391acb67db86b0ec/base/win/com_init_check_hook_unittest.cc

Sign in to add a comment