servo v4: DUT port comes up in DFP data role |
|||||||
Issue descriptionIf the servo v4 host port is attached to a device that supports UFP/DFP (eg. kevin), we may default to DFP, which will cause USB pass-thru / USB ethernet to not function on the host. Servo should probably auto-request a role swap in this case.
,
Jun 28 2017
This looks like a separate issue, but we're also detecting Rd on both CC lines, when servo v4 is in PD_STATE_SRC_DISCONNECTED_DEBOUNCE and attached to kevin. I'm pretty sure my kevin isn't a debug accessory...
,
Jun 29 2017
This could related to the issue we are currently exploring on other type C devices. https://bugs.chromium.org/p/chromium/issues/detail?id=732519
,
Jun 29 2017
,
Jun 29 2017
Servo_v4 prefers UFP for its data role. However, the request to change data role only happens if the servo_v4 port reaches SRC_READY and the DUT port reaches SNK_READY state. Re #3, by default servo_v4 presents Rp on both CC lines so the DUT should port should go to SNK_DEBUG_ACCESSORY state, similar to what happens when suzyq is connected. But, since servo_v4 doesn't not remain in SRC_DEBUG_ACCESSORY state and instead attempts to establish a PD contract, it will send SRC CAPs. On systems I have tested with Reef or Eve, because SRC CAPS are not responded to, it goes through 2 hard reset iterations and this causes the DUT port to advance to SNK_DISCOVERY where it will respond to servo_v4 SRC CAPs and should then be able to negotiate a PD contract.
,
Jun 29 2017
I tested the data role setting recently with my Eve system and I noticed that servo_v4 DUT port was remaining in DFP data role. However, I did verify that it's sending a data role swap request to the DUT, but that request is being rejected. If I initiated the role swap request from the DUT (via the EC console) then it did swap. I'm certain that previously servo_v4 DUT port would swap from DFP to UFP once it reached SRC_READY. I don't know why I didn't see this when I tested it yesterday.
,
Jun 30 2017
I did a couple more quick tests. I found that when I connect to Electro, then the servo_v4's DR swap request message is being accepted and it swaps to UFP. But, when I do the same test on Pyro, the role swap is not successful. I will look more into this inconsistent behavior.
,
Jun 30 2017
I think our PD_STATE_SNK_ACCESSORY state is incomplete, but I'm not sure how we want to change it. The DTS source (servo v4) is sending source caps after turning on VBUS (transition to PD_STATE_SRC_STARTUP) and it expects to get back a request, otherwise it will send hard reset. Based on my reading of the spec, the DTS source is behaving correctly here. The TS sink (eg. kevin) will stay in PD_STATE_SNK_ACCESSORY, where it ignores source caps (incorrectly, I think). We should be able to handle most/all PD messages in PD_STATE_SNK_ACCESSORY, similar to PD_STATE_SNK_DISCOVERY / SNK_REQUESTED / SNK_READY. Basically, I don't think PD_STATE_SNK_ACCESSORY should even exist in our state machine (it's not a PD state, it's defined by the USB-C spec), instead it should be a modifier to those existing SNK states. Please chime in if this sounds horribly wrong.
,
Jul 4 2017
> I don't think PD_STATE_SNK_ACCESSORY should even exist in our state machine > (it's not a PD state, it's defined by the USB-C spec), instead it should be a > modifier to those existing SNK states. > > Please chime in if this sounds horribly wrong. Long time ago, I tried this on Ryu with PD_STATE_SRC_ACCESSORY, and this was nearly impossible to get it done correctly as the PD sink state machine was freaking out everywhere due to the Rd/Rd combo on the supply side. It's certainly easier with PD_STATE_SNK_ACCESSORY since the CC lines state is closer, probably worth trying to write it.
,
Sep 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/ec/+/dde1a514de4cc5a570db6a3cff4f43396e8c90f4 commit dde1a514de4cc5a570db6a3cff4f43396e8c90f4 Author: Shawn Nematbakhsh <shawnn@chromium.org> Date: Mon Sep 11 18:14:23 2017 pd: Remove support for debug accessories that provide VBUS + Rd Reworked suzy-q and suzy-qable all provide Rp, so there is no need for special detection handling in S5. Also, CONFIG_USB_PD_QUIRK_SLOW_CC_STATUS is no longer relevant, since we no longer take special action when VBUS is seen without Rp. BUG= chromium:737755 BRANCH=None TEST=On kevin, verify reworked suzy-q and suzy-qable are detected in S5. Also, verify zinger works in S5 on reef. Signed-off-by: Shawn Nematbakhsh <shawnn@chromium.org> Change-Id: I50967bd6415d964a038b2e7d134374132eda11ec Reviewed-on: https://chromium-review.googlesource.com/656067 Commit-Ready: Shawn N <shawnn@chromium.org> Tested-by: Shawn N <shawnn@chromium.org> Reviewed-by: Vincent Palatin <vpalatin@chromium.org> [modify] https://crrev.com/dde1a514de4cc5a570db6a3cff4f43396e8c90f4/board/glkrvp/board.h [modify] https://crrev.com/dde1a514de4cc5a570db6a3cff4f43396e8c90f4/board/coral/board.h [modify] https://crrev.com/dde1a514de4cc5a570db6a3cff4f43396e8c90f4/board/eve/board.h [modify] https://crrev.com/dde1a514de4cc5a570db6a3cff4f43396e8c90f4/board/poppy/board.h [modify] https://crrev.com/dde1a514de4cc5a570db6a3cff4f43396e8c90f4/common/usb_pd_protocol.c [modify] https://crrev.com/dde1a514de4cc5a570db6a3cff4f43396e8c90f4/board/reef_it8320/board.h [modify] https://crrev.com/dde1a514de4cc5a570db6a3cff4f43396e8c90f4/board/fizz/board.h [modify] https://crrev.com/dde1a514de4cc5a570db6a3cff4f43396e8c90f4/include/config.h [modify] https://crrev.com/dde1a514de4cc5a570db6a3cff4f43396e8c90f4/board/reef/board.h [modify] https://crrev.com/dde1a514de4cc5a570db6a3cff4f43396e8c90f4/board/kahlee/board.h
,
Sep 16 2017
,
Sep 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/ec/+/45f6907fb22cf244f04b842855eba5773cf27e86 commit 45f6907fb22cf244f04b842855eba5773cf27e86 Author: Shawn Nematbakhsh <shawnn@chromium.org> Date: Thu Sep 28 11:10:10 2017 pd: Remove support for debug accessories that provide VBUS + Rd Reworked suzy-q and suzy-qable all provide Rp, so there is no need for special detection handling in S5. Also, CONFIG_USB_PD_QUIRK_SLOW_CC_STATUS is no longer relevant, since we no longer take special action when VBUS is seen without Rp. BUG= chromium:737755 BRANCH=None TEST=On kevin, verify reworked suzy-q and suzy-qable are detected in S5. Also, verify zinger works in S5 on reef. Change-Id: I3712c38bf41603fef85e9f06b9c6952fd3da77c8 Signed-off-by: Duncan Laurie <dlaurie@google.com> Original-Commit-Id: dde1a514de4cc5a570db6a3cff4f43396e8c90f4 Original-Signed-off-by: Shawn Nematbakhsh <shawnn@chromium.org> Original-Change-Id: I50967bd6415d964a038b2e7d134374132eda11ec Original-Reviewed-on: https://chromium-review.googlesource.com/656067 Original-Commit-Ready: Shawn N <shawnn@chromium.org> Original-Tested-by: Shawn N <shawnn@chromium.org> Original-Reviewed-by: Vincent Palatin <vpalatin@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/690176 [modify] https://crrev.com/45f6907fb22cf244f04b842855eba5773cf27e86/board/coral/board.h [modify] https://crrev.com/45f6907fb22cf244f04b842855eba5773cf27e86/board/eve/board.h [modify] https://crrev.com/45f6907fb22cf244f04b842855eba5773cf27e86/board/poppy/board.h [modify] https://crrev.com/45f6907fb22cf244f04b842855eba5773cf27e86/common/usb_pd_protocol.c [modify] https://crrev.com/45f6907fb22cf244f04b842855eba5773cf27e86/board/reef_it8320/board.h [modify] https://crrev.com/45f6907fb22cf244f04b842855eba5773cf27e86/board/fizz/board.h [modify] https://crrev.com/45f6907fb22cf244f04b842855eba5773cf27e86/include/config.h [modify] https://crrev.com/45f6907fb22cf244f04b842855eba5773cf27e86/board/reef/board.h [modify] https://crrev.com/45f6907fb22cf244f04b842855eba5773cf27e86/board/kahlee/board.h
,
Oct 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/ec/+/1e72cc1f5719d5c5df6dbe76a8c86f60a525fe1a commit 1e72cc1f5719d5c5df6dbe76a8c86f60a525fe1a Author: Shawn Nematbakhsh <shawnn@chromium.org> Date: Thu Oct 05 17:36:14 2017 cleanup: pd: Remove CONFIG_CASE_CLOSED_DEBUG CONFIG_CASE_CLOSED_DEBUG (CCD functionality implemented by EC) is no longer used in conjunction with CONFIG_USB_POWER_DELIVERY, and the common routines are only used by one board. BUG= chromium:737755 BRANCH=None TEST=`make buildall -j` Change-Id: Idc3d2fccef6cbec2af786cef634d752a02a0e859 Signed-off-by: Shawn Nematbakhsh <shawnn@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/656315 Commit-Ready: Shawn N <shawnn@chromium.org> Tested-by: Shawn N <shawnn@chromium.org> Reviewed-by: Nick Sanders <nsanders@chromium.org> Reviewed-by: Vincent Palatin <vpalatin@chromium.org> [modify] https://crrev.com/1e72cc1f5719d5c5df6dbe76a8c86f60a525fe1a/include/console_channel.inc [modify] https://crrev.com/1e72cc1f5719d5c5df6dbe76a8c86f60a525fe1a/common/build.mk [modify] https://crrev.com/1e72cc1f5719d5c5df6dbe76a8c86f60a525fe1a/common/usb_pd_protocol.c [modify] https://crrev.com/1e72cc1f5719d5c5df6dbe76a8c86f60a525fe1a/include/case_closed_debug.h [modify] https://crrev.com/1e72cc1f5719d5c5df6dbe76a8c86f60a525fe1a/board/mn50/board.c [modify] https://crrev.com/1e72cc1f5719d5c5df6dbe76a8c86f60a525fe1a/board/mn50/board.h [delete] https://crrev.com/7dc3066837aaaa565af5df2e1433d7564d43220b/common/case_closed_debug.c [modify] https://crrev.com/1e72cc1f5719d5c5df6dbe76a8c86f60a525fe1a/include/config.h
,
Oct 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/ec/+/251212fb9dea6d95a8caa43ec9eeb210abfa2df8 commit 251212fb9dea6d95a8caa43ec9eeb210abfa2df8 Author: Shawn Nematbakhsh <shawnn@chromium.org> Date: Thu Oct 19 19:56:42 2017 pd: Remove ACCESSORY states According to the USB-C spec, when a debug accessory is identified, we may optionally establish USB PD communication over CC. Some DTS partners (eg. servo_v4) expect us to speak PD, so let's make it so. There is no need for special ACCESSORY states, these do not exist in the PD spec. BRANCH=servo BUG= chromium:737755 ,b:65837068 TEST=On scarlet, attach servo_v4 and verify scarlet charges. Also verify EC and cr50 consoles are available through servo_v4. Change-Id: I59d1ca50b4766509eccf38562cdf926578138585 Signed-off-by: Shawn Nematbakhsh <shawnn@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/693294 Commit-Ready: Shawn N <shawnn@chromium.org> Tested-by: Shawn N <shawnn@chromium.org> Reviewed-by: Vincent Palatin <vpalatin@chromium.org> [modify] https://crrev.com/251212fb9dea6d95a8caa43ec9eeb210abfa2df8/board/nefario/board.h [modify] https://crrev.com/251212fb9dea6d95a8caa43ec9eeb210abfa2df8/board/coral/board.h [modify] https://crrev.com/251212fb9dea6d95a8caa43ec9eeb210abfa2df8/board/servo_v4/board.h [modify] https://crrev.com/251212fb9dea6d95a8caa43ec9eeb210abfa2df8/board/eve/board.h [modify] https://crrev.com/251212fb9dea6d95a8caa43ec9eeb210abfa2df8/board/servo_v4/usb_pd_policy.c [modify] https://crrev.com/251212fb9dea6d95a8caa43ec9eeb210abfa2df8/include/usb_pd.h [modify] https://crrev.com/251212fb9dea6d95a8caa43ec9eeb210abfa2df8/board/poppy/board.h [modify] https://crrev.com/251212fb9dea6d95a8caa43ec9eeb210abfa2df8/common/usb_pd_protocol.c [modify] https://crrev.com/251212fb9dea6d95a8caa43ec9eeb210abfa2df8/board/reef_it8320/board.h [modify] https://crrev.com/251212fb9dea6d95a8caa43ec9eeb210abfa2df8/board/kevin/board.h [modify] https://crrev.com/251212fb9dea6d95a8caa43ec9eeb210abfa2df8/include/case_closed_debug.h [modify] https://crrev.com/251212fb9dea6d95a8caa43ec9eeb210abfa2df8/board/servo_v4/board.c [modify] https://crrev.com/251212fb9dea6d95a8caa43ec9eeb210abfa2df8/board/scarlet/board.h [modify] https://crrev.com/251212fb9dea6d95a8caa43ec9eeb210abfa2df8/board/fizz/board.h [modify] https://crrev.com/251212fb9dea6d95a8caa43ec9eeb210abfa2df8/include/config.h [modify] https://crrev.com/251212fb9dea6d95a8caa43ec9eeb210abfa2df8/board/reef/board.h [modify] https://crrev.com/251212fb9dea6d95a8caa43ec9eeb210abfa2df8/board/kahlee/board.h
,
Oct 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/ec/+/5bc215110938f5964cfec2d885274eec167506ee commit 5bc215110938f5964cfec2d885274eec167506ee Author: Shawn Nematbakhsh <shawnn@chromium.org> Date: Mon Oct 30 17:04:24 2017 cleanup: pd: Remove CONFIG_CASE_CLOSED_DEBUG CONFIG_CASE_CLOSED_DEBUG (CCD functionality implemented by EC) is no longer used in conjunction with CONFIG_USB_POWER_DELIVERY, and the common routines are only used by one board. BUG= chromium:737755 BRANCH=None TEST=`make buildall -j` Change-Id: Idc3d2fccef6cbec2af786cef634d752a02a0e859 Signed-off-by: Shawn Nematbakhsh <shawnn@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/656315 Commit-Ready: Shawn N <shawnn@chromium.org> Tested-by: Shawn N <shawnn@chromium.org> Reviewed-by: Nick Sanders <nsanders@chromium.org> Reviewed-by: Vincent Palatin <vpalatin@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/739987 [modify] https://crrev.com/5bc215110938f5964cfec2d885274eec167506ee/include/console_channel.inc [modify] https://crrev.com/5bc215110938f5964cfec2d885274eec167506ee/common/build.mk [modify] https://crrev.com/5bc215110938f5964cfec2d885274eec167506ee/include/config.h [modify] https://crrev.com/5bc215110938f5964cfec2d885274eec167506ee/include/case_closed_debug.h [delete] https://crrev.com/d018798cedf2de0d10fbb660ff447db5afdc1cfe/common/case_closed_debug.c [modify] https://crrev.com/5bc215110938f5964cfec2d885274eec167506ee/common/usb_pd_protocol.c
,
Oct 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/ec/+/7fa6d703897701d76e4ca67b5f8299378527c226 commit 7fa6d703897701d76e4ca67b5f8299378527c226 Author: Shawn Nematbakhsh <shawnn@chromium.org> Date: Mon Oct 30 17:04:46 2017 pd: Remove support for debug accessories that provide VBUS + Rd Reworked suzy-q and suzy-qable all provide Rp, so there is no need for special detection handling in S5. Also, CONFIG_USB_PD_QUIRK_SLOW_CC_STATUS is no longer relevant, since we no longer take special action when VBUS is seen without Rp. BUG= chromium:737755 BRANCH=None TEST=On kevin, verify reworked suzy-q and suzy-qable are detected in S5. Also, verify zinger works in S5 on reef. Signed-off-by: Shawn Nematbakhsh <shawnn@chromium.org> Change-Id: I50967bd6415d964a038b2e7d134374132eda11ec Reviewed-on: https://chromium-review.googlesource.com/656067 Commit-Ready: Shawn N <shawnn@chromium.org> Tested-by: Shawn N <shawnn@chromium.org> Reviewed-by: Vincent Palatin <vpalatin@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/739993 [modify] https://crrev.com/7fa6d703897701d76e4ca67b5f8299378527c226/board/pyro/board.h [modify] https://crrev.com/7fa6d703897701d76e4ca67b5f8299378527c226/board/eve/board.h [modify] https://crrev.com/7fa6d703897701d76e4ca67b5f8299378527c226/board/snappy/board.h [modify] https://crrev.com/7fa6d703897701d76e4ca67b5f8299378527c226/include/config.h [modify] https://crrev.com/7fa6d703897701d76e4ca67b5f8299378527c226/common/usb_pd_protocol.c [modify] https://crrev.com/7fa6d703897701d76e4ca67b5f8299378527c226/board/reef/board.h
,
Oct 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/ec/+/0efc14b3c037397058cb1fd2b2abe1073904470b commit 0efc14b3c037397058cb1fd2b2abe1073904470b Author: Shawn Nematbakhsh <shawnn@chromium.org> Date: Mon Oct 30 17:04:51 2017 pd: Remove ACCESSORY states According to the USB-C spec, when a debug accessory is identified, we may optionally establish USB PD communication over CC. Some DTS partners (eg. servo_v4) expect us to speak PD, so let's make it so. There is no need for special ACCESSORY states, these do not exist in the PD spec. BRANCH=servo BUG= chromium:737755 ,b:65837068 TEST=On scarlet, attach servo_v4 and verify scarlet charges. Also verify EC and cr50 consoles are available through servo_v4. Change-Id: I59d1ca50b4766509eccf38562cdf926578138585 Signed-off-by: Shawn Nematbakhsh <shawnn@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/693294 Commit-Ready: Shawn N <shawnn@chromium.org> Tested-by: Shawn N <shawnn@chromium.org> Reviewed-by: Vincent Palatin <vpalatin@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/739995 [modify] https://crrev.com/0efc14b3c037397058cb1fd2b2abe1073904470b/board/pyro/board.h [modify] https://crrev.com/0efc14b3c037397058cb1fd2b2abe1073904470b/board/eve/board.h [modify] https://crrev.com/0efc14b3c037397058cb1fd2b2abe1073904470b/include/usb_pd.h [modify] https://crrev.com/0efc14b3c037397058cb1fd2b2abe1073904470b/board/snappy/board.h [modify] https://crrev.com/0efc14b3c037397058cb1fd2b2abe1073904470b/common/usb_pd_protocol.c [modify] https://crrev.com/0efc14b3c037397058cb1fd2b2abe1073904470b/board/kevin/board.h [modify] https://crrev.com/0efc14b3c037397058cb1fd2b2abe1073904470b/include/case_closed_debug.h [modify] https://crrev.com/0efc14b3c037397058cb1fd2b2abe1073904470b/board/servo_v4/board.c [modify] https://crrev.com/0efc14b3c037397058cb1fd2b2abe1073904470b/board/servo_v4/usb_pd_policy.c [modify] https://crrev.com/0efc14b3c037397058cb1fd2b2abe1073904470b/include/config.h [modify] https://crrev.com/0efc14b3c037397058cb1fd2b2abe1073904470b/board/reef/board.h [modify] https://crrev.com/0efc14b3c037397058cb1fd2b2abe1073904470b/board/servo_v4/board.h
,
Nov 30 2017
Shawn, is this fixed? (I got here via crbug.com/716211)
,
Nov 30 2017
This is fixed in TOT EC FW (ACCESSORY states no longer exist, PD contract will always be established with DTS partner), but there are still legacy devices which may be broken. b/69119387 (gale) is one example.
,
Feb 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/ec/+/f2cf8bdca39e27d35350492688fab9587ca12ae5 commit f2cf8bdca39e27d35350492688fab9587ca12ae5 Author: Shawn Nematbakhsh <shawnn@chromium.org> Date: Mon Feb 12 19:49:23 2018 cleanup: pd: Remove CONFIG_CASE_CLOSED_DEBUG CONFIG_CASE_CLOSED_DEBUG (CCD functionality implemented by EC) is no longer used in conjunction with CONFIG_USB_POWER_DELIVERY, and the common routines are only used by one board. BUG= chromium:737755 BRANCH=None TEST=`make buildall -j` Change-Id: I19a86afc99907502678d01cf1b6c07604803b7a9 Signed-off-by: Duncan Laurie <dlaurie@google.com> Original-Commit-Id: 1e72cc1f5719d5c5df6dbe76a8c86f60a525fe1a Original-Change-Id: Idc3d2fccef6cbec2af786cef634d752a02a0e859 Original-Signed-off-by: Shawn Nematbakhsh <shawnn@chromium.org> Original-Reviewed-on: https://chromium-review.googlesource.com/656315 Original-Commit-Ready: Shawn N <shawnn@chromium.org> Original-Tested-by: Shawn N <shawnn@chromium.org> Original-Reviewed-by: Nick Sanders <nsanders@chromium.org> Original-Reviewed-by: Vincent Palatin <vpalatin@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/914646 [modify] https://crrev.com/f2cf8bdca39e27d35350492688fab9587ca12ae5/common/build.mk [modify] https://crrev.com/f2cf8bdca39e27d35350492688fab9587ca12ae5/include/config.h [modify] https://crrev.com/f2cf8bdca39e27d35350492688fab9587ca12ae5/include/case_closed_debug.h [modify] https://crrev.com/f2cf8bdca39e27d35350492688fab9587ca12ae5/board/mn50/board.h [delete] https://crrev.com/596aee9fcdef1bfe46eb1bb9605a175a1a93665f/common/case_closed_debug.c [modify] https://crrev.com/f2cf8bdca39e27d35350492688fab9587ca12ae5/common/usb_pd_protocol.c
,
Feb 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/ec/+/288bcacfb48934a3646e181bf7d80e03f2cff39f commit 288bcacfb48934a3646e181bf7d80e03f2cff39f Author: Shawn Nematbakhsh <shawnn@chromium.org> Date: Mon Feb 12 19:49:24 2018 pd: Remove ACCESSORY states According to the USB-C spec, when a debug accessory is identified, we may optionally establish USB PD communication over CC. Some DTS partners (eg. servo_v4) expect us to speak PD, so let's make it so. There is no need for special ACCESSORY states, these do not exist in the PD spec. BRANCH=servo BUG= chromium:737755 ,b:65837068 TEST=On scarlet, attach servo_v4 and verify scarlet charges. Also verify EC and cr50 consoles are available through servo_v4. Change-Id: I84e7b1664a7503a889739b8872d9a2410c9ba5c5 Signed-off-by: Duncan Laurie <dlaurie@google.com> Original-Commit-Id: 251212fb9dea6d95a8caa43ec9eeb210abfa2df8 Original-Change-Id: I59d1ca50b4766509eccf38562cdf926578138585 Original-Signed-off-by: Shawn Nematbakhsh <shawnn@chromium.org> Original-Reviewed-on: https://chromium-review.googlesource.com/693294 Original-Commit-Ready: Shawn N <shawnn@chromium.org> Original-Tested-by: Shawn N <shawnn@chromium.org> Original-Reviewed-by: Vincent Palatin <vpalatin@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/914647 [modify] https://crrev.com/288bcacfb48934a3646e181bf7d80e03f2cff39f/board/coral/board.h [modify] https://crrev.com/288bcacfb48934a3646e181bf7d80e03f2cff39f/board/eve/board.h [modify] https://crrev.com/288bcacfb48934a3646e181bf7d80e03f2cff39f/include/usb_pd.h [modify] https://crrev.com/288bcacfb48934a3646e181bf7d80e03f2cff39f/board/poppy/board.h [modify] https://crrev.com/288bcacfb48934a3646e181bf7d80e03f2cff39f/common/usb_pd_protocol.c [modify] https://crrev.com/288bcacfb48934a3646e181bf7d80e03f2cff39f/board/reef_it8320/board.h [modify] https://crrev.com/288bcacfb48934a3646e181bf7d80e03f2cff39f/board/kevin/board.h [modify] https://crrev.com/288bcacfb48934a3646e181bf7d80e03f2cff39f/include/case_closed_debug.h [modify] https://crrev.com/288bcacfb48934a3646e181bf7d80e03f2cff39f/board/servo_v4/usb_pd_policy.c [modify] https://crrev.com/288bcacfb48934a3646e181bf7d80e03f2cff39f/include/config.h [modify] https://crrev.com/288bcacfb48934a3646e181bf7d80e03f2cff39f/board/reef/board.h [modify] https://crrev.com/288bcacfb48934a3646e181bf7d80e03f2cff39f/board/kahlee/board.h |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by sha...@chromium.org
, Jun 28 2017