New issue
Advanced search Search tips

Issue 737748 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

[Workspace] Browser crashes when devtools try to search across files

Project Member Reported by lushnikov@chromium.org, Jun 28 2017

Issue description

Chrome Version       : 61.0.3144.0
OS Version: Linux

What steps will reproduce the problem?
1. Open devtools
2. Drop some folders in the workspace
3. Try to search across files ("Ctrl-Shift-F")

I'd expect: Search works.

In fact: Browser crashes.

(chrome:26098): LIBDBUSMENU-GLIB-WARNING **: Unable to get session bus: Unknown or unsupported transport 'disabled' for address 'disabled:'
Received signal 7 <unknown> 000000000000
#0 0x7fc11e19f637 base::debug::StackTrace::StackTrace()
#1 0x7fc11e19f1af base::debug::(anonymous namespace)::StackDumpSignalHandler()
#2 0x7fc11e2df330 <unknown>
#3 0x7fc11e261172 (anonymous namespace)::do_malloc()
#4 0x7fc11e26eec9 tc_malloc
#5 0x7fc11e254a6e operator new()
#6 0x559afcd25e0b DevToolsFileSystemIndexer::FileSystemIndexingJob::FinishFileIndexing()
#7 0x559afcd26100 DevToolsFileSystemIndexer::FileSystemIndexingJob::ReadFromFile()
#8 0x7fc11e19ff2b base::debug::TaskAnnotator::RunTask()
#9 0x7fc11e2104d4 base::internal::TaskTracker::PerformRunTask()
#10 0x7fc11e210a70 base::internal::TaskTrackerPosix::PerformRunTask()
#11 0x7fc11e20ffec base::internal::TaskTracker::RunNextTask()
#12 0x7fc11e20c2a9 base::internal::SchedulerWorker::Thread::ThreadMain()
#13 0x7fc11e21b383 base::(anonymous namespace)::ThreadFunc()
#14 0x7fc11e2d7184 start_thread
#15 0x7fc113181bed clone
  r8: 000033e485fd7d80  r9: 00000000000000a6 r10: 000033e4875f8da8 r11: 00007fc11320f0f0
 r12: 0000000000000118 r13: 000000000000008c r14: 000033e4836e9b90 r15: 000033e4870986c0
  di: 0000000000000118  si: 0000000000000011  bp: ffedffec01f80ede  bx: 00000003fe08f12f
  dx: 0000000000000000  ax: 0000000000000033  cx: 0000000000000005  sp: 00007fc1016aa0b0
  ip: 00007fc11e261172 efl: 0000000000010217 cgf: 0000000000000033 erf: 0000000000000000
 trp: 000000000000000c msk: 0000000000000000 cr2: 0000000000000000
[end of stack trace]
Calling _exit(1). Core file will not be generated.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f9e21f7d006de6ca4c26b3a1e97c65380d36cc62

commit f9e21f7d006de6ca4c26b3a1e97c65380d36cc62
Author: Andrey Kosyakov <caseq@chromium.org>
Date: Thu Jul 06 17:38:19 2017

Fix DCHECKs and a crash in DevToolsFileSystemIndexer

- make FileSystemIndexingJob RefCountedThreadSafe
- add missing static on the LazyTaskRunner;
- post task rather than call when proceeding to next file;
- add tests.

Bug:  737748 
Change-Id: I28a63693629c087781fd6dc031ae202c236fd975
Reviewed-on: https://chromium-review.googlesource.com/553958
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484654}
[modify] https://crrev.com/f9e21f7d006de6ca4c26b3a1e97c65380d36cc62/chrome/browser/devtools/devtools_file_system_indexer.cc
[modify] https://crrev.com/f9e21f7d006de6ca4c26b3a1e97c65380d36cc62/chrome/browser/devtools/devtools_file_system_indexer.h
[add] https://crrev.com/f9e21f7d006de6ca4c26b3a1e97c65380d36cc62/chrome/browser/devtools/devtools_file_system_indexer_unittest.cc
[modify] https://crrev.com/f9e21f7d006de6ca4c26b3a1e97c65380d36cc62/chrome/test/BUILD.gn
[add] https://crrev.com/f9e21f7d006de6ca4c26b3a1e97c65380d36cc62/chrome/test/data/devtools/indexer/hello_world.c
[add] https://crrev.com/f9e21f7d006de6ca4c26b3a1e97c65380d36cc62/chrome/test/data/devtools/indexer/hello_world.html
[add] https://crrev.com/f9e21f7d006de6ca4c26b3a1e97c65380d36cc62/chrome/test/data/devtools/indexer/hello_world.js

Project Member

Comment 2 by sheriffbot@chromium.org, Jul 13 2017

Pri-0 bugs are critical regressions or serious emergencies, and this bug has not been updated in three days. Could you please provide an update, or adjust the priority to a more appropriate level if applicable?

If a fix is in active development, please set the status to Started.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 3 by caseq@chromium.org, Jul 13 2017

Labels: -OS-Linux -Pri-0 OS-All Pri-1
Status: Fixed (was: Assigned)

Sign in to add a comment