Issue metadata
Sign in to add a comment
|
Enable Auotmated Accessibility Tests on MD Pages |
||||||||||||||||||
Issue descriptionWe had automated a11y audits enabled in browser tests. As we moved forward with mocha + polymer, the way we ran tests didn't work well anymore. This issue will track work related to re-enabling a11y audits in our tests. Design doc: go/a11y-chrome-settings-design ⛆ |
|
|
,
Jul 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3a71d24d73db20f5861c0bb7e65a5eda341d35ee commit 3a71d24d73db20f5861c0bb7e65a5eda341d35ee Author: Tina Quach <quacht@google.com> Date: Tue Jul 18 18:18:41 2017 [MD Settings] Fixed accessibility issues in password section. Specify labels that are referenced using the aria-labelledby attribute to passwords section's searchInputs and passwords. Remove the for attribute, not needed since we are using aria-labelledby instead. Bug: 737739 Change-Id: Ibdc7d0752d2e1972c8692ca743e39ababc24f868 Reviewed-on: https://chromium-review.googlesource.com/568240 Reviewed-by: Hector Carmona <hcarmona@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Tina Quach <quacht@google.com> Cr-Commit-Position: refs/heads/master@{#487530} [modify] https://crrev.com/3a71d24d73db20f5861c0bb7e65a5eda341d35ee/chrome/browser/resources/settings/passwords_and_forms_page/password_list_item.html [modify] https://crrev.com/3a71d24d73db20f5861c0bb7e65a5eda341d35ee/chrome/browser/resources/settings/settings_page/settings_subpage_search.html [modify] https://crrev.com/3a71d24d73db20f5861c0bb7e65a5eda341d35ee/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.html
,
Jul 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/41a4e644696cbf54dde18d513274adcfca52a583 commit 41a4e644696cbf54dde18d513274adcfca52a583 Author: Tina Quach <quacht@google.com> Date: Sat Jul 22 03:47:07 2017 Add accessibility tests for passwords section of Chrome Settings. This change includes setting up the GTest and Mocha-based a11y testing framework for Chrome WebUI by defining an accessibility_browsertest.js file for a11y test fixtures and including this file in the BUILD.gn. The passwords section now fires an event when the settings section has expanded--an event that is responded to in the added a11y test. Bug: 737739 Change-Id: I54572d16e4d6e6749a20f82b557c2804bdd2f574 Reviewed-on: https://chromium-review.googlesource.com/567769 Commit-Queue: Tina Quach <quacht@google.com> Reviewed-by: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#488850} [modify] https://crrev.com/41a4e644696cbf54dde18d513274adcfca52a583/chrome/browser/resources/settings/settings_page/settings_section.js [modify] https://crrev.com/41a4e644696cbf54dde18d513274adcfca52a583/chrome/test/data/webui/BUILD.gn [add] https://crrev.com/41a4e644696cbf54dde18d513274adcfca52a583/chrome/test/data/webui/settings/accessibility_browsertest.js [add] https://crrev.com/41a4e644696cbf54dde18d513274adcfca52a583/chrome/test/data/webui/settings/passwords_a11y_test.js
,
Jul 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ba2888fc2b34d60a244ce4d4e238d304ef429db5 commit ba2888fc2b34d60a244ce4d4e238d304ef429db5 Author: Tina Quach <quacht@google.com> Date: Sat Jul 22 19:00:13 2017 Revert "Add accessibility tests for passwords section of Chrome Settings." This reverts commit 41a4e644696cbf54dde18d513274adcfca52a583. Reason for revert: Waiting on additional LGTM Original change's description: > Add accessibility tests for passwords section of Chrome Settings. > > This change includes setting up the GTest and Mocha-based a11y testing framework for Chrome WebUI > by defining an accessibility_browsertest.js file for a11y test fixtures and including this file in the BUILD.gn. > > The passwords section now fires an event when the settings section has expanded--an event that is responded to in > the added a11y test. > > Bug: 737739 > Change-Id: I54572d16e4d6e6749a20f82b557c2804bdd2f574 > Reviewed-on: https://chromium-review.googlesource.com/567769 > Commit-Queue: Tina Quach <quacht@google.com> > Reviewed-by: Tommy Li <tommycli@chromium.org> > Cr-Commit-Position: refs/heads/master@{#488850} TBR=aboxhall@chromium.org,tommycli@chromium.org,hcarmona@chromium.org,quacht@google.com Change-Id: I3cafc236e259490f0e1d0a08cea15e82012eb747 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 737739 Reviewed-on: https://chromium-review.googlesource.com/582472 Reviewed-by: Hector Carmona <hcarmona@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#488862} [modify] https://crrev.com/ba2888fc2b34d60a244ce4d4e238d304ef429db5/chrome/browser/resources/settings/settings_page/settings_section.js [modify] https://crrev.com/ba2888fc2b34d60a244ce4d4e238d304ef429db5/chrome/test/data/webui/BUILD.gn [delete] https://crrev.com/941dae278d7b0dfd369cb0168569665601d752ed/chrome/test/data/webui/settings/accessibility_browsertest.js [delete] https://crrev.com/941dae278d7b0dfd369cb0168569665601d752ed/chrome/test/data/webui/settings/passwords_a11y_test.js
,
Jul 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/48bcb0c6f02caf8d0a714745d4e94d61bc82c0ad commit 48bcb0c6f02caf8d0a714745d4e94d61bc82c0ad Author: Tina Quach <quacht@google.com> Date: Mon Jul 24 23:44:09 2017 [MD Settings] Fixed accessibility issue in chrome://settings/help The page uses a settings-section element without a page title, resulting in an empty header that violates the rule that headings have discernible text. This changes makes the h2 element aria-hidden so that visually the page stays the same, but the empty element can be ignored by the screen reader. Bug: 737739 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ia8e975359ce5638514b37fb4ba82731f28fa1d17 Reviewed-on: https://chromium-review.googlesource.com/581740 Commit-Queue: Tina Quach <quacht@google.com> Reviewed-by: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#489144} [modify] https://crrev.com/48bcb0c6f02caf8d0a714745d4e94d61bc82c0ad/chrome/browser/resources/settings/settings_page/settings_section.html [modify] https://crrev.com/48bcb0c6f02caf8d0a714745d4e94d61bc82c0ad/chrome/browser/resources/settings/settings_page/settings_section.js
,
Jul 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5f0e6d474d24c14f071b97c6dc07137819e12320 commit 5f0e6d474d24c14f071b97c6dc07137819e12320 Author: Tina Quach <quacht@google.com> Date: Tue Jul 25 16:33:38 2017 Update axe-core to have updates from the shadow DOM branch. Over the last few weeks, the axe-core team has been making many additions to shadow DOM support, useful for testing Chrome Settings. Bug: 737739 Change-Id: Ia736ba14387b19b00dc142854ab4b15c330a2fc2 Reviewed-on: https://chromium-review.googlesource.com/583769 Reviewed-by: Tommy Li <tommycli@chromium.org> Reviewed-by: Hector Carmona <hcarmona@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#489330} [modify] https://crrev.com/5f0e6d474d24c14f071b97c6dc07137819e12320/third_party/axe-core/README.chromium [modify] https://crrev.com/5f0e6d474d24c14f071b97c6dc07137819e12320/third_party/axe-core/axe.js [modify] https://crrev.com/5f0e6d474d24c14f071b97c6dc07137819e12320/third_party/axe-core/axe.min.js
,
Jul 25 2017
,
Jul 25 2017
,
Jul 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9c0b1bb3fea8ef2a24480d554555d83a7d387978 commit 9c0b1bb3fea8ef2a24480d554555d83a7d387978 Author: Tina Quach <quacht@google.com> Date: Wed Jul 26 01:42:24 2017 Add accessibility tests for passwords section of Chrome Settings. This change includes setting up the GTest and Mocha-based a11y testing framework for Chrome WebUI by defining an accessibility_browsertest.js file for a11y test fixtures and including this file in the BUILD.gn. The passwords section now fires an event when the settings section has expanded--an event that is responded to in the added a11y test. Bug: 737739 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:linux_site_isolation Change-Id: I5eb85b3c1622cfc822dee33d9f6283f87f241201 Reviewed-on: https://chromium-review.googlesource.com/583445 Commit-Queue: Tina Quach <quacht@google.com> Reviewed-by: Hector Carmona <hcarmona@chromium.org> Reviewed-by: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#489520} [modify] https://crrev.com/9c0b1bb3fea8ef2a24480d554555d83a7d387978/chrome/browser/resources/settings/settings_page/settings_section.js [modify] https://crrev.com/9c0b1bb3fea8ef2a24480d554555d83a7d387978/chrome/test/data/webui/BUILD.gn [add] https://crrev.com/9c0b1bb3fea8ef2a24480d554555d83a7d387978/chrome/test/data/webui/settings/accessibility_browsertest.js [add] https://crrev.com/9c0b1bb3fea8ef2a24480d554555d83a7d387978/chrome/test/data/webui/settings/passwords_a11y_test.js
,
Jul 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d1c6f933beebe20d6afce1cc25122164d28aeb1c commit d1c6f933beebe20d6afce1cc25122164d28aeb1c Author: Yuki Shiino <yukishiino@chromium.org> Date: Wed Jul 26 09:11:41 2017 Revert "Add accessibility tests for passwords section of Chrome Settings." This reverts commit 9c0b1bb3fea8ef2a24480d554555d83a7d387978. Reason for revert: This seems like causing failures on Linux Tests (dbg) and (dbg) (32). Original change's description: > Add accessibility tests for passwords section of Chrome Settings. > > This change includes setting up the GTest and Mocha-based a11y testing framework for Chrome WebUI > by defining an accessibility_browsertest.js file for a11y test fixtures and including this file in the BUILD.gn. > > The passwords section now fires an event when the settings section has expanded--an event that is responded to in > the added a11y test. > > Bug: 737739 > Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:linux_site_isolation > Change-Id: I5eb85b3c1622cfc822dee33d9f6283f87f241201 > Reviewed-on: https://chromium-review.googlesource.com/583445 > Commit-Queue: Tina Quach <quacht@google.com> > Reviewed-by: Hector Carmona <hcarmona@chromium.org> > Reviewed-by: Tommy Li <tommycli@chromium.org> > Cr-Commit-Position: refs/heads/master@{#489520} TBR=aboxhall@chromium.org,tommycli@chromium.org,hcarmona@chromium.org,quacht@google.com Change-Id: Id2dcdb60a0356a8f56ec575f21a715748ec3f664 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 737739, 748994 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:linux_site_isolation Reviewed-on: https://chromium-review.googlesource.com/586087 Reviewed-by: Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#489569} [modify] https://crrev.com/d1c6f933beebe20d6afce1cc25122164d28aeb1c/chrome/browser/resources/settings/settings_page/settings_section.js [modify] https://crrev.com/d1c6f933beebe20d6afce1cc25122164d28aeb1c/chrome/test/data/webui/BUILD.gn [delete] https://crrev.com/983299c943a4ba6eec819c91ff6f6b429df4e90a/chrome/test/data/webui/settings/accessibility_browsertest.js [delete] https://crrev.com/983299c943a4ba6eec819c91ff6f6b429df4e90a/chrome/test/data/webui/settings/passwords_a11y_test.js
,
Jul 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0d3384ab7c68dc1623fd864a9a58d00b88732fdd commit 0d3384ab7c68dc1623fd864a9a58d00b88732fdd Author: Pavel Kalinnikov <pkalinnikov@chromium.org> Date: Wed Jul 26 09:32:19 2017 Revert "Add accessibility tests for passwords section of Chrome Settings." This reverts commit 9c0b1bb3fea8ef2a24480d554555d83a7d387978. Reason for revert: SettingsAccessibilityTest.All fails consistently in debug mode (Linux, Win7, Linux ChromiumOS). E.g.: https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/61856 Original change's description: > Add accessibility tests for passwords section of Chrome Settings. > > This change includes setting up the GTest and Mocha-based a11y testing framework for Chrome WebUI > by defining an accessibility_browsertest.js file for a11y test fixtures and including this file in the BUILD.gn. > > The passwords section now fires an event when the settings section has expanded--an event that is responded to in > the added a11y test. > > Bug: 737739 > Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:linux_site_isolation > Change-Id: I5eb85b3c1622cfc822dee33d9f6283f87f241201 > Reviewed-on: https://chromium-review.googlesource.com/583445 > Commit-Queue: Tina Quach <quacht@google.com> > Reviewed-by: Hector Carmona <hcarmona@chromium.org> > Reviewed-by: Tommy Li <tommycli@chromium.org> > Cr-Commit-Position: refs/heads/master@{#489520} TBR=aboxhall@chromium.org,tommycli@chromium.org,hcarmona@chromium.org,quacht@google.com Change-Id: I5d6f821756af8f11e5e786d06b28e64458e0c945 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 737739 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:linux_site_isolation Reviewed-on: https://chromium-review.googlesource.com/586148 Reviewed-by: Pavel Kalinnikov <pkalinnikov@chromium.org> Commit-Queue: Pavel Kalinnikov <pkalinnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#489570}
,
Jul 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/099c1190811a71b20162df04a53368b3d2a7f0ef commit 099c1190811a71b20162df04a53368b3d2a7f0ef Author: Tina Quach <quacht@google.com> Date: Fri Jul 28 01:47:17 2017 Add accessibility tests for passwords section of Chrome Settings. Set up the GTest and Mocha-based a11y testing framework for Chrome WebUI by defining an accessibility_browsertest.js file for a11y test fixtures and including this file in the BUILD.gn. The passwords section now fires an event when the settings section has expanded--an event that is responded to in the added a11y test. The accessibility tests are only defined in normal mode because they timeout in debug mode. Bug: 737739 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I43cb3b4f8d897e82292c1cddcae50ffc2fb83912 Reviewed-on: https://chromium-review.googlesource.com/589696 Commit-Queue: Tina Quach <quacht@google.com> Reviewed-by: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#490192} [modify] https://crrev.com/099c1190811a71b20162df04a53368b3d2a7f0ef/chrome/browser/resources/settings/settings_page/settings_section.js [modify] https://crrev.com/099c1190811a71b20162df04a53368b3d2a7f0ef/chrome/test/data/webui/BUILD.gn [add] https://crrev.com/099c1190811a71b20162df04a53368b3d2a7f0ef/chrome/test/data/webui/settings/accessibility_browsertest.js [add] https://crrev.com/099c1190811a71b20162df04a53368b3d2a7f0ef/chrome/test/data/webui/settings/passwords_a11y_test.js
,
Jul 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6280c12791637f0daeb563d2636eb3a590045720 commit 6280c12791637f0daeb563d2636eb3a590045720 Author: Tina Quach <quacht@google.com> Date: Fri Jul 28 01:52:53 2017 MD Settings a11y: Initialize controlled-radio-buttons aria-checked. Before this change, the unselected controlled-radio-buttons would not have their aria-checked attributes set until after they had been selected at least once. Bug: 737739 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I433f3fb0517bf530edefee74e5107bf7466fddbe Reviewed-on: https://chromium-review.googlesource.com/585642 Reviewed-by: Hector Carmona <hcarmona@chromium.org> Commit-Queue: Tina Quach <quacht@google.com> Cr-Commit-Position: refs/heads/master@{#490198} [modify] https://crrev.com/6280c12791637f0daeb563d2636eb3a590045720/chrome/browser/resources/settings/controls/controlled_radio_button.js
,
Jul 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a4bce1abf6150a5f5fc35846931608610a64c964 commit a4bce1abf6150a5f5fc35846931608610a64c964 Author: meade_UTC10 <meade@chromium.org> Date: Fri Jul 28 03:55:43 2017 Revert "Add accessibility tests for passwords section of Chrome Settings." This reverts commit 099c1190811a71b20162df04a53368b3d2a7f0ef. Reason for revert: Seems to cause failure in browser_tests SettingsAccessibilityTest.All. See http://crbug.com/749943 Original change's description: > Add accessibility tests for passwords section of Chrome Settings. > > Set up the GTest and Mocha-based a11y testing framework for Chrome WebUI > by defining an accessibility_browsertest.js file for a11y test fixtures > and including this file in the BUILD.gn. > > The passwords section now fires an event when the settings section has > expanded--an event that is responded to in the added a11y test. > > The accessibility tests are only defined in normal mode because they > timeout in debug mode. > > Bug: 737739 > Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation > Change-Id: I43cb3b4f8d897e82292c1cddcae50ffc2fb83912 > Reviewed-on: https://chromium-review.googlesource.com/589696 > Commit-Queue: Tina Quach <quacht@google.com> > Reviewed-by: Hector Carmona <hcarmona@chromium.org> > Cr-Commit-Position: refs/heads/master@{#490192} TBR=tommycli@chromium.org,hcarmona@chromium.org,quacht@google.com Change-Id: I610728997486ece8dec0335239d0593bd70d3684 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 737739, 749943 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/590911 Reviewed-by: meade_UTC10 <meade@chromium.org> Commit-Queue: meade_UTC10 <meade@chromium.org> Cr-Commit-Position: refs/heads/master@{#490250} [modify] https://crrev.com/a4bce1abf6150a5f5fc35846931608610a64c964/chrome/browser/resources/settings/settings_page/settings_section.js [modify] https://crrev.com/a4bce1abf6150a5f5fc35846931608610a64c964/chrome/test/data/webui/BUILD.gn [delete] https://crrev.com/fd7957902206f5958800cbed6203ba8b9a01dd81/chrome/test/data/webui/settings/accessibility_browsertest.js [delete] https://crrev.com/fd7957902206f5958800cbed6203ba8b9a01dd81/chrome/test/data/webui/settings/passwords_a11y_test.js
,
Aug 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6829a5b8f05dcfd00ba29f323ef73631472dd0bd commit 6829a5b8f05dcfd00ba29f323ef73631472dd0bd Author: Tina Quach <quacht@google.com> Date: Wed Aug 02 17:06:30 2017 Add accessibility tests for passwords section of Chrome Settings. Set up the GTest and Mocha-based a11y testing framework for Chrome WebUI by defining an accessibility_browsertest.js file for a11y test fixtures and including this file in the BUILD.gn. The passwords section now fires an event when the settings section has expanded--an event that is responded to in the added a11y test. The tests are disabled in debug mode and memory sanitizer mode due to timeout. Bug: 737739 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I8715e83778409802849db38d90fef387db203f9b Reviewed-on: https://chromium-review.googlesource.com/592156 Commit-Queue: Tina Quach <quacht@google.com> Reviewed-by: Hector Carmona <hcarmona@chromium.org> Reviewed-by: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#491409} [modify] https://crrev.com/6829a5b8f05dcfd00ba29f323ef73631472dd0bd/chrome/browser/resources/settings/settings_page/settings_section.js [modify] https://crrev.com/6829a5b8f05dcfd00ba29f323ef73631472dd0bd/chrome/test/data/webui/BUILD.gn [add] https://crrev.com/6829a5b8f05dcfd00ba29f323ef73631472dd0bd/chrome/test/data/webui/settings/accessibility_browsertest.js [add] https://crrev.com/6829a5b8f05dcfd00ba29f323ef73631472dd0bd/chrome/test/data/webui/settings/passwords_a11y_test.js
,
Aug 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a708eb2ef6b2bccc5975b1f1bf6673ee39113c5f commit a708eb2ef6b2bccc5975b1f1bf6673ee39113c5f Author: Luna Lu <loonybear@chromium.org> Date: Wed Aug 02 18:21:14 2017 Revert "Add accessibility tests for passwords section of Chrome Settings." This reverts commit 6829a5b8f05dcfd00ba29f323ef73631472dd0bd. Reason for revert: Seems to cause failure in browser_tests SettingsAccessibilityTest.All. See http://crbug.com/749943 Original change's description: > Add accessibility tests for passwords section of Chrome Settings. > > Set up the GTest and Mocha-based a11y testing framework for Chrome WebUI > by defining an accessibility_browsertest.js file for a11y test fixtures > and including this file in the BUILD.gn. > > The passwords section now fires an event when the settings section has > expanded--an event that is responded to in the added a11y test. > > The tests are disabled in debug mode and memory sanitizer mode due to > timeout. > > Bug: 737739 > Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation > Change-Id: I8715e83778409802849db38d90fef387db203f9b > Reviewed-on: https://chromium-review.googlesource.com/592156 > Commit-Queue: Tina Quach <quacht@google.com> > Reviewed-by: Hector Carmona <hcarmona@chromium.org> > Reviewed-by: Tommy Li <tommycli@chromium.org> > Cr-Commit-Position: refs/heads/master@{#491409} TBR=aboxhall@chromium.org,tommycli@chromium.org,hcarmona@chromium.org,quacht@google.com Change-Id: I3c96c164e1872946897084a8713317e9d12c0aa5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 737739, 749943 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/598607 Commit-Queue: Luna Lu <loonybear@chromium.org> Reviewed-by: Luna Lu <loonybear@chromium.org> Cr-Commit-Position: refs/heads/master@{#491442} [modify] https://crrev.com/a708eb2ef6b2bccc5975b1f1bf6673ee39113c5f/chrome/browser/resources/settings/settings_page/settings_section.js [modify] https://crrev.com/a708eb2ef6b2bccc5975b1f1bf6673ee39113c5f/chrome/test/data/webui/BUILD.gn [delete] https://crrev.com/f1d2878f3e9c945e326f01ffde0472e8eb0e322e/chrome/test/data/webui/settings/accessibility_browsertest.js [delete] https://crrev.com/f1d2878f3e9c945e326f01ffde0472e8eb0e322e/chrome/test/data/webui/settings/passwords_a11y_test.js
,
Aug 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/29aa0d0a8eb8fbc6e0abde2c27af10dab9a9a3da commit 29aa0d0a8eb8fbc6e0abde2c27af10dab9a9a3da Author: Tina Quach <quacht@google.com> Date: Wed Aug 02 22:56:16 2017 Add accessibility tests for passwords section of Chrome Settings. Set up the GTest and Mocha-based a11y testing framework for Chrome WebUI by defining an accessibility_browsertest.js file for a11y test fixtures and including this file in the BUILD.gn. The passwords section now fires an event when the settings section has expanded--an event that is responded to in the added a11y test. The tests are disabled and will be enabled in followup CL for easier review. Bug: 737739 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ief6b002d8ce17950203c917a9baee05e3ac9136c Reviewed-on: https://chromium-review.googlesource.com/598638 Commit-Queue: Tina Quach <quacht@google.com> Reviewed-by: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#491539} [modify] https://crrev.com/29aa0d0a8eb8fbc6e0abde2c27af10dab9a9a3da/chrome/browser/resources/settings/settings_page/settings_section.js [modify] https://crrev.com/29aa0d0a8eb8fbc6e0abde2c27af10dab9a9a3da/chrome/test/data/webui/BUILD.gn [add] https://crrev.com/29aa0d0a8eb8fbc6e0abde2c27af10dab9a9a3da/chrome/test/data/webui/settings/accessibility_browsertest.js [add] https://crrev.com/29aa0d0a8eb8fbc6e0abde2c27af10dab9a9a3da/chrome/test/data/webui/settings/passwords_a11y_test.js
,
Aug 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a5fb18dc7b3bee1635997b71d5ec4a774b948002 commit a5fb18dc7b3bee1635997b71d5ec4a774b948002 Author: Tina Quach <quacht@google.com> Date: Sat Aug 05 00:55:49 2017 Shard the Settings Manage Passwords a11y test by audit rule. On the CFI and MSan builds, the test failed due to timeout. Sharding the test such that each unit test runs a single audit rule, rather than all 58 audit rules, can increase parallelization and prevent timeout. In order to generate a test based on every audit rule, a new file lists the available audit rule ids so that they can be referenced by both the browsertest file and the files defining the mocha tests. Bug: 737739 Change-Id: I9c3916edbc5bab235f88c9af22930ac68f09d22e Reviewed-on: https://chromium-review.googlesource.com/594642 Reviewed-by: Hector Carmona <hcarmona@chromium.org> Reviewed-by: Tommy Li <tommycli@chromium.org> Commit-Queue: Tina Quach <quacht@google.com> Cr-Commit-Position: refs/heads/master@{#492201} [modify] https://crrev.com/a5fb18dc7b3bee1635997b71d5ec4a774b948002/chrome/test/data/webui/BUILD.gn [add] https://crrev.com/a5fb18dc7b3bee1635997b71d5ec4a774b948002/chrome/test/data/webui/settings/accessibility_audit_rules.js [modify] https://crrev.com/a5fb18dc7b3bee1635997b71d5ec4a774b948002/chrome/test/data/webui/settings/accessibility_browsertest.js [modify] https://crrev.com/a5fb18dc7b3bee1635997b71d5ec4a774b948002/chrome/test/data/webui/settings/passwords_a11y_test.js
,
Aug 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/26fb268e5ed0a275a750f3a895f8eda6dc2cfb6e commit 26fb268e5ed0a275a750f3a895f8eda6dc2cfb6e Author: Tina Quach <quacht@google.com> Date: Tue Aug 08 23:07:48 2017 Add AccessibilityTest abstraction for defining tests. In order to make it easier to write accessibility tests, this CL adds the AccessibilityTest namespace, which groups all audit and mocha test related code so it may be reused to test other Chrome WebUI. Bug: 737739 Change-Id: I87cc0db0670a5a17d84406d6d2e3fdd619372774 Reviewed-on: https://chromium-review.googlesource.com/600894 Commit-Queue: Tina Quach <quacht@google.com> Reviewed-by: Alice Boxhall <aboxhall@chromium.org> Reviewed-by: Tommy Li <tommycli@chromium.org> Reviewed-by: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#492767} [modify] https://crrev.com/26fb268e5ed0a275a750f3a895f8eda6dc2cfb6e/chrome/test/data/webui/BUILD.gn [add] https://crrev.com/26fb268e5ed0a275a750f3a895f8eda6dc2cfb6e/chrome/test/data/webui/settings/accessibility_audit.js [modify] https://crrev.com/26fb268e5ed0a275a750f3a895f8eda6dc2cfb6e/chrome/test/data/webui/settings/accessibility_audit_rules.js [modify] https://crrev.com/26fb268e5ed0a275a750f3a895f8eda6dc2cfb6e/chrome/test/data/webui/settings/accessibility_browsertest.js [modify] https://crrev.com/26fb268e5ed0a275a750f3a895f8eda6dc2cfb6e/chrome/test/data/webui/settings/passwords_a11y_test.js
,
Aug 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3e8106bcb649002816db3ef70b40684ca8e75bf5 commit 3e8106bcb649002816db3ef70b40684ca8e75bf5 Author: Tina Quach <quacht@google.com> Date: Wed Aug 09 07:00:06 2017 Add ability to filter accessibility audit results. The aXe-audit sometimes has false positives, this CL allows exceptions to be filtered. It also does some refactoring and adds the aXe audit's type definitions so they may be referenced in documentation. Bug: 737739, 748632 Change-Id: Id7b9e626007b80e64261d36cdbd532b3f93e72b9 Reviewed-on: https://chromium-review.googlesource.com/602584 Commit-Queue: Tina Quach <quacht@google.com> Reviewed-by: Hector Carmona <hcarmona@chromium.org> Reviewed-by: Tommy Li <tommycli@chromium.org> Reviewed-by: Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#492874} [modify] https://crrev.com/3e8106bcb649002816db3ef70b40684ca8e75bf5/chrome/test/data/webui/BUILD.gn [delete] https://crrev.com/f05cf3bcebea7a5b5815337ba39e427d76dd03f7/chrome/test/data/webui/settings/accessibility_audit.js [modify] https://crrev.com/3e8106bcb649002816db3ef70b40684ca8e75bf5/chrome/test/data/webui/settings/accessibility_browsertest.js [add] https://crrev.com/3e8106bcb649002816db3ef70b40684ca8e75bf5/chrome/test/data/webui/settings/accessibility_test.js [modify] https://crrev.com/3e8106bcb649002816db3ef70b40684ca8e75bf5/chrome/test/data/webui/settings/passwords_a11y_test.js [modify] https://crrev.com/3e8106bcb649002816db3ef70b40684ca8e75bf5/third_party/axe-core/README.chromium [add] https://crrev.com/3e8106bcb649002816db3ef70b40684ca8e75bf5/third_party/axe-core/axe.d.ts
,
Aug 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1bfabcd3f69e896bb10a7803222fbf3bf75aff19 commit 1bfabcd3f69e896bb10a7803222fbf3bf75aff19 Author: Tina Quach <quacht@google.com> Date: Fri Aug 11 03:27:36 2017 Add a11y test for BASIC route. In adding these tests, the framework has been restructured such that there is a test fixture per route. In addition, some improvements were made to AccessibilityTest to enable the easy addition of tests. Bug: 737739 Change-Id: I0782dfcfc62b47bb4d91bc7d5ba08e55dfce7575 Reviewed-on: https://chromium-review.googlesource.com/607229 Commit-Queue: Tina Quach <quacht@google.com> Reviewed-by: Alice Boxhall <aboxhall@chromium.org> Reviewed-by: Hector Carmona <hcarmona@chromium.org> Reviewed-by: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#493657} [modify] https://crrev.com/1bfabcd3f69e896bb10a7803222fbf3bf75aff19/chrome/test/data/webui/BUILD.gn [modify] https://crrev.com/1bfabcd3f69e896bb10a7803222fbf3bf75aff19/chrome/test/data/webui/settings/accessibility_browsertest.js [modify] https://crrev.com/1bfabcd3f69e896bb10a7803222fbf3bf75aff19/chrome/test/data/webui/settings/accessibility_test.js [add] https://crrev.com/1bfabcd3f69e896bb10a7803222fbf3bf75aff19/chrome/test/data/webui/settings/basic_a11y_test.js [modify] https://crrev.com/1bfabcd3f69e896bb10a7803222fbf3bf75aff19/chrome/test/data/webui/settings/passwords_a11y_test.js
,
Aug 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cb6ed741ffd3b745de840a6e9270d61bea48c8e3 commit cb6ed741ffd3b745de840a6e9270d61bea48c8e3 Author: Tina Quach <quacht@google.com> Date: Sat Aug 12 01:11:52 2017 Add a11y test for ABOUT route in Settings. This CL also fixes small bug that occurs when axeOptions.rules is undefined. Bug: 737739 Change-Id: I2c637ce3558c9b49ce32d05476a9ee07d55884c7 Reviewed-on: https://chromium-review.googlesource.com/609270 Commit-Queue: Tina Quach <quacht@google.com> Reviewed-by: Tommy Li <tommycli@chromium.org> Reviewed-by: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#493922} [modify] https://crrev.com/cb6ed741ffd3b745de840a6e9270d61bea48c8e3/chrome/test/data/webui/BUILD.gn [add] https://crrev.com/cb6ed741ffd3b745de840a6e9270d61bea48c8e3/chrome/test/data/webui/settings/about_a11y_test.js [modify] https://crrev.com/cb6ed741ffd3b745de840a6e9270d61bea48c8e3/chrome/test/data/webui/settings/accessibility_test.js
,
Aug 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8ba21e60771adf70dcec4c470c8ee71a0a88f56b commit 8ba21e60771adf70dcec4c470c8ee71a0a88f56b Author: Tina Quach <quacht@google.com> Date: Mon Aug 14 19:10:11 2017 Add a11y test for EDIT_DICTIONARY route Bug: 737739 Change-Id: I15b489895ba80515c181a9e5df25125491e44e77 Reviewed-on: https://chromium-review.googlesource.com/608581 Commit-Queue: Tina Quach <quacht@google.com> Reviewed-by: Alice Boxhall <aboxhall@chromium.org> Reviewed-by: Tommy Li <tommycli@chromium.org> Reviewed-by: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#494123} [modify] https://crrev.com/8ba21e60771adf70dcec4c470c8ee71a0a88f56b/chrome/test/data/webui/BUILD.gn [modify] https://crrev.com/8ba21e60771adf70dcec4c470c8ee71a0a88f56b/chrome/test/data/webui/settings/accessibility_browsertest.js [add] https://crrev.com/8ba21e60771adf70dcec4c470c8ee71a0a88f56b/chrome/test/data/webui/settings/edit_dictionary_a11y_test.js
,
Aug 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f0d74c76fb7e919f2bd64163cdca330ad6571a1a commit f0d74c76fb7e919f2bd64163cdca330ad6571a1a Author: Tina Quach <quacht@google.com> Date: Mon Aug 14 20:53:28 2017 Add a11y test for SIGN_OUT route. The test shares browser proxies with people page test. Bug: 737739 Change-Id: Ie0535708980b477beec0d7487fced4183de32413 Reviewed-on: https://chromium-review.googlesource.com/611307 Reviewed-by: Tommy Li <tommycli@chromium.org> Reviewed-by: Hector Carmona <hcarmona@chromium.org> Commit-Queue: Tina Quach <quacht@google.com> Cr-Commit-Position: refs/heads/master@{#494181} [modify] https://crrev.com/f0d74c76fb7e919f2bd64163cdca330ad6571a1a/chrome/test/data/webui/BUILD.gn [modify] https://crrev.com/f0d74c76fb7e919f2bd64163cdca330ad6571a1a/chrome/test/data/webui/settings/cr_settings_browsertest.js [modify] https://crrev.com/f0d74c76fb7e919f2bd64163cdca330ad6571a1a/chrome/test/data/webui/settings/people_page_test.js [add] https://crrev.com/f0d74c76fb7e919f2bd64163cdca330ad6571a1a/chrome/test/data/webui/settings/sign_out_a11y_test.js [add] https://crrev.com/f0d74c76fb7e919f2bd64163cdca330ad6571a1a/chrome/test/data/webui/settings/test_profile_info_browser_proxy.js [add] https://crrev.com/f0d74c76fb7e919f2bd64163cdca330ad6571a1a/chrome/test/data/webui/settings/test_sync_browser_proxy.js
,
Aug 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b19e47c1f362bd042d2d2985a39d906683d36f33 commit b19e47c1f362bd042d2d2985a39d906683d36f33 Author: Tina Quach <quacht@google.com> Date: Tue Aug 15 00:54:39 2017 Added a11y test for MANAGE_PROFILE route. Bug: 737739 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: If982f5307854a15706ad8713c572b739d1eb0485 Reviewed-on: https://chromium-review.googlesource.com/611243 Reviewed-by: Hector Carmona <hcarmona@chromium.org> Reviewed-by: Tommy Li <tommycli@chromium.org> Commit-Queue: Tina Quach <quacht@google.com> Cr-Commit-Position: refs/heads/master@{#494276} [modify] https://crrev.com/b19e47c1f362bd042d2d2985a39d906683d36f33/chrome/browser/resources/settings/printing_page/printing_page.html [modify] https://crrev.com/b19e47c1f362bd042d2d2985a39d906683d36f33/chrome/test/data/webui/BUILD.gn [modify] https://crrev.com/b19e47c1f362bd042d2d2985a39d906683d36f33/chrome/test/data/webui/settings/accessibility_browsertest.js [modify] https://crrev.com/b19e47c1f362bd042d2d2985a39d906683d36f33/chrome/test/data/webui/settings/accessibility_test.js [modify] https://crrev.com/b19e47c1f362bd042d2d2985a39d906683d36f33/chrome/test/data/webui/settings/edit_dictionary_a11y_test.js [add] https://crrev.com/b19e47c1f362bd042d2d2985a39d906683d36f33/chrome/test/data/webui/settings/manage_profile_a11y_test.js
,
Aug 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/da138aff2792abb6f9da647704183a24c895818e commit da138aff2792abb6f9da647704183a24c895818e Author: Tina Quach <quacht@google.com> Date: Tue Aug 15 01:30:08 2017 Create Settings-specific default audit options and violation filter. Provide a11y test writers the ability to use default options as well as override these options while being explicit in the test definition as to exactly what options and filters are currently in use. Bug: 737739 Change-Id: I0a4f6cd7c3f7eab6206f3cbb45f2338bf1822570 Reviewed-on: https://chromium-review.googlesource.com/614773 Commit-Queue: Tina Quach <quacht@google.com> Reviewed-by: Hector Carmona <hcarmona@chromium.org> Reviewed-by: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#494293} [modify] https://crrev.com/da138aff2792abb6f9da647704183a24c895818e/chrome/test/data/webui/settings/about_a11y_test.js [modify] https://crrev.com/da138aff2792abb6f9da647704183a24c895818e/chrome/test/data/webui/settings/accessibility_browsertest.js [modify] https://crrev.com/da138aff2792abb6f9da647704183a24c895818e/chrome/test/data/webui/settings/basic_a11y_test.js [modify] https://crrev.com/da138aff2792abb6f9da647704183a24c895818e/chrome/test/data/webui/settings/edit_dictionary_a11y_test.js [modify] https://crrev.com/da138aff2792abb6f9da647704183a24c895818e/chrome/test/data/webui/settings/manage_profile_a11y_test.js [modify] https://crrev.com/da138aff2792abb6f9da647704183a24c895818e/chrome/test/data/webui/settings/passwords_a11y_test.js [modify] https://crrev.com/da138aff2792abb6f9da647704183a24c895818e/chrome/test/data/webui/settings/sign_out_a11y_test.js
,
Aug 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/067e06ecb5633161ee87b5b3905e1c11ba40c4cb commit 067e06ecb5633161ee87b5b3905e1c11ba40c4cb Author: Tina Quach <quacht@google.com> Date: Tue Aug 15 06:35:50 2017 Group files related to settings a11y test in single folder. Organizes the files and makes GEN_INCLUDE more concise. Bug: 737739 Change-Id: I75d5c723bd5b68d991a615751c9ea7c9e773d965 Reviewed-on: https://chromium-review.googlesource.com/614727 Commit-Queue: Tina Quach <quacht@google.com> Reviewed-by: Hector Carmona <hcarmona@chromium.org> Reviewed-by: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#494335} [modify] https://crrev.com/067e06ecb5633161ee87b5b3905e1c11ba40c4cb/chrome/test/data/webui/BUILD.gn [rename] https://crrev.com/067e06ecb5633161ee87b5b3905e1c11ba40c4cb/chrome/test/data/webui/settings/a11y/about_a11y_test.js [rename] https://crrev.com/067e06ecb5633161ee87b5b3905e1c11ba40c4cb/chrome/test/data/webui/settings/a11y/accessibility_audit_rules.js [rename] https://crrev.com/067e06ecb5633161ee87b5b3905e1c11ba40c4cb/chrome/test/data/webui/settings/a11y/accessibility_test.js [rename] https://crrev.com/067e06ecb5633161ee87b5b3905e1c11ba40c4cb/chrome/test/data/webui/settings/a11y/basic_a11y_test.js [add] https://crrev.com/067e06ecb5633161ee87b5b3905e1c11ba40c4cb/chrome/test/data/webui/settings/a11y/edit_dictionary_a11y_test.js [rename] https://crrev.com/067e06ecb5633161ee87b5b3905e1c11ba40c4cb/chrome/test/data/webui/settings/a11y/manage_profile_a11y_test.js [rename] https://crrev.com/067e06ecb5633161ee87b5b3905e1c11ba40c4cb/chrome/test/data/webui/settings/a11y/passwords_a11y_test.js [rename] https://crrev.com/067e06ecb5633161ee87b5b3905e1c11ba40c4cb/chrome/test/data/webui/settings/a11y/settings_accessibility_test.js [rename] https://crrev.com/067e06ecb5633161ee87b5b3905e1c11ba40c4cb/chrome/test/data/webui/settings/a11y/sign_out_a11y_test.js [modify] https://crrev.com/067e06ecb5633161ee87b5b3905e1c11ba40c4cb/chrome/test/data/webui/settings/edit_dictionary_a11y_test.js
,
Aug 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/43827a54fd4e3bbe482f350d73fe4148d841268c commit 43827a54fd4e3bbe482f350d73fe4148d841268c Author: Tina Quach <quacht@google.com> Date: Tue Aug 15 21:24:40 2017 Remove extra log and assertion in EDIT_DICTIONARY a11y test. Bug: 737739 Change-Id: Iec62d53171612e7e5dbd770e05b5ef23c2264705 Reviewed-on: https://chromium-review.googlesource.com/615609 Reviewed-by: Hector Carmona <hcarmona@chromium.org> Commit-Queue: Tina Quach <quacht@google.com> Cr-Commit-Position: refs/heads/master@{#494553} [modify] https://crrev.com/43827a54fd4e3bbe482f350d73fe4148d841268c/chrome/test/data/webui/settings/a11y/edit_dictionary_a11y_test.js
,
Aug 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/71588313b7dc30cb35499ce649f218fdfd766e88 commit 71588313b7dc30cb35499ce649f218fdfd766e88 Author: Tina Quach <quacht@google.com> Date: Wed Aug 16 21:00:34 2017 Update TODO in Settings a11y tests. Bug: 737739 Change-Id: Ie6887a9eefd988ad80c2d243e4a569719ba8d2d2 Reviewed-on: https://chromium-review.googlesource.com/617361 Reviewed-by: Hector Carmona <hcarmona@chromium.org> Commit-Queue: Tina Quach <quacht@google.com> Cr-Commit-Position: refs/heads/master@{#494946} [modify] https://crrev.com/71588313b7dc30cb35499ce649f218fdfd766e88/chrome/test/data/webui/settings/a11y/manage_profile_a11y_test.js [modify] https://crrev.com/71588313b7dc30cb35499ce649f218fdfd766e88/chrome/test/data/webui/settings/a11y/settings_accessibility_test.js
,
Sep 4 2017
The assigned owner "quacht@google.com" is not able to receive e-mails, please re-triage. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 18 2018
Is this considered fixed?
,
May 18 2018
We need to add many more tests for this issue to be considered fixed. This is the overall bug to enable tests everywhere. I've added several a11y issues that block this issue fixing each should include a test which will get us closer to considering this one done. Another option is we can close this issue and track the individual tests that need to be added |
||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||
Comment 1 by bugdroid1@chromium.org
, Jul 7 2017