New issue
Advanced search Search tips

Issue 737737 link

Starred by 1 user
Status: Fixed
Owner:
csharrison@chromium.org
Closed: Aug 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

subresource_filter: allow a configuration to only enable the strong popup blocker

Project Member Reported by csharrison@chromium.org, Jun 28 2017 
We may need to remotely disable the ruleset via finch (for a particular Configuration).

Rather than disable the entire feature, we may want to just disable filtering rules and instead just activate the strong popup blocker.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d0637d14d97ad57e73f8cd6c4626720ff04a29cb

commit d0637d14d97ad57e73f8cd6c4626720ff04a29cb
Author: Charles Harrison <csharrison@chromium.org>
Date: Thu Jul 20 15:49:05 2017

[subresource_filter] Add a finch param to disable using rules from the ruleset

This allows us to remotely turn off filtering rules while still enabling
other features like the strengthened popup blocker.

Bug:  737737 
Change-Id: Ia77acc7bdb66009fae7204a259ce571bd680ba9f
Reviewed-on: https://chromium-review.googlesource.com/553597
Reviewed-by: Shivani Sharma <shivanisha@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488256}
[modify] https://crrev.com/d0637d14d97ad57e73f8cd6c4626720ff04a29cb/chrome/browser/subresource_filter/subresource_filter_browsertest.cc
[modify] https://crrev.com/d0637d14d97ad57e73f8cd6c4626720ff04a29cb/chrome/browser/subresource_filter/subresource_filter_unittest.cc
[modify] https://crrev.com/d0637d14d97ad57e73f8cd6c4626720ff04a29cb/components/subresource_filter/content/browser/activation_state_computing_navigation_throttle.cc
[modify] https://crrev.com/d0637d14d97ad57e73f8cd6c4626720ff04a29cb/components/subresource_filter/content/browser/activation_state_computing_navigation_throttle.h
[modify] https://crrev.com/d0637d14d97ad57e73f8cd6c4626720ff04a29cb/components/subresource_filter/content/browser/activation_state_computing_navigation_throttle_unittest.cc
[modify] https://crrev.com/d0637d14d97ad57e73f8cd6c4626720ff04a29cb/components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc
[modify] https://crrev.com/d0637d14d97ad57e73f8cd6c4626720ff04a29cb/components/subresource_filter/content/browser/content_subresource_filter_driver_factory.h
[modify] https://crrev.com/d0637d14d97ad57e73f8cd6c4626720ff04a29cb/components/subresource_filter/content/browser/content_subresource_filter_throttle_manager.cc
[modify] https://crrev.com/d0637d14d97ad57e73f8cd6c4626720ff04a29cb/components/subresource_filter/content/browser/content_subresource_filter_throttle_manager.h
[modify] https://crrev.com/d0637d14d97ad57e73f8cd6c4626720ff04a29cb/components/subresource_filter/core/browser/subresource_filter_features.cc
[modify] https://crrev.com/d0637d14d97ad57e73f8cd6c4626720ff04a29cb/components/subresource_filter/core/browser/subresource_filter_features.h

Comment 2 by csharrison@chromium.org, Aug 4 2017

Status: Fixed (was: Started)
►

Sign in to add a comment