New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 737714 link

Starred by 1 user
Status: Duplicate
Merged: issue 737620
Owner:
fmalita@chromium.org
Closed: Jul 2017
Cc:
█ reed@chromium.org
robertphillips@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

Shadow layout tests failing

Project Member Reported by rouslan@chromium.org, Jun 28 2017 
Suspecting one of the recent Skia CLs:

https://chromium-review.googlesource.com/552677
https://chromium-review.googlesource.com/552577
https://chromium-review.googlesource.com/552797
https://chromium-review.googlesource.com/552818

For the new shadow failures:

Unexpected Failures:

fast/borders/border-radius-split-inline.html
fast/box-shadow/basic-shadows.html
fast/box-shadow/box-shadow-radius.html
fast/box-shadow/box-shadow-transformed.html
fast/box-shadow/box-shadow.html
fast/box-shadow/inset-box-shadow-radius.html
fast/box-shadow/scaled-box-shadow.html
fast/canvas/canvas-composite-shadow.html
fast/css/color-correction-on-box-shadow.html
transforms/shadows.html
virtual/display_list_2d_canvas/fast/canvas/canvas-composite-shadow.html

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.10/builds/35192
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 28 2017 

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/0e29c633feb3215174f8fc2e048a573dc3d6de9e

commit 0e29c633feb3215174f8fc2e048a573dc3d6de9e
Author: Robert Phillips <robertphillips@google.com>
Date: Wed Jun 28 21:21:48 2017

Revert "use blitMask for left/right edges in blur-nine"

This reverts commit 3fe44544c93759e7791ee0df3e5d172cb0f268b6.

Reason for revert: I believe this is the cause of the layout test regressions in  crbug.com/737714 

Bug:  737714 

Original change's description:
> use blitMask for left/right edges in blur-nine
> 
> Seems about same speed for legacy blitter, but much faster for raster-pipeline
> 
> Bug: skia:
> Change-Id: I19be307c01a199e2477e045fb8c2cca7784564a5
> Reviewed-on: https://skia-review.googlesource.com/20967
> Commit-Queue: Mike Reed <reed@google.com>
> Reviewed-by: Mike Klein <mtklein@chromium.org>

TBR=mtklein@chromium.org,mtklein@google.com,fmalita@chromium.org,reed@google.com

Change-Id: Id7be3ff779191175d91ebd51c7d275fd1104ae0d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:
Reviewed-on: https://skia-review.googlesource.com/21182
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>

[modify] https://crrev.com/0e29c633feb3215174f8fc2e048a573dc3d6de9e/src/core/SkMaskFilter.cpp
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 28 2017 

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/e911c63b6af02b3f2c669cf37a2000d48fc29f99

commit e911c63b6af02b3f2c669cf37a2000d48fc29f99
Author: Robert Phillips <robertphillips@google.com>
Date: Wed Jun 28 21:29:18 2017

Revert "Revert "use blitMask for left/right edges in blur-nine""

This reverts commit 0e29c633feb3215174f8fc2e048a573dc3d6de9e.

Reason for revert: The layout tests have been suppressed in https://chromium-review.googlesource.com/c/553239/ - no need to revert

Bug:  737714 

Original change's description:
> Revert "use blitMask for left/right edges in blur-nine"
> 
> This reverts commit 3fe44544c93759e7791ee0df3e5d172cb0f268b6.
> 
> Reason for revert: I believe this is the cause of the layout test regressions in  crbug.com/737714 
> 
> Bug:  737714 
> 
> Original change's description:
> > use blitMask for left/right edges in blur-nine
> > 
> > Seems about same speed for legacy blitter, but much faster for raster-pipeline
> > 
> > Bug: skia:
> > Change-Id: I19be307c01a199e2477e045fb8c2cca7784564a5
> > Reviewed-on: https://skia-review.googlesource.com/20967
> > Commit-Queue: Mike Reed <reed@google.com>
> > Reviewed-by: Mike Klein <mtklein@chromium.org>
> 
> TBR=mtklein@chromium.org,mtklein@google.com,fmalita@chromium.org,reed@google.com
> 
> Change-Id: Id7be3ff779191175d91ebd51c7d275fd1104ae0d
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: skia:
> Reviewed-on: https://skia-review.googlesource.com/21182
> Reviewed-by: Robert Phillips <robertphillips@google.com>
> Commit-Queue: Robert Phillips <robertphillips@google.com>

TBR=mtklein@chromium.org,mtklein@google.com,robertphillips@google.com,fmalita@chromium.org,reed@google.com

Change-Id: I9f232e838bcad4e4cf0d8c7226d5e57a349e52be
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  737714 , skia:
Reviewed-on: https://skia-review.googlesource.com/21183
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>

[modify] https://crrev.com/e911c63b6af02b3f2c669cf37a2000d48fc29f99/src/core/SkMaskFilter.cpp

Comment 3 by shrike@chromium.org, Jul 6 2017

Status: Assigned (was: Untriaged)

Comment 4 by fmalita@chromium.org, Jul 7 2017

Mergedinto: 737620
Status: Duplicate (was: Assigned)
►

Sign in to add a comment