New issue
Advanced search Search tips

Issue 737704 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

2.8% regression in system_health.memory_mobile at 482748:482790

Project Member Reported by tdres...@chromium.org, Jun 28 2017

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=737704

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg7vGK_AgM


Bot(s) for this bug's original alert(s):

android-webview-nexus5X
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Jun 29 2017

Cc: pdr@chromium.org
Owner: pdr@chromium.org

=== Auto-CCing suspected CL author pdr@chromium.org ===

Hi pdr@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Philip Rogers
  Commit : 3b13fbc2c29ed02b1dc07cca7975788a4e70a305
  Date   : Tue Jun 27 23:08:51 2017
  Subject: Remove max scroll offset rounding

Bisect Details
  Configuration: android_webview_arm64_aosp_perf_bisect
  Benchmark    : system_health.memory_mobile
  Metric       : memory:webview:all_processes:reported_by_os:system_memory:native_heap:proportional_resident_size_avg/load_chrome/load_chrome_blank
  Change       : 3.38% | 17423957.3333 -> 18013610.6667

Revision             Result                   N
chromium@482747      17423957 +- 99759.0      6      good
chromium@482769      17458261 +- 183303       6      good
chromium@482780      17484203 +- 81066.5      6      good
chromium@482781      17530965 +- 186703       6      good
chromium@482782      17990571 +- 38652.9      6      bad       <--
chromium@482783      17961728 +- 51648.6      6      bad
chromium@482785      17995179 +- 74670.1      6      bad
chromium@482790      18013611 +- 99982.1      6      bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-webview --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=load.chrome.blank system_health.memory_mobile

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8975514416201929168


For feedback, file a bug with component Speed>Bisection
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/579d7f54029f25dd67141765262594c3a37564cb

commit 579d7f54029f25dd67141765262594c3a37564cb
Author: Philip Rogers <pdr@chromium.org>
Date: Thu Jun 29 22:31:17 2017

Revert "Remove max scroll offset rounding"

This reverts commit 3b13fbc2c29ed02b1dc07cca7975788a4e70a305 due to a webview perf regression:
https://bugs.chromium.org/p/chromium/issues/detail?id=737704

Original change's description:
> Remove max scroll offset rounding
> 
> This snapping logic was added in [1] but snapping was later moved to
> the browser [2] and is no longer needed.
> 
> [1] https://src.chromium.org/viewvc/chrome?view=rev&revision=265188
> [2] https://crrev.com/3367dde4ac60c00d422cdd087525ce2f55e5a6e4
> 
> Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I09397c10c51472d3b1fc742728dc1aa2c5af1239
> Reviewed-on: https://chromium-review.googlesource.com/546973
> Reviewed-by: David Bokan <bokan@chromium.org>
> Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
> Commit-Queue: Philip Rogers <pdr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#482782}

TBR=bokan@chromium.org,pdr@chromium.org,chrishtr@chromium.org,chaopeng@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel

Bug:  737704 
Change-Id: I16a147edede57b819e9349cde1992608b4393b5e
Reviewed-on: https://chromium-review.googlesource.com/556158
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#483520}
[modify] https://crrev.com/579d7f54029f25dd67141765262594c3a37564cb/cc/trees/property_tree.cc

Comment 5 by pdr@chromium.org, Jun 29 2017

Status: Fixed (was: Untriaged)
Project Member

Comment 6 by 42576172...@developer.gserviceaccount.com, Jun 30 2017

 Issue 737979  has been merged into this issue.

Comment 7 by pdr@chromium.org, Jul 5 2017

Issue 739317 has been merged into this issue.

Sign in to add a comment