New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 737695 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

x86-generic-no-vmtest-pre-cq is missing chromeos-base/chromeos-chrome prebuilts

Project Member Reported by pprabhu@chromium.org, Jun 28 2017

Issue description

It's complaining loudly, and kicking out CLs, hence P0:

https://groups.google.com/a/google.com/forum/#!topic/chromeos-build-alerts/rsNTyknUyHU


[ebuild  N    ] chromeos-base/chromeos-chrome-61.0.3142.0_rc-r1 to /build/x86-generic/ USE="accessibility autotest build_tests buildcheck chrome_debug chrome_remoting cups debug_fission evdev_gestures fonts gold highdpi nacl opengles runhooks v4l2_codec vaapi xkbcommon -afdo_use -app_shell -asan (-authpolicy) -chrome_debug_tests -chrome_internal -chrome_media -clang -component_build -goma -hardfp -internal_gles_conform -mojo (-neon) -opengl -thinlto -v4lplugin -verbose -vtable_verify" OZONE_PLATFORM="gbm -caca -cast -egltest {-test}" OZONE_PLATFORM_DEFAULT="gbm -caca -cast -egltest {-test}" 

...
[1;31m04:16:05: ERROR: Cannot find prebuilts for chromeos-base/chromeos-chrome on x86-generic
--> deputy.
 
This can happen when we pin chrome to an incorrect version, but I don't know of chrome being pinned right now.

Also, binhost-pre-cq / binhost test on the CQ should start failing in this case, but I haven't seen evidence of that either...
Cc: dgarr...@chromium.org jrbarnette@chromium.org jen...@chromium.org
Labels: OS-Chrome
We turned down the x86-generic builders, it is no longer supported. We should remove this builder as wll.

Comment 3 by sjg@google.com, Jun 28 2017

Cc: sjg@chromium.org
It looks like this has already been fixed when we re-applied
the change to add betty-pre-cq to default list:
    https://chromium-review.googlesource.com/#/c/551111/

However, there are still two possible sources of trouble:
  * Some COMMIT-QUEUE.ini files may refer to the builder.
  * CLs that haven't been rebased will continue to use the
    old config.

The kernel is still configured to test against x86-generic:

    $ find src -name COMMIT-QUEUE.ini 2>/dev/null | xgrep -l 'x86-generic'
    src/overlays/overlay-x86-generic/COMMIT-QUEUE.ini
    src/third_party/kernel/v3.14/COMMIT-QUEUE.ini

Cc: cernekee@chromium.org
Owner: sjg@chromium.org
ayatane@ and I have a meeting:  sjg@ - can you go remove references
to x86-generic from the kernel file (see c#5)?  The change must be
chumped; it can't go through the CQ.  :-(

There will need to be a PSA, which can follow once the code is fixed.

Comment 7 by sjg@google.com, Jun 28 2017

I will be out of meetings in an hour and will look then if no one gets to it first.
Project Member

Comment 8 by bugdroid1@chromium.org, Jun 28 2017

Labels: merge-merged-chromeos-3.14
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/61d4c1883529bac41d46fd62f64e95f7247496dd

commit 61d4c1883529bac41d46fd62f64e95f7247496dd
Author: Kevin Cernekee <cernekee@chromium.org>
Date: Wed Jun 28 21:44:03 2017

CHROMIUM: COMMIT-QUEUE.ini: Remove x86-generic builder

These builders have been turned down and so this entry is causing pre-CQ
failures.

BUG= chromium:737695 
TEST=none

Change-Id: I77faabb904c8be5cc67605236bcb09fe5e7a039d
Reviewed-on: https://chromium-review.googlesource.com/553537
Reviewed-by: Simon Glass <sjg@chromium.org>
Commit-Queue: Kevin Cernekee <cernekee@chromium.org>
Tested-by: Kevin Cernekee <cernekee@chromium.org>

[modify] https://crrev.com/61d4c1883529bac41d46fd62f64e95f7247496dd/COMMIT-QUEUE.ini

Comment 9 by dmitrygr@google.com, Jun 28 2017

Seems to still be happening (change 437525)


ChromeOS Commit Bot posted comments on this change.

View Change

Patch set 22:

The following build(s) failed:

x86-generic-no-vmtest-pre-cq: The BuildPackages stage failed: Cannot find prebuilts for chromeos-base/chromeos-chrome on x86-generic in https://luci-milo.appspot.com/buildbot/chromiumos.tryserver/no_vmtest_pre_cq/65962

This failure was probably caused by your change.

Please check whether the failure is your fault. If your change is not at fault, you may mark it as ready again.

Commit queue documentation: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium-os/commit-queue-overview

To view, visit change 437525. To unsubscribe, visit settings.
> Seems to still be happening (change 437525)

There are some additional steps needed to make the change
take effect.

It _might_ be enough if you rebase the affected CL, or otherwise
change it in some way.

did rebase
no results
> did rebase
> no results

<sigh> You need to repo sync, and then rebase.  The rebase needs
to pick up the CL from c#8:
    https://chromium-review.googlesource.com/553537

> > did rebase
> > no results
>
> <sigh> You need to repo sync, and then rebase.  The rebase needs
> to pick up the CL from c#8:
>     https://chromium-review.googlesource.com/553537

Alas, I've consulted with experts.  In addition to sync and rebase,
there's an administrative action we need to complete.  That's
underway.

I anticipate a PSA once we've taken care of it.
I have restarted the pre-cq launcher, need confirmation that all is well.

Comment 15 by sjg@google.com, Jun 29 2017

Owner: ayatane@chromium.org
A failing change is here, so keep an eye on how it goes:

https://chromium-review.googlesource.com/c/437525

Labels: -Pri-0 Pri-1
> A failing change is here, so keep an eye on how it goes:
>
> https://chromium-review.googlesource.com/c/437525

That CL wasn't rebased until today:  the failure was expected.

Status: Fixed (was: Assigned)

Comment 18 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment