New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 737689 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Last visit > 30 days ago
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Replace uses of deprecated UMA_HISTOGRAM_COUNTS macro.

Project Member Reported by holte@chromium.org, Jun 28 2017

Issue description

This macros is deprecated because it a confusing alias UMA_HISTOGRAM_COUNT_1M. Uses of it should be replaced with the new name, so we can get rid of the macro.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6143e645a26b391ece7c82c4c4b76270eb674b4a

commit 6143e645a26b391ece7c82c4c4b76270eb674b4a
Author: Steven Holte <holte@google.com>
Date: Wed Jun 28 23:31:03 2017

Replace all UMA_HISTOGRAM_COUNTS uses in net/.

UMA_HISTOGRAM_COUNTS is a deprecated alias for UMA_HISTOGRAM_COUNTS_1M.

Bug: 737689
Change-Id: Icb7e3ef2dde93353984b1660c40438dfd99537d7
Reviewed-on: https://chromium-review.googlesource.com/552906
Reviewed-by: Bence Béky <bnc@chromium.org>
Commit-Queue: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#483188}
[modify] https://crrev.com/6143e645a26b391ece7c82c4c4b76270eb674b4a/net/base/network_change_notifier.cc
[modify] https://crrev.com/6143e645a26b391ece7c82c4c4b76270eb674b4a/net/base/sdch_manager.cc
[modify] https://crrev.com/6143e645a26b391ece7c82c4c4b76270eb674b4a/net/disk_cache/blockfile/block_files.cc
[modify] https://crrev.com/6143e645a26b391ece7c82c4c4b76270eb674b4a/net/disk_cache/blockfile/eviction.cc
[modify] https://crrev.com/6143e645a26b391ece7c82c4c4b76270eb674b4a/net/disk_cache/blockfile/histogram_macros.h
[modify] https://crrev.com/6143e645a26b391ece7c82c4c4b76270eb674b4a/net/disk_cache/simple/simple_index.cc
[modify] https://crrev.com/6143e645a26b391ece7c82c4c4b76270eb674b4a/net/disk_cache/simple/simple_index_file.cc
[modify] https://crrev.com/6143e645a26b391ece7c82c4c4b76270eb674b4a/net/dns/dns_hosts.cc
[modify] https://crrev.com/6143e645a26b391ece7c82c4c4b76270eb674b4a/net/dns/dns_session.cc
[modify] https://crrev.com/6143e645a26b391ece7c82c4c4b76270eb674b4a/net/dns/dns_transaction.cc
[modify] https://crrev.com/6143e645a26b391ece7c82c4c4b76270eb674b4a/net/extras/sqlite/sqlite_persistent_cookie_store.cc
[modify] https://crrev.com/6143e645a26b391ece7c82c4c4b76270eb674b4a/net/http/bidirectional_stream.cc
[modify] https://crrev.com/6143e645a26b391ece7c82c4c4b76270eb674b4a/net/http/http_cache_transaction.cc
[modify] https://crrev.com/6143e645a26b391ece7c82c4c4b76270eb674b4a/net/http/http_server_properties_impl.cc
[modify] https://crrev.com/6143e645a26b391ece7c82c4c4b76270eb674b4a/net/http/http_server_properties_manager.cc
[modify] https://crrev.com/6143e645a26b391ece7c82c4c4b76270eb674b4a/net/nqe/network_quality_estimator.cc
[modify] https://crrev.com/6143e645a26b391ece7c82c4c4b76270eb674b4a/net/quic/chromium/quic_chromium_client_session.cc
[modify] https://crrev.com/6143e645a26b391ece7c82c4c4b76270eb674b4a/net/quic/chromium/quic_connection_logger.cc
[modify] https://crrev.com/6143e645a26b391ece7c82c4c4b76270eb674b4a/net/quic/chromium/quic_stream_factory.cc
[modify] https://crrev.com/6143e645a26b391ece7c82c4c4b76270eb674b4a/net/quic/core/quic_crypto_client_stream.cc
[modify] https://crrev.com/6143e645a26b391ece7c82c4c4b76270eb674b4a/net/sdch/sdch_owner.cc
[modify] https://crrev.com/6143e645a26b391ece7c82c4c4b76270eb674b4a/net/spdy/chromium/spdy_stream.cc
[modify] https://crrev.com/6143e645a26b391ece7c82c4c4b76270eb674b4a/net/url_request/url_request_http_job.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Sep 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9592222b61fc2bd136201f737d9e94620db776fd

commit 9592222b61fc2bd136201f737d9e94620db776fd
Author: Steven Holte <holte@google.com>
Date: Fri Sep 14 20:06:23 2018

Replace UMA_HISTOGRAM_COUNTS with UMA_HISTOGRAM_COUNTS_1M.

This is a simple macro rename, with no functional changes.
The old name was deprecated, this is just cleaning up usage.

TBR=creis

Bug: 737689
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:linux_mojo;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I2b985990eb3c4fd13b4af6aa832c99834790ef78
Reviewed-on: https://chromium-review.googlesource.com/1173327
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591443}
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/base/android/java/src/org/chromium/base/metrics/RecordHistogram.java
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/base/metrics/field_trial.h
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/cc/base/histograms.h
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/cc/trees/layer_tree_impl.cc
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/chrome/browser/android/oom_intervention/oom_intervention_tab_helper.cc
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/chrome/browser/bookmarks/bookmark_stats.cc
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/chrome/browser/chromeos/extensions/first_run_private_api.cc
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/chrome/browser/chromeos/input_method/input_method_manager_impl.cc
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/chrome/browser/chromeos/mobile/mobile_activator.cc
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/chrome/browser/extensions/api/processes/processes_api.cc
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/chrome/browser/extensions/install_signer.cc
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/chrome/browser/importer/profile_writer.cc
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.cc
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/chrome/browser/page_load_metrics/page_load_tracker.cc
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/chrome/browser/plugins/plugin_observer.cc
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/chrome/browser/predictors/autocomplete_action_predictor_table.cc
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/chrome/browser/safe_browsing/client_side_detection_service.cc
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/chrome/browser/safe_browsing/download_protection/check_client_download_request.cc
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/chrome/browser/safe_browsing/download_protection/download_feedback_service.cc
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/chrome/browser/safe_browsing/incident_reporting/incident_report_uploader_impl.cc
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/chrome/browser/safe_browsing/incident_reporting/platform_state_store.cc
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/chrome/browser/sync_file_system/drive_backend/metadata_database_index.cc
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/chrome/browser/ui/passwords/password_manager_porter.cc
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/chrome/browser/ui/views/omnibox/omnibox_view_views.cc
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/chrome/browser/ui/webui/print_preview/print_preview_handler.cc
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/chrome/browser/ui/webui/print_preview/print_preview_ui.cc
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/chrome/browser/ui/webui/settings/settings_default_browser_handler.cc
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/chrome/renderer/content_settings_observer.cc
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/chrome/renderer/net/net_error_helper_core.cc
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/chrome/renderer/safe_browsing/features.cc
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/chrome/renderer/safe_browsing/phishing_dom_feature_extractor.cc
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/chrome/renderer/safe_browsing/phishing_term_feature_extractor.cc
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/components/autofill/core/browser/autofill_metrics.cc
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/components/browser_sync/profile_sync_service.cc
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/components/content_settings/core/browser/content_settings_pref.cc
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/components/content_settings/core/browser/content_settings_pref_provider.cc
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats.cc
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats.cc
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/components/data_use_measurement/core/data_use_measurement.cc
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/components/drive/chromeos/change_list_processor.cc
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/components/drive/chromeos/file_cache.cc
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/components/gcm_driver/gcm_client_impl.cc
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/components/gcm_driver/gcm_stats_recorder_impl.cc
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/components/history/core/browser/history_backend.cc
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/components/history/core/browser/history_database.cc
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/components/history/core/browser/in_memory_database.cc
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/components/metrics/persisted_logs_metrics_impl.cc
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/components/ntp_snippets/remote/remote_suggestions_provider_impl.cc
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/components/offline_pages/core/model/offline_page_model_taskified.cc
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/components/omnibox/browser/document_provider.cc
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/components/omnibox/browser/omnibox_edit_model.cc
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/components/omnibox/browser/url_index_private_data.cc
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/components/omnibox/browser/zero_suggest_provider.cc
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/components/password_manager/core/browser/export/password_manager_exporter.cc
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/components/password_manager/core/browser/password_form_manager.cc
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/components/password_manager/core/browser/password_store.cc
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/components/policy/core/common/policy_loader_win.cc
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/components/printing/renderer/print_render_frame_helper.cc
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/components/safe_browsing/db/v4_database.cc
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/components/safe_browsing/db/v4_store.cc
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/components/safe_browsing/db/v4_update_protocol_manager.cc
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/components/signin/core/browser/signin_manager.cc
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/components/signin/core/browser/signin_metrics.cc
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/components/spellcheck/browser/spellcheck_host_metrics.cc
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/components/spellcheck/renderer/spellcheck_provider.cc
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/components/sync/engine/net/http_bridge.cc
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/components/sync/engine_impl/sync_encryption_handler_impl.cc
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/components/sync/engine_impl/sync_manager_impl.cc
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/components/sync_bookmarks/bookmark_model_associator.cc
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/components/sync_sessions/local_session_event_handler_impl.cc
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/components/sync_sessions/lost_navigations_recorder.cc
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/components/viz/service/display/direct_renderer.cc
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/content/browser/child_process_security_policy_impl.cc
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/content/browser/frame_host/navigation_controller_impl.cc
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/content/browser/histogram_synchronizer.cc
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/content/browser/renderer_host/media/video_capture_controller.cc
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/content/renderer/media/stream/processed_local_audio_source.cc
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/content/renderer/media/webrtc/webrtc_audio_renderer.cc
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/extensions/browser/content_verify_job.cc
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/extensions/browser/extension_protocols.cc
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/extensions/browser/sandboxed_unpacker.cc
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/extensions/browser/updater/extension_downloader.cc
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/google_apis/gcm/engine/checkin_request.cc
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/google_apis/gcm/engine/connection_factory_impl.cc
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/google_apis/gcm/engine/gcm_registration_request_handler.cc
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/google_apis/gcm/engine/gcm_store_impl.cc
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/google_apis/gcm/engine/gcm_unregistration_request_handler.cc
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/google_apis/gcm/engine/instance_id_delete_token_request_handler.cc
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/google_apis/gcm/engine/instance_id_get_token_request_handler.cc
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/gpu/command_buffer/service/memory_program_cache.cc
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/ios/chrome/browser/metrics/tab_usage_recorder.mm
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/ios/chrome/browser/prerender/preload_controller.mm
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/ios/chrome/browser/ui/settings/password_exporter.mm
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/media/audio/audio_output_resampler.cc
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/media/audio/mac/audio_auhal_mac.cc
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/media/audio/mac/audio_low_latency_input_mac.cc
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/media/audio/win/audio_low_latency_input_win.cc
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/media/base/pipeline_impl.cc
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/media/capture/video/mac/video_capture_device_avfoundation_mac.mm
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/media/filters/ffmpeg_demuxer.cc
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/media/midi/message_util.cc
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/net/disk_cache/blockfile/histogram_macros.h
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/services/network/cross_origin_read_blocking.cc
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/sql/database.cc
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/sql/initialization.cc
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/third_party/blink/renderer/modules/gamepad/gamepad_shared_memory_reader.cc
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.cc
[modify] https://crrev.com/9592222b61fc2bd136201f737d9e94620db776fd/ui/views/widget/desktop_aura/desktop_drop_target_win.cc

Sign in to add a comment