Issue metadata
Sign in to add a comment
|
tests/git_hyper_blame_test.py broken in depot_tools |
||||||||||||||||||
Issue description
On current depot_tools master:
thakis@thakis:~/src/depot_tools$ python tests/git_hyper_blame_test.py
.....F................
======================================================================
FAIL: testBadFilename (__main__.GitHyperBlameMainTest)
Tests the main function (bad filename).
----------------------------------------------------------------------
Traceback (most recent call last):
File "tests/git_hyper_blame_test.py", line 136, in testBadFilename
self.repo['C'], stderr.getvalue())
AssertionError: 'fatal: no such path some/files/xxxx in a3084d72cb26667a133652f99ca4f3fb2a7e0eac\n' != 'fatal: no such path some/files/xxxx in /usr/share/locale/en_US/LC_MESSAGES/git.mo\n'
----------------------------------------------------------------------
Ran 22 tests in 1.455s
FAILED (failures=1)
,
Jul 5 2017
I'll do a full bisect later. For now... Last known good: e572fef9d459497de2bd719747d5625a27c9b41d (Jan 2016) First known bad: dc076ae5d9fe8c2fbf238b265c1bc1f6f089fd16 (May 2017) (That's a big bisect.)
,
Jul 6 2017
Bisect shows 835c49f7d16c5f0307e71da19618fcfe500c2430 is the culprit ("blame: rework methods that determine 'final' commit").
,
Jul 11 2017
Update: I have a patch for this which I am going to send to the Git mailing list. I'm just checking whether there is any special process for a potential security vulnerability (since this is a use-after-free in git-blame).
,
Jul 11 2017
Nice! Re comment 0: I touch depot_tools maybe once a year, so personally I don't care much. But having passing tests on presubmit seems fairly basic on a project's hierarchy of needs, so disabling it might be nice.
,
Jul 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools/+/6bac8a849974017b8a78c27b97cd52f668bd033f commit 6bac8a849974017b8a78c27b97cd52f668bd033f Author: Matt Giuca <mgiuca@chromium.org> Date: Thu Jul 13 17:18:50 2017 GitHyperBlameMainTest.testBadFilename: Work around git-blame bug. A regression in git-blame prints an incorrect error message which causes this test case to fail. Alter the test to only check the start of the string, until the bug is fixed upstream. Bug: 737688 Change-Id: I4045cb8792d8abe984215c7198e213b23e9f6f5d Reviewed-on: https://chromium-review.googlesource.com/567778 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Reviewed-by: Jochen Eisinger <jochen@chromium.org> [modify] https://crrev.com/6bac8a849974017b8a78c27b97cd52f668bd033f/tests/git_hyper_blame_test.py
,
Jul 14 2017
Fixed test. I will post more info about the upstreaming of the fix to git-blame here. Also removing security since the fix is posted to a public mailing list. |
|||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||
Comment 1 by mgiuca@chromium.org
, Jul 5 2017Status: ExternalDependency (was: Unconfirmed)