New issue
Advanced search Search tips

Issue 737680 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

run-bindings-tests shouldn't print megabytes of output if they fail

Project Member Reported by thakis@chromium.org, Jun 28 2017

Issue description

Patch in https://chromium-review.googlesource.com/c/550238 , run `git cl presubmit`. It prints many screenfulls of diffs. It looks like this comes from the bindings tests.

run-bindings-tests shouldn't print diffs, or, if it must, stop doing so after a couple screens.
 

Comment 1 by bashi@chromium.org, Jun 28 2017

Owner: bashi@chromium.org
Status: Available (was: Unconfirmed)
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f5f505b2021c9d499e2044314ba73e22e851812f

commit f5f505b2021c9d499e2044314ba73e22e851812f
Author: Kenichi Ishibashi <bashi@chromium.org>
Date: Thu Jun 29 23:06:14 2017

Suppress generated code diff for presubmit checks

BUG= 737680 

Change-Id: Ifaf115bbd4bf2b16dd562acff0517e49e69db681
Reviewed-on: https://chromium-review.googlesource.com/553999
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#483531}
[modify] https://crrev.com/f5f505b2021c9d499e2044314ba73e22e851812f/third_party/WebKit/Source/bindings/PRESUBMIT.py
[modify] https://crrev.com/f5f505b2021c9d499e2044314ba73e22e851812f/third_party/WebKit/Tools/Scripts/run-bindings-tests
[modify] https://crrev.com/f5f505b2021c9d499e2044314ba73e22e851812f/third_party/WebKit/Tools/Scripts/webkitpy/bindings/bindings_tests.py

Comment 3 by bashi@chromium.org, Jun 29 2017

Status: Fixed (was: Available)

Sign in to add a comment