New issue
Advanced search Search tips

Issue 737675 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: ----


Previous locations:
gerrit:6592


Sign in to add a comment

CL set as not ready for review after uploading a new patchset

Project Member Reported by jbudorick@chromium.org, Jun 28 2017

Issue description

I'm working on https://chromium-review.googlesource.com/c/550924, which I published as ready for review in patchset 4. I uploaded a new patchset and the review reverted to (WIP) despite being previously published & having reviewers set. Is this intended?
 

Comment 1 by wyatta@google.com, Jun 28 2017

Cc: aga...@chromium.org

Comment 2 by aga...@chromium.org, Jun 28 2017

Project: chromium
Moved issue gerrit:6592 to now be  issue chromium:737675 .

Comment 3 by aga...@chromium.org, Jun 28 2017

Cc: -aga...@chromium.org
Components: Infra>SDK
Labels: Milestone-Afterglow Proj-Gerrit-Migration
Owner: aga...@chromium.org
Status: Started (was: New)
This is intended, but the intention is certainly up for debate and change. I have a proposal for changing this here: https://chromium-review.googlesource.com/c/552779

Comment 4 by aga...@chromium.org, Jun 28 2017

 Issue 737782  has been merged into this issue.
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/844cf2963be2f1e178382cfaf2906a7215746368

commit 844cf2963be2f1e178382cfaf2906a7215746368
Author: Aaron Gable <agable@chromium.org>
Date: Wed Jun 28 23:56:31 2017

git-cl: only set WIP on first upload

It seems like some folks are confused by additional patchsets
after the first putting the change back into WIP mode. This
confusion is honestly understandable. Maybe we try only setting
it on the very first upload, and just controlling the notify
parameter for future patchsets.

Bug:  721836 ,  737675 
Change-Id: If56e5c71e0c6b3b46c2e30ac0b6d80b878218181
Reviewed-on: https://chromium-review.googlesource.com/552779
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: smut <smut@google.com>
Commit-Queue: Aaron Gable <agable@chromium.org>

[modify] https://crrev.com/844cf2963be2f1e178382cfaf2906a7215746368/tests/git_cl_test.py
[modify] https://crrev.com/844cf2963be2f1e178382cfaf2906a7215746368/git_cl.py

Comment 6 by aga...@chromium.org, Jun 29 2017

Status: Fixed (was: Started)
I think it's smarter to only set WIP on the very first upload, as the folks who reported this and discussed it in IRC suggested.

Comment 7 by aga...@chromium.org, Jun 29 2017

Cc: rouslan@chromium.org ellyjo...@chromium.org jamescook@chromium.org mek@chromium.org
+the folks discussing this on IRC for FYI

Comment 8 by aga...@chromium.org, Jun 29 2017

 Issue gerrit:6602  has been merged into this issue.
thanks for listening & tweaking this quickly, agable!

Comment 10 by logan@google.com, Jun 30 2017

 Issue gerrit:6613  has been merged into this issue.

Comment 11 by logan@google.com, Sep 5 2017

 Issue gerrit:6626  has been merged into this issue.

Sign in to add a comment