New issue
Advanced search Search tips

Issue 737666 link

Starred by 2 users

Issue metadata

Status: Available
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression: Clicking on omnibox suggestion from extension does not invoke onInputEntered

Reported by zma...@gmail.com, Jun 28 2017

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/59.0.3071.115 Safari/537.36

Steps to reproduce the problem:
1. Install attached extension in developer mode
2. Ctrl+T to a new tab, type a query
3. In the omnibox either press Enter or select the first suggestion (the first suggestion should be marked as coming from this extension)

What is the expected behavior?
Expected behavior (used to work in older Chrome versions - 1+ years ago): 

1. omnibox sends user to https://www.doubleshotsearch.com/chrome-extension/search/?q={searchTerms} which is set by manifest.json > chrome_settings_overrides > search_url
2. Extension captures the request with chrome.webRequest.onBeforeRequest, then redirects to chrome-extension://<extension_id>/search.html?q={searchTerms} (note it redirects to search.html!)

What went wrong?
Chrome actually redirects user to chrome-extension://<extension_id>/?q={searchTerms} (without search.html!)

Did this work before? Yes I don't know, about one year ago

Does this work in other browsers? N/A

Chrome version: 59.0.3071.115  Channel: stable
OS Version: 10.0
Flash Version: 

I want to be very clear that this used to work in prior Chrome versions with the same extension.

This seems to me like a regression of https://bugs.chromium.org/p/chromium/issues/detail?id=46480
 
double-shot-search.zip
2.4 MB Download
Components: Platform>Extensions
Labels: Needs-Triage-M59 Needs-Bisect

Comment 2 by woxxom@gmail.com, Jun 29 2017

Bisect: 453098 (good) - 453102 (bad), 58.0.3024.0
https://chromium.googlesource.com/chromium/src/+log/85790fe6..d27524ee?pretty=fuller
Suspecting r453100 "Changed keywords conflicts resolution for extensions search engines"
Cc: a-...@yandex-team.ru
CC a-v-y@yandex-team.ru per comment #2
Cc: pbomm...@chromium.org vasi...@chromium.org pkasting@chromium.org
Labels: -Needs-Bisect -Needs-Triage-M59 M-59
Status: Available (was: Unconfirmed)
cc'ing people familiar with the suspected CL for further insights.
Owner: a-...@yandex-team.ru
Status: Started (was: Available)
Status: Available (was: Started)

Sign in to add a comment