New issue
Advanced search Search tips

Issue 737664 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Jun 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Recent change broke chromiumos-sdk builder

Project Member Reported by cmt...@chromium.org, Jun 28 2017

Issue description

This CL: https://chromium-review.googlesource.com/c/546638/
contains a code error that the x86 compiler finds.  This is causing the chromiumos-sdk builder to crash.

The code fix is simple...there's a case statement in a new function that supposedly returns a value, but the compiler (correctly) claims that if none of the cases are matched the function does not return anything:

chromeos-chrome-61.0.3142.0_rc-r1: [18046/38655] CXX obj/ash/ash/attached_panel_window_targeter.o
chromeos-chrome-61.0.3142.0_rc-r1: FAILED: obj/ash/ash/attached_panel_window_targeter.o 
chromeos-chrome-61.0.3142.0_rc-r1: i686-pc-linux-gnu-g++ -B/usr/x86_64-pc-linux-gnu/i686-pc-linux-gnu/binutils-bin/2.25.51-gold -MMD -MF obj/ash/ash/attached_panel_window_targeter.o.d -DASH_IMPLEMENTATION -DV8_DEPRECATION_WARNINGS -DUSE_UDEV -DUSE_ASH=1 -DUSE_AURA=1 -DUSE_NSS_CERTS=1 -DUSE_OZONE=1 -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -DFIELDTRIAL_TESTING_ENABLED -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_FORTIFY_SOURCE=2 -DOS_CHROMEOS -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DUSE_EGL -DTOOLKIT_VIEWS=1 -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_STATIC_IMPLEMENTATION -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE -DUCHAR_TYPE=uint16_t -DSK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS -DSK_HAS_PNG_LIBRARY -DSK_HAS_WEBP_LIBRARY -DSK_HAS_JPEG_LIBRARY -DSK_SUPPORT_GPU=1 -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DHAVE_PTHREAD -DMESA_EGL_NO_X11_HEADERS -I../../../../../../../home/chrome-bot/chrome_root/src -Igen -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/libwebp/src -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/khronos -I../../../../../../../home/chrome-bot/chrome_root/src/gpu -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/ced/src -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/icu/source/common -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/icu/source/i18n -I../../../../../../../home/chrome-bot/chrome_root/src/skia/config -I../../../../../../../home/chrome-bot/chrome_root/src/skia/ext -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/c -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/config -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/core -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/effects -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/encode -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/images -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/lazy -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/pathops -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/pdf -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/pipe -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/ports -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/utils -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/third_party/vulkan -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/gpu -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/src/gpu -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/src/sksl -I/build/x86-generic/usr/include/dbus-1.0 -I/build/x86-generic/usr/lib/dbus-1.0/include -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/protobuf/src -Igen/protoc_out -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/protobuf/src -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/libwebm/source -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/boringssl/src/include -I/build/x86-generic/usr/include/nss -I/build/x86-generic/usr/include/nspr -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/mesa/src/include -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/WebKit -Igen/third_party/WebKit -I../../../../../../../home/chrome-bot/chrome_root/src/v8/include -Igen/v8/include -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/qcms/src -Igen -fno-strict-aliasing -Wno-builtin-macro-redefined -D__DATE__= -D__TIME__= -D__TIMESTAMP__= -funwind-tables -fPIC -pipe -pthread -m32 -msse2 -mfpmath=sse -mmmx -Wall -Werror -Wno-unused-local-typedefs -Wno-maybe-uninitialized -Wno-missing-field-initializers -Wno-unused-parameter -O2 -fno-ident -fdata-sections -ffunction-sections -fno-omit-frame-pointer -g2 -gsplit-dwarf --sysroot=../../../../../../../build/x86-generic -fvisibility=hidden -std=gnu++11 -Wno-narrowing -fno-rtti -fno-exceptions -fvisibility-inlines-hidden -march=i686 -pipe -march=i686 -pipe -pipe -march=i686 -mfpmath=sse -mmmx -msse -msse2 -msse3 -D__google_stl_debug_vector=1 -femit-struct-debug-reduced -c ../../../../../../../home/chrome-bot/chrome_root/src/ash/wm/panels/attached_panel_window_targeter.cc -o obj/ash/ash/attached_panel_window_targeter.o
chromeos-chrome-61.0.3142.0_rc-r1: ../../../../../../../home/chrome-bot/chrome_root/src/ash/wm/panels/attached_panel_window_targeter.cc: In member function 'gfx::Insets ash::AttachedPanelWindowTargeter::GetTouchExtendForShelfAlignment() const':
chromeos-chrome-61.0.3142.0_rc-r1: ../../../../../../../home/chrome-bot/chrome_root/src/ash/wm/panels/attached_panel_window_targeter.cc:73:1: error: control reaches end of non-void function [-Werror=return-type]
chromeos-chrome-61.0.3142.0_rc-r1:  }
chromeos-chrome-61.0.3142.0_rc-r1:  ^
chromeos-chrome-61.0.3142.0_rc-r1: cc1plus: all warnings being treated as errors
chromeos-chrome-61.0.3142.0_rc-r1: 

(see https://uberchromegw.corp.google.com/i/chromiumos/builders/chromiumos-sdk/builds/7993 for the complete build logs).

Please fix this ASAP.  Thanks!
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/03b5851797c8082c8d2ad6d276c0d68d3b0c4925

commit 03b5851797c8082c8d2ad6d276c0d68d3b0c4925
Author: Scott Violet <sky@chromium.org>
Date: Wed Jun 28 20:55:27 2017

chromeos: fix compile on bots

Adds a return to appease compiler.

BUG= 737664 
TEST=none
TBR=sadrul@chromium.org

Change-Id: I3b6431e1cc522e22139eee6efeec020eb4d44ab2
Reviewed-on: https://chromium-review.googlesource.com/552747
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#483129}
[modify] https://crrev.com/03b5851797c8082c8d2ad6d276c0d68d3b0c4925/ash/wm/panels/attached_panel_window_targeter.cc

Comment 2 by sky@chromium.org, Jun 28 2017

Status: Fixed (was: Untriaged)

Comment 3 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment