New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 737662 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Proj-XR
Proj-XR-VR



Sign in to add a comment

Make VrTabHelper::IsInVr (or some wrapper) available on all platforms

Project Member Reported by billorr@chromium.org, Jun 28 2017

Issue description

There are two goals with this change.  First, we can use it in platform-agnostic code, rather than also needing #ifdef's for Android.  Second, if this can be built where we don't have BUILDFLAG(ENABLE_VR), we can simplify consumers.

 

Comment 1 by amp@chromium.org, Jun 28 2017

I thought the long term goal was that we shouldn't need a 'IsInVR' check because we would have VR implementations that did the right thing.  (Swapping out the implementations when we go into VR is still going to be interesting though).

If we start making this platform agnostic it feels like it will be harder to get rid of it down the line.  OTOH, maybe this is required either way if we want to ship something before all VR implementation is complete.
In the short term future, we'll want to enable VR on platforms outside of Android. In the longer term, we'll want to get rid of IsInVR and make UI work while in VR.

This bug is about the short-term.
Cc: asimjour@chromium.org
Owner: billorr@chromium.org
Status: Assigned (was: Untriaged)
On July 24th, Ian moved VrTabHelper into chrome/browser/vr, and it's now built via chrome/browser/BUILD.gn.  The code contains compile-time conditionals.  See this CL:

https://chromium-review.googlesource.com/581724

Bill, I believe this satisfies the issue you filed.  Assigning back to you to either close this bug, or indicate that more work is needed.
Status: Fixed (was: Assigned)

Sign in to add a comment