Issue metadata
Sign in to add a comment
|
Make VrTabHelper::IsInVr (or some wrapper) available on all platforms |
||||||||||||||||||||||||||
Issue descriptionThere are two goals with this change. First, we can use it in platform-agnostic code, rather than also needing #ifdef's for Android. Second, if this can be built where we don't have BUILDFLAG(ENABLE_VR), we can simplify consumers.
,
Jun 28 2017
In the short term future, we'll want to enable VR on platforms outside of Android. In the longer term, we'll want to get rid of IsInVR and make UI work while in VR. This bug is about the short-term.
,
Jul 10 2017
,
Aug 10 2017
On July 24th, Ian moved VrTabHelper into chrome/browser/vr, and it's now built via chrome/browser/BUILD.gn. The code contains compile-time conditionals. See this CL: https://chromium-review.googlesource.com/581724 Bill, I believe this satisfies the issue you filed. Assigning back to you to either close this bug, or indicate that more work is needed.
,
Aug 11 2017
|
|||||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||||
Comment 1 by amp@chromium.org
, Jun 28 2017