New issue
Advanced search Search tips

Issue 737658 link

Starred by 1 user

Issue metadata

Status: Archived
Owner: ----
Closed: Jan 10
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Always symbolize all symbols by default.

Project Member Reported by erikc...@chromium.org, Jun 28 2017

Issue description

When a user is symbolizing a trace, assume that all symbols are present. If all symbols are not present [e.g. because the trace is coming from another user's machine], assume that the caller of the script is sufficiently familiar with the process that they will pass the flag --only-symbolize-chrome-symbols.    
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d4aa831fb4a764cbfa2c58c318849c8a967d7735

commit d4aa831fb4a764cbfa2c58c318849c8a967d7735
Author: catapult-deps-roller@chromium.org <catapult-deps-roller@chromium.org>
Date: Wed Jun 28 21:48:11 2017

Roll src/third_party/catapult/ 8114d33c7..9d1bd9e64 (4 commits)

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/8114d33c7d55..9d1bd9e6442b

$ git log 8114d33c7..9d1bd9e64 --date=short --no-merges --format='%ad %ae %s'
2017-06-28 etienneb Fix coding style issue with diff_heap_profiler script
2017-06-28 erikchen symbolize_trace: Always symbolize all symbols by default.
2017-06-28 erikchen Increase flush timeout for fetching and compressing a memory dump.
2017-06-28 etienneb Add traces diffing tool for memory dumps between chrome traces

Created with:
  roll-dep src/third_party/catapult
BUG= 733056 , 737658 ,726393, 733056 


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I918fd6b10c13bd20a170680c102ff30de6beebf6
Reviewed-on: https://chromium-review.googlesource.com/552873
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#483151}
[modify] https://crrev.com/d4aa831fb4a764cbfa2c58c318849c8a967d7735/DEPS

Status: Archived (was: Untriaged)
Archiving P3s older than 1 year with no owner or component.

Sign in to add a comment