New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 737657 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
OOO until 2019-01-24
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Regression

Blocked on:
issue 730036

Blocking:
issue 692663



Sign in to add a comment

smoothness.maps failing on 3 builders

Project Member Reported by martiniss@chromium.org, Jun 28 2017

Issue description

smoothness.maps failing on 3 builders

Builders failed on: 
- Win 10 High-DPI Perf: 
  https://build.chromium.org/p/chromium.perf/builders/Win%2010%20High-DPI%20Perf
- Win 7 ATI GPU Perf: 
  https://build.chromium.org/p/chromium.perf/builders/Win%207%20ATI%20GPU%20Perf
- Win 7 Nvidia GPU Perf: 
  https://build.chromium.org/p/chromium.perf/builders/Win%207%20Nvidia%20GPU%20Perf

https://chromium-swarm.appspot.com/task?id=370628875c3ef710&refresh=10&show_raw=1 is an example task. The screenshot shows a blank white page. 

Looks like there's no test log; maybe it crashed? Something weird is going on.

It's failing in roughly the same way on all 3 windows bots. Same blank white screenshot on all 3. Looks like the test is actually failing.



 
Hmhh, my guess is the WPR recording doesn't work on these machines

Comment 2 by kbr@chromium.org, Jun 28 2017

Blocking: 692663
Labels: OS-Windows
The reason this started failing is that I just turned on these tests in  Issue 692663 .

These tests should definitely be running correctly on Win7 with NVIDIA GPUs. This WPR archive is run (as a correctness test) on Chromium's CQ.

Indeed, if we look, we can see the test passing sometimes, but mostly failing. Here's a passing run:
https://luci-milo.appspot.com/buildbot/chromium.perf/Win%207%20Nvidia%20GPU%20Perf/936
https://chromium-swarm.appspot.com/task?id=3708290722a2a410&refresh=10&show_raw=1

and a failing run:
https://luci-milo.appspot.com/buildbot/chromium.perf/Win%207%20Nvidia%20GPU%20Perf/935
https://chromium-swarm.appspot.com/task?id=370705655cf65710&refresh=10&show_raw=1

These runs were on the *same* machine, build96-m1:
https://chromium-swarm.appspot.com/bot?id=build96-m1&sort_stats=total%3Adesc

I'm at a loss here. Again, this WPR runs well on similarly configured machines in Chromium's CQ.

The test does run very quickly -- in only a couple of seconds. Could there be a race condition in benchmark measurement for very fast running tests?

What should I do? Disable the test again? If so I'm going to close  Issue 692663  as WontFix.

Is it possible to reproduce this on your local Win machine? IIRC, the win machine on CQ is very different from the bare metal ones.

Comment 4 by kbr@chromium.org, Jul 6 2017

Cc: nedngu...@google.com perezju@chromium.org
Components: Tests>Telemetry
Labels: Type-Bug-Regression
When run locally, the benchmark usually displays a 404 for http://localhost:8000/performance.html . If the tab's reloaded in the launched browser, then the benchmark runs to completion. This is probably the reason the test is failing on the bots.

It looks like there's a race condition when setting up the WPR archive for replay on Windows. This seems like a generic problem in Telemetry's harness to me -- Ned, could someone from the Telemetry team help us look into this?

Blockedon: 730036
Cc: xunji...@chromium.org
xunjieli@ is working on migrating WPR server to Go, I think it's better to probably block this bug on that effort.

Comment 6 by kbr@chromium.org, Jul 7 2017

Owner: kbr@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0e569358d483e0c2b8eb1a4f4868267589d96d17

commit 0e569358d483e0c2b8eb1a4f4868267589d96d17
Author: Kenneth Russell <kbr@chromium.org>
Date: Fri Jul 07 01:59:27 2017

Disable smoothness.maps on Windows again.

There's a race condition in the WPR server still preventing it from
running reliably.

BUG= 692663 ,  737657 
TBR=nednguyen@google.com
NOTRY=true

Change-Id: Ic2d0f9d85747958e752705536f85b41823977b71
Reviewed-on: https://chromium-review.googlesource.com/562749
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484788}
[modify] https://crrev.com/0e569358d483e0c2b8eb1a4f4868267589d96d17/tools/perf/benchmarks/smoothness.py

Comment 8 by kbr@chromium.org, Jul 7 2017

Status: WontFix (was: Assigned)
Since this is essentially a duplicate of  Issue 692663 , closing this one as WontFix. Re-enabling this benchmark on Windows after the WPR server is rewritten in Go will be tracked under the other bug.

Sign in to add a comment